196206 2019-03-25 09:58:45 -0700 Skip WebAssembly test on 32-bit systems 2019-03-26 17:05:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned commit-queue keith_miller mark.lam saam webkit-bug-importer ysuzuki oldest_to_newest 1520887 0 dominik.infuehr 2019-03-25 09:58:45 -0700 Skip WebAssembly test on 32-bit systems 1520888 1 365871 dominik.infuehr 2019-03-25 09:59:01 -0700 Created attachment 365871 Patch 1520891 2 dominik.infuehr 2019-03-25 10:02:51 -0700 Invoking runDefault runs the test immediately, therefore make runDefault conditional. 1520894 3 365871 keith_miller 2019-03-25 10:12:05 -0700 Comment on attachment 365871 Patch I don’t think this is right. It’s definitely possible to have FTL and not warm. Additionally, it’s possible to have warm and not FTL. I would just remove the whole pragma. 1520913 4 365876 dominik.infuehr 2019-03-25 11:06:51 -0700 Created attachment 365876 Patch 1520914 5 dominik.infuehr 2019-03-25 11:07:58 -0700 Tha(In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. Thanks for the review! I've updated the patch to remove runDefault. 1520915 6 keith_miller 2019-03-25 11:08:50 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 365871 [details] > Patch > > I don’t think this is right. It’s definitely possible to have FTL and not > warm. Additionally, it’s possible to have warm and not FTL. I would just > remove the whole pragma. ugh autocorrect... that should be wasm. 1521298 7 365968 dominik.infuehr 2019-03-26 09:12:47 -0700 Created attachment 365968 Patch 1521506 8 366019 dominik.infuehr 2019-03-26 16:18:26 -0700 Created attachment 366019 Patch 1521538 9 366019 commit-queue 2019-03-26 17:03:01 -0700 Comment on attachment 366019 Patch Clearing flags on attachment: 366019 Committed r243529: <https://trac.webkit.org/changeset/243529> 1521539 10 commit-queue 2019-03-26 17:03:02 -0700 All reviewed patches have been landed. Closing bug. 1521540 11 webkit-bug-importer 2019-03-26 17:05:05 -0700 <rdar://problem/49301482> 365871 2019-03-25 09:59:01 -0700 2019-03-25 11:06:45 -0700 Patch bug-196206-20190325175859.patch text/plain 1096 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDM1CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE1NDRjODAxYzdmYmQ5ZTkwODgwODcyOGZkNzM2 OTJmNmViNzM2NzMuLjk1NDNiODZhYzQ4NTZhYTg2OTAwMjMxNjVhNmRkYWM3NDQ4ZmM1MzMgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTktMDMtMjUgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxp YS5jb20+CisKKyAgICAgICAgU2tpcCBXZWJBc3NlbWJseSB0ZXN0IG9uIDMyLWJpdCBzeXN0ZW1z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyMDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20v cmVncmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1leGNlcHRpb24tY2hlY2suanM6CisKIDIw MTktMDMtMjQgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0pTQ10gTW92ZSB0ZXN0IGludG8gZGlyZWN0b3J5IGZvciBXQVNNIHRlc3RzCmRpZmYgLS1n aXQgYS9KU1Rlc3RzL3dhc20vcmVncmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1leGNlcHRp b24tY2hlY2suanMgYi9KU1Rlc3RzL3dhc20vcmVncmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJv ci1leGNlcHRpb24tY2hlY2suanMKaW5kZXggMDdmZDk3OGY1ZjM1NTk4ZDFlMGJhNDExZGIwM2U0 ZjA5YjJiZDE1OC4uZmMwM2ZjMDA0MWEyZjE4YWEyNDUwMmU3Yzg2OTdiMzI4OGIxODhjYiAxMDA2 NDQKLS0tIGEvSlNUZXN0cy93YXNtL3JlZ3Jlc3Mvd2ViLWFzc2VtYmx5LWxpbmstZXJyb3ItZXhj ZXB0aW9uLWNoZWNrLmpzCisrKyBiL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1s aW5rLWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qcwpAQCAtMSwzICsxLDMgQEAKLS8vQCBydW5EZWZh dWx0CisvL0AgcnVuRGVmYXVsdCBpZiBpc0ZUTEVuYWJsZWQKIAogbmV3IFdlYkFzc2VtYmx5Lkxp bmtFcnJvcihbXSk7Cg== 365876 2019-03-25 11:06:51 -0700 2019-03-26 09:12:41 -0700 Patch bug-196206-20190325190649.patch text/plain 1235 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDM1CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE1NDRjODAxYzdmYmQ5ZTkwODgwODcyOGZkNzM2 OTJmNmViNzM2NzMuLmJhZDc2ZGNjZTI3M2Q4ZjNiZjgyZTBiNjFkNTVjMmU5YzJhNzEwMTQgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTktMDMtMjUgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxp YS5jb20+CisKKyAgICAgICAgU2tpcCBXZWJBc3NlbWJseSB0ZXN0IG9uIDMyLWJpdCBzeXN0ZW1z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyMDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnZva2lu ZyBydW5EZWZhdWx0IGV4ZWN1dGVzIHRlc3QgaW1tZWRpYXRlbHkgZXZlbiB0aG91Z2gKKyAgICAg ICAgdGhhdCB0ZXN0IHNob3VsZCBiZSBza2lwcGVkIGR1ZSB0byBtaXNzaW5nIFdBU00gc3VwcG9y dC4KKyAgICAgICAgVGhlcmVmb3JlIHJlbW92ZSBydW5EZWZhdWx0LgorCisgICAgICAgICogd2Fz bS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qczoKKwog MjAxOS0wMy0yNCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbSlNDXSBNb3ZlIHRlc3QgaW50byBkaXJlY3RvcnkgZm9yIFdBU00gdGVzdHMKZGlmZiAt LWdpdCBhL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVycm9yLWV4Y2Vw dGlvbi1jaGVjay5qcyBiL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVy cm9yLWV4Y2VwdGlvbi1jaGVjay5qcwppbmRleCAwN2ZkOTc4ZjVmMzU1OThkMWUwYmE0MTFkYjAz ZTRmMDliMmJkMTU4Li44Mzg2ODI5YzYzNGJmYTMwNTBiZTU1Y2ZhMWM5MzIwNzg1ZWY0NWQ2IDEw MDY0NAotLS0gYS9KU1Rlc3RzL3dhc20vcmVncmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1l eGNlcHRpb24tY2hlY2suanMKKysrIGIvSlNUZXN0cy93YXNtL3JlZ3Jlc3Mvd2ViLWFzc2VtYmx5 LWxpbmstZXJyb3ItZXhjZXB0aW9uLWNoZWNrLmpzCkBAIC0xLDMgKzEgQEAKLS8vQCBydW5EZWZh dWx0Ci0KIG5ldyBXZWJBc3NlbWJseS5MaW5rRXJyb3IoW10pOwo= 365968 2019-03-26 09:12:47 -0700 2019-03-26 16:18:20 -0700 Patch bug-196206-20190326171246.patch text/plain 1286 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDk2CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZiZGUxZGVmMDlhZWQwZmJjY2IyZWM0MzY1ZjQ1 NmQ0ZTFkNDU4YzUuLjk4OWUzNjdkODc0Zjk1ODI2YWEzMDdmOTE0NjFmNDA3Nzc5NTJjNjcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDMtMjYgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxp YS5jb20+CisKKyAgICAgICAgU2tpcCBXZWJBc3NlbWJseSB0ZXN0IG9uIDMyLWJpdCBzeXN0ZW1z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyMDYK KworICAgICAgICBVbnJldmlld2VkLiBJbnZva2luZyBydW5EZWZhdWx0IGV4ZWN1dGVzIHRlc3Qg aW1tZWRpYXRlbHkgZXZlbiB0aG91Z2gKKyAgICAgICAgdGhhdCB0ZXN0IHNob3VsZCBiZSBza2lw cGVkIGR1ZSB0byBtaXNzaW5nIFdBU00gc3VwcG9ydC4KKyAgICAgICAgVGhlcmVmb3JlIHJlbW92 ZSBydW5EZWZhdWx0LgorCisgICAgICAgICogd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5r LWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qczoKKwogMjAxOS0wMy0yNSAgS2VpdGggTWlsbGVyICA8 a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBtX29w ID09IENvbXBhcmVTdHJpY3RFcSBpbiBKU0M6OkRGRzo6Tm9kZTo6Y29udmVydFRvQ29tcGFyZUVx UHRyKEpTQzo6REZHOjpGcm96ZW5WYWx1ZSAqLCBKU0M6OkRGRzo6RWRnZSkKZGlmZiAtLWdpdCBh L0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVycm9yLWV4Y2VwdGlvbi1j aGVjay5qcyBiL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVycm9yLWV4 Y2VwdGlvbi1jaGVjay5qcwppbmRleCAwN2ZkOTc4ZjVmMzU1OThkMWUwYmE0MTFkYjAzZTRmMDli MmJkMTU4Li44Mzg2ODI5YzYzNGJmYTMwNTBiZTU1Y2ZhMWM5MzIwNzg1ZWY0NWQ2IDEwMDY0NAot LS0gYS9KU1Rlc3RzL3dhc20vcmVncmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1leGNlcHRp b24tY2hlY2suanMKKysrIGIvSlNUZXN0cy93YXNtL3JlZ3Jlc3Mvd2ViLWFzc2VtYmx5LWxpbmst ZXJyb3ItZXhjZXB0aW9uLWNoZWNrLmpzCkBAIC0xLDMgKzEgQEAKLS8vQCBydW5EZWZhdWx0Ci0K IG5ldyBXZWJBc3NlbWJseS5MaW5rRXJyb3IoW10pOwo= 366019 2019-03-26 16:18:26 -0700 2019-03-26 17:03:01 -0700 Patch bug-196206-20190327001824.patch text/plain 1247 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTIyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFjMjcwZTFkYjM3ZTkwNWRkNTY3N2M0ZDQzNWEy ZTAwZmEzNGIyMWQuLmZhZDNiOGM3N2NmOTBmZTM2NjAwZTQ3MmQ5ZGExMjk4MWExYWI1ZWIgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTktMDMtMjYgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxp YS5jb20+CisKKyAgICAgICAgU2tpcCBXZWJBc3NlbWJseSB0ZXN0IG9uIDMyLWJpdCBzeXN0ZW1z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYyMDYK KworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBJbnZva2luZyBy dW5EZWZhdWx0IGV4ZWN1dGVzIHRlc3QgaW1tZWRpYXRlbHkgZXZlbiB0aG91Z2gKKyAgICAgICAg dGhhdCB0ZXN0IHNob3VsZCBiZSBza2lwcGVkIGR1ZSB0byBtaXNzaW5nIFdBU00gc3VwcG9ydC4K KyAgICAgICAgVGhlcmVmb3JlIHJlbW92ZSBydW5EZWZhdWx0LgorCisgICAgICAgICogd2FzbS9y ZWdyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qczoKKwogMjAx OS0wMy0yNiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJBc3NlbWJseTogRml4IGYzMi5taW4sIGY2NC5taW4gYW5kIGY2NC5tYXggb3BlcmF0aW9ucyBv biBOYU4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3NlbWJseS1saW5r LWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qcyBiL0pTVGVzdHMvd2FzbS9yZWdyZXNzL3dlYi1hc3Nl bWJseS1saW5rLWVycm9yLWV4Y2VwdGlvbi1jaGVjay5qcwppbmRleCAwN2ZkOTc4ZjVmMzU1OThk MWUwYmE0MTFkYjAzZTRmMDliMmJkMTU4Li44Mzg2ODI5YzYzNGJmYTMwNTBiZTU1Y2ZhMWM5MzIw Nzg1ZWY0NWQ2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3dhc20vcmVncmVzcy93ZWItYXNzZW1ibHkt bGluay1lcnJvci1leGNlcHRpb24tY2hlY2suanMKKysrIGIvSlNUZXN0cy93YXNtL3JlZ3Jlc3Mv d2ViLWFzc2VtYmx5LWxpbmstZXJyb3ItZXhjZXB0aW9uLWNoZWNrLmpzCkBAIC0xLDMgKzEgQEAK LS8vQCBydW5EZWZhdWx0Ci0KIG5ldyBXZWJBc3NlbWJseS5MaW5rRXJyb3IoW10pOwo=