<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196193</bug_id>
          
          <creation_ts>2019-03-24 22:39:36 -0700</creation_ts>
          <short_desc>Pull IPadUserInterfaceSwizzler out into a separate header file</short_desc>
          <delta_ts>2019-03-25 12:09:25 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>DoNotImportToRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>andersca</cc>
    
    <cc>bdakin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1520792</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-24 22:39:36 -0700</bug_when>
    <thetext>Pull IPadUserInterfaceSwizzler out into a separate header file</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520793</commentid>
    <comment_count>1</comment_count>
      <attachid>365850</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-24 22:40:56 -0700</bug_when>
    <thetext>Created attachment 365850
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520853</commentid>
    <comment_count>2</comment_count>
      <attachid>365850</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2019-03-25 08:08:09 -0700</bug_when>
    <thetext>Comment on attachment 365850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365850&amp;action=review

&gt; Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
&gt; +    static UIUserInterfaceIdiom padUserInterfaceIdiom()

Shouldn&apos;t this at least take self and _cmd parameters?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520855</commentid>
    <comment_count>3</comment_count>
      <attachid>365864</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-25 08:16:57 -0700</bug_when>
    <thetext>Created attachment 365864
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520856</commentid>
    <comment_count>4</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-25 08:17:08 -0700</bug_when>
    <thetext>(In reply to Anders Carlsson from comment #2)
&gt; Comment on attachment 365850 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=365850&amp;action=review
&gt; 
&gt; &gt; Tools/TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h:41
&gt; &gt; +    static UIUserInterfaceIdiom padUserInterfaceIdiom()
&gt; 
&gt; Shouldn&apos;t this at least take self and _cmd parameters?

It probably should!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520928</commentid>
    <comment_count>5</comment_count>
      <attachid>365864</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-25 11:43:08 -0700</bug_when>
    <thetext>Comment on attachment 365864
Patch

Thanks for the review!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520935</commentid>
    <comment_count>6</comment_count>
      <attachid>365864</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-25 12:09:23 -0700</bug_when>
    <thetext>Comment on attachment 365864
Patch

Clearing flags on attachment: 365864

Committed r243445: &lt;https://trac.webkit.org/changeset/243445&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520936</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-25 12:09:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>365850</attachid>
            <date>2019-03-24 22:40:56 -0700</date>
            <delta_ts>2019-03-25 08:16:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196193-20190324224055.patch</filename>
            <type>text/plain</type>
            <size>6759</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTBiMTIzN2FiOTA1NWYyY2QwNDAwMmM0OThiN2JmMTRh
MWQ1YzNhYi4uOGM3NGM1OTg1MjgwMzdhNzgxNjM0MWUxN2YwMDMxY2YxYTE3NWJjNiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx
IEBACisyMDE5LTAzLTI0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor
CisgICAgICAgIFB1bGwgSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlciBvdXQgaW50byBhIHNlcGFy
YXRlIGhlYWRlciBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTYxOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBQdWxsIHRoZSBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyIGhlbHBlciBjbGFzcyBv
dXQgaW50byBhIHNlcGFyYXRlIGZpbGUsIHNvIHRoYXQgaXQgbWF5CisgICAgICAgIGJlIHVzZWQg
aW4gb3RoZXIgQVBJIHRlc3RzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0
QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9U
ZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OklQ
YWRVc2VySW50ZXJmYWNlU3dpenpsZXI6OklQYWRVc2VySW50ZXJmYWNlU3dpenpsZXIpOiBEZWxl
dGVkLgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlcjo6
cGFkVXNlckludGVyZmFjZUlkaW9tKTogRGVsZXRlZC4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ
L2lvcy9JUGFkVXNlckludGVyZmFjZVN3aXp6bGVyLmg6IEFkZGVkLgorICAgICAgICAoVGVzdFdl
YktpdEFQSTo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlcjo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6
emxlcik6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpJUGFkVXNlckludGVyZmFjZVN3aXp6bGVy
OjpwYWRVc2VySW50ZXJmYWNlSWRpb20pOgorCiAyMDE5LTAzLTE5ICBNaWNoYWVsIENhdGFuemFy
byAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n
IG91dCByMjQzMTMyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0
QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RX
ZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCBmZDIwNTIyYTU1NTgzMDNk
MjdkZTg4NmYzMDBhYTIwNDk2Nzk1ZTU0Li4xZDFhY2I1N2M5ODc4NjM0OTI0YzZlMTJkNmJmMDQ2
YjM0NGM0NzViIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEku
eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RX
ZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjI4OSw2ICsyMjg5LDcgQEAK
IAkJRjRDRDc0QzUyMEZEQUNGNTAwREUzNzk0IC8qIHRleHQtd2l0aC1hc3luYy1zY3JpcHQuaHRt
bCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25v
d25GaWxlVHlwZSA9IHRleHQuaHRtbDsgcGF0aCA9ICJ0ZXh0LXdpdGgtYXN5bmMtc2NyaXB0Lmh0
bWwiOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGNENENzRDNzIwRkRCNDk2MDBERTM3
OTQgLyogVGVzdFVSTFNjaGVtZUhhbmRsZXIuaCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNl
OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gVGVzdFVSTFNjaGVt
ZUhhbmRsZXIuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJRjRDRDc0QzgyMEZEQjQ5
NjAwREUzNzk0IC8qIFRlc3RVUkxTY2hlbWVIYW5kbGVyLm1tICovID0ge2lzYSA9IFBCWEZpbGVS
ZWZlcmVuY2U7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBwYXRo
ID0gVGVzdFVSTFNjaGVtZUhhbmRsZXIubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJ
CUY0Q0RBQjMzMjI0ODlGRTEwMDU3QTJEOSAvKiBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyLmgg
Ki8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vj
b2RlLmMuaDsgcGF0aCA9IElQYWRVc2VySW50ZXJmYWNlU3dpenpsZXIuaDsgc291cmNlVHJlZSA9
ICI8Z3JvdXA+IjsgfTsKIAkJRjREMjk4NkQyMEZFRTczNzAwOTJENjM2IC8qIFJ1blNjcmlwdEFm
dGVyRG9jdW1lbnRMb2FkLm1tICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGxhc3RLbm93
bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBwYXRoID0gUnVuU2NyaXB0QWZ0ZXJE
b2N1bWVudExvYWQubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCUY0RDRGM0I0MUU0
RTJCQ0IwMEJCMjc2NyAvKiBEcmFnQW5kRHJvcFNpbXVsYXRvcklPUy5tbSAqLyA9IHtpc2EgPSBQ
QlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNv
dXJjZWNvZGUuY3BwLm9iamNwcDsgcGF0aCA9IERyYWdBbmREcm9wU2ltdWxhdG9ySU9TLm1tOyBz
b3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGNEQ0RjNCNzFFNEUzNkU0MDBCQjI3NjcgLyog
RHJhZ0FuZERyb3BUZXN0c0lPUy5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxl
RW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsg
cGF0aCA9IERyYWdBbmREcm9wVGVzdHNJT1MubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07
CkBAIC0yNjkwLDYgKzI2OTEsNyBAQAogCQkJaXNhID0gUEJYR3JvdXA7CiAJCQljaGlsZHJlbiA9
ICgKIAkJCQlGNEQ0RjNCNDFFNEUyQkNCMDBCQjI3NjcgLyogRHJhZ0FuZERyb3BTaW11bGF0b3JJ
T1MubW0gKi8sCisJCQkJRjRDREFCMzMyMjQ4OUZFMTAwNTdBMkQ5IC8qIElQYWRVc2VySW50ZXJm
YWNlU3dpenpsZXIuaCAqLywKIAkJCQkyRTc3NjVDQzE2QzREODBBMDBCQTJCQjEgLyogbWFpbklP
Uy5tbSAqLywKIAkJCQkyRDYxRUMzMDIxQjBCNzVDMDBBN0QxQ0IgLyogUGVuY2lsS2l0VGVzdFNQ
SS5oICovLAogCQkJCUY0NTE3QjY1MjA1NEM0OTUwMEMyNjcyMSAvKiBUZXN0V0tXZWJWaWV3Q29u
dHJvbGxlci5oICovLApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv
QWN0aW9uU2hlZXRUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0FjdGlv
blNoZWV0VGVzdHMubW0KaW5kZXggYmY3ZGE3OTZhY2I2ZGQyMTZkMDZhOTdlZjc5NjM4MjgxN2Nj
OGM5Mi4uZTgxZjEwMmVmNmMxYjMyYWU3ZDMxOTFhNWM0NThhODVjMGFjOTVjYyAxMDA2NDQKLS0t
IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbQorKysg
Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tCkBAIC0y
OSw3ICsyOSw3IEBACiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKIAogI2ltcG9ydCAiQ2xhc3NN
ZXRob2RTd2l6emxlci5oIgotI2ltcG9ydCAiSW5zdGFuY2VNZXRob2RTd2l6emxlci5oIgorI2lt
cG9ydCAiSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlci5oIgogI2ltcG9ydCAiUGxhdGZvcm1VdGls
aXRpZXMuaCIKICNpbXBvcnQgIlRlc3ROYXZpZ2F0aW9uRGVsZWdhdGUuaCIKICNpbXBvcnQgIlRl
c3RXS1dlYlZpZXcuaCIKQEAgLTY1LDIwICs2NSw2IEBAIEBlbmQKIAogbmFtZXNwYWNlIFRlc3RX
ZWJLaXRBUEkgewogCi1jbGFzcyBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyIHsKLXB1YmxpYzoK
LSAgICBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyKCkKLSAgICAgICAgOiBtX3N3aXp6bGVyKFtV
SURldmljZSBjbGFzc10sIEBzZWxlY3Rvcih1c2VySW50ZXJmYWNlSWRpb20pLCByZWludGVycHJl
dF9jYXN0PElNUD4ocGFkVXNlckludGVyZmFjZUlkaW9tKSkKLSAgICB7Ci0gICAgfQotcHJpdmF0
ZToKLSAgICBzdGF0aWMgVUlVc2VySW50ZXJmYWNlSWRpb20gcGFkVXNlckludGVyZmFjZUlkaW9t
KCkKLSAgICB7Ci0gICAgICAgIHJldHVybiBVSVVzZXJJbnRlcmZhY2VJZGlvbVBhZDsKLSAgICB9
Ci0gICAgSW5zdGFuY2VNZXRob2RTd2l6emxlciBtX3N3aXp6bGVyOwotfTsKLQogc3RhdGljIFJl
dGFpblB0cjxVSVZpZXdDb250cm9sbGVyPiBnT3ZlcnJpZGVWaWV3Q29udHJvbGxlckZvckZ1bGxz
Y3JlZW5QcmVzZW50YXRpb247CiBzdGF0aWMgdm9pZCBzZXRPdmVycmlkZVZpZXdDb250cm9sbGVy
Rm9yRnVsbHNjcmVlblByZXNlbnRhdGlvbihVSVZpZXdDb250cm9sbGVyICp2aWV3Q29udHJvbGxl
cikKIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0lQYWRVc2VySW50ZXJm
YWNlU3dpenpsZXIuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0lQYWRVc2VySW50ZXJmYWNl
U3dpenpsZXIuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hOTRkN2ZhMzE3ZjkyODM4M2EzZTIwMjRmMGY2YThlOTM2
YjM0ZDQzCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvSVBhZFVz
ZXJJbnRlcmZhY2VTd2l6emxlci5oCkBAIC0wLDAgKzEsNTAgQEAKKy8qCisgKiBDb3B5cmlnaHQg
KEMpIDIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJp
YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91
dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv
d2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNv
dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwg
dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAq
IDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv
dmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0
aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9v
ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAq
IFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJV
VE9SUyBgYEFTIElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMs
IElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhFIElNUExJRUQgV0FSUkFOVElF
UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVS
UE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMg
Q09OVFJJQlVUT1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ
REVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05TRVFVRU5USUFMIERBTUFHRVMg
KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorICogU1VCU1RJ
VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9S
IEJVU0lORVNTCisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhF
T1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ
VFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyAqIEFSSVNJ
TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE
VklTRUQgT0YKKyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjcHJh
Z21hIG9uY2UKKworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisKKyNpbXBvcnQgIkluc3RhbmNl
TWV0aG9kU3dpenpsZXIuaCIKKworbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgeworCitjbGFzcyBJ
UGFkVXNlckludGVyZmFjZVN3aXp6bGVyIHsKK3B1YmxpYzoKKyAgICBJUGFkVXNlckludGVyZmFj
ZVN3aXp6bGVyKCkKKyAgICAgICAgOiBtX3N3aXp6bGVyKFtVSURldmljZSBjbGFzc10sIEBzZWxl
Y3Rvcih1c2VySW50ZXJmYWNlSWRpb20pLCByZWludGVycHJldF9jYXN0PElNUD4ocGFkVXNlcklu
dGVyZmFjZUlkaW9tKSkKKyAgICB7CisgICAgfQorcHJpdmF0ZToKKyAgICBzdGF0aWMgVUlVc2Vy
SW50ZXJmYWNlSWRpb20gcGFkVXNlckludGVyZmFjZUlkaW9tKCkKKyAgICB7CisgICAgICAgIHJl
dHVybiBVSVVzZXJJbnRlcmZhY2VJZGlvbVBhZDsKKyAgICB9CisgICAgSW5zdGFuY2VNZXRob2RT
d2l6emxlciBtX3N3aXp6bGVyOworfTsKKworfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQor
CisjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>365864</attachid>
            <date>2019-03-25 08:16:57 -0700</date>
            <delta_ts>2019-03-25 12:09:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196193-20190325081656.patch</filename>
            <type>text/plain</type>
            <size>6791</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTBiMTIzN2FiOTA1NWYyY2QwNDAwMmM0OThiN2JmMTRh
MWQ1YzNhYi4uOGM3NGM1OTg1MjgwMzdhNzgxNjM0MWUxN2YwMDMxY2YxYTE3NWJjNiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx
IEBACisyMDE5LTAzLTI0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor
CisgICAgICAgIFB1bGwgSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlciBvdXQgaW50byBhIHNlcGFy
YXRlIGhlYWRlciBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTYxOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBQdWxsIHRoZSBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyIGhlbHBlciBjbGFzcyBv
dXQgaW50byBhIHNlcGFyYXRlIGZpbGUsIHNvIHRoYXQgaXQgbWF5CisgICAgICAgIGJlIHVzZWQg
aW4gb3RoZXIgQVBJIHRlc3RzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0
QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9U
ZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OklQ
YWRVc2VySW50ZXJmYWNlU3dpenpsZXI6OklQYWRVc2VySW50ZXJmYWNlU3dpenpsZXIpOiBEZWxl
dGVkLgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlcjo6
cGFkVXNlckludGVyZmFjZUlkaW9tKTogRGVsZXRlZC4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ
L2lvcy9JUGFkVXNlckludGVyZmFjZVN3aXp6bGVyLmg6IEFkZGVkLgorICAgICAgICAoVGVzdFdl
YktpdEFQSTo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlcjo6SVBhZFVzZXJJbnRlcmZhY2VTd2l6
emxlcik6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpJUGFkVXNlckludGVyZmFjZVN3aXp6bGVy
OjpwYWRVc2VySW50ZXJmYWNlSWRpb20pOgorCiAyMDE5LTAzLTE5ICBNaWNoYWVsIENhdGFuemFy
byAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n
IG91dCByMjQzMTMyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0
QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RX
ZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCBmZDIwNTIyYTU1NTgzMDNk
MjdkZTg4NmYzMDBhYTIwNDk2Nzk1ZTU0Li4xZDFhY2I1N2M5ODc4NjM0OTI0YzZlMTJkNmJmMDQ2
YjM0NGM0NzViIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEku
eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RX
ZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjI4OSw2ICsyMjg5LDcgQEAK
IAkJRjRDRDc0QzUyMEZEQUNGNTAwREUzNzk0IC8qIHRleHQtd2l0aC1hc3luYy1zY3JpcHQuaHRt
bCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25v
d25GaWxlVHlwZSA9IHRleHQuaHRtbDsgcGF0aCA9ICJ0ZXh0LXdpdGgtYXN5bmMtc2NyaXB0Lmh0
bWwiOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGNENENzRDNzIwRkRCNDk2MDBERTM3
OTQgLyogVGVzdFVSTFNjaGVtZUhhbmRsZXIuaCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNl
OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gVGVzdFVSTFNjaGVt
ZUhhbmRsZXIuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJRjRDRDc0QzgyMEZEQjQ5
NjAwREUzNzk0IC8qIFRlc3RVUkxTY2hlbWVIYW5kbGVyLm1tICovID0ge2lzYSA9IFBCWEZpbGVS
ZWZlcmVuY2U7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBwYXRo
ID0gVGVzdFVSTFNjaGVtZUhhbmRsZXIubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJ
CUY0Q0RBQjMzMjI0ODlGRTEwMDU3QTJEOSAvKiBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyLmgg
Ki8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vj
b2RlLmMuaDsgcGF0aCA9IElQYWRVc2VySW50ZXJmYWNlU3dpenpsZXIuaDsgc291cmNlVHJlZSA9
ICI8Z3JvdXA+IjsgfTsKIAkJRjREMjk4NkQyMEZFRTczNzAwOTJENjM2IC8qIFJ1blNjcmlwdEFm
dGVyRG9jdW1lbnRMb2FkLm1tICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGxhc3RLbm93
bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAub2JqY3BwOyBwYXRoID0gUnVuU2NyaXB0QWZ0ZXJE
b2N1bWVudExvYWQubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCUY0RDRGM0I0MUU0
RTJCQ0IwMEJCMjc2NyAvKiBEcmFnQW5kRHJvcFNpbXVsYXRvcklPUy5tbSAqLyA9IHtpc2EgPSBQ
QlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNv
dXJjZWNvZGUuY3BwLm9iamNwcDsgcGF0aCA9IERyYWdBbmREcm9wU2ltdWxhdG9ySU9TLm1tOyBz
b3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQlGNEQ0RjNCNzFFNEUzNkU0MDBCQjI3NjcgLyog
RHJhZ0FuZERyb3BUZXN0c0lPUy5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxl
RW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLm9iamNwcDsg
cGF0aCA9IERyYWdBbmREcm9wVGVzdHNJT1MubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07
CkBAIC0yNjkwLDYgKzI2OTEsNyBAQAogCQkJaXNhID0gUEJYR3JvdXA7CiAJCQljaGlsZHJlbiA9
ICgKIAkJCQlGNEQ0RjNCNDFFNEUyQkNCMDBCQjI3NjcgLyogRHJhZ0FuZERyb3BTaW11bGF0b3JJ
T1MubW0gKi8sCisJCQkJRjRDREFCMzMyMjQ4OUZFMTAwNTdBMkQ5IC8qIElQYWRVc2VySW50ZXJm
YWNlU3dpenpsZXIuaCAqLywKIAkJCQkyRTc3NjVDQzE2QzREODBBMDBCQTJCQjEgLyogbWFpbklP
Uy5tbSAqLywKIAkJCQkyRDYxRUMzMDIxQjBCNzVDMDBBN0QxQ0IgLyogUGVuY2lsS2l0VGVzdFNQ
SS5oICovLAogCQkJCUY0NTE3QjY1MjA1NEM0OTUwMEMyNjcyMSAvKiBUZXN0V0tXZWJWaWV3Q29u
dHJvbGxlci5oICovLApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv
QWN0aW9uU2hlZXRUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0FjdGlv
blNoZWV0VGVzdHMubW0KaW5kZXggYmY3ZGE3OTZhY2I2ZGQyMTZkMDZhOTdlZjc5NjM4MjgxN2Nj
OGM5Mi4uZTgxZjEwMmVmNmMxYjMyYWU3ZDMxOTFhNWM0NThhODVjMGFjOTVjYyAxMDA2NDQKLS0t
IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvQWN0aW9uU2hlZXRUZXN0cy5tbQorKysg
Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9BY3Rpb25TaGVldFRlc3RzLm1tCkBAIC0y
OSw3ICsyOSw3IEBACiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKIAogI2ltcG9ydCAiQ2xhc3NN
ZXRob2RTd2l6emxlci5oIgotI2ltcG9ydCAiSW5zdGFuY2VNZXRob2RTd2l6emxlci5oIgorI2lt
cG9ydCAiSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlci5oIgogI2ltcG9ydCAiUGxhdGZvcm1VdGls
aXRpZXMuaCIKICNpbXBvcnQgIlRlc3ROYXZpZ2F0aW9uRGVsZWdhdGUuaCIKICNpbXBvcnQgIlRl
c3RXS1dlYlZpZXcuaCIKQEAgLTY1LDIwICs2NSw2IEBAIEBlbmQKIAogbmFtZXNwYWNlIFRlc3RX
ZWJLaXRBUEkgewogCi1jbGFzcyBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyIHsKLXB1YmxpYzoK
LSAgICBJUGFkVXNlckludGVyZmFjZVN3aXp6bGVyKCkKLSAgICAgICAgOiBtX3N3aXp6bGVyKFtV
SURldmljZSBjbGFzc10sIEBzZWxlY3Rvcih1c2VySW50ZXJmYWNlSWRpb20pLCByZWludGVycHJl
dF9jYXN0PElNUD4ocGFkVXNlckludGVyZmFjZUlkaW9tKSkKLSAgICB7Ci0gICAgfQotcHJpdmF0
ZToKLSAgICBzdGF0aWMgVUlVc2VySW50ZXJmYWNlSWRpb20gcGFkVXNlckludGVyZmFjZUlkaW9t
KCkKLSAgICB7Ci0gICAgICAgIHJldHVybiBVSVVzZXJJbnRlcmZhY2VJZGlvbVBhZDsKLSAgICB9
Ci0gICAgSW5zdGFuY2VNZXRob2RTd2l6emxlciBtX3N3aXp6bGVyOwotfTsKLQogc3RhdGljIFJl
dGFpblB0cjxVSVZpZXdDb250cm9sbGVyPiBnT3ZlcnJpZGVWaWV3Q29udHJvbGxlckZvckZ1bGxz
Y3JlZW5QcmVzZW50YXRpb247CiBzdGF0aWMgdm9pZCBzZXRPdmVycmlkZVZpZXdDb250cm9sbGVy
Rm9yRnVsbHNjcmVlblByZXNlbnRhdGlvbihVSVZpZXdDb250cm9sbGVyICp2aWV3Q29udHJvbGxl
cikKIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0lQYWRVc2VySW50ZXJm
YWNlU3dpenpsZXIuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL0lQYWRVc2VySW50ZXJmYWNl
U3dpenpsZXIuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMDI1MTkzNGIwNWZmOWI3MDhkNmM2OWQ4MjZlZTA3YWQ4
NmFhMWZlCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvSVBhZFVz
ZXJJbnRlcmZhY2VTd2l6emxlci5oCkBAIC0wLDAgKzEsNTEgQEAKKy8qCisgKiBDb3B5cmlnaHQg
KEMpIDIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJp
YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91
dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv
d2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNv
dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwg
dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAq
IDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv
dmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0
aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9v
ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAq
IFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJV
VE9SUyBgYEFTIElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMs
IElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhFIElNUExJRUQgV0FSUkFOVElF
UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVS
UE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMg
Q09OVFJJQlVUT1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ
REVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05TRVFVRU5USUFMIERBTUFHRVMg
KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorICogU1VCU1RJ
VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9S
IEJVU0lORVNTCisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhF
T1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ
VFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyAqIEFSSVNJ
TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE
VklTRUQgT0YKKyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjcHJh
Z21hIG9uY2UKKworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisKKyNpbXBvcnQgIkluc3RhbmNl
TWV0aG9kU3dpenpsZXIuaCIKKyNpbXBvcnQgPFVJS2l0L1VJS2l0Lmg+CisKK25hbWVzcGFjZSBU
ZXN0V2ViS2l0QVBJIHsKKworY2xhc3MgSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlciB7CitwdWJs
aWM6CisgICAgSVBhZFVzZXJJbnRlcmZhY2VTd2l6emxlcigpCisgICAgICAgIDogbV9zd2l6emxl
cihbVUlEZXZpY2UgY2xhc3NdLCBAc2VsZWN0b3IodXNlckludGVyZmFjZUlkaW9tKSwgcmVpbnRl
cnByZXRfY2FzdDxJTVA+KHBhZFVzZXJJbnRlcmZhY2VJZGlvbSkpCisgICAgeworICAgIH0KK3By
aXZhdGU6CisgICAgc3RhdGljIFVJVXNlckludGVyZmFjZUlkaW9tIHBhZFVzZXJJbnRlcmZhY2VJ
ZGlvbShpZCwgU0VMKQorICAgIHsKKyAgICAgICAgcmV0dXJuIFVJVXNlckludGVyZmFjZUlkaW9t
UGFkOworICAgIH0KKyAgICBJbnN0YW5jZU1ldGhvZFN3aXp6bGVyIG1fc3dpenpsZXI7Cit9Owor
Cit9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCisKKyNlbmRpZiAvLyBQTEFURk9STShJT1Nf
RkFNSUxZKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>