196192 2019-03-24 21:24:39 -0700 [WinCairo] WebProcessDataStoreParameters.h(32): error C2653: 'SandboxExtension': is not a class or namespace name 2019-03-24 22:10:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196104 InRadar P2 Normal --- 1 fujii fujii commit-queue webkit-bug-importer oldest_to_newest 1520783 0 fujii 2019-03-24 21:24:39 -0700 WinCairo builds get broken. > "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe" (...) -c ..\..\Source\WebKit\WebProcess\MediaCache\WebMediaKeyStorageManager.cpp > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C2653: 'SandboxExtension': is not a class or namespace name > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C3646: 'applicationCacheDirectoryExtensionHandle': unknown override specifier > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(32): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C2653: 'SandboxExtension': is not a class or namespace name > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C3646: 'webSQLDatabaseDirectoryExtensionHandle': unknown override specifier > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(35): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C2653: 'SandboxExtension': is not a class or namespace name > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C3646: 'mediaCacheDirectoryExtensionHandle': unknown override specifier > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(37): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C2653: 'SandboxExtension': is not a class or namespace name > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C3646: 'mediaKeyStorageDirectoryExtensionHandle': unknown override specifier > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(39): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C2653: 'SandboxExtension': is not a class or namespace name > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C3646: 'javaScriptConfigurationDirectoryExtensionHandle': unknown override specifier > C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Shared\WebProcessDataStoreParameters.h(41): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 1520784 1 365846 fujii 2019-03-24 21:27:42 -0700 Created attachment 365846 Patch 1520786 2 365846 commit-queue 2019-03-24 22:09:34 -0700 Comment on attachment 365846 Patch Clearing flags on attachment: 365846 Committed r243430: <https://trac.webkit.org/changeset/243430> 1520787 3 commit-queue 2019-03-24 22:09:35 -0700 All reviewed patches have been landed. Closing bug. 1520788 4 webkit-bug-importer 2019-03-24 22:10:19 -0700 <rdar://problem/49204922> 365846 2019-03-24 21:27:42 -0700 2019-03-24 22:09:34 -0700 Patch bug-196192-20190325132741.patch text/plain 1204 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2MjFiMmQwNmVmOTBlNDdl ODc4MTUwY2Y1ZGJjODJhOWY5OWZkYmIuLjZiODU5MTYwNTE0ZjQ0ZmJjMDVlZmUzOTgzZjBlM2U5 YjhiY2VlMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDMtMjQgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBX ZWJQcm9jZXNzRGF0YVN0b3JlUGFyYW1ldGVycy5oKDMyKTogZXJyb3IgQzI2NTM6ICdTYW5kYm94 RXh0ZW5zaW9uJzogaXMgbm90IGEgY2xhc3Mgb3IgbmFtZXNwYWNlIG5hbWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjE5MgorCisgICAgICAgIFVu cmV2aWV3ZWQgZm9yIFdpbkNhaXJvIHBvcnQuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJvY2Vz c0RhdGFTdG9yZVBhcmFtZXRlcnMuaDogQWRkZWQgI2luY2x1ZGUgIlNhbmRib3hFeHRlbnNpb24u aCIuCisKIDIwMTktMDMtMjQgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFt3YXRjaE9TXSBSZW1vdmUgdW51c2VkIFByb3hpbWl0eSBOZXR3b3JraW5nIGNvZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByb2Nlc3NEYXRhU3RvcmVQYXJhbWV0 ZXJzLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcm9jZXNzRGF0YVN0b3JlUGFyYW1ldGVy cy5oCmluZGV4IDI2OTdiOWJlNmE2ZDQ5YWFlMjk5NzQ4MTdlOWNjNDMwYTRmOGZlY2EuLmQ2ZTVj NzA0YWM1NWI0NDMyYmU1MzU0ZTA3NzJkMjcwM2Q2NTc3NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL1dlYlByb2Nlc3NEYXRhU3RvcmVQYXJhbWV0ZXJzLmgKKysrIGIvU291cmNl L1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0RhdGFTdG9yZVBhcmFtZXRlcnMuaApAQCAtMjUsNiAr MjUsOCBAQAogCiAjcHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgIlNhbmRib3hFeHRlbnNpb24uaCIK KwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0cnVjdCBXZWJQcm9jZXNzRGF0YVN0b3JlUGFyYW1l dGVycyB7Cg==