196185 2019-03-24 01:58:33 -0700 [wpe] Build failure after r243325 (WebPasteboardProxyWPE.cpp) 2019-03-25 00:29:46 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psaavedra webkit-unassigned bugs-noreply zan oldest_to_newest 1520682 0 psaavedra 2019-03-24 01:58:33 -0700 Bots for WPE [1] stopped to build OK after r243325 (Stop using LegacySync messages in WebPasteboardProxy - https://bugs.webkit.org/show_bug.cgi?id=196060). [1] https://build.webkit.org/waterfall?category=WPE Error: In file included from /home/buildbot/wpe/wpe-linux-64-debug/build/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-26.cpp:1:0: ../../Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp: In member function ‘void WebKit::WebPasteboardProxy::getPasteboardTypes(WTF::CompletionHandler<void(WTF::Vector<WTF::String>&&)>&&)’: ../../Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp:39:47: error: no match for call to ‘(WTF::CompletionHandler<void(WTF::Vector<WTF::String>&&)>) (std::remove_reference<WTF::Vector<WTF::String>&>::type)’ completionHandler(WTFMove(pasteboardTypes)); ^ In file included from /home/buildbot/wpe/wpe-linux-64-debug/build/WebKitBuild/Debug/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-26.cpp:1:0: ../../Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp: In member function ‘void WebKit::WebPasteboardProxy::readStringFromPasteboard(uint64_t, const WTF::String&, WTF::CompletionHandler<void(WTF::String&&)>&&)’: ../../Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp:44:77: error: no match for call to ‘(WTF::CompletionHandler<void(WTF::String&&)>) (WTF::String)’ completionHandler(PlatformPasteboard().readString(index, pasteboardType)); Related change done in r243325: diff --git a/Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp b/Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp index 0a8d44a65b8..1e84c7c4ddc 100644 --- a/Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp +++ b/Source/WebKit/UIProcess/wpe/WebPasteboardProxyWPE.cpp @@ -32,14 +32,16 @@ namespace WebKit { using namespace WebCore; -void WebPasteboardProxy::getPasteboardTypes(Vector<String>& pasteboardTypes) +void WebPasteboardProxy::getPasteboardTypes(CompletionHandler<void(Vector<String>&&)>&& completionHandler) { + Vector<String> pasteboardTypes; PlatformPasteboard().getTypes(pasteboardTypes); + completionHandler(WTFMove(pasteboardTypes)); } -void WebPasteboardProxy::readStringFromPasteboard(uint64_t index, const String& pasteboardType, WTF::String& value) +void WebPasteboardProxy::readStringFromPasteboard(uint64_t index, const String& pasteboardType, CompletionHandler<void(String&&)>&& completionHandler) { - value = PlatformPasteboard().readString(index, pasteboardType); + completionHandler(PlatformPasteboard().readString(index, pasteboardType)); } void WebPasteboardProxy::writeWebContentToPasteboard(const WebCore::PasteboardWebContent& content) 1520806 1 zan 2019-03-25 00:29:39 -0700 Fixed in r243431. http://trac.webkit.org/changeset/243431/webkit