196171 2019-03-22 21:12:14 -0700 [ContentChangeObserver] Check if the transitioned content is visible at onAnimationEnd 2019-03-23 17:49:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1520577 0 zalan 2019-03-22 21:12:14 -0700 ssia 1520579 1 365802 zalan 2019-03-22 21:25:44 -0700 Created attachment 365802 Patch 1520622 2 365802 simon.fraser 2019-03-23 10:25:43 -0700 Comment on attachment 365802 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365802&action=review > Source/WebCore/ChangeLog:9 > + However the current state (before computing the final style) might already be qualified to be visible. be qualified to be visible -> qualify as visible 1520627 3 zalan 2019-03-23 13:47:54 -0700 Committed r243413: <https://trac.webkit.org/changeset/243413> 1520652 4 webkit-bug-importer 2019-03-23 17:49:24 -0700 <rdar://problem/49191234> 1520653 5 webkit-bug-importer 2019-03-23 17:49:24 -0700 <rdar://problem/49191238> 365802 2019-03-22 21:25:44 -0700 2019-03-23 10:25:43 -0700 Patch bug-196171-20190322212543.patch text/plain 7528 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU4ODZiMjc4YTc4MjZm NDgzNDljN2IwODM2MjY4ZDAwODU5MjFlYi4uNmY1NWExZGFlYWI3Njc2ZGE5N2RmN2VhYTg1Yzdj YWFlYmJjZWMzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAzLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gQ2hlY2sgaWYgdGhlIHRyYW5zaXRpb25lZCBjb250ZW50IGlzIHZpc2libGUgYXQgb25B bmltYXRpb25FbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjE3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEF0IG9uQW5pbWF0aW9uRW5kIHdlIGRvbid0IHlldCBoYXZlIHRoZSBmaW5hbCBjb21wdXRl ZCBzdHlsZSBmb3IgdGhlIHRyYW5zaXRpb25lZCBjb250ZW50LgorICAgICAgICBIb3dldmVyIHRo ZSBjdXJyZW50IHN0YXRlIChiZWZvcmUgY29tcHV0aW5nIHRoZSBmaW5hbCBzdHlsZSkgbWlnaHQg YWxyZWFkeSBiZSBxdWFsaWZpZWQgdG8gYmUgdmlzaWJsZS4KKyAgICAgICAgSW50cm9kdWNlICJD b21wbGV0ZWRUcmFuc2l0aW9uIiB0byBpbmRpY2F0ZSB0aGF0IHRoZSB0cmFuc2l0aW9uIGlzIGFs bCBzZXQgYXMgZmFyIG9ic2VydmluZyBpcyBjb25jZXJuZWQKKyAgICAgICAgKGFzIG9wcG9zZWQg dG8gIkVuZGVkVHJhbnNpdGlvbiIgd2hlcmUgd2Ugc3RpbGwgbmVlZCB0byBvYnNlcnZlIHRoZSBj b250ZW50IGZvciB0aGUgZmluYWwgc3R5bGUgY2hhbmdlKS4KKworICAgICAgICBUZXN0OiBmYXN0 L2V2ZW50cy90b3VjaC9pb3MvY29udGVudC1vYnNlcnZhdGlvbi8xMG1zLWRlbGF5LXRyYW5zaXRp b24tb24tdG91Y2gtc3RhcnQtd2l0aC1ub24tMHB4LWVuZC5odG1sCisKKyAgICAgICAgKiBwYWdl L2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVu dENoYW5nZU9ic2VydmVyOjpkaWRGaW5pc2hUcmFuc2l0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6 OkNvbnRlbnRDaGFuZ2VPYnNlcnZlcjo6YWRqdXN0T2JzZXJ2ZWRTdGF0ZSk6CisgICAgICAgICog cGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmg6CisKIDIwMTktMDMtMjEgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBTVkcgcHJv cGVydHkgdGVhciBvZmYgb2JqZWN0cyBmb3IgU1ZHQW5pbWF0ZWRTdHJpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCmluZGV4IGZkNmQx NGQ1MTA4NjI2YTlkNWRmMmM1ZWVmMDIwMjg5NmIyMzA5NTIuLjBjOTIxYjE0OGU0NjM3YjIwN2E5 YjhiZGM0NTU4YmEwZDc1ZDE0YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9z L0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3Mv Q29udGVudENoYW5nZU9ic2VydmVyLmNwcApAQCAtMTUyLDcgKzE1Miw3IEBAIHZvaWQgQ29udGVu dENoYW5nZU9ic2VydmVyOjpkaWRGaW5pc2hUcmFuc2l0aW9uKGNvbnN0IEVsZW1lbnQmIGVsZW1l bnQsIENTU1Byb3BlCiAgICAgICAgIHJldHVybjsKICAgICBMT0dfV0lUSF9TVFJFQU0oQ29udGVu dE9ic2VydmF0aW9uLCBzdHJlYW0gPDwgImRpZEZpbmlzaFRyYW5zaXRpb246IHRyYW5zaXRpb24g ZmluaXNoZWQgKCIgPDwgJmVsZW1lbnQgPDwgIikuIik7CiAKLSAgICBhZGp1c3RPYnNlcnZlZFN0 YXRlKEV2ZW50OjpFbmRlZFRyYW5zaXRpb24pOworICAgIGFkanVzdE9ic2VydmVkU3RhdGUoaXND b25zaWRlcmVkSGlkZGVuKGVsZW1lbnQpID8gRXZlbnQ6OkVuZGVkVHJhbnNpdGlvbiA6IEV2ZW50 OjpDb21wbGV0ZWRUcmFuc2l0aW9uKTsKIH0KIAogdm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6 OmRpZFJlbW92ZVRyYW5zaXRpb24oY29uc3QgRWxlbWVudCYgZWxlbWVudCwgQ1NTUHJvcGVydHlJ RCBwcm9wZXJ0eUlEKQpAQCAtNDM0LDEzICs0MzQsMjEgQEAgdm9pZCBDb250ZW50Q2hhbmdlT2Jz ZXJ2ZXI6OmFkanVzdE9ic2VydmVkU3RhdGUoRXZlbnQgZXZlbnQpCiAgICAgICAgIGJyZWFrOwog ICAgIGNhc2UgRXZlbnQ6OkVuZGVkVHJhbnNpdGlvbjoKICAgICAgICAgLy8gb25BbmltYXRpb25F bmQgY2FuIGJlIGNhbGxlZCB3aGlsZSBpbiB0aGUgbWlkZGxlIG9mIHJlc29sdmluZyB0aGUgZG9j dW1lbnQgKHN5bmNocm9ub3VzbHkpIG9yCi0gICAgICAgIC8vIGFzeW5jaHJvbm91c2x5IHJpZ2h0 IGJlZm9yZSB0aGUgc3R5bGUgdXBkYXRlIGlzIGlzc3VlZC4KKyAgICAgICAgLy8gYXN5bmNocm9u b3VzbHkgcmlnaHQgYmVmb3JlIHRoZSBzdHlsZSB1cGRhdGUgaXMgaXNzdWVkLiBJdCBhbHNvIG1l YW5zIHdlIGRvbid0IGtub3cgd2hldGhlciB0aGlzIGFuaW1hdGlvbiBlbmRzIHVwIHByb2R1Y2lu ZyB2aXNpYmxlIGNvbnRlbnQgeWV0LiAKICAgICAgICAgaWYgKG1fZG9jdW1lbnQuaW5TdHlsZVJl Y2FsYygpKSB7CiAgICAgICAgICAgICAvLyBXZSBuZWVkIHRvIHN0YXJ0IG9ic2VydmluZyB0aGlz IHN0eWxlIGNoYW5nZSBzeW5jaHJvbm91c2x5LgogICAgICAgICAgICAgbV9pc0luT2JzZXJ2ZWRT dHlsZVJlY2FsYyA9IHRydWU7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgc2V0U2hvdWxk T2JzZXJ2ZU5leHRTdHlsZVJlY2FsYyh0cnVlKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBF dmVudDo6Q29tcGxldGVkVHJhbnNpdGlvbjoKKyAgICAgICAgLy8gU2V0IHZpc2liaWxpdHkgZmxh ZyBvbiBhbmQgcmVwb3J0IHZpc2libGUgY2hhbmdlIHN5bmNocm9ub3VzbHkgb3IgYXN5bmNocm9u b3VzbHkgZGVwZW5kaW5nIHdoZXRoZXIgd2UgYXJlIGluIHRoZSBtaWRkbGUgb2Ygc3R5bGUgcmVj YWxjLgorICAgICAgICBjb250ZW50VmlzaWJpbGl0eURpZENoYW5nZSgpOworICAgICAgICBpZiAo bV9kb2N1bWVudC5pblN0eWxlUmVjYWxjKCkpCisgICAgICAgICAgICBtX2lzSW5PYnNlcnZlZFN0 eWxlUmVjYWxjID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAoIWlzT2JzZXJ2YXRpb25UaW1lV2lu ZG93QWN0aXZlKCkpCisgICAgICAgICAgICBhZGp1c3RTdGF0ZUFuZE5vdGlmeUNvbnRlbnRDaGFu Z2VJZk5lZWRlZCgpOworICAgICAgICBicmVhazsKICAgICBjYXNlIEV2ZW50OjpFbmRlZEZpeGVk T2JzZXJ2YXRpb25UaW1lV2luZG93OgogICAgICAgICBhZGp1c3RTdGF0ZUFuZE5vdGlmeUNvbnRl bnRDaGFuZ2VJZk5lZWRlZCgpOwogICAgICAgICBicmVhazsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oIGIvU291cmNlL1dlYkNvcmUv cGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmgKaW5kZXggMDVhYTA1ODU2MGNjMjNiMDI2 NDlhNzkyN2Q0MmRhZWQzZDkxZDQ0MC4uNGViOTM5MGExM2JjMzdlNzkwZGI4ZDMzNjMwZGU1MWVl MTRmMWYzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5n ZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9i c2VydmVyLmgKQEAgLTE3Myw2ICsxNzMsNyBAQCBwcml2YXRlOgogICAgICAgICBFbmRlZFN0eWxl UmVjYWxjLAogICAgICAgICBBZGRlZFRyYW5zaXRpb24sCiAgICAgICAgIEVuZGVkVHJhbnNpdGlv biwKKyAgICAgICAgQ29tcGxldGVkVHJhbnNpdGlvbiwKICAgICAgICAgQ2FuY2VsZWRUcmFuc2l0 aW9uLAogICAgICAgICBTdGFydGVkRml4ZWRPYnNlcnZhdGlvblRpbWVXaW5kb3csCiAgICAgICAg IEVuZGVkRml4ZWRPYnNlcnZhdGlvblRpbWVXaW5kb3csCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDg0MWY2YjQ1Y2E5ZDdh MmU1ODljZWMyMTM1YTlmNTE1YzYxMTgxNi4uZDc2NmY1YjkwNjljZWUzNDA2YTFjOTBmYmYxYmZi NzM1ODE0YWM4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTIyICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNlcnZlcl0g Q2hlY2sgaWYgdGhlIHRyYW5zaXRpb25lZCBjb250ZW50IGlzIHZpc2libGUgYXQgb25BbmltYXRp b25FbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NjE3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vMTBtcy1kZWxheS10cmFu c2l0aW9uLW9uLXRvdWNoLXN0YXJ0LXdpdGgtbm9uLTBweC1lbmQtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9pb3MvY29udGVudC1vYnNlcnZhdGlvbi8x MG1zLWRlbGF5LXRyYW5zaXRpb24tb24tdG91Y2gtc3RhcnQtd2l0aC1ub24tMHB4LWVuZC5odG1s OiBBZGRlZC4KKwogMjAxOS0wMy0yMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIERvIG5vdCBpbnNlcnQgdGhlIGZpcnN0LWxldHRlciBhbm9ueW1vdXMgY29udGFp bmVyIHVudGlsIGFmdGVyIHdlJ3ZlIGNvbnN0cnVjdGVkIHRoZSBmaXJzdC1sZXR0ZXIgcmVuZGVy ZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvY29udGVu dC1vYnNlcnZhdGlvbi8xMG1zLWRlbGF5LXRyYW5zaXRpb24tb24tdG91Y2gtc3RhcnQtd2l0aC1u b24tMHB4LWVuZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9p b3MvY29udGVudC1vYnNlcnZhdGlvbi8xMG1zLWRlbGF5LXRyYW5zaXRpb24tb24tdG91Y2gtc3Rh cnQtd2l0aC1ub24tMHB4LWVuZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjZkYjRjOTQwOGE2 YzAzMTJkZDBlMmQ0ODVjMDFiODM1ZTdjZjkzZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL3RvdWNoL2lvcy9jb250ZW50LW9ic2VydmF0aW9uLzEwbXMtZGVsYXkt dHJhbnNpdGlvbi1vbi10b3VjaC1zdGFydC13aXRoLW5vbi0wcHgtZW5kLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDIgQEAKK1BBU1MgaWYgJ2NsaWNrZWQnIHRleHQgaXMgbm90IHNob3duIGJlbG93 LgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3MvY29udGVu dC1vYnNlcnZhdGlvbi8xMG1zLWRlbGF5LXRyYW5zaXRpb24tb24tdG91Y2gtc3RhcnQtd2l0aC1u b24tMHB4LWVuZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL2NvbnRl bnQtb2JzZXJ2YXRpb24vMTBtcy1kZWxheS10cmFuc2l0aW9uLW9uLXRvdWNoLXN0YXJ0LXdpdGgt bm9uLTBweC1lbmQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jNTk1NjJhZjg5MzRhYzA2YTBlZGQ5YzI2M2Yz ZmE3YzliNmVjZmVhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv dG91Y2gvaW9zL2NvbnRlbnQtb2JzZXJ2YXRpb24vMTBtcy1kZWxheS10cmFuc2l0aW9uLW9uLXRv dWNoLXN0YXJ0LXdpdGgtbm9uLTBweC1lbmQuaHRtbApAQCAtMCwwICsxLDYwIEBACis8aHRtbD4K KzxoZWFkPgorPHRpdGxlPlRoaXMgdGVzdHMgdGhlIGNhc2Ugd2hlbiB0b3VjaEVuZCB0cmlnZ2Vy cyBhIDBtcyB0cmFuc2l0aW9uIHdpdGggZGVsYXkuPC90aXRsZT4KKzxzY3JpcHQgc3JjPSIuLi8u Li8uLi8uLi8uLi9yZXNvdXJjZXMvYmFzaWMtZ2VzdHVyZXMuanMiPjwvc2NyaXB0PgorPHN0eWxl PgorI3RhcHRoaXMgeworICAgIHdpZHRoOiA0MDBweDsKKyAgICBoZWlnaHQ6IDQwMHB4OworICAg IGJvcmRlcjogMXB4IHNvbGlkIGdyZWVuOworfQorCisjYmVjb21lc1Zpc2libGUgeworCXBvc2l0 aW9uOiBhYnNvbHV0ZTsKKwl0b3A6IDEwMHB4OworCWxlZnQ6IC0xMTBweDsKKwl3aWR0aDogMTAw cHg7CisJaGVpZ2h0OiAxMDBweDsKKwliYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsKKwl0cmFuc2l0 aW9uOiBsZWZ0IDIwMG1zIGVhc2UtaW4tb3V0IDEwbXM7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4K K2FzeW5jIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lciB8fCAh dGVzdFJ1bm5lci5ydW5VSVNjcmlwdCkKKyAgICAgICAgcmV0dXJuOworICAgIGlmICh3aW5kb3cu aW50ZXJuYWxzKQorICAgICAgICBpbnRlcm5hbHMuc2V0dGluZ3Muc2V0Q29udGVudENoYW5nZU9i c2VydmVyRW5hYmxlZCh0cnVlKTsKKworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOwor ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgbGV0IHJlY3QgPSB0YXB0aGlzLmdl dEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAgIGxldCB4ID0gcmVjdC5sZWZ0ICsgcmVjdC53aWR0 aCAvIDI7CisgICAgbGV0IHkgPSByZWN0LnRvcCArIHJlY3QuaGVpZ2h0IC8gMjsKKworICAgIGF3 YWl0IHRhcEF0UG9pbnQoeCwgeSk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9h ZD0idGVzdCgpIj4KKzxkaXYgaWQ9dGFwdGhpcz5QQVNTIGlmICdjbGlja2VkJyB0ZXh0IGlzIG5v dCBzaG93biBiZWxvdy48L2Rpdj4KKzxkaXYgaWQ9YmVjb21lc1Zpc2libGU+PC9kaXY+Cis8cHJl IGlkPXJlc3VsdD48L3ByZT4KKzxzY3JpcHQ+Cit0YXB0aGlzLmFkZEV2ZW50TGlzdGVuZXIoIm1v dXNlbW92ZSIsIGZ1bmN0aW9uKCBldmVudCApIHsKKyAgICBiZWNvbWVzVmlzaWJsZS5zdHlsZS5s ZWZ0ID0gIjQwMHB4IjsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOworfSwgZmFsc2UpOworCitiZWNvbWVzVmlzaWJsZS5hZGRFdmVu dExpc3RlbmVyKCJjbGljayIsIGZ1bmN0aW9uKCBldmVudCApIHsgICAKKyAgICByZXN1bHQuaW5u ZXJIVE1MID0gImNsaWNrZWQgaGlkZGVuIjsKK30sIGZhbHNlKTsKKwordGFwdGhpcy5hZGRFdmVu dExpc3RlbmVyKCJjbGljayIsIGZ1bmN0aW9uKCBldmVudCApIHsgICAKKyAgICByZXN1bHQuaW5u ZXJIVE1MID0gImNsaWNrZWQiOworfSwgZmFsc2UpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==