196170 2019-03-22 18:49:23 -0700 Web Inspector: Page Weight indicator clears on pages with zero length resources (macrumors.com) 2019-03-25 13:49:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1520557 0 joepeck 2019-03-22 18:49:23 -0700 Page Weight indicator clears on pages with zero length resources (macrumors.com) Steps to Reproduce: 1. Inspect macrumors.com 2. Reload => Page weight indicator eventually becomes "–" instead of a total value Notes: • A NaN creeps in from a resource with a body length of zero. 1520558 1 365792 joepeck 2019-03-22 18:51:17 -0700 Created attachment 365792 [PATCH] For EWS Using this to generate platform specific results. 1520562 2 365792 joepeck 2019-03-22 19:14:42 -0700 Comment on attachment 365792 [PATCH] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=365792&action=review > Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:188 > + console.assert(isNaN(delta), "Resource size change should never be NaN."); Err, this should have been `!isNaN(...)`. But I'm just using this first patch to get results from the bots. 1520990 3 joepeck 2019-03-25 13:46:08 -0700 <https://trac.webkit.org/r243452> 1520993 4 webkit-bug-importer 2019-03-25 13:49:04 -0700 <rdar://problem/49227556> 365792 2019-03-22 18:51:17 -0700 2019-03-24 12:53:34 -0700 [PATCH] For EWS for-bots-1.patch text/plain 6149 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MTc4YWFhZDk4ZS4uNmNiYmEwN2E5NWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOS0wMy0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFBhZ2UgV2VpZ2h0IGluZGljYXRvciBjbGVhcnMgb24gcGFnZXMg d2l0aCB6ZXJvIGxlbmd0aCByZXNvdXJjZXMgKG1hY3J1bW9ycy5jb20pCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYxNzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9y L25ldHdvcmsvcmVzb3VyY2Utc2l6ZXMtbmV0d29yay5odG1sOgorICAgICAgICAqIGh0dHAvdGVz dHMvaW5zcGVjdG9yL25ldHdvcmsvcmVzb3VyY2VzL2VtcHR5LnR4dDogQWRkZWQuCisgICAgICAg ICogcGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcmVzb3VyY2Utc2l6 ZXMtbmV0d29yay1leHBlY3RlZC50eHQ6CisKIDIwMTktMDMtMjEgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBUaW1lbGluZXMg LSBDYW5ub3QgZXhwb3J0IG9uIGFib3V0OmJsYW5rIC0gc3VnZ2VzdGVkIGZpbGVuYW1lIGNvbnRh aW5pbmcgYSBjb2xvbiBzaWxlbnRseSBmYWlscwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1zaXplcy1uZXR3b3JrLmh0bWwgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291cmNlLXNpemVzLW5l dHdvcmsuaHRtbAppbmRleCBjNzA2YTNhNDlmZS4uZjlmMjY5MDQ1Y2EgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcmVzb3VyY2Utc2l6ZXMtbmV0 d29yay5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsv cmVzb3VyY2Utc2l6ZXMtbmV0d29yay5odG1sCkBAIC00Miw2ICs0MiwxOSBAQCBmdW5jdGlvbiB0 ZXN0KCkKICAgICAgICAgc2l6ZTogMjk1NSwKICAgICB9KTsKIAorICAgIGFkZFJlc291cmNlU2l6 ZVRlc3Qoc3VpdGUsIHsKKyAgICAgICAgbmFtZTogIlJlc291cmNlLlNpemUuTmV0d29yay50ZXh0 IiwKKyAgICAgICAgZGVzY3JpcHRpb246ICJTaXplcyBvZiBhbiBlbXB0eSB0ZXh0IHJlc291cmNl IiwKKyAgICAgICAgdXJsOiAicmVzb3VyY2VzL2VtcHR5LnR4dD8iICsgTWF0aC5yYW5kb20oKSwK KyAgICAgICAgc3RhdHVzQ29kZTogMjAwLAorICAgICAgICBjb21wcmVzc2VkOiBmYWxzZSwKKyAg ICAgICAgcmVzcG9uc2VTb3VyY2U6IFdJLlJlc291cmNlLlJlc3BvbnNlU291cmNlLk5ldHdvcmss CisgICAgICAgIGhlYWRlcnM6IHRydWUsCisgICAgICAgIHJlcXVlc3RCb2R5VHJhbnNmZXJTaXpl OiAwLAorICAgICAgICByZXNwb25zZUJvZHlUcmFuc2ZlclNpemU6IDAsCisgICAgICAgIHNpemU6 IDAsCisgICAgfSk7CisKICAgICBhZGRSZXNvdXJjZVNpemVUZXN0KHN1aXRlLCB7CiAgICAgICAg IG5hbWU6ICJSZXNvdXJjZS5TaXplLk5ldHdvcmsudGV4dC5nemlwcGVkIiwKICAgICAgICAgZGVz Y3JpcHRpb246ICJTaXplcyBvZiBhIGd6aXBwZWQgdGV4dCByZXNvdXJjZSIsCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291cmNlcy9lbXB0 eS50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291cmNl cy9lbXB0eS50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmU2OWRl MjliYjJkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaHR0cC90ZXN0cy9p bnNwZWN0b3IvbmV0d29yay9yZXNvdXJjZS1zaXplcy1uZXR3b3JrLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291 cmNlLXNpemVzLW5ldHdvcmstZXhwZWN0ZWQudHh0CmluZGV4IGEwMGUwNDRiZjk5Li5jZTcyYjg1 ZTBiMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMvaW5z cGVjdG9yL25ldHdvcmsvcmVzb3VyY2Utc2l6ZXMtbmV0d29yay1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcmVz b3VyY2Utc2l6ZXMtbmV0d29yay1leHBlY3RlZC50eHQKQEAgLTE2LDYgKzE2LDIwIEBAIFBBU1M6 IHJlc3BvbnNlQm9keVRyYW5zZmVyU2l6ZSBzaG91bGQgYmUgZXhhY3RseSAyOTU1IGJ5dGVzLgog UEFTUzogcmVxdWVzdEhlYWRlcnNUcmFuc2ZlclNpemUgc2hvdWxkIGJlIG5vbi1lbXB0eS4KIFBB U1M6IHJlc3BvbnNlSGVhZGVyc1RyYW5zZmVyU2l6ZSBzaG91bGQgYmUgbm9uLWVtcHR5LgogCist LSBSdW5uaW5nIHRlc3QgY2FzZTogUmVzb3VyY2UuU2l6ZS5OZXR3b3JrLnRleHQKK1BBU1M6IHN0 YXR1c0NvZGUgc2hvdWxkIGJlIDIwMC4KK1BBU1M6IGNvbXByZXNzZWQgc2hvdWxkIGJlIGZhbHNl LgorUEFTUzogcmVzcG9uc2VTb3VyY2Ugc2hvdWxkIGJlIFN5bWJvbChuZXR3b3JrKS4KK1BBU1M6 IGVzdGltYXRlZE5ldHdvcmtFbmNvZGVkU2l6ZSBzaG91bGQgYmUgZXhhY3RseSAwIGJ5dGVzLgor UEFTUzogZXN0aW1hdGVkVG90YWxUcmFuc2ZlclNpemUgc2hvdWxkIGJlID49IChlbmNvZGVkIGJv ZHkgc2l6ZSArIGhlYWRlcnMpLgorUEFTUzogc2l6ZSBzaG91bGQgYmUgZXhhY3RseSAwIGJ5dGVz LgorUEFTUzogbmV0d29ya0VuY29kZWRTaXplIHNob3VsZCBiZSBleGFjdGx5IDAgYnl0ZXMuCitQ QVNTOiBuZXR3b3JrVG90YWxUcmFuc2ZlclNpemUgc2hvdWxkIGJlID49IChlbmNvZGVkIGJvZHkg c2l6ZSArIGhlYWRlcnMpLgorUEFTUzogcmVxdWVzdEJvZHlUcmFuc2ZlclNpemUgc2hvdWxkIGJl IGV4YWN0bHkgMCBieXRlcy4KK1BBU1M6IHJlc3BvbnNlQm9keVRyYW5zZmVyU2l6ZSBzaG91bGQg YmUgZXhhY3RseSAwIGJ5dGVzLgorUEFTUzogcmVxdWVzdEhlYWRlcnNUcmFuc2ZlclNpemUgc2hv dWxkIGJlIG5vbi1lbXB0eS4KK1BBU1M6IHJlc3BvbnNlSGVhZGVyc1RyYW5zZmVyU2l6ZSBzaG91 bGQgYmUgbm9uLWVtcHR5LgorCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogUmVzb3VyY2UuU2l6ZS5O ZXR3b3JrLnRleHQuZ3ppcHBlZAogUEFTUzogc3RhdHVzQ29kZSBzaG91bGQgYmUgMjAwLgogUEFT UzogY29tcHJlc3NlZCBzaG91bGQgYmUgdHJ1ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4 IGNhNGFhNDc3YzAwLi43NGU0Yjc0YThhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTktMDMtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBQYWdlIFdlaWdodCBpbmRpY2F0b3IgY2xl YXJzIG9uIHBhZ2VzIHdpdGggemVybyBsZW5ndGggcmVzb3VyY2VzIChtYWNydW1vcnMuY29tKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MTcwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL01vZGVscy9EZWZhdWx0RGFzaGJvYXJkLmpzOgorICAgICAgICAoV0kuRGVmYXVsdERh c2hib2FyZC5wcm90b3R5cGUuX3Jlc291cmNlU2l6ZURpZENoYW5nZSk6CisgICAgICAgIENhdGNo IE5hTiBlYXJsaWVyLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2Uu anM6CisgICAgICAgIChXSS5SZXNvdXJjZS5wcm90b3R5cGUudXBkYXRlV2l0aE1ldHJpY3MpOgor ICAgICAgICBXaGVuIHdlIHJlY2VpdmUgZXhhY3QgbWV0cmljcyB0cmFuc2l0aW9uIHRoZSBlc3Rp bWF0ZWQgc2l6ZSB0byB6ZXJvLAorICAgICAgICBzaW5jZSB3ZSB3b24ndCByZWNlaXZlIGFueSBt b3JlIHVwZGF0ZXMgZm9yIHRoZSByZXNvdXJjZS4KKwogMjAxOS0wMy0yMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVs aW5lcyAtIENhbm5vdCBleHBvcnQgb24gYWJvdXQ6YmxhbmsgLSBzdWdnZXN0ZWQgZmlsZW5hbWUg Y29udGFpbmluZyBhIGNvbG9uIHNpbGVudGx5IGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRGVmYXVsdERhc2hib2FyZC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9EZWZhdWx0RGFzaGJvYXJk LmpzCmluZGV4IDIxMGUyNmE2MDZhLi42NDYxN2Y0MzM2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RlZmF1bHREYXNoYm9hcmQuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RlZmF1bHREYXNo Ym9hcmQuanMKQEAgLTE4Myw3ICsxODMsMTAgQEAgV0kuRGVmYXVsdERhc2hib2FyZCA9IGNsYXNz IERlZmF1bHREYXNoYm9hcmQgZXh0ZW5kcyBXSS5PYmplY3QKICAgICB7CiAgICAgICAgIGlmIChl dmVudC50YXJnZXQudXJsQ29tcG9uZW50cy5zY2hlbWUgPT09ICJkYXRhIikKICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgdGhpcy5yZXNvdXJjZXNTaXplICs9IGV2ZW50LnRhcmdldC5zaXpl IC0gZXZlbnQuZGF0YS5wcmV2aW91c1NpemU7CisKKyAgICAgICAgbGV0IGRlbHRhID0gZXZlbnQu dGFyZ2V0LnNpemUgLSBldmVudC5kYXRhLnByZXZpb3VzU2l6ZTsKKyAgICAgICAgY29uc29sZS5h c3NlcnQoaXNOYU4oZGVsdGEpLCAiUmVzb3VyY2Ugc2l6ZSBjaGFuZ2Ugc2hvdWxkIG5ldmVyIGJl IE5hTi4iKTsKKyAgICAgICAgdGhpcy5yZXNvdXJjZXNTaXplICs9IGRlbHRhOwogICAgIH0KIAog ICAgIF9zdGFydFVwZGF0aW5nVGltZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMKaW5kZXggZjJhMGY1Mjg4MGUuLmZk YTA2YzJmOWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvUmVzb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCkBAIC03ODksNiArNzg5LDEwIEBAIFdJLlJlc291cmNl ID0gY2xhc3MgUmVzb3VyY2UgZXh0ZW5kcyBXSS5Tb3VyY2VDb2RlCiAgICAgICAgICAgICBjb25z b2xlLmFzc2VydCh0aGlzLl9yZXNwb25zZUJvZHlUcmFuc2ZlclNpemUgPj0gMCk7CiAgICAgICAg ICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9yZXNwb25zZUJvZHlTaXplID49IDApOwogCisgICAg ICAgICAgICAvLyBUaGVyZSBtYXkgaGF2ZSBiZWVuIG5vIHNpemUgdXBkYXRlcyByZWNlaXZlZCBk dXJpbmcgbG9hZCBpZiBDb250ZW50LUxlbmd0aCB3YXMgMC4KKyAgICAgICAgICAgIGlmIChpc05h Tih0aGlzLl9lc3RpbWF0ZWRTaXplKSkKKyAgICAgICAgICAgICAgICB0aGlzLl9lc3RpbWF0ZWRT aXplID0gMDsKKwogICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0ku UmVzb3VyY2UuRXZlbnQuU2l6ZURpZENoYW5nZSwge3ByZXZpb3VzU2l6ZTogdGhpcy5fZXN0aW1h dGVkU2l6ZX0pOwogICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0ku UmVzb3VyY2UuRXZlbnQuVHJhbnNmZXJTaXplRGlkQ2hhbmdlKTsKICAgICAgICAgfQo=