196159 2019-03-22 14:31:02 -0700 Add WebKit logging for first paint and other interesting layout milestones 2019-03-25 13:47:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1520472 0 krollin 2019-03-22 14:31:02 -0700 Add some logging to indicate what layout milestones have been reached. This should help us determine if there's a client, rendering, layout, or some other issue when page content does not appear in the client window. <rdar://problem/49128952> 1520474 1 krollin 2019-03-22 14:32:37 -0700 The logging is being added to WebFrameLoaderClient::dispatchDidReachLayoutMilestone. This seems like a nice central place to capture layout milestones. However, it will only log notifications that are being sent to clients. It does not indicate all milestones that have occurred. That is, it does not report milestones that are filtered out due to client disinterest. There doesn't seem to be a good central place to capture all milestones, regardless of client interest. 1520477 2 krollin 2019-03-22 14:38:59 -0700 $ rg 'dispatchDidReachLayoutMilestone' low.txt 2019-03-22 14:19:50.805015-0700 0x64f1e3 Default 0x0 1649 0 com.apple.WebKit.WebContent.Development: (WebKit) [com.apple.WebKit:Layout] 0x651bf7ae0 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching DidFirstLayoutForFrame, page = 0x7fcffe004e08 2019-03-22 14:19:50.805017-0700 0x64f1e3 Default 0x0 1649 0 com.apple.WebKit.WebContent.Development: (WebKit) [com.apple.WebKit:Layout] 0x651bf7ae0 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7fcffe004e08 2019-03-22 14:19:50.805029-0700 0x64f1e3 Default 0x0 1649 0 com.apple.WebKit.WebContent.Development: (WebKit) [com.apple.WebKit:Layout] 0x651bf7ae0 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching DidReachLayoutMilestone, page = 0x7fcffe004e08, milestones = DidFirstLayout, DidFirstVisuallyNonEmptyLayout 2019-03-22 14:19:50.805031-0700 0x64f1e3 Default 0x0 1649 0 com.apple.WebKit.WebContent.Development: (WebKit) [com.apple.WebKit:Layout] 0x651bf7ae0 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching DidFirstVisuallyNonEmptyLayoutForFrame, page = 0x7fcffe004e08 2019-03-22 14:19:50.860795-0700 0x64f1e3 Default 0x0 1649 0 com.apple.WebKit.WebContent.Development: (WebKit) [com.apple.WebKit:Layout] 0x651bf7ae0 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching DidReachLayoutMilestone, page = 0x7fcffe004e08, milestones = DidFirstMeaningfulPaint 1520480 3 krollin 2019-03-22 14:41:28 -0700 <rdar://problem/49128952> 1520482 4 365762 krollin 2019-03-22 14:43:18 -0700 Created attachment 365762 Patch 1520991 5 365762 commit-queue 2019-03-25 13:46:59 -0700 Comment on attachment 365762 Patch Clearing flags on attachment: 365762 Committed r243453: <https://trac.webkit.org/changeset/243453> 1520992 6 commit-queue 2019-03-25 13:47:00 -0700 All reviewed patches have been landed. Closing bug. 365762 2019-03-22 14:43:18 -0700 2019-03-25 13:46:59 -0700 Patch bug-196159-20190322144318.patch text/plain 6472 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhYjhhNTg2NmEwY2UwNDEz ZWJjNGMxODkyMDc1MDdlNGJiOWRlNjQuLjVhOGYxYTkzZTA2ZTg4NDlhMjRlYjFkNzNlYjAyMDY4 YTAzYzVlOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTktMDMtMjIgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBXZWJLaXQgbG9nZ2luZyBm b3IgZmlyc3QgcGFpbnQgYW5kIG90aGVyIGludGVyZXN0aW5nIGxheW91dCBtaWxlc3RvbmVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYxNTkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MTI4OTUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzb21lIGxvZ2dpbmcgdG8gaW5kaWNhdGUgd2hh dCBsYXlvdXQgbWlsZXN0b25lcyBoYXZlIGJlZW4gcmVhY2hlZC4KKyAgICAgICAgVGhpcyBzaG91 bGQgaGVscCB1cyBkZXRlcm1pbmUgaWYgdGhlcmUncyBhIGNsaWVudCwgcmVuZGVyaW5nLCBsYXlv dXQsCisgICAgICAgIG9yIHNvbWUgb3RoZXIgaXNzdWUgd2hlbiBwYWdlIGNvbnRlbnQgZG9lcyBu b3QgYXBwZWFyIGluIHRoZSBjbGllbnQKKyAgICAgICAgd2luZG93LgorCisgICAgICAgIFRoZSBs b2dnaW5nIGlzIGJlaW5nIGFkZGVkIHRvCisgICAgICAgIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpk aXNwYXRjaERpZFJlYWNoTGF5b3V0TWlsZXN0b25lLiBUaGlzIHNlZW1zIGxpa2UKKyAgICAgICAg YSBuaWNlIGNlbnRyYWwgcGxhY2UgdG8gY2FwdHVyZSBsYXlvdXQgbWlsZXN0b25lcy4gSG93ZXZl ciwgaXQgd2lsbAorICAgICAgICBvbmx5IGxvZyBub3RpZmljYXRpb25zIHRoYXQgYXJlIGJlaW5n IHNlbnQgdG8gY2xpZW50cy4gSXQgZG9lcyBub3QKKyAgICAgICAgaW5kaWNhdGUgYWxsIG1pbGVz dG9uZXMgdGhhdCBoYXZlIG9jY3VycmVkLiBUaGF0IGlzLCBpdCBkb2VzIG5vdAorICAgICAgICBy ZXBvcnQgbWlsZXN0b25lcyB0aGF0IGFyZSBmaWx0ZXJlZCBvdXQgZHVlIHRvIGNsaWVudCBkaXNp bnRlcmVzdC4KKyAgICAgICAgVGhlcmUgZG9lc24ndCBzZWVtIHRvIGJlIGEgZ29vZCBjZW50cmFs IHBsYWNlIHRvIGNhcHR1cmUgYWxsCisgICAgICAgIG1pbGVzdG9uZXMsIHJlZ2FyZGxlc3Mgb2Yg Y2xpZW50IGludGVyZXN0LgorCisgICAgICAgICogUGxhdGZvcm0vTG9nZ2luZy5oOgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRSZWFjaExh eW91dE1pbGVzdG9uZSk6CisKIDIwMTktMDMtMjIgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBUaGluTFRPIHN1cHBvcnQgaW4gUHJvZHVjdGlvbiBi dWlsZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vTG9nZ2luZy5oIGIvU291 cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggMjM0ZTBhZTVkOTNhZDY4N2Y1Y2Q5 OGY2NDkwOWZhNTcxNWU0OTU3ZS4uNGM1Y2M2NzQ0MWYyYjAxYmE0OWVhZGFiNGQ0MWYzZTkwODFm ODk3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKKysrIGIv U291cmNlL1dlYktpdC9QbGF0Zm9ybS9Mb2dnaW5nLmgKQEAgLTU1LDYgKzU1LDcgQEAgZXh0ZXJu ICJDIiB7CiAgICAgTShJUEMpIFwKICAgICBNKEtleUhhbmRsaW5nKSBcCiAgICAgTShMYXllcnMp IFwKKyAgICBNKExheW91dCkgXAogICAgIE0oTG9hZGluZykgXAogICAgIE0oTG9jYWxTdG9yYWdl RGF0YWJhc2VUcmFja2VyKSBcCiAgICAgTShNb3VzZUhhbmRsaW5nKSBcCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGll bnQuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50LmNwcAppbmRleCA3MzY5NDkxMTkzMGQyNTdkZTk1YjJjZGM5OWUyZDk0MDMx ZDEzYTc0Li41MGM3OWVhZDlkZDZlNTFkODk4NWVjMTdkZTkzZDc2NzY3MWYzNTJkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2Fk ZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKQEAgLTY0Niw2ICs2NDYsOCBAQCB2b2lkIFdlYkZy YW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlYWNoTGF5b3V0TWlsZXN0b25lKE9wdGlvblNl dDxXZWJDb3JlOjpMYQogICAgIFJlZlB0cjxBUEk6Ok9iamVjdD4gdXNlckRhdGE7CiAKICAgICBp ZiAobWlsZXN0b25lcyAmIERpZEZpcnN0TGF5b3V0KSB7CisgICAgICAgIFJFTEVBU0VfTE9HKExh eW91dCwgIiVwIC0gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkUmVhY2hMYXlvdXRN aWxlc3RvbmU6IGRpc3BhdGNoaW5nIERpZEZpcnN0TGF5b3V0Rm9yRnJhbWUsIHBhZ2UgPSAlcCIs IHRoaXMsIHdlYlBhZ2UpOworCiAgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY29uc2lkZXIg cmVtb3ZpbmcgdGhlIG9sZCBkaWRGaXJzdExheW91dCBBUEkgc2luY2UgdGhpcyBpcyBkb2luZyBk b3VibGUgZHV0eSB3aXRoIHRoZQogICAgICAgICAvLyBuZXcgZGlkTGF5b3V0IEFQSS4KICAgICAg ICAgd2ViUGFnZS0+aW5qZWN0ZWRCdW5kbGVMb2FkZXJDbGllbnQoKS5kaWRGaXJzdExheW91dEZv ckZyYW1lKCp3ZWJQYWdlLCAqbV9mcmFtZSwgdXNlckRhdGEpOwpAQCAtNjU0LDYgKzY1Niw3IEBA IHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkUmVhY2hMYXlvdXRNaWxlc3Rv bmUoT3B0aW9uU2V0PFdlYkNvcmU6OkxhCiAjaWYgUExBVEZPUk0oTUFDKQogICAgICAgICAvLyBG SVhNRTogRG8gdGhpcyBvbiBEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQgd2hlbiBNYWMg U2FmYXJpIGlzIGFibGUgdG8gaGFuZGxlIGl0ICg8cmRhcjovL3Byb2JsZW0vMTc1ODAwMjE+KQog ICAgICAgICBpZiAobV9mcmFtZS0+aXNNYWluRnJhbWUoKSAmJiAhbV9kaWRDb21wbGV0ZVBhZ2VU cmFuc2l0aW9uICYmICF3ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLnN1cHByZXNzZXNJ bmNyZW1lbnRhbFJlbmRlcmluZygpKSB7CisgICAgICAgICAgICBSRUxFQVNFX0xPRyhMYXlvdXQs ICIlcCAtIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZFJlYWNoTGF5b3V0TWlsZXN0 b25lOiBkaXNwYXRjaGluZyBkaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uLCBwYWdlID0gJXAiLCB0 aGlzLCB3ZWJQYWdlKTsKICAgICAgICAgICAgIHdlYlBhZ2UtPmRpZENvbXBsZXRlUGFnZVRyYW5z aXRpb24oKTsKICAgICAgICAgICAgIG1fZGlkQ29tcGxldGVQYWdlVHJhbnNpdGlvbiA9IHRydWU7 CiAgICAgICAgIH0KQEAgLTY2NSwxNyArNjY4LDQyIEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGll bnQ6OmRpc3BhdGNoRGlkUmVhY2hMYXlvdXRNaWxlc3RvbmUoT3B0aW9uU2V0PFdlYkNvcmU6Okxh CiAjZW5kaWYKICAgICB9CiAKKyNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQKKyAgICBTdHJpbmdC dWlsZGVyIGJ1aWxkZXI7CisgICAgYXV0byBhZGRJZlNldCA9IFsmbWlsZXN0b25lcywgJmJ1aWxk ZXJdIChXZWJDb3JlOjpMYXlvdXRNaWxlc3RvbmUgbWlsZXN0b25lLCBjb25zdCBTdHJpbmcmIHRv QWRkKSB7CisgICAgICAgIGlmIChtaWxlc3RvbmVzLmNvbnRhaW5zKG1pbGVzdG9uZSkpIHsKKyAg ICAgICAgICAgIGlmICghYnVpbGRlci5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgYnVpbGRl ci5hcHBlbmQoIiwgIik7CisgICAgICAgICAgICBidWlsZGVyLmFwcGVuZCh0b0FkZCk7CisgICAg ICAgIH0KKyAgICB9OworCisgICAgYWRkSWZTZXQoRGlkRmlyc3RMYXlvdXQsICJEaWRGaXJzdExh eW91dCJfcyk7CisgICAgYWRkSWZTZXQoRGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0LCAi RGlkRmlyc3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Il9zKTsKKyAgICBhZGRJZlNldChEaWRIaXRS ZWxldmFudFJlcGFpbnRlZE9iamVjdHNBcmVhVGhyZXNob2xkLCAiRGlkSGl0UmVsZXZhbnRSZXBh aW50ZWRPYmplY3RzQXJlYVRocmVzaG9sZCJfcyk7CisgICAgYWRkSWZTZXQoRGlkRmlyc3RGbHVz aEZvckhlYWRlckxheWVyLCAiRGlkRmlyc3RGbHVzaEZvckhlYWRlckxheWVyIl9zKTsKKyAgICBh ZGRJZlNldChEaWRGaXJzdExheW91dEFmdGVyU3VwcHJlc3NlZEluY3JlbWVudGFsUmVuZGVyaW5n LCAiRGlkRmlyc3RMYXlvdXRBZnRlclN1cHByZXNzZWRJbmNyZW1lbnRhbFJlbmRlcmluZyJfcyk7 CisgICAgYWRkSWZTZXQoRGlkRmlyc3RQYWludEFmdGVyU3VwcHJlc3NlZEluY3JlbWVudGFsUmVu ZGVyaW5nLCAiRGlkRmlyc3RQYWludEFmdGVyU3VwcHJlc3NlZEluY3JlbWVudGFsUmVuZGVyaW5n Il9zKTsKKyAgICBhZGRJZlNldChSZWFjaGVkU2Vzc2lvblJlc3RvcmF0aW9uUmVuZGVyVHJlZVNp emVUaHJlc2hvbGQsICJSZWFjaGVkU2Vzc2lvblJlc3RvcmF0aW9uUmVuZGVyVHJlZVNpemVUaHJl c2hvbGQiX3MpOworICAgIGFkZElmU2V0KERpZFJlbmRlclNpZ25pZmljYW50QW1vdW50T2ZUZXh0 LCAiRGlkUmVuZGVyU2lnbmlmaWNhbnRBbW91bnRPZlRleHQiX3MpOworICAgIGFkZElmU2V0KERp ZEZpcnN0TWVhbmluZ2Z1bFBhaW50LCAiRGlkRmlyc3RNZWFuaW5nZnVsUGFpbnQiX3MpOworCisg ICAgUkVMRUFTRV9MT0coTGF5b3V0LCAiJXAgLSBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0 Y2hEaWRSZWFjaExheW91dE1pbGVzdG9uZTogZGlzcGF0Y2hpbmcgRGlkUmVhY2hMYXlvdXRNaWxl c3RvbmUsIHBhZ2UgPSAlcCwgbWlsZXN0b25lcyA9ICV7cHVibGljfXMiLCB0aGlzLCB3ZWJQYWdl LCBidWlsZGVyLnRvU3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisjZW5kaWYKKwogICAgIC8vIFNl bmQgdGhpcyBhZnRlciBEaWRGaXJzdExheW91dC1zcGVjaWZpYyBjYWxscyBzaW5jZSBzb21lIGNs aWVudHMgZXhwZWN0IHRvIGdldCB0aG9zZSBtZXNzYWdlcyBmaXJzdC4KICAgICB3ZWJQYWdlLT5k aXNwYXRjaERpZFJlYWNoTGF5b3V0TWlsZXN0b25lKG1pbGVzdG9uZXMpOwogCiAgICAgaWYgKG1p bGVzdG9uZXMgJiBEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQpIHsKICAgICAgICAgaWYg KG1fZnJhbWUtPmlzTWFpbkZyYW1lKCkgJiYgIW1fZGlkQ29tcGxldGVQYWdlVHJhbnNpdGlvbiAm JiAhd2ViUGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS5zdXBwcmVzc2VzSW5jcmVtZW50YWxS ZW5kZXJpbmcoKSkgeworICAgICAgICAgICAgUkVMRUFTRV9MT0coTGF5b3V0LCAiJXAgLSBXZWJG cmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRSZWFjaExheW91dE1pbGVzdG9uZTogZGlzcGF0 Y2hpbmcgZGlkQ29tcGxldGVQYWdlVHJhbnNpdGlvbiwgcGFnZSA9ICVwIiwgdGhpcywgd2ViUGFn ZSk7CiAgICAgICAgICAgICB3ZWJQYWdlLT5kaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uKCk7CiAg ICAgICAgICAgICBtX2RpZENvbXBsZXRlUGFnZVRyYW5zaXRpb24gPSB0cnVlOwogICAgICAgICB9 CiAKICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBjb25zaWRlciByZW1vdmluZyB0aGUgb2xk IGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lIEFQSSBzaW5jZSB0aGlzIGlz IGRvaW5nCiAgICAgICAgIC8vIGRvdWJsZSBkdXR5IHdpdGggdGhlIG5ldyBkaWRMYXlvdXQgQVBJ LgorICAgICAgICBSRUxFQVNFX0xPRyhMYXlvdXQsICIlcCAtIFdlYkZyYW1lTG9hZGVyQ2xpZW50 OjpkaXNwYXRjaERpZFJlYWNoTGF5b3V0TWlsZXN0b25lOiBkaXNwYXRjaGluZyBEaWRGaXJzdFZp c3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JGcmFtZSwgcGFnZSA9ICVwIiwgdGhpcywgd2ViUGFnZSk7 CiAgICAgICAgIHdlYlBhZ2UtPmluamVjdGVkQnVuZGxlTG9hZGVyQ2xpZW50KCkuZGlkRmlyc3RW aXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUoKndlYlBhZ2UsICptX2ZyYW1lLCB1c2VyRGF0 YSk7CiAgICAgICAgIHdlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGlkRmly c3RWaXN1YWxseU5vbkVtcHR5TGF5b3V0Rm9yRnJhbWUobV9mcmFtZS0+ZnJhbWVJRCgpLCBVc2Vy RGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS50cmFuc2Zvcm1PYmplY3RzVG9IYW5kbGVzKHVz ZXJEYXRhLmdldCgpKS5nZXQoKSkpKTsKICAgICB9Cg==