196154 2019-03-22 10:38:47 -0700 Placate exception check validation in genericTypedArrayViewProtoFuncLastIndexOf(). 2019-03-24 08:42:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam dominik.infuehr ews-watchlist fpizlo keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1520403 0 mark.lam 2019-03-22 10:38:47 -0700 <rdar://problem/49145307> 1520412 1 365742 mark.lam 2019-03-22 10:42:16 -0700 Created attachment 365742 proposed patch. 1520420 2 365743 mark.lam 2019-03-22 10:47:52 -0700 Created attachment 365743 proposed patch. 1520426 3 mark.lam 2019-03-22 10:59:53 -0700 Thanks for the review. Landed in r243391: <http://trac.webkit.org/r243391>. 1520687 4 dominik.infuehr 2019-03-24 03:30:52 -0700 Hi! web-assembly-link-error-exception-check.js is failing on 32-bit because WebAssembly isn't supported. Shouldn't this test be moved into JSTests/wasm/stress? 1520711 5 dominik.infuehr 2019-03-24 08:42:41 -0700 I've uploaded a patch that moves this test into JSTests/wasm/stress: https://bugs.webkit.org/show_bug.cgi?id=196187 365742 2019-03-22 10:42:16 -0700 2019-03-22 10:47:52 -0700 proposed patch. bug-196154.patch text/plain 3070 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMzODYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBQbGFjYXRlIGV4Y2VwdGlvbiBjaGVjayB2YWxpZGF0aW9uIGluIGdlbmVy aWNUeXBlZEFycmF5Vmlld1Byb3RvRnVuY0xhc3RJbmRleE9mKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYxNTQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ5MTQ1MzA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogc3RyZXNzL3R5cGVkLWFycmF5LWxhc3RJbmRleE9mLWV4Y2VwdGlvbi1jaGVj ay5qczogQWRkZWQuCisKIDIwMTktMDMtMjIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIFBsYWNhdGUgZXhjZXB0aW9uIGNoZWNrIHZhbGlkYXRpb24gaW4gY29uc3Ry dWN0SlNXZWJBc3NlbWJseUxpbmtFcnJvcigpLgpJbmRleDogSlNUZXN0cy9zdHJlc3MvdHlwZWQt YXJyYXktbGFzdEluZGV4T2YtZXhjZXB0aW9uLWNoZWNrLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVz dHMvc3RyZXNzL3R5cGVkLWFycmF5LWxhc3RJbmRleE9mLWV4Y2VwdGlvbi1jaGVjay5qcwkobm9u ZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy90eXBlZC1hcnJheS1sYXN0SW5kZXhPZi1leGNl cHRpb24tY2hlY2suanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzIEBACituZXcgVWludDhB cnJheSgpLmxhc3RJbmRleE9mKDAsIHsKKyAgdmFsdWVPZjogKCkgPT4gLTEKK30pOwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDMzODYpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTkt MDMtMjIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBsYWNhdGUg ZXhjZXB0aW9uIGNoZWNrIHZhbGlkYXRpb24gaW4gZ2VuZXJpY1R5cGVkQXJyYXlWaWV3UHJvdG9G dW5jTGFzdEluZGV4T2YoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NjE1NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkxNDUzMDc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0pT R2VuZXJpY1R5cGVkQXJyYXlWaWV3UHJvdG90eXBlRnVuY3Rpb25zLmg6CisgICAgICAgIChKU0M6 OmdlbmVyaWNUeXBlZEFycmF5Vmlld1Byb3RvRnVuY0xhc3RJbmRleE9mKToKKwogMjAxOS0wMy0y MiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUGxhY2F0ZSBleGNl cHRpb24gY2hlY2sgdmFsaWRhdGlvbiBpbiBjb25zdHJ1Y3RKU1dlYkFzc2VtYmx5TGlua0Vycm9y KCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dlbmVyaWNUeXBlZEFy cmF5Vmlld1Byb3RvdHlwZUZ1bmN0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3UHJvdG90eXBlRnVuY3Rpb25z LmgJKHJldmlzaW9uIDI0MzM4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT R2VuZXJpY1R5cGVkQXJyYXlWaWV3UHJvdG90eXBlRnVuY3Rpb25zLmgJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTcgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CkBAIC0zMTcsNiArMzE3LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBnZW5lcmlj VHlwZQogICAgIGlmIChleGVjLT5hcmd1bWVudENvdW50KCkgPj0gMikgewogICAgICAgICBKU1Zh bHVlIGZyb21WYWx1ZSA9IGV4ZWMtPnVuY2hlY2tlZEFyZ3VtZW50KDEpOwogICAgICAgICBkb3Vi bGUgZnJvbURvdWJsZSA9IGZyb21WYWx1ZS50b0ludGVnZXIoZXhlYyk7CisgICAgICAgIFJFVFVS Tl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgICAgICBpZiAoZnJv bURvdWJsZSA8IDApIHsKICAgICAgICAgICAgIGZyb21Eb3VibGUgKz0gbGVuZ3RoOwogICAgICAg ICAgICAgaWYgKGZyb21Eb3VibGUgPCAwKQpAQCAtMzI2LDggKzMyNyw2IEBAIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZ2VuZXJpY1R5cGUKICAgICAgICAgICAgIGluZGV4ID0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KGZyb21Eb3VibGUpOwogICAgIH0KIAotICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotCiAgICAgaWYgKHRoaXNPYmplY3QtPmlz TmV1dGVyZWQoKSkKICAgICAgICAgcmV0dXJuIHRocm93Vk1UeXBlRXJyb3IoZXhlYywgc2NvcGUs IHR5cGVkQXJyYXlCdWZmZXJIYXNCZWVuRGV0YWNoZWRFcnJvck1lc3NhZ2UpOwogCg== 365743 2019-03-22 10:47:52 -0700 2019-03-22 10:49:58 -0700 proposed patch. bug-196154.patch text/plain 3678 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMzODYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBQbGFjYXRlIGV4Y2VwdGlvbiBjaGVjayB2YWxpZGF0aW9uIGluIGdlbmVy aWNUeXBlZEFycmF5Vmlld1Byb3RvRnVuY0xhc3RJbmRleE9mKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYxNTQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ5MTQ1MzA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFsc28gYWRkZWQgLy9AIHJ1bkRlZmF1bHQgY29uc3RyYWludCB0byB3ZWItYXNz ZW1ibHktbGluay1lcnJvci1leGNlcHRpb24tY2hlY2suanMuCisgICAgICAgIFRoZXJlJ3Mgbm8g bmVlZCB0byBydW4gdGhpcyB0ZXN0IG9uIG1vcmUgdGhhbiAxIHRlc3QgY29uZmlndXJhdGlvbi4K KworICAgICAgICAqIHN0cmVzcy90eXBlZC1hcnJheS1sYXN0SW5kZXhPZi1leGNlcHRpb24tY2hl Y2suanM6IEFkZGVkLgorICAgICAgICAqIHN0cmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1l eGNlcHRpb24tY2hlY2suanM6CisKIDIwMTktMDMtMjIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFBsYWNhdGUgZXhjZXB0aW9uIGNoZWNrIHZhbGlkYXRpb24gaW4g Y29uc3RydWN0SlNXZWJBc3NlbWJseUxpbmtFcnJvcigpLgpJbmRleDogSlNUZXN0cy9zdHJlc3Mv dHlwZWQtYXJyYXktbGFzdEluZGV4T2YtZXhjZXB0aW9uLWNoZWNrLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEpTVGVzdHMvc3RyZXNzL3R5cGVkLWFycmF5LWxhc3RJbmRleE9mLWV4Y2VwdGlvbi1jaGVjay5q cwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy90eXBlZC1hcnJheS1sYXN0SW5kZXhP Zi1leGNlcHRpb24tY2hlY2suanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1IEBACisvL0Ag cnVuRGVmYXVsdAorCituZXcgVWludDhBcnJheSgpLmxhc3RJbmRleE9mKDAsIHsKKyAgICB2YWx1 ZU9mOiAoKSA9PiAtMQorfSk7CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy93ZWItYXNzZW1ibHktbGlu ay1lcnJvci1leGNlcHRpb24tY2hlY2suanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mv d2ViLWFzc2VtYmx5LWxpbmstZXJyb3ItZXhjZXB0aW9uLWNoZWNrLmpzCShyZXZpc2lvbiAyNDMz ODYpCisrKyBKU1Rlc3RzL3N0cmVzcy93ZWItYXNzZW1ibHktbGluay1lcnJvci1leGNlcHRpb24t Y2hlY2suanMJKHdvcmtpbmcgY29weSkKQEAgLTEgKzEsMyBAQAorLy9AIHJ1bkRlZmF1bHQKKwog bmV3IFdlYkFzc2VtYmx5LkxpbmtFcnJvcihbXSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDI0MzM4NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wMy0yMiAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUGxhY2F0ZSBleGNlcHRpb24gY2hlY2sgdmFs aWRhdGlvbiBpbiBnZW5lcmljVHlwZWRBcnJheVZpZXdQcm90b0Z1bmNMYXN0SW5kZXhPZigpLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MTU0Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTE0NTMwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZp ZXdQcm90b3R5cGVGdW5jdGlvbnMuaDoKKyAgICAgICAgKEpTQzo6Z2VuZXJpY1R5cGVkQXJyYXlW aWV3UHJvdG9GdW5jTGFzdEluZGV4T2YpOgorCiAyMDE5LTAzLTIyICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBQbGFjYXRlIGV4Y2VwdGlvbiBjaGVjayB2YWxpZGF0 aW9uIGluIGNvbnN0cnVjdEpTV2ViQXNzZW1ibHlMaW5rRXJyb3IoKS4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3UHJvdG90eXBlRnVu Y3Rpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH ZW5lcmljVHlwZWRBcnJheVZpZXdQcm90b3R5cGVGdW5jdGlvbnMuaAkocmV2aXNpb24gMjQzMzg1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZp ZXdQcm90b3R5cGVGdW5jdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8q Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAxNyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTMxNyw2ICszMTcsNyBA QCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGdlbmVyaWNUeXBlCiAgICAgaWYgKGV4ZWMt PmFyZ3VtZW50Q291bnQoKSA+PSAyKSB7CiAgICAgICAgIEpTVmFsdWUgZnJvbVZhbHVlID0gZXhl Yy0+dW5jaGVja2VkQXJndW1lbnQoMSk7CiAgICAgICAgIGRvdWJsZSBmcm9tRG91YmxlID0gZnJv bVZhbHVlLnRvSW50ZWdlcihleGVjKTsKKyAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29w ZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgICAgIGlmIChmcm9tRG91YmxlIDwgMCkgewogICAg ICAgICAgICAgZnJvbURvdWJsZSArPSBsZW5ndGg7CiAgICAgICAgICAgICBpZiAoZnJvbURvdWJs ZSA8IDApCkBAIC0zMjYsOCArMzI3LDYgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBn ZW5lcmljVHlwZQogICAgICAgICAgICAgaW5kZXggPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oZnJv bURvdWJsZSk7CiAgICAgfQogCi0gICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2Rl ZEpTVmFsdWUoKSk7Ci0KICAgICBpZiAodGhpc09iamVjdC0+aXNOZXV0ZXJlZCgpKQogICAgICAg ICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihleGVjLCBzY29wZSwgdHlwZWRBcnJheUJ1ZmZlckhh c0JlZW5EZXRhY2hlZEVycm9yTWVzc2FnZSk7CiAK