196152 2019-03-22 10:08:40 -0700 Placate exception check validation in constructJSWebAssemblyLinkError(). 2019-03-24 08:41:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue dominik.infuehr ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1520378 0 mark.lam 2019-03-22 10:08:40 -0700 <rdar://problem/49145257> 1520380 1 webkit-bug-importer 2019-03-22 10:10:43 -0700 <rdar://problem/49157806> 1520381 2 mark.lam 2019-03-22 10:12:00 -0700 <rdar://problem/49145257> 1520383 3 365739 mark.lam 2019-03-22 10:13:54 -0700 Created attachment 365739 proposed patch. 1520388 4 365739 msaboff 2019-03-22 10:17:13 -0700 Comment on attachment 365739 proposed patch. r=me 1520390 5 mark.lam 2019-03-22 10:22:19 -0700 Thanks for the review. Landed in r243386: <http://trac.webkit.org/r243386>. 1520710 6 dominik.infuehr 2019-03-24 08:41:00 -0700 web-assembly-link-error-exception-check.js is failing on 32-bit systems because of missing WASM support. I've uploaded a patch that moves this test into JSTests/wasm/stress: https://bugs.webkit.org/show_bug.cgi?id=196187 365739 2019-03-22 10:13:54 -0700 2019-03-22 10:30:57 -0700 proposed patch. bug-196152.patch text/plain 2939 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMzODMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBQbGFjYXRlIGV4Y2VwdGlvbiBjaGVjayB2YWxpZGF0aW9uIGluIGNvbnN0 cnVjdEpTV2ViQXNzZW1ibHlMaW5rRXJyb3IoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjE1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkx NDUyNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBzdHJlc3Mvd2ViLWFzc2VtYmx5LWxpbmstZXJyb3ItZXhjZXB0aW9uLWNoZWNrLmpzOiBBZGRl ZC4KKwogMjAxOS0wMy0yMiAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlhLmNvbT4K IAogICAgICAgICBTa2lwIHRlc3RzIHJ1bm5pbmcgb3V0IG9mIG1lbW9yeSBvbiBBUk0vTUlQUwpJ bmRleDogSlNUZXN0cy9zdHJlc3Mvd2ViLWFzc2VtYmx5LWxpbmstZXJyb3ItZXhjZXB0aW9uLWNo ZWNrLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3dlYi1hc3NlbWJseS1saW5rLWVy cm9yLWV4Y2VwdGlvbi1jaGVjay5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy93 ZWItYXNzZW1ibHktbGluay1lcnJvci1leGNlcHRpb24tY2hlY2suanMJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSBAQAorbmV3IFdlYkFzc2VtYmx5LkxpbmtFcnJvcihbXSk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzM0NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wMy0y MiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUGxhY2F0ZSBleGNl cHRpb24gY2hlY2sgdmFsaWRhdGlvbiBpbiBjb25zdHJ1Y3RKU1dlYkFzc2VtYmx5TGlua0Vycm9y KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYx NTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5MTQ1MjU3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2FzbS9qcy9XZWJBc3NlbWJseUxpbmtF cnJvckNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Y29uc3RydWN0SlNXZWJBc3NlbWJs eUxpbmtFcnJvcik6CisKIDIwMTktMDMtMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSBhbiBpbnZhbGlkIGFzc2VydGlvbiBpbiBERkc6OlNwZWN1bGF0 aXZlSklUOjpub25TcGVjdWxhdGl2ZU5vblBlZXBob2xlQ29tcGFyZU51bGxPclVuZGVmaW5lZCgp LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vanMvV2ViQXNzZW1ibHlMaW5rRXJy b3JDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vanMvV2ViQXNzZW1ibHlMaW5rRXJyb3JDb25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDI0MzM0 NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFzc2VtYmx5TGlua0Vycm9y Q29uc3RydWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENv cHlyaWdodCAoQykgMjAxNi0yMDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxNi0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNTEsNyArNTEsNyBAQCBzdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zCiAgICAgSlNWYWx1ZSBtZXNzYWdlID0g ZXhlYy0+YXJndW1lbnQoMCk7CiAgICAgYXV0byogc3RydWN0dXJlID0gSW50ZXJuYWxGdW5jdGlv bjo6Y3JlYXRlU3ViY2xhc3NTdHJ1Y3R1cmUoZXhlYywgZXhlYy0+bmV3VGFyZ2V0KCksIGpzQ2Fz dDxJbnRlcm5hbEZ1bmN0aW9uKj4oZXhlYy0+anNDYWxsZWUoKSktPmdsb2JhbE9iamVjdCh2bSkt PndlYkFzc2VtYmx5TGlua0Vycm9yU3RydWN0dXJlKCkpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJ T04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo SlNXZWJBc3NlbWJseUxpbmtFcnJvcjo6Y3JlYXRlKGV4ZWMsIHZtLCBzdHJ1Y3R1cmUsIG1lc3Nh Z2UpKTsKKyAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIEpTVmFsdWU6OmVuY29kZShKU1dl YkFzc2VtYmx5TGlua0Vycm9yOjpjcmVhdGUoZXhlYywgdm0sIHN0cnVjdHVyZSwgbWVzc2FnZSkp KTsKIH0KIAogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY2FsbEpTV2ViQXNz ZW1ibHlMaW5rRXJyb3IoRXhlY1N0YXRlKiBleGVjKQo=