196148 2019-03-22 07:55:36 -0700 [Flatpak] Manifest expanding fails for qt WPE extension 2019-03-22 10:46:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand achristensen cgarcia commit-queue lforschler tsaunier webkit-bug-importer oldest_to_newest 1520305 0 pnormand 2019-03-22 07:55:36 -0700 $ Tools/Scripts/webkit-flatpak --platform wpe --wpe-extension=qt --update Updating Flatpak environment for WPE (Release) Installing for user: org.kde.Platform/x86_64/5.11 from flathub [####################] 12 delta parts, 104 loose fetched; 298436 KiB transferred in 22 seconds Installing for user: org.freedesktop.Platform.ffmpeg/x86_64/1.6 from flathub [####################] 1 delta parts, 2 loose fetched; 2649 KiB transferred in 0 seconds Installing for user: org.kde.KStyle.Adwaita/x86_64/5.11 from flathub [####################] 1 delta parts, 2 loose fetched; 351 KiB transferred in 0 seconds Installing for user: org.kde.Platform.Locale/x86_64/5.11 from flathub [####################] 4 metadata, 1 content objects fetched; 14 KiB transferred in 0 seconds Installing for user: org.kde.Sdk/x86_64/5.11 from flathub [####################] 22 delta parts, 117 loose fetched; 274907 KiB transferred in 32 seconds Installing for user: org.kde.Sdk.Locale/x86_64/5.11 from flathub [####################] 3 metadata, 1 content objects fetched; 13 KiB transferred in 0 seconds Installing for user: org.kde.Platform.Locale/x86_64/5.11 from flathub [####################] 5 delta parts, 128 loose fetched; 100516 KiB transferred in 6 seconds Building org.webkit.WPE and dependencies in /home/igalia/pnormand/WebKit/WebKitBuild/WPE/FlatpakTreeRelease Traceback (most recent call last): File "Tools/Scripts/webkit-flatpak", line 28, in <module> sys.exit(WebkitFlatpak.load_from_args().run()) File "./Tools/flatpak/flatpakutils.py", line 836, in run return self.setup_dev_env() File "./Tools/flatpak/flatpakutils.py", line 872, in setup_dev_env self.name, self.sandbox_source_root, self.command): File "./Tools/flatpak/flatpakutils.py", line 209, in expand_manifest modules = expand_submodules_recurse(modules, manifest_path, port_name, command) File "./Tools/flatpak/flatpakutils.py", line 178, in expand_submodules_recurse submanifest = load_manifest(submanifest_path, port_name=port_name, command=command) File "./Tools/flatpak/flatpakutils.py", line 152, in load_manifest with open(manifest_path, "r") as mr: IOError: [Errno 2] No such file or directory: '/home/igalia/pnormand/WebKit/Tools/flatpak/buildsystem' 1520310 1 365727 pnormand 2019-03-22 08:00:02 -0700 Created attachment 365727 Patch 1520313 2 365727 tsaunier 2019-03-22 08:24:10 -0700 Comment on attachment 365727 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365727&action=review Looks good otherwise. > Tools/flatpak/flatpakutils.py:176 > + if type(modules) != list: Should be `if not isinstance(modules, list)` 1520314 3 365728 pnormand 2019-03-22 08:29:38 -0700 Created attachment 365728 Patch 1520315 4 365728 tsaunier 2019-03-22 08:30:30 -0700 Comment on attachment 365728 Patch Informal r+ 1520405 5 365728 commit-queue 2019-03-22 10:40:19 -0700 Comment on attachment 365728 Patch Clearing flags on attachment: 365728 Committed r243387: <https://trac.webkit.org/changeset/243387> 1520406 6 commit-queue 2019-03-22 10:40:21 -0700 All reviewed patches have been landed. Closing bug. 1520418 7 webkit-bug-importer 2019-03-22 10:46:53 -0700 <rdar://problem/49159586> 365727 2019-03-22 08:00:02 -0700 2019-03-22 08:29:34 -0700 Patch bug-196148-20190322160001.patch text/plain 1595 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTIwOWEzZDEzMTI2YTRkMjkxZThiMmY3NWNiMzU0MjZh MDFlODE1Ni4uNTc0NDI1NWJlYWJhNTc3ZTllYTAzYzU1NmEzNTE2ZGFjMDBhYjEwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAzLTIyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBha10gTWFuaWZlc3QgZXhwYW5kaW5nIGZhaWxzIGZvciBxdCBXUEUg ZXh0ZW5zaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTYxNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZsYXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoZXhwYW5kX3N1Ym1vZHVsZXNf cmVjdXJzZSk6IFRoZSBsYXN0IHJlY3Vyc2UgbWFuaWZlc3QgZXhwYW5kCisgICAgICAgIGl0ZXJh dGlvbiBtaWdodCBsZWFkIHRvIGEgc2luZ2xlIG1vZHVsZSBzbyB0YWtlIGl0IGludG8gYWNjb3Vu dAorICAgICAgICBhbmQgZG9uJ3QgdHJ5IHRvIHJlY3Vyc2UgZnVydGhlci4KKwogMjAxOS0wMy0y MiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJhY2sgb3V0 IGxvY2FsIGNoYW5nZXMgdG8gQWxleCdzIFN1YnZlcnNpb24gd29ya2luZyBkaXJlY3RvcnkKZGlm ZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxhdHBhay9m bGF0cGFrdXRpbHMucHkKaW5kZXggMGUzZDEzMjFhZmRjZDE2MmU5OGYxMGJjMGRhZTgzZDIyMTUw NGM2YS4uNzBlNmM5YzU2ODU1MDRlMWY0NzQxYzAyZGUyNjllYjgzYTYwNjg5NiAxMDA2NDQKLS0t IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkKKysrIGIvVG9vbHMvZmxhdHBhay9mbGF0 cGFrdXRpbHMucHkKQEAgLTE3Miw2ICsxNzIsMTEgQEAgZGVmIGV4cGFuZF9zdWJtb2R1bGVzX3Jl Y3Vyc2UobW9kdWxlcywgbWFuaWZlc3RfcGF0aCwgcG9ydF9uYW1lLCBjb21tYW5kKToKICAgICAg ICAgYWxsX21vZHVsZXMuZXh0ZW5kKGV4cGFuZF9zdWJtb2R1bGVzX3JlY3Vyc2Uoc3VibWFuaWZl c3QsIHN1Ym1hbmlmZXN0X3BhdGgsIHBvcnRfbmFtZSwgY29tbWFuZCkpCiAgICAgICAgIHJldHVy biBhbGxfbW9kdWxlcwogCisgICAgIyBUaGUgbGFzdCByZWN1cnNlIG1hbmlmZXN0IGV4cGFuZCBp dGVyYXRpb24gbWlnaHQgbGVhZCB0byBhIHNpbmdsZSBtb2R1bGUuCisgICAgaWYgdHlwZShtb2R1 bGVzKSAhPSBsaXN0OgorICAgICAgICBhbGxfbW9kdWxlcy5hcHBlbmQobW9kdWxlcykKKyAgICAg ICAgcmV0dXJuIGFsbF9tb2R1bGVzCisKICAgICBmb3IgbW9kdWxlIGluIG1vZHVsZXM6CiAgICAg ICAgIGlmIHR5cGUobW9kdWxlKSBpcyBzdHI6CiAgICAgICAgICAgICBzdWJtYW5pZmVzdF9wYXRo ID0gb3MucGF0aC5qb2luKG9zLnBhdGguZGlybmFtZShtYW5pZmVzdF9wYXRoKSwgbW9kdWxlKQo= 365728 2019-03-22 08:29:38 -0700 2019-03-22 10:40:19 -0700 Patch bug-196148-20190322162936.patch text/plain 1603 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTIwOWEzZDEzMTI2YTRkMjkxZThiMmY3NWNiMzU0MjZh MDFlODE1Ni4uNTc0NDI1NWJlYWJhNTc3ZTllYTAzYzU1NmEzNTE2ZGFjMDBhYjEwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAzLTIyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBha10gTWFuaWZlc3QgZXhwYW5kaW5nIGZhaWxzIGZvciBxdCBXUEUg ZXh0ZW5zaW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTYxNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGZsYXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoZXhwYW5kX3N1Ym1vZHVsZXNf cmVjdXJzZSk6IFRoZSBsYXN0IHJlY3Vyc2UgbWFuaWZlc3QgZXhwYW5kCisgICAgICAgIGl0ZXJh dGlvbiBtaWdodCBsZWFkIHRvIGEgc2luZ2xlIG1vZHVsZSBzbyB0YWtlIGl0IGludG8gYWNjb3Vu dAorICAgICAgICBhbmQgZG9uJ3QgdHJ5IHRvIHJlY3Vyc2UgZnVydGhlci4KKwogMjAxOS0wMy0y MiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJhY2sgb3V0 IGxvY2FsIGNoYW5nZXMgdG8gQWxleCdzIFN1YnZlcnNpb24gd29ya2luZyBkaXJlY3RvcnkKZGlm ZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxhdHBhay9m bGF0cGFrdXRpbHMucHkKaW5kZXggMGUzZDEzMjFhZmRjZDE2MmU5OGYxMGJjMGRhZTgzZDIyMTUw NGM2YS4uMDRkN2M4ZGNhNGRhNWE1ZWFhNDM3ZWJmMDYyZDQxNmY0MDFiYzM3NiAxMDA2NDQKLS0t IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkKKysrIGIvVG9vbHMvZmxhdHBhay9mbGF0 cGFrdXRpbHMucHkKQEAgLTE3Miw2ICsxNzIsMTEgQEAgZGVmIGV4cGFuZF9zdWJtb2R1bGVzX3Jl Y3Vyc2UobW9kdWxlcywgbWFuaWZlc3RfcGF0aCwgcG9ydF9uYW1lLCBjb21tYW5kKToKICAgICAg ICAgYWxsX21vZHVsZXMuZXh0ZW5kKGV4cGFuZF9zdWJtb2R1bGVzX3JlY3Vyc2Uoc3VibWFuaWZl c3QsIHN1Ym1hbmlmZXN0X3BhdGgsIHBvcnRfbmFtZSwgY29tbWFuZCkpCiAgICAgICAgIHJldHVy biBhbGxfbW9kdWxlcwogCisgICAgIyBUaGUgbGFzdCByZWN1cnNlIG1hbmlmZXN0IGV4cGFuZCBp dGVyYXRpb24gbWlnaHQgbGVhZCB0byBhIHNpbmdsZSBtb2R1bGUuCisgICAgaWYgbm90IGlzaW5z dGFuY2UobW9kdWxlcywgbGlzdCk6CisgICAgICAgIGFsbF9tb2R1bGVzLmFwcGVuZChtb2R1bGVz KQorICAgICAgICByZXR1cm4gYWxsX21vZHVsZXMKKwogICAgIGZvciBtb2R1bGUgaW4gbW9kdWxl czoKICAgICAgICAgaWYgdHlwZShtb2R1bGUpIGlzIHN0cjoKICAgICAgICAgICAgIHN1Ym1hbmlm ZXN0X3BhdGggPSBvcy5wYXRoLmpvaW4ob3MucGF0aC5kaXJuYW1lKG1hbmlmZXN0X3BhdGgpLCBt b2R1bGUpCg==