196124 2019-03-21 18:54:55 -0700 Clean up some TiledCoreAnimationDrawingArea members 2019-03-21 21:30:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton webkit-bug-importer oldest_to_newest 1520095 0 simon.fraser 2019-03-21 18:54:55 -0700 Clean up some TiledCoreAnimationDrawingArea members 1520096 1 365663 simon.fraser 2019-03-21 18:55:32 -0700 Created attachment 365663 Patch 1520103 2 365663 simon.fraser 2019-03-21 19:04:07 -0700 Comment on attachment 365663 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365663&action=review > Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:698 > - [m_rootLayer setSublayerTransform:m_transform]; > + [m_rootLayer setSublayerTransform:CATransform3DIdentity]; // FIXME: is this necessary? This can be removed. 1520154 3 simon.fraser 2019-03-21 21:23:01 -0700 https://trac.webkit.org/r243360 1520155 4 webkit-bug-importer 2019-03-21 21:30:46 -0700 <rdar://problem/49138635> 365663 2019-03-21 18:55:32 -0700 2019-03-21 19:00:24 -0700 Patch bug-196124-20190321185531.patch text/plain 5219 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0MTllZWIyZWE5MDVmMzIx MGQxMmIyMGRiMWJhMGI3NDg3ODAzYWYuLjhlM2ZmNThlYzg5MDAwMzY0ZmQwZjNkZjNlZTcxNGYz MWEzNzhlNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDMtMjEgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgc29tZSBU aWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYSBtZW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYxMjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZ2lhbnQgbV90cmFuc2Zvcm0gd2FzIHVu dXNlZC4KKyAgICAgICAgCisgICAgICAgIEdyb3VwIHRoZSBib29scyBldGMuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmg6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3 aW5nQXJlYS5tbToKKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0Fy ZWE6OlRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhKToKKyAgICAgICAgKFdlYktpdDo6VGls ZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNldFJvb3RDb21wb3NpdGluZ0xheWVyKToKKwog MjAxOS0wMy0yMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TIFdLMl0gVHVybiBvbiBhc3luYyBvdmVyZmxvdyBzY3JvbGxpbmcgYnkgZGVmYXVs dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVk Q29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaAppbmRleCA3NDY2MWZkM2Rl MjNiMmMwNjVmMWYyMDdjMDJiOTQwZWNjMTI3MGQyLi41OGJkYTY0MWQxOGJiYzE2ZTVhNDI0OGU3 M2JkMjYzZGFjZWQwM2ZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEu aApAQCAtMTM2LDI4ICsxMzYsMjUgQEAgcHJpdmF0ZToKICAgICB2b2lkIHN0YXJ0TGF5ZXJGbHVz aFRocm90dGxpbmdUaW1lcigpOwogICAgIHZvaWQgbGF5ZXJGbHVzaFRocm90dGxpbmdUaW1lckZp cmVkKCk7CiAKLSAgICBib29sIG1fbGF5ZXJUcmVlU3RhdGVJc0Zyb3plbjsKLQogICAgIHN0ZDo6 dW5pcXVlX3B0cjxMYXllckhvc3RpbmdDb250ZXh0PiBtX2xheWVySG9zdGluZ0NvbnRleHQ7CiAK ICAgICBSZXRhaW5QdHI8Q0FMYXllcj4gbV9ob3N0aW5nTGF5ZXI7CiAgICAgUmV0YWluUHRyPENB TGF5ZXI+IG1fcm9vdExheWVyOwogICAgIFJldGFpblB0cjxDQUxheWVyPiBtX2RlYnVnSW5mb0xh eWVyOwotCiAgICAgUmV0YWluUHRyPENBTGF5ZXI+IG1fcGVuZGluZ1Jvb3RMYXllcjsKIAotICAg IGJvb2wgbV9pc1BhaW50aW5nU3VzcGVuZGVkOwotCiAgICAgT3B0aW9uYWw8V2ViQ29yZTo6Rmxv YXRSZWN0PiBtX3ZpZXdFeHBvc2VkUmVjdDsKICAgICBPcHRpb25hbDxXZWJDb3JlOjpGbG9hdFJl Y3Q+IG1fc2Nyb2xsZWRWaWV3RXhwb3NlZFJlY3Q7CiAKKyAgICBXZWJDb3JlOjpJbnRTaXplIG1f bGFzdFZpZXdTaXplRm9yU2NhbGVUb0ZpdDsKKyAgICBXZWJDb3JlOjpJbnRTaXplIG1fbGFzdERv Y3VtZW50U2l6ZUZvclNjYWxlVG9GaXQ7CisKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fbGFzdFNl bnRJbnRyaW5zaWNDb250ZW50U2l6ZTsKLSAgICBib29sIG1faW5VcGRhdGVHZW9tZXRyeTsKIAot ICAgIGRvdWJsZSBtX3RyYW5zaWVudFpvb21TY2FsZTsKKyAgICBkb3VibGUgbV90cmFuc2llbnRa b29tU2NhbGUgeyAxIH07CiAgICAgV2ViQ29yZTo6RmxvYXRQb2ludCBtX3RyYW5zaWVudFpvb21P cmlnaW47CiAKLSAgICBXZWJDb3JlOjpUcmFuc2Zvcm1hdGlvbk1hdHJpeCBtX3RyYW5zZm9ybTsK KyAgICBXZWJDb3JlOjpUaW1lciBtX2xheWVyRmx1c2hUaHJvdHRsaW5nVGltZXI7CiAKICAgICBS dW5Mb29wOjpUaW1lcjxUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYT4gbV9zZW5kRGlkVXBk YXRlQWN0aXZpdHlTdGF0ZVRpbWVyOwogICAgIFZlY3RvcjxDYWxsYmFja0lEPiBtX25leHRBY3Rp dml0eVN0YXRlQ2hhbmdlQ2FsbGJhY2tJRHM7CkBAIC0xNjUsMjEgKzE2MiwxOSBAQCBwcml2YXRl OgogCiAgICAgUmVmUHRyPFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXI+IG1fdmlld092ZXJsYXlSb290 TGF5ZXI7CiAKLSAgICBib29sIG1fc2hvdWxkU2NhbGVWaWV3VG9GaXREb2N1bWVudCB7IGZhbHNl IH07Ci0gICAgYm9vbCBtX2lzU2NhbGluZ1ZpZXdUb0ZpdERvY3VtZW50IHsgZmFsc2UgfTsKLSAg ICBXZWJDb3JlOjpJbnRTaXplIG1fbGFzdFZpZXdTaXplRm9yU2NhbGVUb0ZpdDsKLSAgICBXZWJD b3JlOjpJbnRTaXplIG1fbGFzdERvY3VtZW50U2l6ZUZvclNjYWxlVG9GaXQ7Ci0KICAgICBPcHRp b25TZXQ8V2ViQ29yZTo6TGF5b3V0TWlsZXN0b25lPiBtX3BlbmRpbmdOZXdseVJlYWNoZWRMYXlv dXRNaWxlc3RvbmVzOwogICAgIFZlY3RvcjxDYWxsYmFja0lEPiBtX3BlbmRpbmdDYWxsYmFja0lE czsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpSdW5Mb29wT2JzZXJ2ZXI+IG1fbGF5 ZXJGbHVzaFJ1bkxvb3BPYnNlcnZlcjsKIAorICAgIGJvb2wgbV9pc1BhaW50aW5nU3VzcGVuZGVk IHsgZmFsc2UgfTsKKyAgICBib29sIG1faW5VcGRhdGVHZW9tZXRyeSB7IGZhbHNlIH07CisgICAg Ym9vbCBtX2xheWVyVHJlZVN0YXRlSXNGcm96ZW4geyBmYWxzZSB9OworICAgIGJvb2wgbV9zaG91 bGRTY2FsZVZpZXdUb0ZpdERvY3VtZW50IHsgZmFsc2UgfTsKKyAgICBib29sIG1faXNTY2FsaW5n Vmlld1RvRml0RG9jdW1lbnQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc1Rocm90dGxpbmdMYXll ckZsdXNoZXMgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc0xheWVyRmx1c2hUaHJvdHRsaW5nVGVt cG9yYXJpbHlEaXNhYmxlZEZvckludGVyYWN0aW9uIHsgZmFsc2UgfTsKICAgICBib29sIG1fbmVl ZHNTZW5kRW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSB7IHRydWUgfTsKLQotICAgIFdl YkNvcmU6OlRpbWVyIG1fbGF5ZXJGbHVzaFRocm90dGxpbmdUaW1lcjsKIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCmlu ZGV4IDZlMDYzMDhhM2NlMmUxZTAxZmM5Zjg0YzYyMzA5YTg4ZGRlMzIzMmMuLjRkNjU5YjdmMTBl ODQ5ZmZlNjNjYzljZDA5NjQzODcwYTVmMzA0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0 aW9uRHJhd2luZ0FyZWEubW0KQEAgLTc1LDEyICs3NSw5IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJD b3JlOwogCiBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6VGlsZWRDb3JlQW5pbWF0aW9u RHJhd2luZ0FyZWEoV2ViUGFnZSYgd2ViUGFnZSwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1l dGVycyYgcGFyYW1ldGVycykKICAgICA6IERyYXdpbmdBcmVhKERyYXdpbmdBcmVhVHlwZVRpbGVk Q29yZUFuaW1hdGlvbiwgcGFyYW1ldGVycy5kcmF3aW5nQXJlYUlkZW50aWZpZXIsIHdlYlBhZ2Up Ci0gICAgLCBtX2xheWVyVHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpCi0gICAgLCBtX2lzUGFpbnRp bmdTdXNwZW5kZWQoIShwYXJhbWV0ZXJzLmFjdGl2aXR5U3RhdGUgJiBBY3Rpdml0eVN0YXRlOjpJ c1Zpc2libGUpKQotICAgICwgbV90cmFuc2llbnRab29tU2NhbGUoMSkKLSAgICAsIG1fc2VuZERp ZFVwZGF0ZUFjdGl2aXR5U3RhdGVUaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZUaWxlZENv cmVBbmltYXRpb25EcmF3aW5nQXJlYTo6ZGlkVXBkYXRlQWN0aXZpdHlTdGF0ZVRpbWVyRmlyZWQp Ci0gICAgLCBtX3ZpZXdPdmVybGF5Um9vdExheWVyKG51bGxwdHIpCiAgICAgLCBtX2xheWVyRmx1 c2hUaHJvdHRsaW5nVGltZXIoKnRoaXMsICZUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6 bGF5ZXJGbHVzaFRocm90dGxpbmdUaW1lckZpcmVkKQorICAgICwgbV9zZW5kRGlkVXBkYXRlQWN0 aXZpdHlTdGF0ZVRpbWVyKFJ1bkxvb3A6Om1haW4oKSwgdGhpcywgJlRpbGVkQ29yZUFuaW1hdGlv bkRyYXdpbmdBcmVhOjpkaWRVcGRhdGVBY3Rpdml0eVN0YXRlVGltZXJGaXJlZCkKKyAgICAsIG1f aXNQYWludGluZ1N1c3BlbmRlZCghKHBhcmFtZXRlcnMuYWN0aXZpdHlTdGF0ZSAmIEFjdGl2aXR5 U3RhdGU6OklzVmlzaWJsZSkpCiB7CiAgICAgbV93ZWJQYWdlLmNvcmVQYWdlKCktPnNldHRpbmdz KCkuc2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAKQEAgLTY5OCw3ICs2OTUsNyBAQCB2 b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXRSb290Q29tcG9zaXRpbmdMYXll cihDQUxheWVyICpsYXllcikKIAogICAgIGJvb2wgaGFkUm9vdExheWVyID0gISFtX3Jvb3RMYXll cjsKICAgICBtX3Jvb3RMYXllciA9IGxheWVyOwotICAgIFttX3Jvb3RMYXllciBzZXRTdWJsYXll clRyYW5zZm9ybTptX3RyYW5zZm9ybV07CisgICAgW21fcm9vdExheWVyIHNldFN1YmxheWVyVHJh bnNmb3JtOkNBVHJhbnNmb3JtM0RJZGVudGl0eV07IC8vIEZJWE1FOiBpcyB0aGlzIG5lY2Vzc2Fy eT8KIAogICAgIHVwZGF0ZVJvb3RMYXllcnMoKTsKIAo=