196116 2019-03-21 16:17:38 -0700 Remove an invalid assertion in DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined(). 2019-03-21 19:22:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1520007 0 mark.lam 2019-03-21 16:17:38 -0700 The DFG backend should not make assumptions about what optimizations the front end will or will not do. The assertion asserts that the operand cannot be known to be a cell. However, it is not guaranteed that the front end will fold away this case. Also, the DFG backend is perfectly capable of generating code to handle the case where the operand is a cell. <rdar://problem/48976951> 1520016 1 365639 mark.lam 2019-03-21 16:24:59 -0700 Created attachment 365639 proposed patch. 1520019 2 365639 fpizlo 2019-03-21 16:26:52 -0700 Comment on attachment 365639 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=365639&action=review > Source/JavaScriptCore/ChangeLog:10 > + The DFG backend should not make assumptions about what optimizations the front end > + will or will not do. The assertion asserts that the operand cannot be known to be You're right - the DFG is making a back assumption here because optimizations should be optional. 1520020 3 fpizlo 2019-03-21 16:27:06 -0700 (In reply to Filip Pizlo from comment #2) > Comment on attachment 365639 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365639&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + The DFG backend should not make assumptions about what optimizations the front end > > + will or will not do. The assertion asserts that the operand cannot be known to be > > You're right - the DFG is making a back assumption here because > optimizations should be optional. *bad assumption 1520029 4 mark.lam 2019-03-21 16:35:33 -0700 Thanks for the review. Landed in r243344: <http://trac.webkit.org/r243344>. 1520116 5 365639 saam 2019-03-21 19:22:01 -0700 Comment on attachment 365639 proposed patch. LGTM too. 365639 2019-03-21 16:24:59 -0700 2019-03-21 16:26:52 -0700 proposed patch. bug-196116.patch text/plain 3609 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMzNDIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgYW4gaW52YWxpZCBhc3NlcnRpb24gaW4gREZHOjpTcGVjdWxh dGl2ZUpJVDo6bm9uU3BlY3VsYXRpdmVOb25QZWVwaG9sZUNvbXBhcmVOdWxsT3JVbmRlZmluZWQo KS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjEx NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg5NzY5NTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZGZnLWNvbXBhcmUtZXEtdmlh LW5vblNwZWN1bGF0aXZlTm9uUGVlcGhvbGVDb21wYXJlTnVsbE9yVW5kZWZpbmVkLmpzOiBBZGRl ZC4KKwogMjAxOS0wMy0yMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JMZW5ndGgg c2hvdWxkIGNoZWNrIGlmIGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JTcGFyc2VN YXAKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2RmZy1jb21wYXJlLWVxLXZpYS1ub25TcGVjdWxhdGl2 ZU5vblBlZXBob2xlQ29tcGFyZU51bGxPclVuZGVmaW5lZC5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rl c3RzL3N0cmVzcy9kZmctY29tcGFyZS1lcS12aWEtbm9uU3BlY3VsYXRpdmVOb25QZWVwaG9sZUNv bXBhcmVOdWxsT3JVbmRlZmluZWQuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mv ZGZnLWNvbXBhcmUtZXEtdmlhLW5vblNwZWN1bGF0aXZlTm9uUGVlcGhvbGVDb21wYXJlTnVsbE9y VW5kZWZpbmVkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNyBAQAorLy9AIHJ1bkRlZmF1 bHQoIi0tY29sbGVjdENvbnRpbnVvdXNseT10cnVlIiwgIi0tY29sbGVjdENvbnRpbnVvdXNseVBl cmlvZE1TPTAuMTUiLCAiLS11c2VNYXhpbWFsRmx1c2hJbnNlcnRpb25QaGFzZT10cnVlIiwgIi0t dXNlTExJbnQ9ZmFsc2UiLCAiLS11c2VGVExKSVQ9ZmFsc2UiLCAiLS1qaXRQb2xpY3lTY2FsZT0w IikKKworLy8gVGhpcyB0ZXN0IGV4ZXJjaXNlcyBERkc6OlNwZWN1bGF0aXZlSklUOjpub25TcGVj dWxhdGl2ZU5vblBlZXBob2xlQ29tcGFyZU51bGxPclVuZGVmaW5lZCgpLgorCitmb3IgKGxldCBp ID0gMDsgaSA8IDI1OyBpKyspCisgICAgJ2EnLm1hdGNoKC9hLyk7CisKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQzMzM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAzLTIxICBN YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYW4gaW52YWxp ZCBhc3NlcnRpb24gaW4gREZHOjpTcGVjdWxhdGl2ZUpJVDo6bm9uU3BlY3VsYXRpdmVOb25QZWVw aG9sZUNvbXBhcmVOdWxsT3JVbmRlZmluZWQoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjExNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg5 NzY5NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIERGRyBiYWNrZW5kIHNob3VsZCBub3QgbWFrZSBhc3N1bXB0aW9ucyBhYm91dCB3aGF0IG9w dGltaXphdGlvbnMgdGhlIGZyb250IGVuZAorICAgICAgICB3aWxsIG9yIHdpbGwgbm90IGRvLiAg VGhlIGFzc2VydGlvbiBhc3NlcnRzIHRoYXQgdGhlIG9wZXJhbmQgY2Fubm90IGJlIGtub3duIHRv IGJlCisgICAgICAgIGEgY2VsbC4gIEhvd2V2ZXIsIGl0IGlzIG5vdCBndWFyYW50ZWVkIHRoYXQg dGhlIGZyb250IGVuZCB3aWxsIGZvbGQgYXdheSB0aGlzIGNhc2UuCisgICAgICAgIEFsc28sIHRo ZSBERkcgYmFja2VuZCBpcyBwZXJmZWN0bHkgY2FwYWJsZSBvZiBnZW5lcmF0aW5nIGNvZGUgdG8g aGFuZGxlIHRoZSBjYXNlCisgICAgICAgIHdoZXJlIHRoZSBvcGVyYW5kIGlzIGEgY2VsbC4KKwor ICAgICAgICBUaGUgYXR0YWNoZWQgdGVzdCBjYXNlIGRlbW9uc3RyYXRlcyBhIGNhc2Ugd2hlcmUg dGhlIG9wZXJhbmQgY2FuIGJlIGEga25vd24gY2VsbC4KKyAgICAgICAgVGhlIHRlc3QgbmVlZHMg dG8gYmUgcnVuIHdpdGggdGhlIGNvbmN1cnJlbnQgSklUIGFuZCBHQywgYW5kIGlzIHJhY3kuICBJ dCB1c2VkIHRvCisgICAgICAgIHRyaXAgdXAgdGhpcyBhc3NlcnRpb24gYWJvdXQgb25jZSBldmVy eSAxMCBydW5zIG9yIHNvLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpub25TcGVjdWxhdGl2ZU5vblBl ZXBob2xlQ29tcGFyZU51bGxPclVuZGVmaW5lZCk6CisKIDIwMTktMDMtMjEgIFRhZGV1IFphZ2Fs bG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNDOjpjcmVhdGVFcnJvciBzaG91 bGQgY2xlYXIgZXhjZXB0aW9uIHRocm93biBieSBlcnJvckRlc2NyaXB0aW9uRm9yVmFsdWUKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0 LmNwcAkocmV2aXNpb24gMjQzMzM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE3LDggKzIxNyw2IEBAIHZv aWQgU3BlY3VsYXRpdmVKSVQ6OmNhY2hlZEdldEJ5SWRXaXRoVGgKIAogdm9pZCBTcGVjdWxhdGl2 ZUpJVDo6bm9uU3BlY3VsYXRpdmVOb25QZWVwaG9sZUNvbXBhcmVOdWxsT3JVbmRlZmluZWQoRWRn ZSBvcGVyYW5kKQogewotICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIW1hc3F1ZXJhZGVzQXNVbmRl ZmluZWRXYXRjaHBvaW50SXNTdGlsbFZhbGlkKCkgfHwgIWlzS25vd25DZWxsKG9wZXJhbmQubm9k ZSgpKSwgIlRoZSBDb21wYXJlIHNob3VsZCBoYXZlIGJlZW4gZWxpbWluYXRlZCwgaXQgaXMga25v d24gdG8gYmUgYWx3YXlzIGZhbHNlLiIpOwotCiAgICAgSlNWYWx1ZU9wZXJhbmQgYXJnKHRoaXMs IG9wZXJhbmQsIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbik7CiAgICAgR1BSUmVnIGFyZ0dQUiA9 IGFyZy5ncHIoKTsKICAgICAK