196111 2019-03-21 14:22:48 -0700 AX: labels that only contains static text should not have children 2021-08-31 09:36:09 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All NEW InRadar P2 Normal --- 1 ericliang webkit-unassigned aboxhall apinheiro cfleizach dmazzoni ericliang ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1519937 0 ericliang 2019-03-21 14:22:48 -0700 Labels that only contains static text should not have children because the label is a static text. 1519938 1 webkit-bug-importer 2019-03-21 14:24:14 -0700 <rdar://problem/49124032> 1520510 2 365769 ericliang 2019-03-22 16:00:03 -0700 Created attachment 365769 Patch 1520723 3 365769 cfleizach 2019-03-24 10:04:04 -0700 Comment on attachment 365769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review > Source/WebCore/accessibility/AccessibilityLabel.cpp:119 > + m_children.clear(); This seems like it should be covered by the dirty Boolean flag of the same name The way it’s coded now it will clear the children every time it’s asked (it appears) 1525239 4 365769 cfleizach 2019-04-08 10:32:54 -0700 Comment on attachment 365769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365769&action=review >> Source/WebCore/accessibility/AccessibilityLabel.cpp:119 >> + m_children.clear(); > > This seems like it should be covered by the dirty Boolean flag of the same name > > The way it’s coded now it will clear the children every time it’s asked (it appears) any comment on this? 1525247 5 ericliang 2019-04-08 10:38:59 -0700 Yes apparently I found issue on this patch. Somehow the children are still there. This needs rework apparently. 365769 2019-03-22 16:00:03 -0700 2021-08-31 09:36:09 -0700 Patch bug-196111-20190322160003.patch text/plain 6316 ericliang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2YxMDdhNGZkZDExZDQy ZDdjYWYwMGE4YzVmMjcyNDFhMmU3ZWI5NC4uMmVmODRlZjUyZWU3YTRlOWRiZDUyMTM4NDg0NWY3 MmI5YTQ0YTk2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTIyICBFcmlj IExpYW5nICA8ZXJpY2xpYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogbGFiZWxzIHRoYXQg b25seSBjb250YWlucyBzdGF0aWMgdGV4dCBzaG91bGQgbm90IGhhdmUgY2hpbGRyZW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjExMQorCisgICAg ICAgIFJldHVybnMgZW1wdHkgY2hpbGRyZW4gYXJyYXkgaWYgbGFiZWwgb25seSBoYXMgc3RhdGlj IHRleHQgYXMgY2hpbGRyZW4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2xlYXIgdGhlIGNoaWxkcmVuIGluIHVwZGF0ZUNoaWxkcmVuSWZOZWNlc3Nh cnkgaWYgb25seSB0aGV5IGFyZSBvbmx5IHN0YXRpYyB0ZXh0cy4gQ2hpbGRyZW4gbmVlZCB0byBi ZSBidWlsdCBmaXJzdCBzbyB0aGF0IHRoZXkgY2FuIGJlIGNoZWNrZWQgYWdhaW5zdC4KKworICAg ICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxhYmVsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlMYWJlbDo6dXBkYXRlQ2hpbGRyZW5JZk5lY2Vzc2FyeSk6CisK IDIwMTktMDMtMjAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IERPTTogbGF6aWx5IGNyZWF0ZSB0aGUgYWdlbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxhYmVsLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxhYmVsLmNwcAppbmRleCBi NDVmYzYwMDI0YTRmMzBhYjAwNzU1NmViNTZiMzQ5ZjIzNDIyZjU4Li40YjAwZmE4MTY2OTI1YjQx MGU5NWEwNWRhNWVkMDAyYjVlZDhjNWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMYWJlbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGFiZWwuY3BwCkBAIC0xMTUsNiArMTE1LDggQEAgdm9p ZCBBY2Nlc3NpYmlsaXR5TGFiZWw6OnVwZGF0ZUNoaWxkcmVuSWZOZWNlc3NhcnkoKQogICAgIEFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnVwZGF0ZUNoaWxkcmVuSWZOZWNlc3NhcnkoKTsKICAg ICBpZiAobV9jb250YWluc09ubHlTdGF0aWNUZXh0RGlydHkpCiAgICAgICAgIG1fY29udGFpbnNP bmx5U3RhdGljVGV4dCA9IGNoaWxkcmVuQ29udGFpbk9ubHlTdGF0aWNUZXh0KG1fY2hpbGRyZW4p OworICAgIGlmIChtX2NvbnRhaW5zT25seVN0YXRpY1RleHQpCisgICAgICAgIG1fY2hpbGRyZW4u Y2xlYXIoKTsKICAgICBtX2NvbnRhaW5zT25seVN0YXRpY1RleHREaXJ0eSA9IGZhbHNlOwogfQog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZjU3ZDEwNTBhY2NlYTBmYzMxM2VkMDIyMDZkM2ZhMjRiZGY4Mzg1OS4uYWQxMzZi Zjg4YzUwZGI4NjZmMWMxNjU3YjM0MmJlMzgzY2U0NzdhYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTAzLTIyICBFcmljIExpYW5nICA8ZXJpY2xpYW5nQGFwcGxlLmNvbT4KKworICAgICAg ICBBWDogbGFiZWxzIHRoYXQgb25seSBjb250YWlucyBzdGF0aWMgdGV4dCBzaG91bGQgbm90IGhh dmUgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjExMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3RzIHVwZGF0ZWQuCisgCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvbGFiZWwt ZWxlbWVudC13aXRoLWhpZGRlbi1jb250cm9sLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L21hYy9sYWJlbC1lbGVtZW50LXdpdGgtaGlkZGVuLWNvbnRyb2wuaHRtbDoKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9zbGlkZXItYWxsb3dzLXRpdGxlLXVpLWVsZW1lbnQt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL3NsaWRlci1hbGxvd3Mt dGl0bGUtdWktZWxlbWVudC5odG1sOgorCiAyMDE5LTAzLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbmNsdWRlIFdBTCBhbmQgU0hNIGZpbGUgc2l6ZSBp biBJREIgZGF0YWJhc2Ugc2l6ZSBjb21wdXRhdGlvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9tYWMvbGFiZWwtZWxlbWVudC13aXRoLWhpZGRlbi1jb250cm9sLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2xhYmVsLWVsZW1lbnQtd2l0 aC1oaWRkZW4tY29udHJvbC1leHBlY3RlZC50eHQKaW5kZXggODY5NDIyNDZmNjQ3ZDQxYTg2YmRj NGIyZmYwM2U1M2JlYWJjZWUxNS4uYzkwYWMwNmJkNGE4NTdkM2YwYjQ0NjdiOTc1Zjk4YjQxMDMz OGJiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvbGFiZWwtZWxl bWVudC13aXRoLWhpZGRlbi1jb250cm9sLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L21hYy9sYWJlbC1lbGVtZW50LXdpdGgtaGlkZGVuLWNvbnRyb2wtZXhwZWN0 ZWQudHh0CkBAIC01LDggKzUsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiAKIFBBU1Mg Y29udGFpbmVyLmNoaWxkQXRJbmRleCgnMCcpLnJvbGUgaXMgJ0FYUm9sZTogQVhTdGF0aWNUZXh0 JwotUEFTUyBjb250YWluZXIuY2hpbGRBdEluZGV4KCcwJykuY2hpbGRBdEluZGV4KDApLnJvbGUg aXMgJ0FYUm9sZTogQVhTdGF0aWNUZXh0JwotUEFTUyBjb250YWluZXIuY2hpbGRBdEluZGV4KCcw JykuY2hpbGRBdEluZGV4KDApLnN0cmluZ1ZhbHVlIGlzICdBWFZhbHVlOiBUZXN0IGxhYmVsMScK K0ZBSUwgY29udGFpbmVyLmNoaWxkcmVuQ291bnQgc2hvdWxkIGJlIDAuIFdhcyAzLgogUEFTUyBj b250YWluZXIuY2hpbGRBdEluZGV4KCcyJykucm9sZSBpcyAnQVhSb2xlOiBBWENoZWNrQm94Jwog UEFTUyBjb250YWluZXIuY2hpbGRBdEluZGV4KCcyJykudGl0bGVVSUVsZW1lbnQoKS5pc0VxdWFs KGxhYmVsRm9yQ2hlY2tib3gpIGlzIHRydWUKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2xhYmVsLWVsZW1l bnQtd2l0aC1oaWRkZW4tY29udHJvbC5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9t YWMvbGFiZWwtZWxlbWVudC13aXRoLWhpZGRlbi1jb250cm9sLmh0bWwKaW5kZXggNGM1ODE0MTk5 YTE0MTlkZjQ2YjI0Y2FjYTBhZTRkMGVlYzU2YThhMS4uNjA0NGZhYTEyZjVmZTM0ZDNkNTRlNjdi MWI4OTg5MjBiZjU3ZDU2NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9t YWMvbGFiZWwtZWxlbWVudC13aXRoLWhpZGRlbi1jb250cm9sLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9tYWMvbGFiZWwtZWxlbWVudC13aXRoLWhpZGRlbi1jb250cm9sLmh0 bWwKQEAgLTIxLDkgKzIxLDggQEAKICAgICAgICAgICAgIHZhciBib2R5ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImJvZHkiKTsKICAgICAgICAgICAgIGJvZHkuZm9jdXMoKTsKICAgICAgICAg ICAgIHZhciBjb250YWluZXIgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVu dC5jaGlsZEF0SW5kZXgoMCk7Ci0gICAgICAgICAgICBzaG91bGRCZSgiY29udGFpbmVyLmNoaWxk QXRJbmRleCgnMCcpLnJvbGUiLCAiJ0FYUm9sZTogQVhTdGF0aWNUZXh0JyIpOyAgICAgICAgICAg IAotICAgICAgICAgICAgc2hvdWxkQmUoImNvbnRhaW5lci5jaGlsZEF0SW5kZXgoJzAnKS5jaGls ZEF0SW5kZXgoMCkucm9sZSIsICInQVhSb2xlOiBBWFN0YXRpY1RleHQnIik7ICAgICAgICAgICAg Ci0gICAgICAgICAgICBzaG91bGRCZSgiY29udGFpbmVyLmNoaWxkQXRJbmRleCgnMCcpLmNoaWxk QXRJbmRleCgwKS5zdHJpbmdWYWx1ZSIsICInQVhWYWx1ZTogVGVzdCBsYWJlbDEnIik7ICAgICAg ICAgICAgCisgICAgICAgICAgICBzaG91bGRCZSgiY29udGFpbmVyLmNoaWxkQXRJbmRleCgnMCcp LnJvbGUiLCAiJ0FYUm9sZTogQVhTdGF0aWNUZXh0JyIpOworICAgICAgICAgICAgc2hvdWxkQmUo ImNvbnRhaW5lci5jaGlsZHJlbkNvdW50IiwgIjAiKTsgICAgICAgCiAgICAgICAgICAgICBzaG91 bGRCZSgiY29udGFpbmVyLmNoaWxkQXRJbmRleCgnMicpLnJvbGUiLCAiJ0FYUm9sZTogQVhDaGVj a0JveCciKTsKICAgICAgICAgICAgIHZhciBsYWJlbEZvckNoZWNrYm94ID0gYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJsYWJlbDIiKTsKICAgICAgICAgICAg IHNob3VsZEJlVHJ1ZSgiY29udGFpbmVyLmNoaWxkQXRJbmRleCgnMicpLnRpdGxlVUlFbGVtZW50 KCkuaXNFcXVhbChsYWJlbEZvckNoZWNrYm94KSIpOyAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvc2xpZGVyLWFsbG93cy10aXRsZS11aS1lbGVt ZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3NsaWRlci1h bGxvd3MtdGl0bGUtdWktZWxlbWVudC1leHBlY3RlZC50eHQKaW5kZXggZjYyOWZmODM2MjRkZWU5 OGVlYzUyMDFmYTc1MThiNDQ0NzIyMmJiOS4uOTRkZDkwYWJmMWVjMzliOTQwNzQxYTllMjRjNjZl ODlkMjk3M2NhNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvc2xp ZGVyLWFsbG93cy10aXRsZS11aS1lbGVtZW50LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L21hYy9zbGlkZXItYWxsb3dzLXRpdGxlLXVpLWVsZW1lbnQtZXhwZWN0 ZWQudHh0CkBAIC02LDcgKzYsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiBQQVNTIHNs aWRlci50aXRsZVVJRWxlbWVudCgpLmlzRXF1YWwodGl0bGUpIGlzIHRydWUKIFBBU1MgdGl0bGUu cm9sZSBpcyAnQVhSb2xlOiBBWFN0YXRpY1RleHQnCi1QQVNTIHRpdGxlLmNoaWxkQXRJbmRleCgw KS5yb2xlIGlzICdBWFJvbGU6IEFYU3RhdGljVGV4dCcKK1BBU1MgdGl0bGUuY2hpbGRyZW5Db3Vu dCBpcyAwCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3NsaWRlci1hbGxvd3Mt dGl0bGUtdWktZWxlbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvc2xp ZGVyLWFsbG93cy10aXRsZS11aS1lbGVtZW50Lmh0bWwKaW5kZXggYWY0ZjFkZGJjMDFlOGU5YTIx NTg2M2NlMzUxNjkyNGFhMTg4ZWQ0My4uMDEwY2RlOTBjNWQxNjI4OGFhMTkyM2UyZTY3MjYwNWNj Nzc5ZGNhNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvc2xpZGVy LWFsbG93cy10aXRsZS11aS1lbGVtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9tYWMvc2xpZGVyLWFsbG93cy10aXRsZS11aS1lbGVtZW50Lmh0bWwKQEAgLTI1LDcgKzI1 LDcgQEAKIAogICAgICAgICBzaG91bGRCZVRydWUoInNsaWRlci50aXRsZVVJRWxlbWVudCgpLmlz RXF1YWwodGl0bGUpIik7CiAgICAgICAgIHNob3VsZEJlKCJ0aXRsZS5yb2xlIiwgIidBWFJvbGU6 IEFYU3RhdGljVGV4dCciKTsKLSAgICAgICAgc2hvdWxkQmUoInRpdGxlLmNoaWxkQXRJbmRleCgw KS5yb2xlIiwgIidBWFJvbGU6IEFYU3RhdGljVGV4dCciKTsKKyAgICAgICAgc2hvdWxkQmUoInRp dGxlLmNoaWxkcmVuQ291bnQiLCAiMCIpOwogICAgIH0KIAogPC9zY3JpcHQ+Cg==