196103 2019-03-21 12:20:11 -0700 testB3::testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead() has a validation failure in debug mode 2020-06-15 17:10:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195303 InRadar P2 Normal --- 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1519828 0 rmorisset 2019-03-21 12:20:11 -0700 On top-of-tree (only in debug mode): BB#0: ; frequency = 1.000000 Void @0 = Patchpoint($42(@1):Register(%rax), $42(@1):Register(%rcx), $42(@1):Register(%rdx), $42(@1):Register(%rbx), $42(@1):Register(%rsi), $42(@1):Register(%rdi), $42(@1):Register(%r8), $42(@1):Register(%r9), $42(@1):Register(%r10), $42(@1):Register(%r11), $42(@1):Register(%r12), $42(@1):Register(%r13), $42(@1):Register(%r14), $42(@1):Register(%r15), generator = 0x1187a2250, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = WarmAny, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top) Int32 @1 = Const32(42) Void @2 = Patchpoint($10(@3):LateRegister(%rax), $10(@3):LateRegister(%rcx), $10(@3):LateRegister(%rdx), $10(@3):LateRegister(%rbx), $10(@3):LateRegister(%rsi), $10(@3):LateRegister(%rdi), $10(@3):LateRegister(%r8), $10(@3):LateRegister(%r9), $10(@3):LateRegister(%r10), $10(@3):LateRegister(%r11), $10(@3):LateRegister(%r12), $10(@3):LateRegister(%r13), $10(@3):LateRegister(%r14), $10(@3):LateRegister(%r15), generator = 0x118f18c30, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = WarmAny, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top) Int32 @3 = Const32(10) Int32 @4 = Patchpoint(generator = 0x118f18c48, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = SomeEarlyRegister, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top) Void @5 = Return(Terminal) B3 VALIDATION FAILURE valueIndex.get(value) > valueIndex.get(child) (./b3/B3Validate.cpp:104) At @0->$42(@1) After initial This test was introduced in https://bugs.webkit.org/show_bug.cgi?id=195303 1597349 1 webkit-bug-importer 2019-12-10 14:23:55 -0800 <rdar://problem/57808549> 1662894 2 401956 rmorisset 2020-06-15 16:32:02 -0700 Created attachment 401956 Patch 1662898 3 401956 keith_miller 2020-06-15 16:40:42 -0700 Comment on attachment 401956 Patch r=me 1662901 4 rmorisset 2020-06-15 16:50:57 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 401956 [details] > Patch > > r=me Thanks for the review. 1662908 5 ews-feeder 2020-06-15 17:10:35 -0700 Committed r263068: <https://trac.webkit.org/changeset/263068> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401956. 401956 2020-06-15 16:32:02 -0700 2020-06-15 17:10:36 -0700 Patch patch196103 text/plain 3566 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ2OTMzMmIyMmU5ZC4uOTcyMWEzNmEyMTEwIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wNi0xNSAgUm9i aW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAgICAgIHRlc3RCMzo6dGVz dFJlcG9ydFVzZWRSZWdpc3RlcnNMYXRlVXNlRm9sbG93ZWRCeUVhcmx5RGVmRG9lc05vdE1hcmtV c2VBc0RlYWQoKSBoYXMgYSB2YWxpZGF0aW9uIGZhaWx1cmUgaW4gZGVidWcgbW9kZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MTAzCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81NzgwODU0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdHJpdmlhbDogcGF0Y2hwb2ludHMg d2VyZSByZWZlcnJpbmcgdG8gY29uc3RhbnRzIHRoYXQgd2VyZSBkZWZpbmVkIGFmdGVyIHRoZW0u CisgICAgICAgIEp1c3QgZXhjaGFuZ2luZyB0aGUgb3JkZXIgb2YgdGhlIGRlZmluaXRpb24gd2Fz IGVub3VnaCB0byBtYWtlIHRoaXMgdGVzdCBwYXNzLgorCisgICAgICAgICogYjMvdGVzdGIzXzEu Y3BwOgorICAgICAgICAoc2hvdWxkUnVuKToKKyAgICAgICAgKiBiMy90ZXN0YjNfNy5jcHA6Cisg ICAgICAgICh0ZXN0UmVwb3J0VXNlZFJlZ2lzdGVyc0xhdGVVc2VGb2xsb3dlZEJ5RWFybHlEZWZE b2VzTm90TWFya1VzZUFzRGVhZCk6CisKIDIwMjAtMDYtMTUgIEFsZXhleSBTaHZheWthICA8c2h2 YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIHN1cGVyIHNob3VsZCBub3QgZGVwZW5kIG9u IF9fcHJvdG9fXwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM18x LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfMS5jcHAKaW5kZXggNmQ0ZWE2 N2EyODQ0Li4wNGUxZThjNTk1ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My90ZXN0YjNfMS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM18xLmNw cApAQCAtMzUsNyArMzUsNiBAQCBib29sIHNob3VsZFJ1bihjb25zdCBjaGFyKiBmaWx0ZXIsIGNv bnN0IGNoYXIqIHRlc3ROYW1lKQogICAgIC8vIEZJWE1FOiBUaGVzZSB0ZXN0cyBmYWlsIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk5MzMwPi4KICAgICBpZiAoIWZp bHRlciAmJiBpc0FSTTY0KCkpIHsKICAgICAgICAgZm9yIChhdXRvJiBmYWlsaW5nVGVzdCA6IHsK LSAgICAgICAgICAgICJ0ZXN0UmVwb3J0VXNlZFJlZ2lzdGVyc0xhdGVVc2VGb2xsb3dlZEJ5RWFy bHlEZWZEb2VzTm90TWFya1VzZUFzRGVhZCIsCiAgICAgICAgICAgICAidGVzdE5lZ0Zsb2F0V2l0 aFVzZWxlc3NEb3VibGVDb252ZXJzaW9uIiwKICAgICAgICAgICAgICJ0ZXN0UGluUmVnaXN0ZXJz IiwKICAgICAgICAgfSkgewpAQCAtNDUsMTYgKzQ0LDYgQEAgYm9vbCBzaG91bGRSdW4oY29uc3Qg Y2hhciogZmlsdGVyLCBjb25zdCBjaGFyKiB0ZXN0TmFtZSkKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgIH0KLSAgICBpZiAoIWZpbHRlciAmJiBpc1g4NigpKSB7Ci0gICAgICAgIGZvciAo YXV0byYgZmFpbGluZ1Rlc3QgOiB7Ci0gICAgICAgICAgICAidGVzdFJlcG9ydFVzZWRSZWdpc3Rl cnNMYXRlVXNlRm9sbG93ZWRCeUVhcmx5RGVmRG9lc05vdE1hcmtVc2VBc0RlYWQiLAotICAgICAg ICB9KSB7Ci0gICAgICAgICAgICBpZiAoV1RGOjpmaW5kSWdub3JpbmdBU0NJSUNhc2VXaXRob3V0 TGVuZ3RoKHRlc3ROYW1lLCBmYWlsaW5nVGVzdCkgIT0gV1RGOjpub3RGb3VuZCkgewotICAgICAg ICAgICAgICAgIGRhdGFMb2dMbigiKioqIFdhcm5pbmc6IFNraXBwaW5nIGtub3duLWJhZCB0ZXN0 OiAiLCB0ZXN0TmFtZSk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAg ICAgfQotICAgICAgICB9Ci0gICAgfQogICAgIHJldHVybiAhZmlsdGVyIHx8IFdURjo6ZmluZEln bm9yaW5nQVNDSUlDYXNlV2l0aG91dExlbmd0aCh0ZXN0TmFtZSwgZmlsdGVyKSAhPSBXVEY6Om5v dEZvdW5kOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIz XzcuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM183LmNwcAppbmRleCBkZWE0 MDllZmRiMWEuLjUzYjIwNDExZjE5MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL3Rlc3RiM183LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzcu Y3BwCkBAIC0xNDY4LDE2ICsxNDY4LDE2IEBAIHZvaWQgdGVzdFJlcG9ydFVzZWRSZWdpc3RlcnNM YXRlVXNlRm9sbG93ZWRCeUVhcmx5RGVmRG9lc05vdE1hcmtVc2VBc0RlYWQoKQogCiAgICAgewog ICAgICAgICAvLyBNYWtlIGV2ZXJ5IHJlZyA0MiAoanVzdCBuZWVkcyB0byBiZSBhIHZhbHVlIG90 aGVyIHRoYW4gMTApLgotICAgICAgICBQYXRjaHBvaW50VmFsdWUqIHBhdGNocG9pbnQgPSByb290 LT5hcHBlbmROZXc8UGF0Y2hwb2ludFZhbHVlPihwcm9jLCBWb2lkLCBPcmlnaW4oKSk7CiAgICAg ICAgIFZhbHVlKiBjb25zdDQyID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0MzJWYWx1ZT4ocHJvYywg T3JpZ2luKCksIDQyKTsKKyAgICAgICAgUGF0Y2hwb2ludFZhbHVlKiBwYXRjaHBvaW50ID0gcm9v dC0+YXBwZW5kTmV3PFBhdGNocG9pbnRWYWx1ZT4ocHJvYywgVm9pZCwgT3JpZ2luKCkpOwogICAg ICAgICBmb3IgKFJlZyByZWcgOiBhbGxSZWdzKQogICAgICAgICAgICAgcGF0Y2hwb2ludC0+YXBw ZW5kKGNvbnN0NDIsIFZhbHVlUmVwOjpyZWcocmVnKSk7CiAgICAgICAgIHBhdGNocG9pbnQtPnNl dEdlbmVyYXRvcihbJl0gKENDYWxsSGVscGVycyYsIGNvbnN0IFN0YWNrbWFwR2VuZXJhdGlvblBh cmFtcyYpIHsgfSk7CiAgICAgfQogCiAgICAgewotICAgICAgICBQYXRjaHBvaW50VmFsdWUqIHBh dGNocG9pbnQgPSByb290LT5hcHBlbmROZXc8UGF0Y2hwb2ludFZhbHVlPihwcm9jLCBWb2lkLCBP cmlnaW4oKSk7CiAgICAgICAgIFZhbHVlKiBjb25zdDEwID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0 MzJWYWx1ZT4ocHJvYywgT3JpZ2luKCksIDEwKTsKKyAgICAgICAgUGF0Y2hwb2ludFZhbHVlKiBw YXRjaHBvaW50ID0gcm9vdC0+YXBwZW5kTmV3PFBhdGNocG9pbnRWYWx1ZT4ocHJvYywgVm9pZCwg T3JpZ2luKCkpOwogICAgICAgICBmb3IgKFJlZyByZWcgOiBhbGxSZWdzKQogICAgICAgICAgICAg cGF0Y2hwb2ludC0+YXBwZW5kKGNvbnN0MTAsIFZhbHVlUmVwOjpsYXRlUmVnKHJlZykpOwogICAg ICAgICBwYXRjaHBvaW50LT5zZXRHZW5lcmF0b3IoWyZdIChDQ2FsbEhlbHBlcnMmIGppdCwgY29u c3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJikgewo=