196098 2019-03-21 11:42:37 -0700 [JSC] Fix JSC build with newer ICU 2019-03-21 12:09:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1519782 0 ysuzuki 2019-03-21 11:42:37 -0700 [JSC] Fix JSC build with newer ICU 1519785 1 365580 ysuzuki 2019-03-21 11:45:46 -0700 Created attachment 365580 Patch 1519787 2 ysuzuki 2019-03-21 11:46:25 -0700 <rdar://problem/49113565> 1519788 3 365580 keith_miller 2019-03-21 11:49:56 -0700 Comment on attachment 365580 Patch Would we rather be forced to to handle new cases? Maybe debug builds shouldn't have the default? 1519793 4 ysuzuki 2019-03-21 11:56:18 -0700 (In reply to Keith Miller from comment #3) > Comment on attachment 365580 [details] > Patch > > Would we rather be forced to to handle new cases? Maybe debug builds > shouldn't have the default? I think that "default" is OK here. This is because newly added fields are not handled in ECMAScript until it is specified in the ECMA402 spec. If we do not use "default" clause here, we will notice that a new enum field is added in ICU side. But it does not mean we should handle it at that time. When we handle it, we will see the proposal/spec and add it here anyway. 1519800 5 keith_miller 2019-03-21 11:58:57 -0700 (In reply to Yusuke Suzuki from comment #4) > (In reply to Keith Miller from comment #3) > > Comment on attachment 365580 [details] > > Patch > > > > Would we rather be forced to to handle new cases? Maybe debug builds > > shouldn't have the default? > > I think that "default" is OK here. This is because newly added fields are > not handled in ECMAScript until it is specified in the ECMA402 spec. > If we do not use "default" clause here, we will notice that a new enum field > is added in ICU side. > But it does not mean we should handle it at that time. > When we handle it, we will see the proposal/spec and add it here anyway. Sounds good. r=me 1519813 6 ysuzuki 2019-03-21 12:09:16 -0700 Committed r243311: <https://trac.webkit.org/changeset/243311> 365580 2019-03-21 11:45:46 -0700 2019-03-21 11:58:31 -0700 Patch bug-196098-20190321114545.patch text/plain 2913 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ODYxYTQzMzcxYTIxODBkYTQwZDI2N2U0OTNiMGFmMGIwZDk5MDFiLi41Y2U4NjQzZWI5OTExMzM0 OTc5Njg0YmE2NjVjODk0OGY5ZWJmZjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0yMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEZpeCBKU0MgYnVpbGQgd2l0aCBuZXdlciBJQ1UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjA5OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGxEYXRlVGltZUZvcm1h dCBhbmQgSW50bE51bWJlckZvcm1hdCBoYXZlIHN3aXRjaCBzdGF0ZW1lbnQgb3ZlciBJQ1UncyBl bnVtcy4gSG93ZXZlciBpdCBsYWNrcyAiZGVmYXVsdCIgY2xhdXNlIHNvIHRoYXQKKyAgICAgICAg dGhlIGNvbXBpbGUgZXJyb3Igb2NjdXJzIHdoZW4gYSBuZXcgZW51bSB2YWx1ZSBpcyBhZGRlZCBp biBJQ1Ugc2lkZS4gV2Ugc2hvdWxkIGhhdmUgImRlZmF1bHQiIGNsYXVzZSB3aGljaCBqdXN0IGZh bGxiYWNrcworICAgICAgICAidW5rbm93biJfcyBjYXNlLiBUaGUgYmVoYXZpb3IgaXMgbm90IGNo YW5nZWQgc2luY2Ugd2UgYWxyZWFkeSBoYXZlIGByZXR1cm4gInVua25vd24iX3M7YCBzdGF0ZW1l bnQgYW55d2F5IGFmdGVyIHRoZQorICAgICAgICBzd2l0Y2ggc3RhdGVtZW50LiBUaGlzIHBhdGNo IGp1c3Qgc3VwcHJlc3NlcyBhIGNvbXBpbGUgZXJyb3IuCisKKyAgICAgICAgKiBydW50aW1lL0lu dGxEYXRlVGltZUZvcm1hdC5jcHA6CisgICAgICAgIChKU0M6OkludGxEYXRlVGltZUZvcm1hdDo6 cGFydFR5cGVTdHJpbmcpOgorICAgICAgICAqIHJ1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHA6 CisgICAgICAgIChKU0M6OkludGxOdW1iZXJGb3JtYXQ6OnBhcnRUeXBlU3RyaW5nKToKKwogMjAx OS0wMy0yMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBK U09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JMZW5ndGggc2hvdWxkIGNo ZWNrIGlmIGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JTcGFyc2VNYXAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxEYXRlVGltZUZvcm1hdC5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsRGF0ZVRpbWVGb3JtYXQuY3Bw CmluZGV4IDFlOGQ5ZTNjYjNjMDI2MWRjZDU4MzA3MzU4YTA0OTdiODUwNDYzZmMuLjczOGI1NDEy Nzk1NWRjYjAyMDM2Y2ZiYTRhNzI2Y2QzYjUwNTgyYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0ludGxEYXRlVGltZUZvcm1hdC5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bERhdGVUaW1lRm9ybWF0LmNwcApAQCAtOTc3LDkgKzk3 NywxMCBAQCBBU0NJSUxpdGVyYWwgSW50bERhdGVUaW1lRm9ybWF0OjpwYXJ0VHlwZVN0cmluZyhV RGF0ZUZvcm1hdEZpZWxkIGZpZWxkKQogI2lmIFVfSUNVX1ZFUlNJT05fTUFKT1JfTlVNIDwgNTgg fHwgIWRlZmluZWQoVV9ISURFX0RFUFJFQ0FURURfQVBJKQogICAgIGNhc2UgVURBVF9GSUVMRF9D T1VOVDoKICNlbmRpZgorICAgIC8vIEFueSBuZXdlciBhZGRpdGlvbnMgdG8gdGhlIFVEYXRlRm9y bWF0RmllbGQgZW51bSBzaG91bGQganVzdCBiZSBjb25zaWRlcmVkIGFuICJ1bmtub3duIiBwYXJ0 LgorICAgIGRlZmF1bHQ6CiAgICAgICAgIHJldHVybiAidW5rbm93biJfczsKICAgICB9Ci0gICAg Ly8gQW55IG5ld2VyIGFkZGl0aW9ucyB0byB0aGUgVURhdGVGb3JtYXRGaWVsZCBlbnVtIHNob3Vs ZCBqdXN0IGJlIGNvbnNpZGVyZWQgYW4gInVua25vd24iIHBhcnQuCiAgICAgcmV0dXJuICJ1bmtu b3duIl9zOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9J bnRsTnVtYmVyRm9ybWF0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxO dW1iZXJGb3JtYXQuY3BwCmluZGV4IGUwMTU4YTNmOTYzNTNlOTkxODFkNGZkNGNiNzQ3YjM2MTg3 MTBiMzguLjEzMTEzODFjNDVkOTlkNjI0OTAwMzM1Y2UwNWM1MjQxYjg5ZmRjOGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCkBA IC00NzYsOSArNDc2LDEwIEBAIEFTQ0lJTGl0ZXJhbCBJbnRsTnVtYmVyRm9ybWF0OjpwYXJ0VHlw ZVN0cmluZyhVTnVtYmVyRm9ybWF0RmllbGRzIGZpZWxkLCBkb3VibGUKICNpZiAhZGVmaW5lZChV X0hJREVfREVQUkVDQVRFRF9BUEkpCiAgICAgY2FzZSBVTlVNX0ZJRUxEX0NPVU5UOgogI2VuZGlm CisgICAgLy8gQW55IG5ld2VyIGFkZGl0aW9ucyB0byB0aGUgVU51bWJlckZvcm1hdEZpZWxkcyBl bnVtIHNob3VsZCBqdXN0IGJlIGNvbnNpZGVyZWQgYW4gInVua25vd24iIHBhcnQuCisgICAgZGVm YXVsdDoKICAgICAgICAgcmV0dXJuICJ1bmtub3duIl9zOwogICAgIH0KLSAgICAvLyBBbnkgbmV3 ZXIgYWRkaXRpb25zIHRvIHRoZSBVTnVtYmVyRm9ybWF0RmllbGRzIGVudW0gc2hvdWxkIGp1c3Qg YmUgY29uc2lkZXJlZCBhbiAidW5rbm93biIgcGFydC4KICAgICByZXR1cm4gInVua25vd24iX3M7 CiB9CiAK