196093 2019-03-21 11:06:07 -0700 [B3] Use numChildren() instead of children().size() 2019-07-12 15:47:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 196091 https://bugs.webkit.org/show_bug.cgi?id=196091 P2 Trivial --- 196091 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1519739 0 rmorisset 2019-03-21 11:06:07 -0700 This is a trivial refactoring, but it will be required for https://bugs.webkit.org/show_bug.cgi?id=196091 1519743 1 365569 rmorisset 2019-03-21 11:07:57 -0700 Created attachment 365569 Patch 1552570 2 rmorisset 2019-07-12 15:47:45 -0700 *** This bug has been marked as a duplicate of bug 196091 *** 365569 2019-03-21 11:07:57 -0700 2019-04-04 16:24:55 -0700 Patch bug-196093-20190321110756.patch text/plain 3425 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ODYxYTQzMzcxYTIxODBkYTQwZDI2N2U0OTNiMGFmMGIwZDk5MDFiLi43MjBjN2FmZTA5YjMzZDc3 NGI4ZjE5MTA2NDUzMWNjNWRhNWQ5Nzg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wMy0yMSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtCM10gVXNlIG51bUNoaWxkcmVuKCkgaW5zdGVhZCBvZiBjaGlsZHJl bigpLnNpemUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBiMy9CM1N0YWNrbWFwU3BlY2lhbC5jcHA6CisgICAgICAgIChKU0M6OkIzOjpTdGFja21h cFNwZWNpYWw6OmZvckVhY2hBcmdJbXBsKToKKyAgICAgICAgKEpTQzo6QjM6OlN0YWNrbWFwU3Bl Y2lhbDo6aXNWYWxpZEltcGwpOgorCiAyMDE5LTAzLTIxICBUYWRldSBaYWdhbGxvICA8dHphZ2Fs bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTT2JqZWN0OjpwdXREaXJlY3RJbmRleFNsb3dPckJl eW9uZFZlY3Rvckxlbmd0aCBzaG91bGQgY2hlY2sgaWYgaW5kZXhJc1N1ZmZpY2llbnRseUJleW9u ZExlbmd0aEZvclNwYXJzZU1hcApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L0IzU3RhY2ttYXBTcGVjaWFsLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1N0YWNr bWFwU3BlY2lhbC5jcHAKaW5kZXggZTdjNmI0OTViNmJiMTEyMDdjOTc5OTRlNzdkYWMyZWU3ZjY4 YzAzYi4uMmYwNzExMTQ3MDE4OGE5Y2U5YWVjYTNmMWViY2YzN2ViZGJkM2YzZCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzU3RhY2ttYXBTcGVjaWFsLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNTdGFja21hcFNwZWNpYWwuY3BwCkBAIC04MywxMSAr ODMsMTEgQEAgdm9pZCBTdGFja21hcFNwZWNpYWw6OmZvckVhY2hBcmdJbXBsKAogCiAgICAgLy8g Q2hlY2sgdGhhdCBpbnNhbmUgdGhpbmdzIGhhdmUgbm90IGhhcHBlbmVkLgogICAgIEFTU0VSVChp bnN0LmFyZ3Muc2l6ZSgpID49IG51bUlnbm9yZWRBaXJBcmdzKTsKLSAgICBBU1NFUlQodmFsdWUt PmNoaWxkcmVuKCkuc2l6ZSgpID49IG51bUlnbm9yZWRCM0FyZ3MpOwotICAgIEFTU0VSVChpbnN0 LmFyZ3Muc2l6ZSgpIC0gbnVtSWdub3JlZEFpckFyZ3MgPj0gdmFsdWUtPmNoaWxkcmVuKCkuc2l6 ZSgpIC0gbnVtSWdub3JlZEIzQXJncyk7CisgICAgQVNTRVJUKHZhbHVlLT5udW1DaGlsZHJlbigp ID49IG51bUlnbm9yZWRCM0FyZ3MpOworICAgIEFTU0VSVChpbnN0LmFyZ3Muc2l6ZSgpIC0gbnVt SWdub3JlZEFpckFyZ3MgPj0gdmFsdWUtPm51bUNoaWxkcmVuKCkgLSBudW1JZ25vcmVkQjNBcmdz KTsKICAgICBBU1NFUlQoaW5zdC5hcmdzWzBdLmtpbmQoKSA9PSBBcmc6OktpbmQ6OlNwZWNpYWwp OwogCi0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHZhbHVlLT5jaGlsZHJlbigpLnNpemUo KSAtIG51bUlnbm9yZWRCM0FyZ3M7ICsraSkgeworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkg PCB2YWx1ZS0+bnVtQ2hpbGRyZW4oKSAtIG51bUlnbm9yZWRCM0FyZ3M7ICsraSkgewogICAgICAg ICBBcmcmIGFyZyA9IGluc3QuYXJnc1tpICsgbnVtSWdub3JlZEFpckFyZ3NdOwogICAgICAgICBD b25zdHJhaW5lZFZhbHVlIGNoaWxkID0gdmFsdWUtPmNvbnN0cmFpbmVkQ2hpbGQoaSArIG51bUln bm9yZWRCM0FyZ3MpOwogCkBAIC0xNjAsMTYgKzE2MCwxNiBAQCBib29sIFN0YWNrbWFwU3BlY2lh bDo6aXNWYWxpZEltcGwoCiAKICAgICAvLyBDaGVjayB0aGF0IGluc2FuZSB0aGluZ3MgaGF2ZSBu b3QgaGFwcGVuZWQuCiAgICAgQVNTRVJUKGluc3QuYXJncy5zaXplKCkgPj0gbnVtSWdub3JlZEFp ckFyZ3MpOwotICAgIEFTU0VSVCh2YWx1ZS0+Y2hpbGRyZW4oKS5zaXplKCkgPj0gbnVtSWdub3Jl ZEIzQXJncyk7CisgICAgQVNTRVJUKHZhbHVlLT5udW1DaGlsZHJlbigpID49IG51bUlnbm9yZWRC M0FyZ3MpOwogCiAgICAgLy8gRm9yIHRoZSBJbnN0IHRvIGJlIHZhbGlkLCBpdCBuZWVkcyB0byBo YXZlIHRoZSByaWdodCBudW1iZXIgb2YgYXJndW1lbnRzLgotICAgIGlmIChpbnN0LmFyZ3Muc2l6 ZSgpIC0gbnVtSWdub3JlZEFpckFyZ3MgPCB2YWx1ZS0+Y2hpbGRyZW4oKS5zaXplKCkgLSBudW1J Z25vcmVkQjNBcmdzKQorICAgIGlmIChpbnN0LmFyZ3Muc2l6ZSgpIC0gbnVtSWdub3JlZEFpckFy Z3MgPCB2YWx1ZS0+bnVtQ2hpbGRyZW4oKSAtIG51bUlnbm9yZWRCM0FyZ3MpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAogICAgIC8vIFJlZ2FyZGxlc3Mgb2YgY29uc3RyYWludHMsIHN0YWNrbWFw cyBoYXZlIHNvbWUgYmFzaWMgcmVxdWlyZW1lbnRzIGZvciB0aGVpciBhcmd1bWVudHMuIEZvcgog ICAgIC8vIGV4YW1wbGUsIHlvdSBjYW4ndCBoYXZlIGEgbm9uLUZQLW9mZnNldCBhZGRyZXNzLiBU aGlzIHZlcmlmaWVzIHRob3NlIGNvbmRpdGlvbnMgYXMgd2VsbCBhcyB0aGUKICAgICAvLyBhcmd1 bWVudCB0eXBlcy4KLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdmFsdWUtPmNoaWxkcmVu KCkuc2l6ZSgpIC0gbnVtSWdub3JlZEIzQXJnczsgKytpKSB7CisgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IHZhbHVlLT5udW1DaGlsZHJlbigpIC0gbnVtSWdub3JlZEIzQXJnczsgKytpKSB7 CiAgICAgICAgIFZhbHVlKiBjaGlsZCA9IHZhbHVlLT5jaGlsZChpICsgbnVtSWdub3JlZEIzQXJn cyk7CiAgICAgICAgIEFyZyYgYXJnID0gaW5zdC5hcmdzW2kgKyBudW1JZ25vcmVkQWlyQXJnc107 CiAKQEAgLTE3OCw3ICsxNzgsNyBAQCBib29sIFN0YWNrbWFwU3BlY2lhbDo6aXNWYWxpZEltcGwo CiAgICAgfQogCiAgICAgLy8gVGhlIG51bWJlciBvZiBjb25zdHJhaW50cyBoYXMgdG8gYmUgbm8g Z3JlYXRlciB0aGFuIHRoZSBudW1iZXIgb2YgQjMgY2hpbGRyZW4uCi0gICAgQVNTRVJUKHZhbHVl LT5tX3JlcHMuc2l6ZSgpIDw9IHZhbHVlLT5jaGlsZHJlbigpLnNpemUoKSk7CisgICAgQVNTRVJU KHZhbHVlLT5tX3JlcHMuc2l6ZSgpIDw9IHZhbHVlLT5udW1DaGlsZHJlbigpKTsKIAogICAgIC8v IFZlcmlmeSBhbnkgZXhwbGljaXRseSBzdXBwbGllZCBjb25zdHJhaW50cy4KICAgICBmb3IgKHVu c2lnbmVkIGkgPSBudW1JZ25vcmVkQjNBcmdzOyBpIDwgdmFsdWUtPm1fcmVwcy5zaXplKCk7ICsr aSkgewo=