196092 2019-03-21 10:49:07 -0700 [B3] Remove setKindUnsafely and setOpcodeUnsafely 2022-02-27 23:29:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 196091 P2 Normal --- 196091 1 rmorisset rmorisset ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1519725 0 rmorisset 2019-03-21 10:49:07 -0700 Will be useful for https://bugs.webkit.org/show_bug.cgi?id=196091, and this API generally looks like it is neither safe nor particularly useful (it is only used in two places, neither of which are a hot path). 1519726 1 365567 rmorisset 2019-03-21 10:54:45 -0700 Created attachment 365567 Patch 1552572 2 rmorisset 2019-07-12 15:48:12 -0700 *** This bug has been marked as a duplicate of bug 196091 *** 365567 2019-03-21 10:54:45 -0700 2022-02-27 23:29:07 -0800 Patch patch196092 text/plain 5096 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVjY2Q2Y2U0N2ZhLi4xNGUwOTA4ZmJjZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDMtMjEgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBbQjNdIFJlbW92ZSBz ZXRLaW5kVW5zYWZlbHkgYW5kIHNldE9wY29kZVVuc2FmZWx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYwOTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaWxsIGJlIHVzZWZ1bCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjA5MSwgYW5kIHRoaXMgQVBJIGdlbmVy YWxseSBsb29rcyBsaWtlIGl0IGlzIG5laXRoZXIgc2FmZSBub3IgcGFydGljdWxhcmx5IHVzZWZ1 bCAoaXQgaXMgb25seSB1c2VkIGluIHR3byBwbGFjZXMsIG5laXRoZXIgb2Ygd2hpY2ggYXJlIGEg aG90IHBhdGgpLgorCisgICAgICAgICogYjMvQjNMb3dlck1hY3Jvcy5jcHA6CisgICAgICAgICog YjMvQjNWYWx1ZS5oOgorCiAyMDE5LTAzLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBPcGVuIHNvdXJjZSBhcm02NGUgY29kZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAppbmRleCA0YzU5NGQyNGIzMy4uZTc0NDI2MGFkYTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlck1hY3Jvcy5jcHAKQEAgLTI1NSwz MyArMjU1LDM3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgLy8gemVyby1leHRlbmQgdGhl aXIgaGlnaCBiaXRzLCBleGNlcHQgdGhhdCB0aGUgaGlnaCBiaXRzIG1pZ2h0IGdldCBwb2xsdXRl ZCBieSBoaWdoCiAgICAgICAgICAgICAgICAgLy8gYml0cyBpbiB0aGUgb3BlcmFuZC4gU28sIGVp dGhlciB3YXksIHdlIG5lZWQgdG8gdGhyb3cgYSBzaWduLWV4dGVuZCBvbiB0aGVzZQogICAgICAg ICAgICAgICAgIC8vIHRoaW5ncy4KLSAgICAgICAgICAgICAgICAKKworICAgICAgICAgICAgICAg IEF0b21pY1ZhbHVlKiBhdG9taWMgPSBtX3ZhbHVlLT5hczxBdG9taWNWYWx1ZT4oKTsKKwogICAg ICAgICAgICAgICAgIGlmIChpc1g4NigpKSB7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChtX3Zh bHVlLT5vcGNvZGUoKSA9PSBBdG9taWNYY2hnU3ViICYmIG1fdXNlQ291bnRzLm51bVVzZXMobV92 YWx1ZSkpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIE9uIHg4NiwgeGNoZ2FkZCBpcyBi ZXR0ZXIgdGhhbiB4Y2hnc3ViIGlmIGl0IGhhcyBhbnkgdXNlcnMuCi0gICAgICAgICAgICAgICAg ICAgICAgICBtX3ZhbHVlLT5zZXRPcGNvZGVVbnNhZmVseShBdG9taWNYY2hnQWRkKTsKLSAgICAg ICAgICAgICAgICAgICAgICAgIG1fdmFsdWUtPmNoaWxkKDApID0gbV9pbnNlcnRpb25TZXQuaW5z ZXJ0PFZhbHVlPigKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2luZGV4LCBOZWcsIG1f b3JpZ2luLCBtX3ZhbHVlLT5jaGlsZCgwKSk7Ci0gICAgICAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgIGJvb2wgZXhlbXB0ID0gZmFsc2U7 CiAgICAgICAgICAgICAgICAgICAgIHN3aXRjaCAobV92YWx1ZS0+b3Bjb2RlKCkpIHsKICAgICAg ICAgICAgICAgICAgICAgY2FzZSBBdG9taWNYY2hnQW5kOgogICAgICAgICAgICAgICAgICAgICBj YXNlIEF0b21pY1hjaGdPcjoKLSAgICAgICAgICAgICAgICAgICAgY2FzZSBBdG9taWNYY2hnU3Vi OgogICAgICAgICAgICAgICAgICAgICBjYXNlIEF0b21pY1hjaGdYb3I6CiAgICAgICAgICAgICAg ICAgICAgICAgICBleGVtcHQgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICAgICAgICAgIGNhc2UgQXRvbWljWGNoZ1N1YjoKKyAgICAgICAgICAgICAg ICAgICAgICAgIGlmIChtX3VzZUNvdW50cy5udW1Vc2VzKGF0b21pYykpIHsKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAvLyBPbiB4ODYsIHhjaGdhZGQgaXMgYmV0dGVyIHRoYW4geGNoZ3N1 YiBpZiBpdCBoYXMgYW55IHVzZXJzLgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGF1dG8q IG5lZ0NoaWxkID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0PFZhbHVlPihtX2luZGV4LCBOZWcsIG1f b3JpZ2luLCBhdG9taWMtPmNoaWxkKDApKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBX aWR0aCB3aWR0aCA9IGF0b21pYy0+YWNjZXNzV2lkdGgoKTsKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICBWYWx1ZSogbmV3VmFsdWUgPSBtX2luc2VydGlvblNldC5pbnNlcnQ8QXRvbWljVmFs dWU+KG1faW5kZXgsIEF0b21pY1hjaGdBZGQsIG1fb3JpZ2luLCB3aWR0aCwgbmVnQ2hpbGQsIGF0 b21pYy0+Y2hpbGQoMSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICghaXNDYW5v bmljYWxXaWR0aCh3aWR0aCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5ld1Zh bHVlID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0PFZhbHVlPihtX2luZGV4LCBzaWduRXh0ZW5kT3Bj b2RlKHdpZHRoKSwgbV9vcmlnaW4sIG5ld1ZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBhdG9taWMtPnJlcGxhY2VXaXRoSWRlbnRpdHkobmV3VmFsdWUpOworICAgICAgICAgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAgICAgICAgZXhlbXB0ID0gdHJ1ZTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBkZWZhdWx0 OgogICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICAgICAgaWYgKGV4ZW1wdCkKICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAKLSAgICAgICAgICAg ICAgICBBdG9taWNWYWx1ZSogYXRvbWljID0gbV92YWx1ZS0+YXM8QXRvbWljVmFsdWU+KCk7CisK ICAgICAgICAgICAgICAgICBXaWR0aCB3aWR0aCA9IGF0b21pYy0+YWNjZXNzV2lkdGgoKTsKLSAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoaXNDYW5vbmljYWxXaWR0aCh3aWR0 aCkpCiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIApAQCAtMzA0 LDkgKzMwOCwxMiBAQCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgICAgICAKICAgICAgICAgICAgICAgICAvLyBTdWItd2lkdGggbG9hZC1hY3Egb24gQVJN NjQgYWx3YXlzIHNpZ24gZXh0ZW5kcy4KLSAgICAgICAgICAgICAgICBWYWx1ZSogbmV3TG9hZCA9 IG1faW5zZXJ0aW9uU2V0Lmluc2VydENsb25lKG1faW5kZXgsIG1lbW9yeSk7Ci0gICAgICAgICAg ICAgICAgbmV3TG9hZC0+c2V0T3Bjb2RlVW5zYWZlbHkobWVtb3J5LT5vcGNvZGUoKSA9PSBMb2Fk OFogPyBMb2FkOFMgOiBMb2FkMTZTKTsKLSAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAg ICBhdXRvIG5ld09wY29kZSA9IG1lbW9yeS0+b3Bjb2RlKCkgPT0gTG9hZDhaID8gTG9hZDhTIDog TG9hZDE2UzsKKyAgICAgICAgICAgICAgICBhdXRvKiBuZXdMb2FkID0gbV9pbnNlcnRpb25TZXQu aW5zZXJ0PE1lbW9yeVZhbHVlPihtX2luZGV4LCBuZXdPcGNvZGUsIG1fb3JpZ2luLCBtZW1vcnkt PmNoaWxkKDApKTsKKyAgICAgICAgICAgICAgICBuZXdMb2FkLT5zZXRPZmZzZXQobWVtb3J5LT5v ZmZzZXQoKSk7CisgICAgICAgICAgICAgICAgbmV3TG9hZC0+c2V0UmFuZ2UobWVtb3J5LT5yYW5n ZSgpKTsKKyAgICAgICAgICAgICAgICBuZXdMb2FkLT5zZXRGZW5jZVJhbmdlKG1lbW9yeS0+ZmVu Y2VSYW5nZSgpKTsKKwogICAgICAgICAgICAgICAgIFZhbHVlKiBuZXdWYWx1ZSA9IG1faW5zZXJ0 aW9uU2V0Lmluc2VydDxWYWx1ZT4oCiAgICAgICAgICAgICAgICAgICAgIG1faW5kZXgsIEJpdEFu ZCwgbV9vcmlnaW4sIG5ld0xvYWQsCiAgICAgICAgICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0 Lmluc2VydEludENvbnN0YW50KApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L0IzVmFsdWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1ZhbHVlLmgKaW5kZXggMDE0 ZTc4ZTExZjMuLjkzZDhhMGM1N2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YjMvQjNWYWx1ZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1ZhbHVlLmgKQEAg LTY5LDExICs2OSw2IEBAIHB1YmxpYzoKICAgICAKICAgICBPcGNvZGUgb3Bjb2RlKCkgY29uc3Qg eyByZXR1cm4ga2luZCgpLm9wY29kZSgpOyB9CiAgICAgCi0gICAgLy8gTm90ZSB0aGF0IHRoZSBr aW5kIGlzIG1lYW50IHRvIGJlIGltbXV0YWJsZS4gRG8gdGhpcyB3aGVuIHlvdSBrbm93IHRoYXQg dGhpcyBpcyBzYWZlLiBJdCdzIG5vdAotICAgIC8vIHVzdWFsbHkgc2FmZS4KLSAgICB2b2lkIHNl dEtpbmRVbnNhZmVseShLaW5kIGtpbmQpIHsgbV9raW5kID0ga2luZDsgfQotICAgIHZvaWQgc2V0 T3Bjb2RlVW5zYWZlbHkoT3Bjb2RlIG9wY29kZSkgeyBtX2tpbmQuc2V0T3Bjb2RlKG9wY29kZSk7 IH0KLSAgICAKICAgICAvLyBJdCdzIGdvb2QgcHJhY3RpY2UgdG8gbWlycm9yIEtpbmQgbWV0aG9k cyBoZXJlLCBzbyB5b3UgY2FuIHNheSB2YWx1ZS0+aXNCbGFoKCkKICAgICAvLyBpbnN0ZWFkIG9m IHZhbHVlLT5raW5kKCkuaXNCbGFoKCkuCiAgICAgYm9vbCBpc0NoaWxsKCkgY29uc3QgeyByZXR1 cm4ga2luZCgpLmlzQ2hpbGwoKTsgfQo=