196088 2019-03-21 10:26:39 -0700 Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing 2025-10-25 19:28:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 301475 1 timothy timothy bburg bdakin commit-queue darin ews-watchlist fred.wang glenn lforschler thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1519708 0 timothy 2019-03-21 10:26:39 -0700 "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounds (at a glance) like it is expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro. An error more like would help: "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number" 1519763 1 365575 timothy 2019-03-21 11:19:43 -0700 Created attachment 365575 Patch 1519770 2 365575 bburg 2019-03-21 11:26:20 -0700 Comment on attachment 365575 Patch r=mews 1519774 3 timothy 2019-03-21 11:30:43 -0700 webkitpy failures are 3 other tests. 1519794 4 365575 commit-queue 2019-03-21 11:57:14 -0700 Comment on attachment 365575 Patch Clearing flags on attachment: 365575 Committed r243308: <https://trac.webkit.org/changeset/243308> 1519795 5 commit-queue 2019-03-21 11:57:16 -0700 All reviewed patches have been landed. Closing bug. 1519801 6 webkit-bug-importer 2019-03-21 11:59:11 -0700 <rdar://problem/49117433> 365575 2019-03-21 11:19:43 -0700 2019-03-21 11:57:14 -0700 Patch bug-196088-20190321111942.patch text/plain 6842 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQ1OWZiNjkxN2ZkNDI0YjY3NDZkZjc3NzYyYzZkZWVi NDA4MTc1ZC4uYjc4ZTQ4OTQ0YmUwYTJmOTMwODNhOWI1MTYzMTUzZWY2ZDRlYjdkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTAzLTIxICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKwor ICAgICAgICBTdHlsZSBjaGVjayBlcnJvciAiV0tfTUFDX1RCQSBpcyBuZWl0aGVyIGEgdmVyc2lv biBudW1iZXIgbm9yIFdLX0lPU19UQkEiIGlzIGNvbmZ1c2luZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjA4OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgZXJyb3IgbWVzc2FnZXMgdXNl ZCB3aGVuIGxvb2tpbmcgZm9yIG1hY29zKFdLX0lPU19UQkEpIG9yIGlvcyhXS19NQUNfVEJBKS4K KyAgICAgICAgU3VwcG9ydCBjaGVja3Mgd2hlbiBvbmx5IG9uZSBwbGF0Zm9ybSBpcyBzcGVjaWZp ZWQuIEFsc28gZGVwcmVjYXRlIG1hY29zeCgpIGFuZAorICAgICAgICBmb3JjZSB0aGUgdXNlIG9m IG1hY29zKCkgaW5zdGVhZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbWluX3ZlcnNpb25zX29mX3drX2FwaV9hdmFp bGFibGUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfbWluX3ZlcnNpb25zX29m X3drX2FwaV9hdmFpbGFibGUpOgorCiAyMDE5LTAzLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWJ1aWxkXSBJbXByb3ZlIGZhaWx1cmUgc3Vt bWFyeSBzdHJpbmcgZm9yIEFwcGx5UGF0Y2ggc3RlcApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA0ODc3YjAyNjg4MDI3NGRlMTcxYzMyZjM4ODNj YzM4MjAwYTBjNWNjLi5kYjcwNWY0MmVhYzk2NjFjODQ5OTgwNDg4ZGU1ZjNjYzljOWY3Njg1IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjg2 MiwxNSArMjg2MiwzMiBAQCBkZWYgY2hlY2tfbWluX3ZlcnNpb25zX29mX3drX2FwaV9hdmFpbGFi bGUoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAKICAgICBsaW5lID0gY2xlYW5f bGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXSAgIyBHZXQgcmlkIG9mIGNvbW1lbnRzIGFuZCBzdHJp bmdzLgogCi0gICAgd2tfYXBpX2F2YWlsYWJsZSA9IHNlYXJjaChyJ1dLX0FQSV9BVkFJTEFCTEVc KG1hY29zeFwoKFteXCldKylcKSwgaW9zXCgoW15cKV0rKVwpXCknLCBsaW5lKQorICAgIHdrX2Fw aV9hdmFpbGFibGUgPSBzZWFyY2gocidXS19BUElfQVZBSUxBQkxFXChtYWNvc3hcKCcsIGxpbmUp CiAgICAgaWYgd2tfYXBpX2F2YWlsYWJsZToKLSAgICAgICAgbWFjb3N4TWluVmVyc2lvbiA9IHdr X2FwaV9hdmFpbGFibGUuZ3JvdXAoMSkKLSAgICAgICAgaWYgbm90IG1hdGNoKHInXihbXGRcLl0r fFdLX01BQ19UQkEpJCcsIG1hY29zeE1pblZlcnNpb24pOgotICAgICAgICAgICAgZXJyb3IobGlu ZV9udW1iZXIsICdidWlsZC93a19hcGlfYXZhaWxhYmxlJywgNSwgJyVzIGlzIG5laXRoZXIgYSB2 ZXJzaW9uIG51bWJlciBub3IgV0tfTUFDX1RCQScgJSBtYWNvc3hNaW5WZXJzaW9uKQorICAgICAg ICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3drX2FwaV9hdmFpbGFibGUnLCA1LCAnbWFjb3N4 KCkgaXMgZGVwcmVjYXRlZDsgdXNlIG1hY29zKCkgaW5zdGVhZCcpCisKKyAgICAjIEZJWE1FOiBU aGlzIHNob3VsZCBzdXBwb3J0IGFueSBvcmRlci4KKyAgICB3a19hcGlfYXZhaWxhYmxlID0gc2Vh cmNoKHInV0tfQVBJX0FWQUlMQUJMRVwobWFjb3NcKChbXlwpXSspXCksIGlvc1woKFteXCldKylc KVwpJywgbGluZSkKKyAgICBpZiB3a19hcGlfYXZhaWxhYmxlOgorICAgICAgICBtYWNvc01pblZl cnNpb24gPSB3a19hcGlfYXZhaWxhYmxlLmdyb3VwKDEpCisgICAgICAgIGlmIG5vdCBtYXRjaChy J14oW1xkXC5dK3xXS19NQUNfVEJBKSQnLCBtYWNvc01pblZlcnNpb24pOgorICAgICAgICAgICAg ZXJyb3IobGluZV9udW1iZXIsICdidWlsZC93a19hcGlfYXZhaWxhYmxlJywgNSwgJ21hY29zKCVz KSBpcyBpbnZhbGlkOyBleHBlY3RlZCBXS19NQUNfVEJBIG9yIGEgbnVtYmVyJyAlIG1hY29zTWlu VmVyc2lvbikKIAogICAgICAgICBpb3NNaW5WZXJzaW9uID0gd2tfYXBpX2F2YWlsYWJsZS5ncm91 cCgyKQogICAgICAgICBpZiBub3QgbWF0Y2gocideKFtcZFwuXSt8V0tfSU9TX1RCQSkkJywgaW9z TWluVmVyc2lvbik6Ci0gICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL3drX2Fw aV9hdmFpbGFibGUnLCA1LCAnJXMgaXMgbmVpdGhlciBhIHZlcnNpb24gbnVtYmVyIG5vciBXS19J T1NfVEJBJyAlIGlvc01pblZlcnNpb24pCisgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwg J2J1aWxkL3drX2FwaV9hdmFpbGFibGUnLCA1LCAnaW9zKCVzKSBpcyBpbnZhbGlkOyBleHBlY3Rl ZCBXS19JT1NfVEJBIG9yIGEgbnVtYmVyJyAlIGlvc01pblZlcnNpb24pCisKKyAgICB3a19hcGlf YXZhaWxhYmxlID0gc2VhcmNoKHInV0tfQVBJX0FWQUlMQUJMRVwobWFjb3NcKChbXlwpXSspXClc KScsIGxpbmUpCisgICAgaWYgd2tfYXBpX2F2YWlsYWJsZToKKyAgICAgICAgbWFjb3NNaW5WZXJz aW9uID0gd2tfYXBpX2F2YWlsYWJsZS5ncm91cCgxKQorICAgICAgICBpZiBub3QgbWF0Y2gocide KFtcZFwuXSt8V0tfTUFDX1RCQSkkJywgbWFjb3NNaW5WZXJzaW9uKToKKyAgICAgICAgICAgIGVy cm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQvd2tfYXBpX2F2YWlsYWJsZScsIDUsICdtYWNvcyglcykg aXMgaW52YWxpZDsgZXhwZWN0ZWQgV0tfTUFDX1RCQSBvciBhIG51bWJlcicgJSBtYWNvc01pblZl cnNpb24pCisKKyAgICB3a19hcGlfYXZhaWxhYmxlID0gc2VhcmNoKHInV0tfQVBJX0FWQUlMQUJM RVwoaW9zXCgoW15cKV0rKVwpXCknLCBsaW5lKQorICAgIGlmIHdrX2FwaV9hdmFpbGFibGU6Cisg ICAgICAgIGlvc01pblZlcnNpb24gPSB3a19hcGlfYXZhaWxhYmxlLmdyb3VwKDEpCisgICAgICAg IGlmIG5vdCBtYXRjaChyJ14oW1xkXC5dK3xXS19JT1NfVEJBKSQnLCBpb3NNaW5WZXJzaW9uKToK KyAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQvd2tfYXBpX2F2YWlsYWJsZScs IDUsICdpb3MoJXMpIGlzIGludmFsaWQ7IGV4cGVjdGVkIFdLX0lPU19UQkEgb3IgYSBudW1iZXIn ICUgaW9zTWluVmVyc2lvbikKIAogZGVmIGNoZWNrX3N0eWxlKGNsZWFuX2xpbmVzLCBsaW5lX251 bWJlciwgZmlsZV9leHRlbnNpb24sIGNsYXNzX3N0YXRlLCBmaWxlX3N0YXRlLCBlbnVtX3N0YXRl LCBlcnJvcik6CiAgICAgIiIiQ2hlY2tzIHJ1bGVzIGZyb20gdGhlICdDKysgc3R5bGUgcnVsZXMn IHNlY3Rpb24gb2YgY3BwZ3VpZGUuaHRtbC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggMzc4YjVhNGFkMjJmMzVj MTYwYzVmMDdhNTg0MmJhOWE2MzM0NDZmOS4uZjE5OTJhMWJlNTg5MzJjNjhlNDlhMWZlM2FlMjQw ZmMyNzgxODk2NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTU2ODUsMTAgKzU2ODUsMTkgQEAgY2xhc3MgV2Vi S2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50 KCdNWU1BQ1JPKGEgPyBiKCkgOiBjKTsnLCAnJykKIAogICAgIGRlZiB0ZXN0X21pbl92ZXJzaW9u c19vZl93a19hcGlfYXZhaWxhYmxlKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydF9saW50KCdX S19BUElfQVZBSUxBQkxFKG1hY29zeCgxLjIuMyksIGlvcygzLjQuNSkpJywgJycpICAjIHZlcnNp b24gbnVtYmVycyBhcmUgT0suCi0gICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1dLX0FQSV9BVkFJ TEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpJywgJycpICAjIFdLX01B Q19UQkEgYW5kIFdLX0lPU19UQkEgYXJlIE9LLgotICAgICAgICBzZWxmLmFzc2VydF9saW50KCdX S19BUElfQVZBSUxBQkxFKG1hY29zeChXS19JT1NfVEJBKSwgaW9zKDMuNC41KSknLCAnV0tfSU9T X1RCQSBpcyBuZWl0aGVyIGEgdmVyc2lvbiBudW1iZXIgbm9yIFdLX01BQ19UQkEgIFtidWlsZC93 a19hcGlfYXZhaWxhYmxlXSBbNV0nKQotICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElf QVZBSUxBQkxFKG1hY29zeCgxLjIuMyksIGlvcyhXS19NQUNfVEJBKSknLCAnV0tfTUFDX1RCQSBp cyBuZWl0aGVyIGEgdmVyc2lvbiBudW1iZXIgbm9yIFdLX0lPU19UQkEgIFtidWlsZC93a19hcGlf YXZhaWxhYmxlXSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxB QkxFKG1hY29zeCgxLjIuMykpJywgJ21hY29zeCgpIGlzIGRlcHJlY2F0ZWQ7IHVzZSBtYWNvcygp IGluc3RlYWQgIFtidWlsZC93a19hcGlfYXZhaWxhYmxlXSBbNV0nKQorICAgICAgICBzZWxmLmFz c2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSknLCAnbWFjb3N4 KCkgaXMgZGVwcmVjYXRlZDsgdXNlIG1hY29zKCkgaW5zdGVhZCAgW2J1aWxkL3drX2FwaV9hdmFp bGFibGVdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1dLX0FQSV9BVkFJTEFCTEUo bWFjb3MoMS4yLjMpLCBpb3MoMy40LjUpKScsICcnKSAgIyB2ZXJzaW9uIG51bWJlcnMgYXJlIE9L LgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01B Q19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpJywgJycpICAjIFdLX01BQ19UQkEgYW5kIFdLX0lPU19U QkEgYXJlIE9LLgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKG1h Y29zKFdLX0lPU19UQkEpLCBpb3MoMy40LjUpKScsICdtYWNvcyhXS19JT1NfVEJBKSBpcyBpbnZh bGlkOyBleHBlY3RlZCBXS19NQUNfVEJBIG9yIGEgbnVtYmVyICBbYnVpbGQvd2tfYXBpX2F2YWls YWJsZV0gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnV0tfQVBJX0FWQUlMQUJMRSht YWNvcygxLjIuMyksIGlvcyhXS19NQUNfVEJBKSknLCAnaW9zKFdLX01BQ19UQkEpIGlzIGludmFs aWQ7IGV4cGVjdGVkIFdLX0lPU19UQkEgb3IgYSBudW1iZXIgIFtidWlsZC93a19hcGlfYXZhaWxh YmxlXSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKG1h Y29zKDEuMi4zKSknLCAnJykgICMgdmVyc2lvbiBudW1iZXJzIGFyZSBPSy4KKyAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSknLCAnJykg ICMgV0tfTUFDX1RCQSBpcyBPSy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnV0tfQVBJX0FW QUlMQUJMRShpb3MoMy40LjUpKScsICcnKSAgIyB2ZXJzaW9uIG51bWJlcnMgYXJlIE9LLgorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSkn LCAnJykgICMgV0tfSU9TX1RCQSBpcyBPSy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnV0tf QVBJX0FWQUlMQUJMRShtYWNvcyhXS19JT1NfVEJBKSknLCAnbWFjb3MoV0tfSU9TX1RCQSkgaXMg aW52YWxpZDsgZXhwZWN0ZWQgV0tfTUFDX1RCQSBvciBhIG51bWJlciAgW2J1aWxkL3drX2FwaV9h dmFpbGFibGVdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1dLX0FQSV9BVkFJTEFC TEUobWFjb3MoV0tfSU9TX1RCQSkpJywgJ21hY29zKFdLX0lPU19UQkEpIGlzIGludmFsaWQ7IGV4 cGVjdGVkIFdLX01BQ19UQkEgb3IgYSBudW1iZXIgIFtidWlsZC93a19hcGlfYXZhaWxhYmxlXSBb NV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdXS19BUElfQVZBSUxBQkxFKGlvcyhXS19N QUNfVEJBKSknLCAnaW9zKFdLX01BQ19UQkEpIGlzIGludmFsaWQ7IGV4cGVjdGVkIFdLX0lPU19U QkEgb3IgYSBudW1iZXIgIFtidWlsZC93a19hcGlfYXZhaWxhYmxlXSBbNV0nKQogCiAgICAgZGVm IHRlc3Rfb3NfdmVyc2lvbl9jaGVja3Moc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQo JyNpZiBQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFV SVJFRCA8IDExMDAwMCcsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBh IG5hbWVkIG1hY3JvIGluIHd0Zi9QbGF0Zm9ybS5oLCB3dGYvRmVhdHVyZURlZmluZXMuaCwgb3Ig YW4gYXBwcm9wcmlhdGUgaW50ZXJuYWwgZmlsZS4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0n KQo=