196078 2019-03-21 08:39:55 -0700 JSObject::putDirectIndexSlowOrBeyondVectorLength should check if indexIsSufficientlyBeyondLengthForSparseMap 2019-03-21 10:42:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1519643 0 tzagallo 2019-03-21 08:39:55 -0700 ... 1519647 1 365548 tzagallo 2019-03-21 08:42:14 -0700 Created attachment 365548 Patch 1519651 2 tzagallo 2019-03-21 08:47:26 -0700 <rdar://problem/35925380> 1519670 3 365548 mark.lam 2019-03-21 09:18:59 -0700 Comment on attachment 365548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365548&action=review r=me > JSTests/ChangeLog:9 > + * microbenchmarks/put-by-val-direct-large-index.js: Added. Please record here what gains the microbenchmark shows. 1519691 4 365561 tzagallo 2019-03-21 09:52:14 -0700 Created attachment 365561 Patch for landing 1519719 5 365561 commit-queue 2019-03-21 10:42:46 -0700 Comment on attachment 365561 Patch for landing Clearing flags on attachment: 365561 Committed r243299: <https://trac.webkit.org/changeset/243299> 1519720 6 commit-queue 2019-03-21 10:42:48 -0700 All reviewed patches have been landed. Closing bug. 365548 2019-03-21 08:42:14 -0700 2019-03-21 09:52:10 -0700 Patch bug-196078-20190321164213.patch text/plain 3116 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzkxNzU3ZTA2OTQyN2Q2NGMxMWY4ZGUyNTU3ZmYzMDYxNGVmMmZmLi45N2IxN2Q4YzExNTViNTYy NTU0NTllNDIxNWFkYzNhMzk1NjY1OWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0yMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JM ZW5ndGggc2hvdWxkIGNoZWNrIGlmIGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JT cGFyc2VNYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NjA3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5MjUzODA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5saWtlIHRoZSBvdGhlciB2YXJp YXRpb25zIG9mIHB1dEJ5SW5kZXgsIGl0IG9ubHkgY2hlY2tlZCBpZiB0aGUgaW5kZXgKKyAgICAg ICAgd2FzIGxhcmdlciB0aGFuIE1JTl9TUEFSU0VfQVJSQVlfSU5ERVggd2hlbiB0aGUgaW5kZXhp bmdUeXBlIHdhcworICAgICAgICBBTExfQkxBTktfSU5ERVhJTkdfVFlQRVMuIFRoaXMgcmVzdWx0 ZWQgaW4gYSBodWdlIGJ1dHRlcmZseSBiZWluZworICAgICAgICBhbGxvY2F0ZWQgZm9yIG9iamVj dCBsaXRlcmFscyAoZS5nLiBge1s5ZTRdOiAuLi59YCkgYW5kIG9iamVjdHMgcGFyc2VkCisgICAg ICAgIGZyb20gSlNPTi4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAg ICAoSlNDOjpKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JMZW5ndGgp OgorCiAyMDE5LTAzLTIxICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtKU0NdWzMyLWJpdF0gQnVpbGQgZmFpbHVyZSBhZnRlciByMjQzMjMyCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKaW5kZXggM2U4ZjZlMDI1NWFk MmNhNzk4NTE5NGMzNmY3OGI5MWY0MDEyMjEyMi4uZWNkN2I4NDU0OWExMDg1MzI2ZGJlMjI4Mjg5 OGQ2MDdkODFiYzc2MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmNwcApAQCAtMzA1NSw3ICszMDU1LDcgQEAgYm9vbCBKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhT bG93T3JCZXlvbmRWZWN0b3JMZW5ndGgoRXhlY1N0YXRlKiBleGVjLCB1bnNpZ25lZAogICAgICAg ICAgICAgICAgIGV4ZWMsIGksIHZhbHVlLCBhdHRyaWJ1dGVzLCBtb2RlLAogICAgICAgICAgICAg ICAgIGVuc3VyZUFycmF5U3RvcmFnZUV4aXN0c0FuZEVudGVyRGljdGlvbmFyeUluZGV4aW5nTW9k ZSh2bSkpOwogICAgICAgICB9Ci0gICAgICAgIGlmIChpID49IE1JTl9TUEFSU0VfQVJSQVlfSU5E RVgpIHsKKyAgICAgICAgaWYgKGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JTcGFy c2VNYXAoaSwgMCkgfHwgaSA+PSBNSU5fU1BBUlNFX0FSUkFZX0lOREVYKSB7CiAgICAgICAgICAg ICByZXR1cm4gcHV0RGlyZWN0SW5kZXhCZXlvbmRWZWN0b3JMZW5ndGhXaXRoQXJyYXlTdG9yYWdl KAogICAgICAgICAgICAgICAgIGV4ZWMsIGksIHZhbHVlLCBhdHRyaWJ1dGVzLCBtb2RlLCBjcmVh dGVBcnJheVN0b3JhZ2Uodm0sIDAsIDApKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvSlNUZXN0 cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA5MGNmZmIxNjVkNDUxZTRiMGE5 ODExZDRmOGJjYWI2MWRlMjY5NzIzLi41M2Y3ODU3NTU3OGE3ODM1MDc3NGU5MzFkNTNkZjg1YTIz MzlhOWQ3IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTIxICBUYWRldSBaYWdhbGxvICA8dHphZ2Fs bG9AYXBwbGUuY29tPgorCisgICAgICAgIEpTT2JqZWN0OjpwdXREaXJlY3RJbmRleFNsb3dPckJl eW9uZFZlY3Rvckxlbmd0aCBzaG91bGQgY2hlY2sgaWYgaW5kZXhJc1N1ZmZpY2llbnRseUJleW9u ZExlbmd0aEZvclNwYXJzZU1hcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk2MDc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTkyNTM4MD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1pY3JvYmVu Y2htYXJrcy9wdXQtYnktdmFsLWRpcmVjdC1sYXJnZS1pbmRleC5qczogQWRkZWQuCisKIDIwMTkt MDMtMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcCBsZW5n dGggb2YgYW4gYXJyYXkgd2l0aCBzcHJlYWQgdG8gTUlOX0FSUkFZX1NUT1JBR0VfQ09OU1RSVUNU SU9OX0xFTkdUSC4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL3B1dC1ieS12 YWwtZGlyZWN0LWxhcmdlLWluZGV4LmpzIGIvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvcHV0LWJ5 LXZhbC1kaXJlY3QtbGFyZ2UtaW5kZXguanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOWNkMjM0MDdkOWVjMzE3MjNi MTU4YTZiMGFkM2RkMzc2ZWVhODllMAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvbWljcm9i ZW5jaG1hcmtzL3B1dC1ieS12YWwtZGlyZWN0LWxhcmdlLWluZGV4LmpzCkBAIC0wLDAgKzEsNCBA QAordmFyIGFjYyA9IFtdOworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTY7IGkrKykgeworICAgIGFj Yy5wdXNoKHtbNWU0ICsgKGkgJSAxZTQpXTogdHJ1ZX0pOworfQo= 365561 2019-03-21 09:52:14 -0700 2019-03-21 10:42:46 -0700 Patch for landing bug-196078-20190321175213.patch text/plain 3278 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzkxNzU3ZTA2OTQyN2Q2NGMxMWY4ZGUyNTU3ZmYzMDYxNGVmMmZmLi41MDc2OGFmNmMyZjJkMGVk NGI2MTEzZDNmMjNiMjNlYTk4MzgwNGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0yMSAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JM ZW5ndGggc2hvdWxkIGNoZWNrIGlmIGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JT cGFyc2VNYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NjA3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU5MjUzODA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgVW5saWtlIHRoZSBvdGhlciB2YXJpYXRpb25z IG9mIHB1dEJ5SW5kZXgsIGl0IG9ubHkgY2hlY2tlZCBpZiB0aGUgaW5kZXgKKyAgICAgICAgd2Fz IGxhcmdlciB0aGFuIE1JTl9TUEFSU0VfQVJSQVlfSU5ERVggd2hlbiB0aGUgaW5kZXhpbmdUeXBl IHdhcworICAgICAgICBBTExfQkxBTktfSU5ERVhJTkdfVFlQRVMuIFRoaXMgcmVzdWx0ZWQgaW4g YSBodWdlIGJ1dHRlcmZseSBiZWluZworICAgICAgICBhbGxvY2F0ZWQgZm9yIG9iamVjdCBsaXRl cmFscyAoZS5nLiBge1s5ZTRdOiAuLi59YCkgYW5kIG9iamVjdHMgcGFyc2VkCisgICAgICAgIGZy b20gSlNPTi4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAgICAoSlND OjpKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JCZXlvbmRWZWN0b3JMZW5ndGgpOgorCiAy MDE5LTAzLTIxICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtKU0NdWzMyLWJpdF0gQnVpbGQgZmFpbHVyZSBhZnRlciByMjQzMjMyCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKaW5kZXggM2U4ZjZlMDI1NWFkMmNhNzk4 NTE5NGMzNmY3OGI5MWY0MDEyMjEyMi4uZWNkN2I4NDU0OWExMDg1MzI2ZGJlMjI4Mjg5OGQ2MDdk ODFiYzc2MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmpl Y3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcApA QCAtMzA1NSw3ICszMDU1LDcgQEAgYm9vbCBKU09iamVjdDo6cHV0RGlyZWN0SW5kZXhTbG93T3JC ZXlvbmRWZWN0b3JMZW5ndGgoRXhlY1N0YXRlKiBleGVjLCB1bnNpZ25lZAogICAgICAgICAgICAg ICAgIGV4ZWMsIGksIHZhbHVlLCBhdHRyaWJ1dGVzLCBtb2RlLAogICAgICAgICAgICAgICAgIGVu c3VyZUFycmF5U3RvcmFnZUV4aXN0c0FuZEVudGVyRGljdGlvbmFyeUluZGV4aW5nTW9kZSh2bSkp OwogICAgICAgICB9Ci0gICAgICAgIGlmIChpID49IE1JTl9TUEFSU0VfQVJSQVlfSU5ERVgpIHsK KyAgICAgICAgaWYgKGluZGV4SXNTdWZmaWNpZW50bHlCZXlvbmRMZW5ndGhGb3JTcGFyc2VNYXAo aSwgMCkgfHwgaSA+PSBNSU5fU1BBUlNFX0FSUkFZX0lOREVYKSB7CiAgICAgICAgICAgICByZXR1 cm4gcHV0RGlyZWN0SW5kZXhCZXlvbmRWZWN0b3JMZW5ndGhXaXRoQXJyYXlTdG9yYWdlKAogICAg ICAgICAgICAgICAgIGV4ZWMsIGksIHZhbHVlLCBhdHRyaWJ1dGVzLCBtb2RlLCBjcmVhdGVBcnJh eVN0b3JhZ2Uodm0sIDAsIDApKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFu Z2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA5MGNmZmIxNjVkNDUxZTRiMGE5ODExZDRm OGJjYWI2MWRlMjY5NzIzLi44ZmQ4NWE0ZTMwYzg2Y2I0MjQ0MjJlZWYxODQ5M2YyZDQyMDVhMTRm IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTIxICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBw bGUuY29tPgorCisgICAgICAgIEpTT2JqZWN0OjpwdXREaXJlY3RJbmRleFNsb3dPckJleW9uZFZl Y3Rvckxlbmd0aCBzaG91bGQgY2hlY2sgaWYgaW5kZXhJc1N1ZmZpY2llbnRseUJleW9uZExlbmd0 aEZvclNwYXJzZU1hcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2MDc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTkyNTM4MD4KKworICAgICAg ICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBBZGQgYSBuZXcgYmVuY2htYXJrIHRo YXQgYWxsb2NhdGVzIHNldmVyYWwgb2JqZWN0cyBhbmQgaW52b2tlcyBwdXRfYnlfdmFsX2RpcmVj dAorICAgICAgICB3aXRoIGEgbGFyZ2UgaW5kZXguIHJ1bi1qc2MtYmVuY2htYXJrcyBzYXlzICJk ZWZpbml0ZWx5IDEuNjE3OHggZmFzdGVyIi4KKworICAgICAgICAqIG1pY3JvYmVuY2htYXJrcy9w dXQtYnktdmFsLWRpcmVjdC1sYXJnZS1pbmRleC5qczogQWRkZWQuCisKIDIwMTktMDMtMjEgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcCBsZW5ndGggb2YgYW4g YXJyYXkgd2l0aCBzcHJlYWQgdG8gTUlOX0FSUkFZX1NUT1JBR0VfQ09OU1RSVUNUSU9OX0xFTkdU SC4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL3B1dC1ieS12YWwtZGlyZWN0 LWxhcmdlLWluZGV4LmpzIGIvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvcHV0LWJ5LXZhbC1kaXJl Y3QtbGFyZ2UtaW5kZXguanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOWNkMjM0MDdkOWVjMzE3MjNiMTU4YTZiMGFk M2RkMzc2ZWVhODllMAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtz L3B1dC1ieS12YWwtZGlyZWN0LWxhcmdlLWluZGV4LmpzCkBAIC0wLDAgKzEsNCBAQAordmFyIGFj YyA9IFtdOworZm9yICh2YXIgaSA9IDA7IGkgPCAxZTY7IGkrKykgeworICAgIGFjYy5wdXNoKHtb NWU0ICsgKGkgJSAxZTQpXTogdHJ1ZX0pOworfQo=