196068 2019-03-21 01:13:58 -0700 [JSCore][32-bit] Build failure after r243232 2019-03-21 04:08:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1519546 0 psaavedra 2019-03-21 01:13:58 -0700 Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the JSC builds for WPE 1519547 1 365516 psaavedra 2019-03-21 01:18:46 -0700 Created attachment 365516 patch 1519555 2 psaavedra 2019-03-21 01:33:54 -0700 CodeOrigin changes and now is defined as a class. ``` -struct CodeOrigin { - static const unsigned invalidBytecodeIndex = UINT_MAX; - - // Bytecode offset that you'd use to re-execute this instruction, and the - // bytecode index of the bytecode instruction that produces some result that - // you're interested in (used for mapping Nodes whose values you're using - // to bytecode instructions that have the appropriate value profile). - unsigned bytecodeIndex; - - InlineCallFrame* inlineCallFrame; - +class CodeOrigin { +public: ... ``` ... bytecodeIndex is now defined as function ``` ... + unsigned bytecodeIndex() const + { +#if CPU(ADDRESS64) + if (!isSet()) + return s_invalidBytecodeIndex; + if (UNLIKELY(isOutOfLine())) + return outOfLineCodeOrigin()->bytecodeIndex; + return m_compositeValue >> (64 - s_freeBitsAtTop); +#else + return m_bytecodeIndex; +#endif + } ``` 1519560 3 mark.lam 2019-03-21 01:51:41 -0700 (In reply to Pablo Saavedra from comment #0) > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the > JSC builds for WPE Can you please provide a dump of the build failure? According to the WPE EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build fine. 1519562 4 mark.lam 2019-03-21 01:53:35 -0700 (In reply to Mark Lam from comment #3) > (In reply to Pablo Saavedra from comment #0) > > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the > > JSC builds for WPE > > Can you please provide a dump of the build failure? According to the WPE > EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build > fine. OK, I see what the issue is. It's not a WPE build issue, but a 32-bit build issue. 1519563 5 365516 mark.lam 2019-03-21 01:54:41 -0700 Comment on attachment 365516 patch View in context: https://bugs.webkit.org/attachment.cgi?id=365516&action=review r=me with fixed title change. > Source/JavaScriptCore/ChangeLog:3 > + Build failure after r243232 Please retitle this bug to say "32-bit build failure after r243232". 1519571 6 psaavedra 2019-03-21 02:22:05 -0700 (In reply to Mark Lam from comment #5) > Comment on attachment 365516 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365516&action=review > > r=me with fixed title change. > > > Source/JavaScriptCore/ChangeLog:3 > > + Build failure after r243232 > > Please retitle this bug to say "32-bit build failure after r243232". +1 1519574 7 psaavedra 2019-03-21 02:25:53 -0700 (In reply to Mark Lam from comment #4) > (In reply to Mark Lam from comment #3) > > (In reply to Pablo Saavedra from comment #0) > > > Patch landed in breaks in https://bugs.webkit.org/show_bug.cgi?id=195928 the > > > JSC builds for WPE > > > > Can you please provide a dump of the build failure? According to the WPE > > EWS on https://bugs.webkit.org/show_bug.cgi?id=195928, it seemed to build > > fine. > > OK, I see what the issue is. It's not a WPE build issue, but a 32-bit build > issue. Ahh, yes. I expressed myself poorly. I saw the problem in the ARMv7 JSCore bots for WPE https://build.webkit.org/waterfall?category=misc but probably appeared in other 32-bits bots as well. 1519581 8 mark.lam 2019-03-21 02:50:53 -0700 Please fix the title in the ChangeLog as well. 1519583 9 365527 psaavedra 2019-03-21 02:56:25 -0700 Created attachment 365527 patch 1519584 10 365528 psaavedra 2019-03-21 02:58:41 -0700 Created attachment 365528 patch 1519586 11 psaavedra 2019-03-21 02:59:42 -0700 (In reply to Mark Lam from comment #8) > Please fix the title in the ChangeLog as well. done. 1519590 12 365528 commit-queue 2019-03-21 03:36:03 -0700 Comment on attachment 365528 patch Clearing flags on attachment: 365528 Committed r243286: <https://trac.webkit.org/changeset/243286> 1519591 13 commit-queue 2019-03-21 03:36:05 -0700 All reviewed patches have been landed. Closing bug. 1519595 14 webkit-bug-importer 2019-03-21 04:08:44 -0700 <rdar://problem/49102907> 365516 2019-03-21 01:18:46 -0700 2019-03-21 02:56:21 -0700 patch bug-196068-20190321091844.patch text/plain 4713 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 M2VhNmM4NWM3Mjk4YzQyYTMyMGEwNDgwYTZhZTJkOWJmMGNkNjMyLi5kODAxYjc1ZjM5NjRmMjdj MDQ2ZGVjMDdmZDlkOGY0ZjA4YWFlZTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMy0yMSAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlh LmNvbT4KKworICAgICAgICBCdWlsZCBmYWlsdXJlIGFmdGVyIHIyNDMyMzIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjA2OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR09TUkV4aXQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OnJlaWZ5SW5saW5lZENhbGxGcmFtZXMpOgorICAgICAgICAq IGRmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3BwOgorICAgICAgICAoSlNDOjpERkc6OnJl aWZ5SW5saW5lZENhbGxGcmFtZXMpOgorCiAyMDE5LTAzLTIxICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBDYXAgbGVuZ3RoIG9mIGFuIGFycmF5IHdpdGggc3ByZWFk IHRvIE1JTl9BUlJBWV9TVE9SQUdFX0NPTlNUUlVDVElPTl9MRU5HVEguCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNwcAppbmRleCA2M2ZlZDNmZDhkMzhlZmM5MmNiYWMxY2Nm NzdmYTgzOGUxYWQ1YjhmLi5hYjZmNGI5NzA5NTQxMDI1MTE1NzI3YmNlNTliOGE0MjAzYmY0NTFh IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAKQEAgLTgyNyw3ICs4 MjcsNyBAQCBzdGF0aWMgdm9pZCByZWlmeUlubGluZWRDYWxsRnJhbWVzKENvbnRleHQmIGNvbnRl eHQsIENvZGVCbG9jayogb3V0ZXJtb3N0QmFzZWxpbgogICAgICAgICBpZiAoIWlubGluZUNhbGxG cmFtZS0+aXNDbG9zdXJlQ2FsbCkKICAgICAgICAgICAgIGZyYW1lLnNldE9wZXJhbmQoaW5saW5l Q2FsbEZyYW1lLT5zdGFja09mZnNldCArIENhbGxGcmFtZVNsb3Q6OmNhbGxlZSwgSlNWYWx1ZShp bmxpbmVDYWxsRnJhbWUtPmNhbGxlZUNvbnN0YW50KCkpKTsKICNlbHNlIC8vIFVTRShKU1ZBTFVF NjQpIC8vIHNvIHRoaXMgaXMgdGhlIDMyLWJpdCBwYXJ0Ci0gICAgICAgIGNvbnN0IEluc3RydWN0 aW9uKiBpbnN0cnVjdGlvbiA9IGJhc2VsaW5lQ29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChj b2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KS5wdHIoKTsKKyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rp b24qIGluc3RydWN0aW9uID0gYmFzZWxpbmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0KGNv ZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgoKSkucHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0 aW9uQml0cyA9IENhbGxTaXRlSW5kZXgoaW5zdHJ1Y3Rpb24pLmJpdHMoKTsKICAgICAgICAgZnJh bWUuc2V0T3BlcmFuZDx1aW50MzJfdD4oaW5saW5lQ2FsbEZyYW1lLT5zdGFja09mZnNldCArIENh bGxGcmFtZVNsb3Q6OmFyZ3VtZW50Q291bnQsIFRhZ09mZnNldCwgbG9jYXRpb25CaXRzKTsKICAg ICAgICAgZnJhbWUuc2V0T3BlcmFuZDx1aW50MzJfdD4oaW5saW5lQ2FsbEZyYW1lLT5zdGFja09m ZnNldCArIENhbGxGcmFtZVNsb3Q6OmNhbGxlZSwgVGFnT2Zmc2V0LCBzdGF0aWNfY2FzdDx1aW50 MzJfdD4oSlNWYWx1ZTo6Q2VsbFRhZykpOwpAQCAtODQxLDcgKzg0MSw3IEBAIHN0YXRpYyB2b2lk IHJlaWZ5SW5saW5lZENhbGxGcmFtZXMoQ29udGV4dCYgY29udGV4dCwgQ29kZUJsb2NrKiBvdXRl cm1vc3RCYXNlbGluCiAjaWYgVVNFKEpTVkFMVUU2NCkKICAgICAgICAgdWludDMyX3QgbG9jYXRp b25CaXRzID0gQ2FsbFNpdGVJbmRleChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpLmJpdHMo KTsKICNlbHNlCi0gICAgICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IG91dGVy bW9zdEJhc2VsaW5lQ29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRl Y29kZUluZGV4KS5wdHIoKTsKKyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9u ID0gb3V0ZXJtb3N0QmFzZWxpbmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0KGNvZGVPcmln aW4tPmJ5dGVjb2RlSW5kZXgoKSkucHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0 cyA9IENhbGxTaXRlSW5kZXgoaW5zdHJ1Y3Rpb24pLmJpdHMoKTsKICNlbmRpZgogICAgICAgICBm cmFtZS5zZXRPcGVyYW5kPHVpbnQzMl90PihDYWxsRnJhbWVTbG90Ojphcmd1bWVudENvdW50LCBU YWdPZmZzZXQsIGxvY2F0aW9uQml0cyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHAKaW5kZXggODM1MzgwMDdjZjAwMTRm NjAxM2Y0ZmUzMjA1Y2NkZTZlMDM1NTYyYS4uMjQ5YzkxNzk2MGM3YzFhZjJlNGI2YTA2Mzk5MjE2 ZTFjM2IyYWVhYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JF eGl0Q29tcGlsZXJDb21tb24uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcApAQCAtMjM3LDcgKzIzNyw3IEBAIHZvaWQgcmVpZnlJ bmxpbmVkQ2FsbEZyYW1lcyhDQ2FsbEhlbHBlcnMmIGppdCwgY29uc3QgT1NSRXhpdEJhc2UmIGV4 aXQpCiAgICAgICAgICAgICBqaXQuc3RvcmU2NChBc3NlbWJseUhlbHBlcnM6OlRydXN0ZWRJbW02 NChKU1ZhbHVlOjplbmNvZGUoSlNWYWx1ZShpbmxpbmVDYWxsRnJhbWUtPmNhbGxlZUNvbnN0YW50 KCkpKSksIEFzc2VtYmx5SGVscGVyczo6YWRkcmVzc0ZvcigoVmlydHVhbFJlZ2lzdGVyKShpbmxp bmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlKSkpOwogI2Vs c2UgLy8gVVNFKEpTVkFMVUU2NCkgLy8gc28gdGhpcyBpcyB0aGUgMzItYml0IHBhcnQKICAgICAg ICAgaml0LnN0b3JlUHRyKGNhbGxlckZyYW1lR1BSLCBBc3NlbWJseUhlbHBlcnM6OmFkZHJlc3NG b3JCeXRlT2Zmc2V0KGlubGluZUNhbGxGcmFtZS0+Y2FsbGVyRnJhbWVPZmZzZXQoKSkpOwotICAg ICAgICBjb25zdCBJbnN0cnVjdGlvbiogaW5zdHJ1Y3Rpb24gPSBiYXNlbGluZUNvZGVCbG9jay0+ aW5zdHJ1Y3Rpb25zKCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCkucHRyKCk7CisgICAg ICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGJhc2VsaW5lQ29kZUJsb2NrLT5p bnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpLnB0cigpOwogICAg ICAgICB1aW50MzJfdCBsb2NhdGlvbkJpdHMgPSBDYWxsU2l0ZUluZGV4KGluc3RydWN0aW9uKS5i aXRzKCk7CiAgICAgICAgIGppdC5zdG9yZTMyKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMy KGxvY2F0aW9uQml0cyksIEFzc2VtYmx5SGVscGVyczo6dGFnRm9yKChWaXJ0dWFsUmVnaXN0ZXIp KGlubGluZUNhbGxGcmFtZS0+c3RhY2tPZmZzZXQgKyBDYWxsRnJhbWVTbG90Ojphcmd1bWVudENv dW50KSkpOwogICAgICAgICBqaXQuc3RvcmUzMihBc3NlbWJseUhlbHBlcnM6OlRydXN0ZWRJbW0z MihKU1ZhbHVlOjpDZWxsVGFnKSwgQXNzZW1ibHlIZWxwZXJzOjp0YWdGb3IoKFZpcnR1YWxSZWdp c3RlcikoaW5saW5lQ2FsbEZyYW1lLT5zdGFja09mZnNldCArIENhbGxGcmFtZVNsb3Q6OmNhbGxl ZSkpKTsKQEAgLTI1MSw3ICsyNTEsNyBAQCB2b2lkIHJlaWZ5SW5saW5lZENhbGxGcmFtZXMoQ0Nh bGxIZWxwZXJzJiBqaXQsIGNvbnN0IE9TUkV4aXRCYXNlJiBleGl0KQogI2lmIFVTRShKU1ZBTFVF NjQpCiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0cyA9IENhbGxTaXRlSW5kZXgoY29kZU9y aWdpbi0+Ynl0ZWNvZGVJbmRleCgpKS5iaXRzKCk7CiAjZWxzZQotICAgICAgICBjb25zdCBJbnN0 cnVjdGlvbiogaW5zdHJ1Y3Rpb24gPSBqaXQuYmFzZWxpbmVDb2RlQmxvY2soKS0+aW5zdHJ1Y3Rp b25zKCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCkucHRyKCk7CisgICAgICAgIGNvbnN0 IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGppdC5iYXNlbGluZUNvZGVCbG9jaygpLT5pbnN0 cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpLnB0cigpOwogICAgICAg ICB1aW50MzJfdCBsb2NhdGlvbkJpdHMgPSBDYWxsU2l0ZUluZGV4KGluc3RydWN0aW9uKS5iaXRz KCk7CiAjZW5kaWYKICAgICAgICAgaml0LnN0b3JlMzIoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVk SW1tMzIobG9jYXRpb25CaXRzKSwgQXNzZW1ibHlIZWxwZXJzOjp0YWdGb3IoKFZpcnR1YWxSZWdp c3RlcikoQ2FsbEZyYW1lU2xvdDo6YXJndW1lbnRDb3VudCkpKTsK 365527 2019-03-21 02:56:25 -0700 2019-03-21 02:58:38 -0700 patch bug-196068-20190321105623.patch text/plain 4730 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 M2VhNmM4NWM3Mjk4YzQyYTMyMGEwNDgwYTZhZTJkOWJmMGNkNjMyLi5mZTMzNjQxN2NkNmZjMjc1 MDYzMWEyNzllYTUxM2M5MTlhZWQ2NmMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMy0yMSAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlh LmNvbT4KKworICAgICAgICBbSlNDb3JlXVszMi1iaXRdIEJ1aWxkIGZhaWx1cmUgYWZ0ZXIgcjI0 MzIzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2 MDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBk ZmcvREZHT1NSRXhpdC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6cmVpZnlJbmxpbmVkQ2FsbEZy YW1lcyk6CisgICAgICAgICogZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6cmVpZnlJbmxpbmVkQ2FsbEZyYW1lcyk6CisKIDIwMTktMDMtMjEgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcCBsZW5ndGggb2YgYW4g YXJyYXkgd2l0aCBzcHJlYWQgdG8gTUlOX0FSUkFZX1NUT1JBR0VfQ09OU1RSVUNUSU9OX0xFTkdU SC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDYzZmVkM2Zk OGQzOGVmYzkyY2JhYzFjY2Y3N2ZhODM4ZTFhZDViOGYuLmFiNmY0Yjk3MDk1NDEwMjUxMTU3Mjdi Y2U1OWI4YTQyMDNiZjQ1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT1NSRXhpdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0 LmNwcApAQCAtODI3LDcgKzgyNyw3IEBAIHN0YXRpYyB2b2lkIHJlaWZ5SW5saW5lZENhbGxGcmFt ZXMoQ29udGV4dCYgY29udGV4dCwgQ29kZUJsb2NrKiBvdXRlcm1vc3RCYXNlbGluCiAgICAgICAg IGlmICghaW5saW5lQ2FsbEZyYW1lLT5pc0Nsb3N1cmVDYWxsKQogICAgICAgICAgICAgZnJhbWUu c2V0T3BlcmFuZChpbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6 Y2FsbGVlLCBKU1ZhbHVlKGlubGluZUNhbGxGcmFtZS0+Y2FsbGVlQ29uc3RhbnQoKSkpOwogI2Vs c2UgLy8gVVNFKEpTVkFMVUU2NCkgLy8gc28gdGhpcyBpcyB0aGUgMzItYml0IHBhcnQKLSAgICAg ICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gYmFzZWxpbmVDb2RlQmxvY2stPmlu c3RydWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgpLnB0cigpOworICAgICAg ICBjb25zdCBJbnN0cnVjdGlvbiogaW5zdHJ1Y3Rpb24gPSBiYXNlbGluZUNvZGVCbG9jay0+aW5z dHJ1Y3Rpb25zKCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCgpKS5wdHIoKTsKICAgICAg ICAgdWludDMyX3QgbG9jYXRpb25CaXRzID0gQ2FsbFNpdGVJbmRleChpbnN0cnVjdGlvbikuYml0 cygpOwogICAgICAgICBmcmFtZS5zZXRPcGVyYW5kPHVpbnQzMl90PihpbmxpbmVDYWxsRnJhbWUt PnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6YXJndW1lbnRDb3VudCwgVGFnT2Zmc2V0LCBs b2NhdGlvbkJpdHMpOwogICAgICAgICBmcmFtZS5zZXRPcGVyYW5kPHVpbnQzMl90PihpbmxpbmVD YWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlLCBUYWdPZmZzZXQs IHN0YXRpY19jYXN0PHVpbnQzMl90PihKU1ZhbHVlOjpDZWxsVGFnKSk7CkBAIC04NDEsNyArODQx LDcgQEAgc3RhdGljIHZvaWQgcmVpZnlJbmxpbmVkQ2FsbEZyYW1lcyhDb250ZXh0JiBjb250ZXh0 LCBDb2RlQmxvY2sqIG91dGVybW9zdEJhc2VsaW4KICNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAg ICB1aW50MzJfdCBsb2NhdGlvbkJpdHMgPSBDYWxsU2l0ZUluZGV4KGNvZGVPcmlnaW4tPmJ5dGVj b2RlSW5kZXgoKSkuYml0cygpOwogI2Vsc2UKLSAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGlu c3RydWN0aW9uID0gb3V0ZXJtb3N0QmFzZWxpbmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0 KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgpLnB0cigpOworICAgICAgICBjb25zdCBJbnN0cnVj dGlvbiogaW5zdHJ1Y3Rpb24gPSBvdXRlcm1vc3RCYXNlbGluZUNvZGVCbG9jay0+aW5zdHJ1Y3Rp b25zKCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCgpKS5wdHIoKTsKICAgICAgICAgdWlu dDMyX3QgbG9jYXRpb25CaXRzID0gQ2FsbFNpdGVJbmRleChpbnN0cnVjdGlvbikuYml0cygpOwog I2VuZGlmCiAgICAgICAgIGZyYW1lLnNldE9wZXJhbmQ8dWludDMyX3Q+KENhbGxGcmFtZVNsb3Q6 OmFyZ3VtZW50Q291bnQsIFRhZ09mZnNldCwgbG9jYXRpb25CaXRzKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcAppbmRl eCA4MzUzODAwN2NmMDAxNGY2MDEzZjRmZTMyMDVjY2RlNmUwMzU1NjJhLi4yNDljOTE3OTYwYzdj MWFmMmU0YjZhMDYzOTkyMTZlMWMzYjJhZWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3BwCkBAIC0yMzcsNyArMjM3 LDcgQEAgdm9pZCByZWlmeUlubGluZWRDYWxsRnJhbWVzKENDYWxsSGVscGVycyYgaml0LCBjb25z dCBPU1JFeGl0QmFzZSYgZXhpdCkKICAgICAgICAgICAgIGppdC5zdG9yZTY0KEFzc2VtYmx5SGVs cGVyczo6VHJ1c3RlZEltbTY0KEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlKGlubGluZUNhbGxGcmFt ZS0+Y2FsbGVlQ29uc3RhbnQoKSkpKSwgQXNzZW1ibHlIZWxwZXJzOjphZGRyZXNzRm9yKChWaXJ0 dWFsUmVnaXN0ZXIpKGlubGluZUNhbGxGcmFtZS0+c3RhY2tPZmZzZXQgKyBDYWxsRnJhbWVTbG90 OjpjYWxsZWUpKSk7CiAjZWxzZSAvLyBVU0UoSlNWQUxVRTY0KSAvLyBzbyB0aGlzIGlzIHRoZSAz Mi1iaXQgcGFydAogICAgICAgICBqaXQuc3RvcmVQdHIoY2FsbGVyRnJhbWVHUFIsIEFzc2VtYmx5 SGVscGVyczo6YWRkcmVzc0ZvckJ5dGVPZmZzZXQoaW5saW5lQ2FsbEZyYW1lLT5jYWxsZXJGcmFt ZU9mZnNldCgpKSk7Ci0gICAgICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGJh c2VsaW5lQ29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUlu ZGV4KS5wdHIoKTsKKyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gYmFz ZWxpbmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5k ZXgoKSkucHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0cyA9IENhbGxTaXRlSW5k ZXgoaW5zdHJ1Y3Rpb24pLmJpdHMoKTsKICAgICAgICAgaml0LnN0b3JlMzIoQXNzZW1ibHlIZWxw ZXJzOjpUcnVzdGVkSW1tMzIobG9jYXRpb25CaXRzKSwgQXNzZW1ibHlIZWxwZXJzOjp0YWdGb3Io KFZpcnR1YWxSZWdpc3RlcikoaW5saW5lQ2FsbEZyYW1lLT5zdGFja09mZnNldCArIENhbGxGcmFt ZVNsb3Q6OmFyZ3VtZW50Q291bnQpKSk7CiAgICAgICAgIGppdC5zdG9yZTMyKEFzc2VtYmx5SGVs cGVyczo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcpLCBBc3NlbWJseUhlbHBlcnM6OnRh Z0ZvcigoVmlydHVhbFJlZ2lzdGVyKShpbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2Fs bEZyYW1lU2xvdDo6Y2FsbGVlKSkpOwpAQCAtMjUxLDcgKzI1MSw3IEBAIHZvaWQgcmVpZnlJbmxp bmVkQ2FsbEZyYW1lcyhDQ2FsbEhlbHBlcnMmIGppdCwgY29uc3QgT1NSRXhpdEJhc2UmIGV4aXQp CiAjaWYgVVNFKEpTVkFMVUU2NCkKICAgICAgICAgdWludDMyX3QgbG9jYXRpb25CaXRzID0gQ2Fs bFNpdGVJbmRleChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpLmJpdHMoKTsKICNlbHNlCi0g ICAgICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGppdC5iYXNlbGluZUNvZGVC bG9jaygpLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KS5wdHIo KTsKKyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gaml0LmJhc2VsaW5l Q29kZUJsb2NrKCktPmluc3RydWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgo KSkucHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0cyA9IENhbGxTaXRlSW5kZXgo aW5zdHJ1Y3Rpb24pLmJpdHMoKTsKICNlbmRpZgogICAgICAgICBqaXQuc3RvcmUzMihBc3NlbWJs eUhlbHBlcnM6OlRydXN0ZWRJbW0zMihsb2NhdGlvbkJpdHMpLCBBc3NlbWJseUhlbHBlcnM6OnRh Z0ZvcigoVmlydHVhbFJlZ2lzdGVyKShDYWxsRnJhbWVTbG90Ojphcmd1bWVudENvdW50KSkpOwo= 365528 2019-03-21 02:58:41 -0700 2019-03-21 03:36:03 -0700 patch bug-196068-20190321105840.patch text/plain 4727 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 M2VhNmM4NWM3Mjk4YzQyYTMyMGEwNDgwYTZhZTJkOWJmMGNkNjMyLi4zMTVmYTI5NzM2MjFmZTJm NWM4OTIxZWU2MDg1YzA1OGEzZjY3ODNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMy0yMSAgUGFibG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlh LmNvbT4KKworICAgICAgICBbSlNDXVszMi1iaXRdIEJ1aWxkIGZhaWx1cmUgYWZ0ZXIgcjI0MzIz MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcv REZHT1NSRXhpdC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6cmVpZnlJbmxpbmVkQ2FsbEZyYW1l cyk6CisgICAgICAgICogZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6cmVpZnlJbmxpbmVkQ2FsbEZyYW1lcyk6CisKIDIwMTktMDMtMjEgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcCBsZW5ndGggb2YgYW4gYXJy YXkgd2l0aCBzcHJlYWQgdG8gTUlOX0FSUkFZX1NUT1JBR0VfQ09OU1RSVUNUSU9OX0xFTkdUSC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDYzZmVkM2ZkOGQz OGVmYzkyY2JhYzFjY2Y3N2ZhODM4ZTFhZDViOGYuLmFiNmY0Yjk3MDk1NDEwMjUxMTU3MjdiY2U1 OWI4YTQyMDNiZjQ1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRXhpdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNw cApAQCAtODI3LDcgKzgyNyw3IEBAIHN0YXRpYyB2b2lkIHJlaWZ5SW5saW5lZENhbGxGcmFtZXMo Q29udGV4dCYgY29udGV4dCwgQ29kZUJsb2NrKiBvdXRlcm1vc3RCYXNlbGluCiAgICAgICAgIGlm ICghaW5saW5lQ2FsbEZyYW1lLT5pc0Nsb3N1cmVDYWxsKQogICAgICAgICAgICAgZnJhbWUuc2V0 T3BlcmFuZChpbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6Y2Fs bGVlLCBKU1ZhbHVlKGlubGluZUNhbGxGcmFtZS0+Y2FsbGVlQ29uc3RhbnQoKSkpOwogI2Vsc2Ug Ly8gVVNFKEpTVkFMVUU2NCkgLy8gc28gdGhpcyBpcyB0aGUgMzItYml0IHBhcnQKLSAgICAgICAg Y29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gYmFzZWxpbmVDb2RlQmxvY2stPmluc3Ry dWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgpLnB0cigpOworICAgICAgICBj b25zdCBJbnN0cnVjdGlvbiogaW5zdHJ1Y3Rpb24gPSBiYXNlbGluZUNvZGVCbG9jay0+aW5zdHJ1 Y3Rpb25zKCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCgpKS5wdHIoKTsKICAgICAgICAg dWludDMyX3QgbG9jYXRpb25CaXRzID0gQ2FsbFNpdGVJbmRleChpbnN0cnVjdGlvbikuYml0cygp OwogICAgICAgICBmcmFtZS5zZXRPcGVyYW5kPHVpbnQzMl90PihpbmxpbmVDYWxsRnJhbWUtPnN0 YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6YXJndW1lbnRDb3VudCwgVGFnT2Zmc2V0LCBsb2Nh dGlvbkJpdHMpOwogICAgICAgICBmcmFtZS5zZXRPcGVyYW5kPHVpbnQzMl90PihpbmxpbmVDYWxs RnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlLCBUYWdPZmZzZXQsIHN0 YXRpY19jYXN0PHVpbnQzMl90PihKU1ZhbHVlOjpDZWxsVGFnKSk7CkBAIC04NDEsNyArODQxLDcg QEAgc3RhdGljIHZvaWQgcmVpZnlJbmxpbmVkQ2FsbEZyYW1lcyhDb250ZXh0JiBjb250ZXh0LCBD b2RlQmxvY2sqIG91dGVybW9zdEJhc2VsaW4KICNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAgICB1 aW50MzJfdCBsb2NhdGlvbkJpdHMgPSBDYWxsU2l0ZUluZGV4KGNvZGVPcmlnaW4tPmJ5dGVjb2Rl SW5kZXgoKSkuYml0cygpOwogI2Vsc2UKLSAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3Ry dWN0aW9uID0gb3V0ZXJtb3N0QmFzZWxpbmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0KGNv ZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgpLnB0cigpOworICAgICAgICBjb25zdCBJbnN0cnVjdGlv biogaW5zdHJ1Y3Rpb24gPSBvdXRlcm1vc3RCYXNlbGluZUNvZGVCbG9jay0+aW5zdHJ1Y3Rpb25z KCkuYXQoY29kZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCgpKS5wdHIoKTsKICAgICAgICAgdWludDMy X3QgbG9jYXRpb25CaXRzID0gQ2FsbFNpdGVJbmRleChpbnN0cnVjdGlvbikuYml0cygpOwogI2Vu ZGlmCiAgICAgICAgIGZyYW1lLnNldE9wZXJhbmQ8dWludDMyX3Q+KENhbGxGcmFtZVNsb3Q6OmFy Z3VtZW50Q291bnQsIFRhZ09mZnNldCwgbG9jYXRpb25CaXRzKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyQ29tbW9uLmNwcAppbmRleCA4 MzUzODAwN2NmMDAxNGY2MDEzZjRmZTMyMDVjY2RlNmUwMzU1NjJhLi4yNDljOTE3OTYwYzdjMWFm MmU0YjZhMDYzOTkyMTZlMWMzYjJhZWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR09TUkV4aXRDb21waWxlckNvbW1vbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGlsZXJDb21tb24uY3BwCkBAIC0yMzcsNyArMjM3LDcg QEAgdm9pZCByZWlmeUlubGluZWRDYWxsRnJhbWVzKENDYWxsSGVscGVycyYgaml0LCBjb25zdCBP U1JFeGl0QmFzZSYgZXhpdCkKICAgICAgICAgICAgIGppdC5zdG9yZTY0KEFzc2VtYmx5SGVscGVy czo6VHJ1c3RlZEltbTY0KEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlKGlubGluZUNhbGxGcmFtZS0+ Y2FsbGVlQ29uc3RhbnQoKSkpKSwgQXNzZW1ibHlIZWxwZXJzOjphZGRyZXNzRm9yKChWaXJ0dWFs UmVnaXN0ZXIpKGlubGluZUNhbGxGcmFtZS0+c3RhY2tPZmZzZXQgKyBDYWxsRnJhbWVTbG90Ojpj YWxsZWUpKSk7CiAjZWxzZSAvLyBVU0UoSlNWQUxVRTY0KSAvLyBzbyB0aGlzIGlzIHRoZSAzMi1i aXQgcGFydAogICAgICAgICBqaXQuc3RvcmVQdHIoY2FsbGVyRnJhbWVHUFIsIEFzc2VtYmx5SGVs cGVyczo6YWRkcmVzc0ZvckJ5dGVPZmZzZXQoaW5saW5lQ2FsbEZyYW1lLT5jYWxsZXJGcmFtZU9m ZnNldCgpKSk7Ci0gICAgICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGJhc2Vs aW5lQ29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4 KS5wdHIoKTsKKyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gYmFzZWxp bmVDb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgo KSkucHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0cyA9IENhbGxTaXRlSW5kZXgo aW5zdHJ1Y3Rpb24pLmJpdHMoKTsKICAgICAgICAgaml0LnN0b3JlMzIoQXNzZW1ibHlIZWxwZXJz OjpUcnVzdGVkSW1tMzIobG9jYXRpb25CaXRzKSwgQXNzZW1ibHlIZWxwZXJzOjp0YWdGb3IoKFZp cnR1YWxSZWdpc3RlcikoaW5saW5lQ2FsbEZyYW1lLT5zdGFja09mZnNldCArIENhbGxGcmFtZVNs b3Q6OmFyZ3VtZW50Q291bnQpKSk7CiAgICAgICAgIGppdC5zdG9yZTMyKEFzc2VtYmx5SGVscGVy czo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcpLCBBc3NlbWJseUhlbHBlcnM6OnRhZ0Zv cigoVmlydHVhbFJlZ2lzdGVyKShpbmxpbmVDYWxsRnJhbWUtPnN0YWNrT2Zmc2V0ICsgQ2FsbEZy YW1lU2xvdDo6Y2FsbGVlKSkpOwpAQCAtMjUxLDcgKzI1MSw3IEBAIHZvaWQgcmVpZnlJbmxpbmVk Q2FsbEZyYW1lcyhDQ2FsbEhlbHBlcnMmIGppdCwgY29uc3QgT1NSRXhpdEJhc2UmIGV4aXQpCiAj aWYgVVNFKEpTVkFMVUU2NCkKICAgICAgICAgdWludDMyX3QgbG9jYXRpb25CaXRzID0gQ2FsbFNp dGVJbmRleChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KCkpLmJpdHMoKTsKICNlbHNlCi0gICAg ICAgIGNvbnN0IEluc3RydWN0aW9uKiBpbnN0cnVjdGlvbiA9IGppdC5iYXNlbGluZUNvZGVCbG9j aygpLT5pbnN0cnVjdGlvbnMoKS5hdChjb2RlT3JpZ2luLT5ieXRlY29kZUluZGV4KS5wdHIoKTsK KyAgICAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0aW9uID0gaml0LmJhc2VsaW5lQ29k ZUJsb2NrKCktPmluc3RydWN0aW9ucygpLmF0KGNvZGVPcmlnaW4tPmJ5dGVjb2RlSW5kZXgoKSku cHRyKCk7CiAgICAgICAgIHVpbnQzMl90IGxvY2F0aW9uQml0cyA9IENhbGxTaXRlSW5kZXgoaW5z dHJ1Y3Rpb24pLmJpdHMoKTsKICNlbmRpZgogICAgICAgICBqaXQuc3RvcmUzMihBc3NlbWJseUhl bHBlcnM6OlRydXN0ZWRJbW0zMihsb2NhdGlvbkJpdHMpLCBBc3NlbWJseUhlbHBlcnM6OnRhZ0Zv cigoVmlydHVhbFJlZ2lzdGVyKShDYWxsRnJhbWVTbG90Ojphcmd1bWVudENvdW50KSkpOwo=