196043 2019-03-20 16:20:51 -0700 [iOS] Allow file-read* for Cookies.binarycookies in NetworkProcess sandbox 2019-03-21 10:39:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1519282 0 pvollan 2019-03-20 16:20:51 -0700 The sandbox needs to allow reading the file Cookies.binarycookies. 1519283 1 pvollan 2019-03-20 16:21:16 -0700 rdar://problem/45818048 1519287 2 365430 pvollan 2019-03-20 16:26:11 -0700 Created attachment 365430 Patch 1519308 3 365433 pvollan 2019-03-20 16:38:54 -0700 Created attachment 365433 Patch 1519323 4 365433 bfulgham 2019-03-20 16:51:46 -0700 Comment on attachment 365433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365433&action=review > Source/WebKit/ChangeLog:9 > + The sandbox needs to allow reading from and writing to the file Cookies.binarycookies. I'm not sure we need file-write. I think that's handled elsewhere? Or did you see file-write issues? > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:110 > + ((relative-regex #"/Library/Cookies/Cookies.binarycookies$")) Gotta love scheme let syntax. So many parentheses. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:111 > + (allow file-read* file-write* I think we should limit it to file-read. Do we know of valid file-write cases? 1519716 5 365433 bfulgham 2019-03-21 10:39:12 -0700 Comment on attachment 365433 Patch Actually, after investigating further, I don't think we want any of this. I think the sandbox violation we noticed was a bug in shutdown code. 1519718 6 bfulgham 2019-03-21 10:39:52 -0700 I think this bug was due to a misunderstanding on my part. I'm going to close this as not needed -- I think we may have a bug in the NetworkProcess shutdown code. 365430 2019-03-20 16:26:11 -0700 2019-03-20 16:38:53 -0700 Patch bug-196043-20190320162611.patch text/plain 1532 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDMyNTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTIwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBbGxvdyBmaWxlLXJl YWQqIGZvciBDb29raWVzLmJpbmFyeWNvb2tpZXMgaW4gTmV0d29ya1Byb2Nlc3Mgc2FuZGJveAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDQzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTgxODA0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2FuZGJveCBuZWVkcyB0byBhbGxvdyByZWFk aW5nIGFuZCB3cml0aW5nIG9mIHRoZSBmaWxlIENvb2tpZXMuYmluYXJ5Y29va2llcy4KKworICAg ICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0 d29ya2luZy5zYjoKKwogMjAxOS0wMS0xNiAgQWxhbiBDb29uICA8YWxhbmNvb25AYXBwbGUuY29t PgogCiAgICAgICAgIENoZXJyeS1waWNrIHIyNDAwODcuIHJkYXI6Ly9wcm9ibGVtLzQ3Mjk3MzA0 CkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5h cHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5z YgkocmV2aXNpb24gMjQzMjQ3KQorKysgU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFBy b2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2IJKHdvcmtpbmcgY29weSkK QEAgLTk4LDMgKzk4LDExIEBACiA7OyBGb3IgcmVwb3J0aW5nIHByb2dyZXNzIGZvciBhY3RpdmUg ZG93bmxvYWRzIDxyZGFyOi8vcHJvYmxlbS80NDQwNTY2MT4KIChhbGxvdyBtYWNoLWxvb2t1cAog ICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlByb2dyZXNzUmVwb3J0aW5nIikpCisKKzs7IDxy ZGFyOi8vcHJvYmxlbS80NTgxODA0OD4KKyhsZXQKKyAgICAoKHJlbGF0aXZlLXJlZ2V4ICMiL0xp YnJhcnkvQ29va2llcy9Db29raWVzLmJpbmFyeWNvb2tpZXMkIikpCisgICAgKGFsbG93IGZpbGUt cmVhZCogZmlsZS13cml0ZSoKKyAgICAgICAgICAgKGFueS1jb250YWluZXItcmVnZXggcmVsYXRp dmUtcmVnZXgpCisgICAgICAgICAgIChhbnktZ3JvdXAtY29udGFpbmVyLXJlZ2V4IHJlbGF0aXZl LXJlZ2V4KQorICAgICAgICAgICAoaG9tZS1yZWdleCByZWxhdGl2ZS1yZWdleCkpKQo= 365433 2019-03-20 16:38:54 -0700 2019-03-21 10:39:12 -0700 Patch bug-196043-20190320163854.patch text/plain 1514 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDMyNTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTIwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBbGxvdyBmaWxlLXJl YWQqIGZvciBDb29raWVzLmJpbmFyeWNvb2tpZXMgaW4gTmV0d29ya1Byb2Nlc3Mgc2FuZGJveAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDQzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NTgxODA0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2FuZGJveCBuZWVkcyB0byBhbGxvdyByZWFk aW5nIGZyb20gYW5kIHdyaXRpbmcgdG8gdGhlIGZpbGUgQ29va2llcy5iaW5hcnljb29raWVzLgor CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5OZXR3b3JraW5nLnNiOgorCiAyMDE5LTAzLTIwICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFw cGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgY2hlY2tzIHRoYXQgZGV0ZXJtaW5lIGlmIFdlYktp dCBpcyBzeXN0ZW0gV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuTmV0d29ya2luZy5zYgkocmV2aXNpb24gMjQzMjU1KQorKysgU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcu c2IJKHdvcmtpbmcgY29weSkKQEAgLTEwNCwzICsxMDQsMTEgQEAKICA7OyA8cmRhcjovL3Byb2Js ZW0vNDc1OTg3NTg+CiAoYWxsb3cgbWFjaC1sb29rdXAKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5uZXNlc3Npb25tYW5hZ2VyLmNvbnRlbnQtZmlsdGVyIikpCisKKzs7IDxyZGFyOi8vcHJv YmxlbS80NTgxODA0OD4KKyhsZXQKKyAgICAoKHJlbGF0aXZlLXJlZ2V4ICMiL0xpYnJhcnkvQ29v a2llcy9Db29raWVzLmJpbmFyeWNvb2tpZXMkIikpCisgICAgKGFsbG93IGZpbGUtcmVhZCogZmls ZS13cml0ZSoKKyAgICAgICAgKGFueS1jb250YWluZXItcmVnZXggcmVsYXRpdmUtcmVnZXgpCisg ICAgICAgIChhbnktZ3JvdXAtY29udGFpbmVyLXJlZ2V4IHJlbGF0aXZlLXJlZ2V4KQorICAgICAg ICAoaG9tZS1yZWdleCByZWxhdGl2ZS1yZWdleCkpKQo=