196032 2019-03-20 13:56:51 -0700 JSC::createError needs to check for OOM in errorDescriptionForValue 2019-03-27 19:49:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196089 InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue dwfault ews-watchlist keith_miller mark.lam msaboff rmorisset ryanhaddad saam sroberts webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1519159 0 tzagallo 2019-03-20 13:56:51 -0700 ... 1519164 1 365396 tzagallo 2019-03-20 14:07:18 -0700 Created attachment 365396 Patch 1519179 2 tzagallo 2019-03-20 14:25:41 -0700 <rdar://problem/46842740> 1519185 3 365396 mark.lam 2019-03-20 14:31:18 -0700 Comment on attachment 365396 Patch r=me 1519222 4 365396 commit-queue 2019-03-20 15:12:18 -0700 Comment on attachment 365396 Patch Clearing flags on attachment: 365396 Committed r243246: <https://trac.webkit.org/changeset/243246> 1519223 5 commit-queue 2019-03-20 15:12:19 -0700 All reviewed patches have been landed. Closing bug. 1519316 6 ryanhaddad 2019-03-20 16:48:17 -0700 stress/create-error-out-of-memory-rope-string.js is failing on the Release JSC bot: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20JSC%20%28Tests%29/builds/8582/steps/jscore-test/logs/stdio 1519351 7 ysuzuki 2019-03-20 17:28:05 -0700 Committed r243265: <https://trac.webkit.org/changeset/243265> 1519685 8 sroberts 2019-03-21 09:37:11 -0700 stress/create-error-out-of-memory-rope-string.js.bytecode-cache stress/create-error-out-of-memory-rope-string.js.default stress/create-error-out-of-memory-rope-string.js.dfg-eager stress/create-error-out-of-memory-rope-string.js.dfg-eager-no-cjit-validate stress/create-error-out-of-memory-rope-string.js.dfg-maximal-flush-validate-no-cjit stress/create-error-out-of-memory-rope-string.js.ftl-eager stress/create-error-out-of-memory-rope-string.js.ftl-eager-no-cjit stress/create-error-out-of-memory-rope-string.js.ftl-eager-no-cjit-b3o1 stress/create-error-out-of-memory-rope-string.js.ftl-no-cjit-b3o0 stress/create-error-out-of-memory-rope-string.js.ftl-no-cjit-no-inline-validate stress/create-error-out-of-memory-rope-string.js.ftl-no-cjit-no-put-stack-validate stress/create-error-out-of-memory-rope-string.js.ftl-no-cjit-small-pool stress/create-error-out-of-memory-rope-string.js.ftl-no-cjit-validate-sampling-profiler stress/create-error-out-of-memory-rope-string.js.no-cjit-validate-phases stress/create-error-out-of-memory-rope-string.js.no-ftl stress/create-error-out-of-memory-rope-string.js.no-llint New test is causing 15 Failures on JSC Debug queue's. https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20(Tests)/builds/2394/steps/jscore-test/logs/stdio 1519759 9 tzagallo 2019-03-21 11:15:37 -0700 (In reply to Shawn Roberts from comment #8) > New test is causing 15 Failures on JSC Debug queue's. I'm fixing it in https://bugs.webkit.org/show_bug.cgi?id=196089 1521983 10 dwfault 2019-03-27 19:49:14 -0700 *** Bug 195875 has been marked as a duplicate of this bug. *** 365396 2019-03-20 14:07:18 -0700 2019-03-20 15:12:18 -0700 Patch bug-196032-20190320220715.patch text/plain 5754 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MWZhOWI2ZDg5ZGJjMGVlY2MzOTkzYTNjYzM4NWExNWRiMjU0NDAwLi5iNWY4NTZjMTFjMzVjZDk3 Y2NkNWZmMWU2MzEyODYzYjU2YWU0NDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOS0wMy0yMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBKU0M6OmNyZWF0ZUVycm9yIG5lZWRzIHRvIGNoZWNrIGZvciBPT00gaW4g ZXJyb3JEZXNjcmlwdGlvbkZvclZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTYwMzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2ODQyNzQw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdl cmUgbWlzc2luZyBleGNlcHRpb25zIGNoZWNrcyBhdCB0d28gbGV2ZWxzOgorICAgICAgICAtIElu IGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZSwgd2hlbiB0aGUgdmFsdWUgaXMgYSBzdHJpbmcsIHdl IHNob3VsZAorICAgICAgICAgIGNoZWNrIHRoYXQgSlNTdHJpbmc6OnZhbHVlIHJldHVybnMgYSB2 YWxpZCBzdHJpbmcsIHNpbmNlIHdlIG1pZ2h0IHJ1bgorICAgICAgICAgIG91dCBvZiBtZW1vcnkg aWYgaXQgaXMgYSByb3BlIGFuZCB3ZSBuZWVkIHRvIHJlc29sdmUgaXQuCisgICAgICAgIC0gSW4g Y3JlYXRlRXJyb3IsIHdlIHNob3VsZCBjaGVjayBmb3IgdGhlIHJlc3VsdCBvZiBlcnJvckRlc2Ny aXB0aW9uRm9yVmFsdWUKKyAgICAgICAgICBiZWZvcmUgY29uY2F0ZW5hdGluZyBpdCB3aXRoIHRo ZSBtZXNzYWdlIHByb3ZpZGVkIGJ5IHRoZSBjYWxsZXIuCisKKyAgICAgICAgKiBydW50aW1lL0V4 Y2VwdGlvbkhlbHBlcnMuY3BwOgorICAgICAgICAoSlNDOjplcnJvckRlc2NyaXB0aW9uRm9yVmFs dWUpOgorICAgICAgICAoSlNDOjpjcmVhdGVFcnJvcik6CisgICAgICAgICogcnVudGltZS9FeGNl cHRpb25IZWxwZXJzLmg6CisKIDIwMTktMDMtMjAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlYXJjaDogYWxsb3cgRE9NIHNlYXJj aGVzIHRvIGJlIGNhc2Ugc2Vuc2l0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCmluZGV4IDk1YWU0NGM3YzE5MmQ2YTI3NDk0YTU4 YWI2NWRjYmNmYzg5M2JiN2MuLmY4ZGUwZTQ0ZGU4NjAzOGQ5MDIyZmU5OGZhYzhmZTk1OTk0MzQ3 YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhl bHBlcnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhl bHBlcnMuY3BwCkBAIC04OSwyMSArODksMjYgQEAgSlNPYmplY3QqIGNyZWF0ZVVuZGVmaW5lZFZh cmlhYmxlRXJyb3IoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBpZGVudCkKICAg ICByZXR1cm4gY3JlYXRlUmVmZXJlbmNlRXJyb3IoZXhlYywgbWVzc2FnZSk7CiB9CiAgICAgCi1K U1N0cmluZyogZXJyb3JEZXNjcmlwdGlvbkZvclZhbHVlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1 ZSB2KQorU3RyaW5nIGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIEpT VmFsdWUgdikKIHsKLSAgICBpZiAodi5pc1N0cmluZygpKQotICAgICAgICByZXR1cm4ganNOb250 cml2aWFsU3RyaW5nKGV4ZWMsIG1ha2VTdHJpbmcoJyInLCBhc1N0cmluZyh2KS0+dmFsdWUoZXhl YyksICciJykpOworICAgIGlmICh2LmlzU3RyaW5nKCkpIHsKKyAgICAgICAgU3RyaW5nIHN0cmlu ZyA9IGFzU3RyaW5nKHYpLT52YWx1ZShleGVjKTsKKyAgICAgICAgaWYgKCFzdHJpbmcpCisgICAg ICAgICAgICByZXR1cm4gc3RyaW5nOworICAgICAgICByZXR1cm4gdHJ5TWFrZVN0cmluZygnIics IHN0cmluZywgJyInKTsKKyAgICB9CisKICAgICBpZiAodi5pc1N5bWJvbCgpKQotICAgICAgICBy ZXR1cm4ganNOb250cml2aWFsU3RyaW5nKGV4ZWMsIGFzU3ltYm9sKHYpLT5kZXNjcmlwdGl2ZVN0 cmluZygpKTsKKyAgICAgICAgcmV0dXJuIGFzU3ltYm9sKHYpLT5kZXNjcmlwdGl2ZVN0cmluZygp OwogICAgIGlmICh2LmlzT2JqZWN0KCkpIHsKICAgICAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsK ICAgICAgICAgQ2FsbERhdGEgY2FsbERhdGE7CiAgICAgICAgIEpTT2JqZWN0KiBvYmplY3QgPSBh c09iamVjdCh2KTsKICAgICAgICAgaWYgKG9iamVjdC0+bWV0aG9kVGFibGUodm0pLT5nZXRDYWxs RGF0YShvYmplY3QsIGNhbGxEYXRhKSAhPSBDYWxsVHlwZTo6Tm9uZSkKLSAgICAgICAgICAgIHJl dHVybiB2bS5zbWFsbFN0cmluZ3MuZnVuY3Rpb25TdHJpbmcoKTsKLSAgICAgICAgcmV0dXJuIGpz U3RyaW5nKGV4ZWMsIEpTT2JqZWN0OjpjYWxjdWxhdGVkQ2xhc3NOYW1lKG9iamVjdCkpOworICAg ICAgICAgICAgcmV0dXJuIHZtLnNtYWxsU3RyaW5ncy5mdW5jdGlvblN0cmluZygpLT52YWx1ZShl eGVjKTsKKyAgICAgICAgcmV0dXJuIEpTT2JqZWN0OjpjYWxjdWxhdGVkQ2xhc3NOYW1lKG9iamVj dCk7CiAgICAgfQotICAgIHJldHVybiB2LnRvU3RyaW5nKGV4ZWMpOworICAgIHJldHVybiB2LnRv U3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKTsKIH0KICAgICAKIHN0YXRpYyBTdHJpbmcgZGVmYXVs dEFwcHJveGltYXRlU291cmNlRXJyb3IoY29uc3QgU3RyaW5nJiBvcmlnaW5hbE1lc3NhZ2UsIGNv bnN0IFN0cmluZyYgc291cmNlVGV4dCkKQEAgLTI2OSw4ICsyNzQsMTEgQEAgSlNPYmplY3QqIGNy ZWF0ZUVycm9yKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgY29uc3QgU3RyaW5nJiBt ZXNzYWdlLCBFcnIKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBE RUNMQVJFX0NBVENIX1NDT1BFKHZtKTsKIAotICAgIFN0cmluZyBlcnJvck1lc3NhZ2UgPSB0cnlN YWtlU3RyaW5nKGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZShleGVjLCB2YWx1ZSktPnZhbHVlKGV4 ZWMpLCAnICcsIG1lc3NhZ2UpOwotICAgIGlmIChlcnJvck1lc3NhZ2UuaXNOdWxsKCkpCisgICAg U3RyaW5nIHZhbHVlRGVzY3JpcHRpb24gPSBlcnJvckRlc2NyaXB0aW9uRm9yVmFsdWUoZXhlYywg dmFsdWUpOworICAgIGlmICghdmFsdWVEZXNjcmlwdGlvbikKKyAgICAgICAgcmV0dXJuIGNyZWF0 ZU91dE9mTWVtb3J5RXJyb3IoZXhlYyk7CisgICAgU3RyaW5nIGVycm9yTWVzc2FnZSA9IHRyeU1h a2VTdHJpbmcodmFsdWVEZXNjcmlwdGlvbiwgJyAnLCBtZXNzYWdlKTsKKyAgICBpZiAoIWVycm9y TWVzc2FnZSkKICAgICAgICAgcmV0dXJuIGNyZWF0ZU91dE9mTWVtb3J5RXJyb3IoZXhlYyk7CiAg ICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKICAgICBKU09iamVjdCogZXhjZXB0aW9uID0g Y3JlYXRlVHlwZUVycm9yKGV4ZWMsIGVycm9yTWVzc2FnZSwgYXBwZW5kZXIsIHJ1bnRpbWVUeXBl Rm9yVmFsdWUodm0sIHZhbHVlKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9FeGNlcHRpb25IZWxwZXJzLmgKaW5kZXggZDEzNTg1ODUzYWQzNWYyZWExOGU0ZmMwZjBjNjJi MTE0M2I1MzE1ZC4uYWE1MTE0MDNkZWM3NDQ3NjI3YmVhODA0NTk4YTA4MjcyYmFkZmRjZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuaApA QCAtNTQsNyArNTQsNyBAQCBKU09iamVjdCogY3JlYXRlSW52YWxpZEluc3RhbmNlb2ZQYXJhbWV0 ZXJFcnJvckhhc0luc3RhbmNlVmFsdWVOb3RGdW5jdGlvbihFeGVjUwogSlNPYmplY3QqIGNyZWF0 ZU5vdEFDb25zdHJ1Y3RvckVycm9yKEV4ZWNTdGF0ZSosIEpTVmFsdWUpOwogSlNPYmplY3QqIGNy ZWF0ZU5vdEFGdW5jdGlvbkVycm9yKEV4ZWNTdGF0ZSosIEpTVmFsdWUpOwogSlNPYmplY3QqIGNy ZWF0ZUVycm9yRm9ySW52YWxpZEdsb2JhbEFzc2lnbm1lbnQoRXhlY1N0YXRlKiwgY29uc3QgU3Ry aW5nJik7Ci1KU1N0cmluZyogZXJyb3JEZXNjcmlwdGlvbkZvclZhbHVlKEV4ZWNTdGF0ZSosIEpT VmFsdWUpOworU3RyaW5nIGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZShFeGVjU3RhdGUqLCBKU1Zh bHVlKTsKIAogSlNfRVhQT1JUX1BSSVZBVEUgRXhjZXB0aW9uKiB0aHJvd091dE9mTWVtb3J5RXJy b3IoRXhlY1N0YXRlKiwgVGhyb3dTY29wZSYpOwogSlNfRVhQT1JUX1BSSVZBVEUgRXhjZXB0aW9u KiB0aHJvd1N0YWNrT3ZlcmZsb3dFcnJvcihFeGVjU3RhdGUqLCBUaHJvd1Njb3BlJik7CmRpZmYg LS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVkZGQ4 NWQ5MTc5MTI4MWFjMDVmNDlhZDAyMjk1MGYzNGE0ZWIzMjUuLjAxZmYxZTNjMzA1M2M5YzNlYjg1 NThiM2U1MmZmNTY0YTdjOGJmNTUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBi L0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDMtMjAgIFRhZGV1IFph Z2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CisKKyAgICAgICAgSlNDOjpjcmVhdGVFcnJvciBu ZWVkcyB0byBjaGVjayBmb3IgT09NIGluIGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDMyCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80Njg0Mjc0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9jcmVhdGUtZXJyb3Itb3V0LW9mLW1lbW9yeS1y b3BlLXN0cmluZy5qczogQWRkZWQuCisKIDIwMTktMDMtMTkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZWR1Y2UgIyBvZiBpdGVyYXRp b25zIHRvIGF2b2lkIHRpbWluZyBvdXQgYWZ0ZXIgcjI0Mjk5MQpkaWZmIC0tZ2l0IGEvSlNUZXN0 cy9zdHJlc3MvY3JlYXRlLWVycm9yLW91dC1vZi1tZW1vcnktcm9wZS1zdHJpbmcuanMgYi9KU1Rl c3RzL3N0cmVzcy9jcmVhdGUtZXJyb3Itb3V0LW9mLW1lbW9yeS1yb3BlLXN0cmluZy5qcwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5jMzQxOTFjOWM4Mzk2OTgzMGYwYzQ4NWFkMTExZDBmMzEzMjE5MzdhCi0tLSAvZGV2 L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvY3JlYXRlLWVycm9yLW91dC1vZi1tZW1vcnktcm9w ZS1zdHJpbmcuanMKQEAgLTAsMCArMSwzIEBACit2YXIgZm9vID0gJ3l5P3hcdUZGRkQkdyAgICA1 P1x1RkZGRG9cdUZGRkQ/XHVGRkZEXCdpP1x1RkZGREUtTlx1RkZGRFx1RkZGRDZfXHVGRkZEXFwg ZCc7Citmb28gPSBmb28ucGFkRW5kKDIxNDc0ODM2NDQsIDEpOworZXZhbCgnZm9vKCknKTsK