196030 2019-03-20 13:53:21 -0700 typeOfDoubleSum is wrong for when NaN can be produced 2019-03-20 22:42:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195924 InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1519156 0 saam 2019-03-20 13:53:21 -0700 Infinity - Infinity => NaN Is not accounted for. 1519186 1 365402 saam 2019-03-20 14:33:15 -0700 Created attachment 365402 patch 1519192 2 365402 mark.lam 2019-03-20 14:39:53 -0700 Comment on attachment 365402 patch LGTM too. 1519363 3 365402 commit-queue 2019-03-20 17:40:29 -0700 Comment on attachment 365402 patch Rejecting attachment 365402 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365402, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365402&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196030&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 365402 from bug 196030. Fetching: https://bugs.webkit.org/attachment.cgi?id=365402 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... A JSTests/stress/double-add-sub-mul-can-produce-nan.js M JSTests/ChangeLog M Source/JavaScriptCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date W: 4d40f7bafaea8029ae231f38a2a41421c8de85f4 and refs/remotes/origin/master differ, using rebase: :040000 040000 85bf7abca3a79b62a8c05669af0c40976710bc5a a69ecbb95b421f9bf452b0d5d197e76dddc5f3ff M JSTests :040000 040000 345ff4410c941d1627384c445a0909190368aac5 aca9e99a40d141f1cdcb7e217dc5a9b38fcd8b8a M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... A JSTests/stress/double-add-sub-mul-can-produce-nan.js M JSTests/ChangeLog M Source/JavaScriptCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/JavaScriptCore/ChangeLog' is out of date W: 4d40f7bafaea8029ae231f38a2a41421c8de85f4 and refs/remotes/origin/master differ, using rebase: :040000 040000 85bf7abca3a79b62a8c05669af0c40976710bc5a a69ecbb95b421f9bf452b0d5d197e76dddc5f3ff M JSTests :040000 040000 345ff4410c941d1627384c445a0909190368aac5 aca9e99a40d141f1cdcb7e217dc5a9b38fcd8b8a M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit d67192ed7e9..ef6c3148711 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 243263 = d67192ed7e9efc330afba5524c134dfbc682dc76 r243264 = 996dffcff457b7bd0872ec61a9d10e2a42215515 r243265 = 7e125bb19efc0fce646a4589f869ea936df32dd0 r243266 = f9426b3fb8fa00e960f94a135116eb4b36f89b2a r243267 = ef6c3148711bb4111b84a8635c0e10f7e3b95b93 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11588535 1519477 4 365402 commit-queue 2019-03-20 22:41:26 -0700 Comment on attachment 365402 patch Clearing flags on attachment: 365402 Committed r243277: <https://trac.webkit.org/changeset/243277> 1519478 5 commit-queue 2019-03-20 22:41:28 -0700 All reviewed patches have been landed. Closing bug. 1519479 6 webkit-bug-importer 2019-03-20 22:42:14 -0700 <rdar://problem/49095288> 365402 2019-03-20 14:33:15 -0700 2019-03-20 22:41:26 -0700 patch c-backup.diff text/plain 5206 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMyMzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIHR5cGVPZkRvdWJsZVN1bSBpcyB3cm9uZyBmb3Igd2hlbiBOYU4gY2Fu IGJlIHByb2R1Y2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTYwMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHN0cmVzcy9kb3VibGUtYWRkLXN1Yi1tdWwtY2FuLXByb2R1Y2UtbmFuLmpzOiBBZGRl ZC4KKyAgICAgICAgKGFzc2VydCk6CisgICAgICAgIChub0lubGluZS5zdWIpOgorICAgICAgICAo bm9JbmxpbmUpOgorICAgICAgICAoYXNzZXJ0Lm11bCk6CisgICAgICAgIChhc3NlcnQuYWRkKToK KwogMjAxOS0wMy0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJlZHVjZSAjIG9mIGl0ZXJhdGlvbnMgdG8gYXZvaWQgdGltaW5nIG91 dCBhZnRlciByMjQyOTkxCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9kb3VibGUtYWRkLXN1Yi1tdWwt Y2FuLXByb2R1Y2UtbmFuLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2RvdWJsZS1h ZGQtc3ViLW11bC1jYW4tcHJvZHVjZS1uYW4uanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9z dHJlc3MvZG91YmxlLWFkZC1zdWItbXVsLWNhbi1wcm9kdWNlLW5hbi5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDc3IEBACisidXNlIHN0cmljdCI7CisKK2Z1bmN0aW9uIGFzc2VydChiKSB7 CisgICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3I7Cit9Citub0lubGluZShhc3Nl cnQpOworCit7CisgICAgZnVuY3Rpb24gc3ViKGFyciwgYiwgYykgeworICAgICAgICBsZXQgeCA9 IGIgLSBjOworICAgICAgICBhcnJbMF0gPSB4OworICAgIH0KKyAgICBub0lubGluZShzdWIpOwor CisKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwOyArK2kpIHsKKyAgICAgICAgbGV0IGFy ciA9IFtdOworICAgICAgICBhcnIubGVuZ3RoID0gMjsKKyAgICAgICAgYXJyWzFdID0gMTAuNTsK KyAgICAgICAgc3ViKGFyciwgMTAuNSwgMjAuNSk7CisgICAgICAgIGFzc2VydCgwIGluIGFycik7 CisgICAgfQorCisgICAgbGV0IGFyciA9IFtdOworICAgIGFyci5sZW5ndGggPSAyOworICAgIGFy clsxXSA9IDEwLjU7CisgICAgc3ViKGFyciwgSW5maW5pdHksIEluZmluaXR5KTsKKyAgICBhc3Nl cnQodHlwZW9mIGFyclswXSA9PT0gIm51bWJlciIgJiYgaXNOYU4oYXJyWzBdKSk7CisgICAgYXNz ZXJ0KDAgaW4gYXJyKTsKK30KKworeworICAgIGZ1bmN0aW9uIG11bChhcnIsIGIsIGMpIHsKKyAg ICAgICAgbGV0IHggPSBiICogYzsKKyAgICAgICAgYXJyWzBdID0geDsKKyAgICB9CisgICAgbm9J bmxpbmUobXVsKTsKKworICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICAg ICAgICBsZXQgYXJyID0gW107CisgICAgICAgIGFyci5sZW5ndGggPSAyOworICAgICAgICBhcnJb MV0gPSAxMC41OworICAgICAgICBtdWwoYXJyLCAxMC41LCAyMC41KTsKKyAgICAgICAgYXNzZXJ0 KDAgaW4gYXJyKTsKKyAgICB9CisKKyAgICBsZXQgYXJyID0gW107CisgICAgYXJyLmxlbmd0aCA9 IDI7CisgICAgYXJyWzFdID0gMTAuNTsKKyAgICBtdWwoYXJyLCBJbmZpbml0eSwgMCk7CisgICAg YXNzZXJ0KHR5cGVvZiBhcnJbMF0gPT09ICJudW1iZXIiICYmIGlzTmFOKGFyclswXSkpOworICAg IGFzc2VydCgwIGluIGFycik7Cit9CisKK3sKKyAgICBmdW5jdGlvbiBhZGQoYXJyLCBiLCBjKSB7 CisgICAgICAgIGxldCB4ID0gYiArIGM7CisgICAgICAgIGFyclswXSA9IHg7CisgICAgfQorICAg IG5vSW5saW5lKGFkZCk7CisKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwOyArK2kpIHsK KyAgICAgICAgbGV0IGFyciA9IFtdOworICAgICAgICBhcnIubGVuZ3RoID0gMjsKKyAgICAgICAg YXJyWzFdID0gMTAuNTsKKyAgICAgICAgYWRkKGFyciwgMTAuNSwgMjAuNSk7CisgICAgICAgIGFz c2VydCgwIGluIGFycik7CisgICAgfQorCisgICAgbGV0IGFyciA9IFtdOworICAgIGFyci5sZW5n dGggPSAyOworICAgIGFyclsxXSA9IDEwLjU7CisgICAgYWRkKGFyciwgSW5maW5pdHksIC1JbmZp bml0eSk7CisgICAgYXNzZXJ0KHR5cGVvZiBhcnJbMF0gPT09ICJudW1iZXIiICYmIGlzTmFOKGFy clswXSkpOworICAgIGFzc2VydCgwIGluIGFycik7Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDI0MzIzOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNCBAQAorMjAxOS0wMy0yMCAgU2FhbSBCYXJh dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICB0eXBlT2ZEb3VibGVTdW0gaXMgd3Jv bmcgZm9yIHdoZW4gTmFOIGNhbiBiZSBwcm9kdWNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSB1c2luZyB0eXBlT2ZEb3VibGVTdW0oU3Bl Y3VsYXRlZFR5cGUsIFNwZWN1bGF0ZWRUeXBlKSBmb3IgYWRkL3N1Yi9tdWwuCisgICAgICAgIEl0 IGFzc3VtZWQgdGhhdCB0aGUgb25seSB3YXkgdGhlIHJlc3VsdGluZyB0eXBlIGNvdWxkIGJlIE5h TiBpcyBpZiBvbmUgb2YKKyAgICAgICAgdGhlIGlucHV0cyB3ZXJlIE5hTi4gSG93ZXZlciwgdGhp cyBpcyB3cm9uZy4gTmFOIGNhbiBiZSBwcm9kdWNlZCBpbiBhdCBsZWFzdAorICAgICAgICB0aGVz ZSBjYXNlczoKKyAgICAgICAgICBJbmZpbml0eSAtIEluZmluaXR5CisgICAgICAgICAgSW5maW5p dHkgKyAoLUluZmluaXR5KQorICAgICAgICAgIEluZmluaXR5ICogMAorCisgICAgICAgICogYnl0 ZWNvZGUvU3BlY3VsYXRlZFR5cGUuY3BwOgorICAgICAgICAoSlNDOjp0eXBlT2ZEb3VibGVTdW1P ckRpZmZlcmVuY2VPclByb2R1Y3QpOgorICAgICAgICAoSlNDOjp0eXBlT2ZEb3VibGVTdW0pOgor ICAgICAgICAoSlNDOjp0eXBlT2ZEb3VibGVEaWZmZXJlbmNlKToKKyAgICAgICAgKEpTQzo6dHlw ZU9mRG91YmxlUHJvZHVjdCk6CisKIDIwMTktMDMtMjAgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9m ZkBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIHRlc3QgY3Jhc2g6IHN0cmVzcy9kb250LXN0cmVu Z3RoLXJlZHVjZS1yZWdleHAtd2l0aC1jb21waWxlLWVycm9yLmpzLmRlZmF1bHQKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNwcAko cmV2aXNpb24gMjQzMjM4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1 bGF0ZWRUeXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEyLDkgKzYxMiwxOCBAQCBib29sIHZh bHVlc0NvdWxkQmVFcXVhbChTcGVjdWxhdGVkVHlwZSBhCiAgICAgcmV0dXJuICEhKGEgJiBiKTsK IH0KIAotU3BlY3VsYXRlZFR5cGUgdHlwZU9mRG91YmxlU3VtKFNwZWN1bGF0ZWRUeXBlIGEsIFNw ZWN1bGF0ZWRUeXBlIGIpCitzdGF0aWMgU3BlY3VsYXRlZFR5cGUgdHlwZU9mRG91YmxlU3VtT3JE aWZmZXJlbmNlT3JQcm9kdWN0KFNwZWN1bGF0ZWRUeXBlIGEsIFNwZWN1bGF0ZWRUeXBlIGIpCiB7 CiAgICAgU3BlY3VsYXRlZFR5cGUgcmVzdWx0ID0gYSB8IGI7CisKKyAgICBpZiAocmVzdWx0ICYg U3BlY05vbkludEFzRG91YmxlKSB7CisgICAgICAgIC8vIE5hTiBjYW4gYmUgcHJvZHVjZWQgYnk6 CisgICAgICAgIC8vIEluZmluaXR5IC0gSW5maW5pdHkKKyAgICAgICAgLy8gSW5maW5pdHkgKyAo LUluZmluaXR5KQorICAgICAgICAvLyBJbmZpbml0eSAqIDAKKyAgICAgICAgcmVzdWx0IHw9IFNw ZWNEb3VibGVQdXJlTmFOOworICAgIH0KKwogICAgIC8vIEltcHVyZSBOYU4gY291bGQgYmVjb21l IHB1cmUgTmFOIGR1cmluZyBhZGRpdGlvbiBiZWNhdXNlIGFkZGl0aW9uIG1heSBjbGVhciBiaXRz LgogICAgIGlmIChyZXN1bHQgJiBTcGVjRG91YmxlSW1wdXJlTmFOKQogICAgICAgICByZXN1bHQg fD0gU3BlY0RvdWJsZVB1cmVOYU47CkBAIC02MjQsMTQgKzYzMywxOSBAQCBTcGVjdWxhdGVkVHlw ZSB0eXBlT2ZEb3VibGVTdW0oU3BlY3VsYXRlCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAorU3Bl Y3VsYXRlZFR5cGUgdHlwZU9mRG91YmxlU3VtKFNwZWN1bGF0ZWRUeXBlIGEsIFNwZWN1bGF0ZWRU eXBlIGIpCit7CisgICAgcmV0dXJuIHR5cGVPZkRvdWJsZVN1bU9yRGlmZmVyZW5jZU9yUHJvZHVj dChhLCBiKTsKK30KKwogU3BlY3VsYXRlZFR5cGUgdHlwZU9mRG91YmxlRGlmZmVyZW5jZShTcGVj dWxhdGVkVHlwZSBhLCBTcGVjdWxhdGVkVHlwZSBiKQogewotICAgIHJldHVybiB0eXBlT2ZEb3Vi bGVTdW0oYSwgYik7CisgICAgcmV0dXJuIHR5cGVPZkRvdWJsZVN1bU9yRGlmZmVyZW5jZU9yUHJv ZHVjdChhLCBiKTsKIH0KIAogU3BlY3VsYXRlZFR5cGUgdHlwZU9mRG91YmxlUHJvZHVjdChTcGVj dWxhdGVkVHlwZSBhLCBTcGVjdWxhdGVkVHlwZSBiKQogewotICAgIHJldHVybiB0eXBlT2ZEb3Vi bGVTdW0oYSwgYik7CisgICAgcmV0dXJuIHR5cGVPZkRvdWJsZVN1bU9yRGlmZmVyZW5jZU9yUHJv ZHVjdChhLCBiKTsKIH0KIAogc3RhdGljIFNwZWN1bGF0ZWRUeXBlIHBvbGx1dGVEb3VibGUoU3Bl Y3VsYXRlZFR5cGUgdmFsdWUpCg==