196019 2019-03-20 11:41:01 -0700 DFGNodeAllocator.h is dead code 2019-03-20 13:38:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1519028 0 rmorisset 2019-03-20 11:41:01 -0700 As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit. This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove. 1519033 1 365370 rmorisset 2019-03-20 11:43:11 -0700 Created attachment 365370 Patch 1519046 2 365370 ysuzuki 2019-03-20 11:51:17 -0700 Comment on attachment 365370 Patch r=me 1519146 3 365370 commit-queue 2019-03-20 13:37:07 -0700 Comment on attachment 365370 Patch Clearing flags on attachment: 365370 Committed r243236: <https://trac.webkit.org/changeset/243236> 1519147 4 commit-queue 2019-03-20 13:37:08 -0700 All reviewed patches have been landed. Closing bug. 1519148 5 webkit-bug-importer 2019-03-20 13:38:22 -0700 <rdar://problem/49076340> 365370 2019-03-20 11:43:11 -0700 2019-03-20 13:37:07 -0700 Patch bug-196019-20190320114306.patch text/plain 3492 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MWZhOWI2ZDg5ZGJjMGVlY2MzOTkzYTNjYzM4NWExNWRiMjU0NDAwLi41YmFlMWQyOTljMjc0Y2Y3 OTI2ZGE0YTc2NzkxN2E3M2UzNjdmZTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMy0yMCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIERGR05vZGVBbGxvY2F0b3IuaCBpcyBkZWFkIGNvZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjAxOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGV4cGxhaW5lZCBieSBZ dXN1a2Ugb24gSVJDLCB0aGUgY29tbWVudCBvbiBERkc6Ok5vZGUgc2F5aW5nIHRoYXQgaXQgY2Fu bm90IGhhdmUgYSBkZXN0cnVjdG9yIGlzIG9ic29sZXRlIHNpbmNlIGh0dHBzOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC8yMTY4MTUvd2Via2l0LgorICAgICAgICBUaGlzIHBhdGNoIHJlbW92 ZXMgYm90aCB0aGUgY29tbWVudCBhbmQgREZHTm9kZUFsbG9jYXRvci5oIHRoYXQgdGhhdCBwYXRj aCBmb3Jnb3QgdG8gcmVtb3ZlLgorCisgICAgICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAg KEpTQzo6REZHOjpOb2RlOjpkdW1wQ2hpbGRyZW4pOgorICAgICAgICAqIGRmZy9ERkdOb2RlQWxs b2NhdG9yLmg6IFJlbW92ZWQuCisKIDIwMTktMDMtMjAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlYXJjaDogYWxsb3cgRE9NIHNl YXJjaGVzIHRvIGJlIGNhc2Ugc2Vuc2l0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR05vZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5o CmluZGV4IDQ1OGRiNjI5NzZjOTY4OTYyOTQ0YWQ0YjBjN2NlOTE2YWQ0NWVlNGYuLjI2Y2M3MzFm OWRlOGMzY2M3NmUzNzBiYTNhNmMzMzQwNWIxNWMxYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTm9kZS5oCkBAIC0yODg3LDggKzI4ODcsNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIG91dC5wcmludGYoIiwgQCV1IiwgY2hpbGQzKCktPmluZGV4KCkpOwogICAg IH0KLSAgICAKLSAgICAvLyBOQi4gVGhpcyBjbGFzcyBtdXN0IGhhdmUgYSB0cml2aWFsIGRlc3Ry dWN0b3IuCiAKICAgICBOb2RlT3JpZ2luIG9yaWdpbjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlQWxsb2NhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR05vZGVBbGxvY2F0b3IuaApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MWQ2MzUyYTUzZWI1ZDAyNjJiYmM4Yjk3MjgzYjI0MWZjNjU0MjViZi4uMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR05vZGVBbGxvY2F0b3IuaAorKysgL2Rldi9udWxsCkBAIC0xLDQ0ICswLDAgQEAKLS8qCi0g KiBDb3B5cmlnaHQgKEMpIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoK LSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICogMS4gUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAq ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJv ZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVu dGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0 aW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBgYEFT IElTJycgQU5EIEFOWQotICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO RywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKLSAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgotICogUFVSUE9TRSBBUkUg RElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IKLSAqIENPTlRSSUJV VE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVD SUFMLAotICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLAotICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBP UiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCi0gKiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCi0gKiBPRiBM SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK LSAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCi0gKi8KLQotI3ByYWdtYSBvbmNlCi0K LSNpZiBFTkFCTEUoREZHX0pJVCkKLQotI2luY2x1ZGUgIkRGR05vZGUuaCIKLQotbmFtZXNwYWNl IEpTQyB7IG5hbWVzcGFjZSBERkcgewotCi10eXBlZGVmIEFsbG9jYXRvcjxOb2RlPiBOb2RlQWxs b2NhdG9yOwotCi19IH0gLy8gbmFtZXNwYWNlIEpTQzo6REZHCi0KLWlubGluZSB2b2lkKiBvcGVy YXRvciBuZXcgKHNpemVfdCBzaXplLCBKU0M6OkRGRzo6Tm9kZUFsbG9jYXRvciYgYWxsb2NhdG9y KQotewotICAgIEFTU0VSVF9VTlVTRUQoc2l6ZSwgc2l6ZSA9PSBzaXplb2YoSlNDOjpERkc6Ok5v ZGUpKTsKLSAgICByZXR1cm4gYWxsb2NhdG9yLmFsbG9jYXRlKCk7Ci19Ci0KLSNlbmRpZiAvLyBF TkFCTEUoREZHX0pJVCkK