196017 2019-03-20 10:55:43 -0700 (Test fix) Override minimumTimeBetweenDataRecordsRemoval in ResourceLoadStatisticsStore::shouldRemoveDataRecord() during layout tests 2019-03-27 11:25:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195923 InRadar P2 Normal --- 1 wilander wilander commit-queue sroberts webkit-bug-importer oldest_to_newest 1518994 0 wilander 2019-03-20 10:55:43 -0700 The test added in https://bugs.webkit.org/show_bug.cgi?id=195923 is failing because ITP refuses (and should refuse) to remove website data repeatedly. We should add an exception to this rule when running under parameters().isRunningTest. 1518996 1 365359 wilander 2019-03-20 10:57:19 -0700 Created attachment 365359 Patch for landing 1519063 2 365359 commit-queue 2019-03-20 12:01:37 -0700 Comment on attachment 365359 Patch for landing Clearing flags on attachment: 365359 Committed r243222: <https://trac.webkit.org/changeset/243222> 1519064 3 commit-queue 2019-03-20 12:01:39 -0700 All reviewed patches have been landed. Closing bug. 1519069 4 webkit-bug-importer 2019-03-20 12:05:10 -0700 <rdar://problem/49072535> 1520440 5 sroberts 2019-03-22 11:36:29 -0700 http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html started to become flaky again on the dashboard ~r243340 Dashboard : https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fwebsite-data-removal-for-site-navigated-to-with-link-decoration.html I can reproduce it locally with : run-webkit-tests http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html --iterations 500 --child-processes 1 Usually only about 2/500 failures in revisions between r243351 to r243373. with 1 child process. If I run it in full parallel (-f), it will fail a lot more consistently, but I don't know if that may be causing false positives. It will fail in full parallel between r242231 and r243347. ~2/5000 iterations Passes in full parallel with 5000 iterations from r243222 to r243230. Local Diff is the same as the bots, with 1 child process or full parallel : --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-actual.txt @@ -32,4 +32,4 @@ localhost gotLinkDecorationFromPrevalentResource: No isPrevalentResource: No isVeryPrevalentResource: No - dataRecordsRemoved: 1 + dataRecordsRemoved: 0 1521757 6 sroberts 2019-03-27 11:25:20 -0700 Regressed issue down to https://trac.webkit.org/changeset/243348/webkit , appears to be responsible for new behavior. 365359 2019-03-20 10:57:19 -0700 2019-03-20 12:01:37 -0700 Patch for landing bug-196017-20190320105719.patch text/plain 2043 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjYmFhOGIxMGM2NzE2OTYz MWIxYTY3NTc3N2E2MzVjYzAwNDBkY2EuLmQyOWVkMzM4YzI4NTFlYzIxMGRjYTI4MDY0MDZkMGY5 N2YzOTUyYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDMtMjAgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgKFRlc3QgZml4KSBPdmVycmlk ZSBtaW5pbXVtVGltZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwgaW4gUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlOjpzaG91bGRSZW1vdmVEYXRhUmVjb3JkKCkgZHVyaW5nIGxheW91dCB0ZXN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MDE3 CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGZpeC4KKworICAgICAgICBUaGlzIHBhdGNoIGFk ZHMgYSBjaGVjayBvZiBwYXJhbWV0ZXJzKCkuaXNSdW5uaW5nVGVzdCB0byB0aGUgcmV0dXJuIG9m CisgICAgICAgIFJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6c2hvdWxkUmVtb3ZlRGF0YVJl Y29yZCgpIHRvIGFsbG93IHN1Y2Nlc3NpdmUKKyAgICAgICAgbGF5b3V0IHRlc3RzIHRvIHJlbW92 ZSB3ZWJzaXRlIGRhdGEsIGVmZmVjdGl2ZWx5IG92ZXJyaWRpbmcgdGhlCisgICAgICAgIG1pbmlt dW1UaW1lQmV0d2VlbkRhdGFSZWNvcmRzUmVtb3ZhbCBzZXR0aW5nLgorCisgICAgICAgICogTmV0 d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwOgor ICAgICAgICAoV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnNob3VsZFJlbW92 ZURhdGFSZWNvcmRzIGNvbnN0KToKKwogMjAxOS0wMy0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0eXBvIGluIGNvbW1lbnQgYWRk ZWQgaW4gcjI0MzE1Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Q2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5j cHAKaW5kZXggYzIwZDA5MjljODlhYzM4Zjg3NTFjMTYxY2Q5NDdjYWIyMGExZjg3OS4uMjI5MWZk M2RiMzBkZGQ4YWY1Mzk5OGUwNTk3NzA1MjIxY2RhYWRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291 cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKQEAgLTQwNiw3ICs0MDYsNyBAQCBib29sIFJlc291 cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6c2hvdWxkUmVtb3ZlRGF0YVJlY29yZHMoKSBjb25zdAog ICAgIH0KICNlbmRpZgogCi0gICAgcmV0dXJuICFtX2xhc3RUaW1lRGF0YVJlY29yZHNXZXJlUmVt b3ZlZCB8fCBNb25vdG9uaWNUaW1lOjpub3coKSA+PSAobV9sYXN0VGltZURhdGFSZWNvcmRzV2Vy ZVJlbW92ZWQgKyBtX3BhcmFtZXRlcnMubWluaW11bVRpbWVCZXR3ZWVuRGF0YVJlY29yZHNSZW1v dmFsKTsKKyAgICByZXR1cm4gIW1fbGFzdFRpbWVEYXRhUmVjb3Jkc1dlcmVSZW1vdmVkIHx8IE1v bm90b25pY1RpbWU6Om5vdygpID49IChtX2xhc3RUaW1lRGF0YVJlY29yZHNXZXJlUmVtb3ZlZCAr IG1fcGFyYW1ldGVycy5taW5pbXVtVGltZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwpIHx8IHBh cmFtZXRlcnMoKS5pc1J1bm5pbmdUZXN0OwogfQogCiB2b2lkIFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZTo6c2V0RGF0YVJlY29yZHNCZWluZ1JlbW92ZWQoYm9vbCB2YWx1ZSkK