<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196014</bug_id>
          
          <creation_ts>2019-03-20 10:41:39 -0700</creation_ts>
          <short_desc>B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes</short_desc>
          <delta_ts>2019-03-21 14:37:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robin Morisset">rmorisset</reporter>
          <assigned_to name="Robin Morisset">rmorisset</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1518976</commentid>
    <comment_count>0</comment_count>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-03-20 10:41:39 -0700</bug_when>
    <thetext>B3::Opcode has less than one hundred cases, so it can easily fit in one byte (from two currently)
This shrinks B3::Kind from 4 bytes to 2 (by removing the byte of padding at the end).
This in turns eliminate padding from B3Value, shrinking it by 8 bytes (out of 80).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1518979</commentid>
    <comment_count>1</comment_count>
      <attachid>365356</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-03-20 10:43:36 -0700</bug_when>
    <thetext>Created attachment 365356
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1518993</commentid>
    <comment_count>2</comment_count>
      <attachid>365356</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-03-20 10:49:17 -0700</bug_when>
    <thetext>Comment on attachment 365356
Patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1519943</commentid>
    <comment_count>3</comment_count>
      <attachid>365356</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-21 14:36:32 -0700</bug_when>
    <thetext>Comment on attachment 365356
Patch

Clearing flags on attachment: 365356

Committed r243330: &lt;https://trac.webkit.org/changeset/243330&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1519944</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-21 14:36:33 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1519945</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-03-21 14:37:26 -0700</bug_when>
    <thetext>&lt;rdar://problem/49124622&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>365356</attachid>
            <date>2019-03-20 10:43:36 -0700</date>
            <delta_ts>2019-03-21 14:36:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196014-20190320104333.patch</filename>
            <type>text/plain</type>
            <size>1538</size>
            <attacher name="Robin Morisset">rmorisset</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1
YzVhODk0MWUwNjk1YzcyZjE5YWY1ZjQ3ZWU4OTZlY2YzMDZiYjhhLi5hZGUxZjU3OGM3MWZkZjQw
OWQ3ODUyOTE2ZWQ4NGJjYmUwMmNiNTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxOS0wMy0yMCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu
Y29tPgorCisgICAgICAgIEIzOjpPcGNvZGUgY2FuIGZpdCBpbiBhIHNpbmdsZSBieXRlLCBzaHJp
bmtpbmcgQjNWYWx1ZSBieSA4IGJ5dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xOTYwMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBCMzo6T3Bjb2RlIGhhcyBsZXNzIHRoYW4gb25lIGh1bmRyZWQgY2Fz
ZXMsIHNvIGl0IGNhbiBlYXNpbHkgZml0IGluIG9uZSBieXRlIChmcm9tIHR3byBjdXJyZW50bHkp
CisgICAgICAgIFRoaXMgc2hyaW5rcyBCMzo6S2luZCBmcm9tIDQgYnl0ZXMgdG8gMiAoYnkgcmVt
b3ZpbmcgdGhlIGJ5dGUgb2YgcGFkZGluZyBhdCB0aGUgZW5kKS4KKyAgICAgICAgVGhpcyBpbiB0
dXJucyBlbGltaW5hdGUgcGFkZGluZyBmcm9tIEIzOjpWYWx1ZSwgc2hyaW5raW5nIGl0IGJ5IDgg
Ynl0ZXMgKG91dCBvZiA4MCkuCisKKyAgICAgICAgKiBiMy9CM09wY29kZS5oOgorCiAyMDE5LTAz
LTE5ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFBydW5lIGNv
ZGUgYWZ0ZXIgRm9yY2VPU1JFeGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
YjMvQjNPcGNvZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM09wY29kZS5oCmluZGV4
IGYxMDlmNTk4ZDZjMDk2NjQ0ZjJhOTNiOTZlOTZlOTBhNGU1ZDNjNjUuLmFhZGYzOWI0Y2Q2ZDg2
YTIwYzc4YmZiNWE2NmRjYWUxMGUwM2RkMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9iMy9CM09wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM09wY29k
ZS5oCkBAIC0zNyw3ICszNyw3IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQjMgewogLy8g
V2FybmluZzogSW4gQjMsIGFuIE9wY29kZSBpcyBqdXN0IG9uZSBwYXJ0IG9mIGEgS2luZC4gS2lu
ZCBpcyB1c2VkIHRoZSB3YXkgdGhhdCBhbiBvcGNvZGUKIC8vIHdvdWxkIGJlIHVzZWQgaW4gc2lt
cGxlIElScy4gU2VlIEIzS2luZC5oLgogCi1lbnVtIE9wY29kZSA6IGludDE2X3QgeworZW51bSBP
cGNvZGUgOiB1aW50OF90IHsKICAgICAvLyBBIG5vLW9wIHRoYXQgcmV0dXJucyBWb2lkLCB1c2Vm
dWwgZm9yIHdoZW4geW91IHdhbnQgdG8gcmVtb3ZlIGEgdmFsdWUuCiAgICAgTm9wLAogICAgIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>