195999 2019-03-20 06:30:56 -0700 Compilation broken in WKWebViewGetContents.mm with iOS SDK (rev 243195) 2019-03-21 15:18:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified iOS 12 RESOLVED FIXED InRadar P2 Normal --- 1 olivierrobin webkit-unassigned ajuma commit-queue fred.wang lforschler thorton timothy webkit-bug-importer oldest_to_newest 1518862 0 olivierrobin 2019-03-20 06:30:56 -0700 Compilation is broken with error webkit/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:60:14: error: '_getContentsAsAttributedStringWithCompletionHandler:' is unavailable: not available on iOS [webView _getContentsAsAttributedStringWithCompletionHandler:^(NSAttributedString *attributedString, NSDictionary<NSAttributedStringDocumentAttributeKey, id> *documentAttributes, NSError *error) { ^ In file included from webkit/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:30: In file included from webkit/Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h:28: In file included from /webkit/WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKNavigationDelegatePrivate.h:29: /WebKitBuild/Debug-iphonesimulator/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:367:1: note: '_getContentsAsAttributedStringWithCompletionHandler:' has been explicitly marked unavailable here - (void)_getContentsAsAttributedStringWithCompletionHandler:(void (^)(NSAttributedString *, NSDictionary<NSAttributedStringDocumentAttributeKey, id> *, NSError *))completionHandler API_AVAILABLE(macosx(NA), ios(NA)); ^ 1 error generated. 1518891 1 365347 olivierrobin 2019-03-20 08:47:13 -0700 Created attachment 365347 Initial upload 1518892 2 ajuma 2019-03-20 08:50:27 -0700 This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so often and breaks the open-source iOS build. 1518939 3 365347 commit-queue 2019-03-20 09:48:00 -0700 Comment on attachment 365347 Initial upload Clearing flags on attachment: 365347 Committed r243212: <https://trac.webkit.org/changeset/243212> 1518940 4 commit-queue 2019-03-20 09:48:02 -0700 All reviewed patches have been landed. Closing bug. 1518941 5 webkit-bug-importer 2019-03-20 09:49:19 -0700 <rdar://problem/49064939> 1519603 6 fred.wang 2019-03-21 05:06:20 -0700 (In reply to Ali Juma from comment #2) > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > often and breaks the open-source iOS build. I had added a style check in bug 181394 ; I wonder why the error was not caught by check-webkit-style? 1519615 7 fred.wang 2019-03-21 05:47:25 -0700 (In reply to Frédéric Wang (:fredw) from comment #6) > (In reply to Ali Juma from comment #2) > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > often and breaks the open-source iOS build. > > I had added a style check in bug 181394 ; I wonder why the error was not > caught by check-webkit-style? OK it was actually detected: https://bugs.webkit.org/show_bug.cgi?id=195636#c52 1519706 8 timothy 2019-03-21 10:22:50 -0700 (In reply to Frédéric Wang (:fredw) from comment #7) > (In reply to Frédéric Wang (:fredw) from comment #6) > > (In reply to Ali Juma from comment #2) > > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > > often and breaks the open-source iOS build. > > > > I had added a style check in bug 181394 ; I wonder why the error was not > > caught by check-webkit-style? > > OK it was actually detected: > https://bugs.webkit.org/show_bug.cgi?id=195636#c52 Oops, I remember seeing that and not fully understanding / reading it I guess. "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" That statement is true, it is not a number nor WK_IOS_TBA — nothing to see here. It sounded (at a glance) like it didn't approve of a define being used — expecting only a number — since macosx(WK_MAC_TBA) was also used on the same line. The missing part is this is about the WK_MAC_TBA being used in the ios() macro. An error more like would help: "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number" I'll file a bug on this. 1519978 9 fred.wang 2019-03-21 15:18:52 -0700 (In reply to Timothy Hatcher from comment #8) > (In reply to Frédéric Wang (:fredw) from comment #7) > > (In reply to Frédéric Wang (:fredw) from comment #6) > > > (In reply to Ali Juma from comment #2) > > > > This typo (WK_MAC_TBA instead of WK_IOS_TBA) unfortunately happens every so > > > > often and breaks the open-source iOS build. > > > > > > I had added a style check in bug 181394 ; I wonder why the error was not > > > caught by check-webkit-style? > > > > OK it was actually detected: > > https://bugs.webkit.org/show_bug.cgi?id=195636#c52 > > Oops, I remember seeing that and not fully understanding / reading it I > guess. > > "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" > > That statement is true, it is not a number nor WK_IOS_TBA — nothing to see > here. It sounded (at a glance) like it didn't approve of a define being used > — expecting only a number — since macosx(WK_MAC_TBA) was also used on the > same line. The missing part is this is about the WK_MAC_TBA being used in > the ios() macro. > > An error more like would help: > > "ios(WK_MAC_TBA) is invalid; expected WK_IOS_TBA or a number" > > I'll file a bug on this. I see. Thanks. 365347 2019-03-20 08:47:13 -0700 2019-03-20 09:48:00 -0700 Initial upload bug-195999-20190320164711.patch text/plain 1925 olivierrobin SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDMxOTUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAzLTIwICBPbGl2aWVyIFJv YmluICA8b2xpdmllcnJvYmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggX2dldENvbnRl bnRzQXNBdHRyaWJ1dGVkU3RyaW5nV2l0aENvbXBsZXRpb25IYW5kbGVyIGF2YWlsYWJpbGl0eSBm b3IgaU9TLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk1OTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwogMjAxOS0wMy0yMCAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYW4g cGxhdGZvcm0tZHJpdmVuIHNwZWxsLWNoZWNraW5nIG1lY2hhbmlzbQpJbmRleDogU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCShy ZXZpc2lvbiAyNDMxOTUpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3UHJpdmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNjQsNyArMzY0LDcgQEAgdHlwZWRl ZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1JlY3RFZAogLSAodm9pZClfZ2V0TWFpblJlc291 cmNlRGF0YVdpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNEYXRhICosIE5TRXJyb3Ig KikpY29tcGxldGlvbkhhbmRsZXI7CiAtICh2b2lkKV9nZXRXZWJBcmNoaXZlRGF0YVdpdGhDb21w bGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNEYXRhICosIE5TRXJyb3IgKikpY29tcGxldGlvbkhh bmRsZXI7CiAtICh2b2lkKV9nZXRDb250ZW50c0FzU3RyaW5nV2l0aENvbXBsZXRpb25IYW5kbGVy Oih2b2lkICheKShOU1N0cmluZyAqLCBOU0Vycm9yICopKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQ SV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwgaW9zKDExLjApKTsKLS0gKHZvaWQpX2dldENvbnRl bnRzQXNBdHRyaWJ1dGVkU3RyaW5nV2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU0F0 dHJpYnV0ZWRTdHJpbmcgKiwgTlNEaWN0aW9uYXJ5PE5TQXR0cmlidXRlZFN0cmluZ0RvY3VtZW50 QXR0cmlidXRlS2V5LCBpZD4gKiwgTlNFcnJvciAqKSljb21wbGV0aW9uSGFuZGxlciBXS19BUElf QVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX01BQ19UQkEpKTsKKy0gKHZvaWQp X2dldENvbnRlbnRzQXNBdHRyaWJ1dGVkU3RyaW5nV2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lk ICheKShOU0F0dHJpYnV0ZWRTdHJpbmcgKiwgTlNEaWN0aW9uYXJ5PE5TQXR0cmlidXRlZFN0cmlu Z0RvY3VtZW50QXR0cmlidXRlS2V5LCBpZD4gKiwgTlNFcnJvciAqKSljb21wbGV0aW9uSGFuZGxl ciBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsK IAogLSAodm9pZClfZ2V0QXBwbGljYXRpb25NYW5pZmVzdFdpdGhDb21wbGV0aW9uSGFuZGxlcjoo dm9pZCAoXikoX1dLQXBwbGljYXRpb25NYW5pZmVzdCAqKSljb21wbGV0aW9uSGFuZGxlciBXS19B UElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMy40KSwgaW9zKDExLjMpKTsKIAo=