195995 2019-03-20 04:05:33 -0700 [ews-build] Improve failure summary string for ApplyPatch step 2019-03-20 13:08:31 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist jbedard lforschler webkit-bug-importer oldest_to_newest 1518832 0 aakash_jain 2019-03-20 04:05:33 -0700 When ApplyPatch step fails, the buildbot generated summary is: 'Applied patch (failure)'. This isn't good and might be confusing. We should improve this to something like: 'Patch does not apply'. 1518833 1 365335 aakash_jain 2019-03-20 04:08:34 -0700 Created attachment 365335 Patch 1518835 2 ews-watchlist 2019-03-20 04:11:26 -0700 Attachment 365335 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:138: [ApplyPatch.getResultSummary] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139: [ApplyPatch.getResultSummary] Instance of 'ApplyPatch' has no 'results' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1518967 3 ap 2019-03-20 10:26:03 -0700 I'm having second thoughts about making Buildbot changes to tweak status bubble content. It's useful to have good text messages in Buildbot UI too. However, relying on Buildbot as authoritative source of status bubble UI text will become problematic once the system is in production, as we don't want to restart Buildbot often. So a less intrusive way to polish UI will need to be added. 1519007 4 365335 commit-queue 2019-03-20 11:10:37 -0700 Comment on attachment 365335 Patch Clearing flags on attachment: 365335 Committed r243217: <https://trac.webkit.org/changeset/243217> 1519008 5 commit-queue 2019-03-20 11:10:38 -0700 All reviewed patches have been landed. Closing bug. 1519011 6 webkit-bug-importer 2019-03-20 11:13:18 -0700 <rdar://problem/49069801> 365335 2019-03-20 04:08:34 -0700 2019-03-20 13:08:31 -0700 Patch bug-195995-20190320070903.patch text/plain 1371 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzE5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBJbXByb3ZlIGZhaWx1cmUgc3VtbWFyeSBzdHJpbmcg Zm9yIEFwcGx5UGF0Y2ggc3RlcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAg ICAgIChBcHBseVBhdGNoLmdldFJlc3VsdFN1bW1hcnkpOiBPdmVycmlkZSBnZXRSZXN1bHRTdW1t YXJ5LgorCiAyMDE5LTAzLTE5ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dlYkF1dGhOXSBJbXBsZW1lbnQgRklETyBBcHBJRCBleHRlbnNpb24KSW5kZXg6 IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0 MzE5NikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29y a2luZyBjb3B5KQpAQCAtMTM1LDYgKzEzNSwxMSBAQCBjbGFzcyBBcHBseVBhdGNoKHNoZWxsLlNo ZWxsQ29tbWFuZCwgQ29tCiAgICAgICAgIGQuYWRkQ2FsbGJhY2sobGFtYmRhIF86IHNlbGYuZG93 bmxvYWRGaWxlQ29udGVudFRvV29ya2VyKCcuYnVpbGRib3QtcGF0Y2hlZCcsICdwYXRjaGVkXG4n KSkKICAgICAgICAgZC5hZGRDYWxsYmFjayhsYW1iZGEgcmVzOiBzaGVsbC5TaGVsbENvbW1hbmQu c3RhcnQoc2VsZikpCiAKKyAgICBkZWYgZ2V0UmVzdWx0U3VtbWFyeShzZWxmKToKKyAgICAgICAg aWYgc2VsZi5yZXN1bHRzICE9IFNVQ0NFU1M6CisgICAgICAgICAgICByZXR1cm4ge3Unc3RlcCc6 IHUnUGF0Y2ggZG9lcyBub3QgYXBwbHknfQorICAgICAgICByZXR1cm4gc3VwZXIoQXBwbHlQYXRj aCwgc2VsZikuZ2V0UmVzdWx0U3VtbWFyeSgpCisKIAogY2xhc3MgQ2hlY2tQYXRjaFJlbGV2YW5j ZShidWlsZHN0ZXAuQnVpbGRTdGVwKToKICAgICBuYW1lID0gJ2NoZWNrLXBhdGNoLXJlbGV2YW5j ZScK