195993 2019-03-20 01:57:47 -0700 ContentChangeObserver build error for not include Element.h 2019-03-21 08:44:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cathiechen cathiechen commit-queue rbuis rwlbuis webkit-bug-importer oldest_to_newest 1518809 0 cathiechen 2019-03-20 01:57:47 -0700 ContentChangeObserver should include Element.h 1518810 1 365327 cathiechen 2019-03-20 02:03:50 -0700 Created attachment 365327 Patch 1518811 2 365328 cathiechen 2019-03-20 02:06:10 -0700 Created attachment 365328 Patch 1518815 3 365328 rbuis 2019-03-20 02:27:02 -0700 Comment on attachment 365328 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review ContentChangeObserver.h may need more fixes, I see Frame is used as well. Change does not hurt though so let's go for it, with ChangeLog improvement please. > Source/WebCore/ChangeLog:8 > + ContentChangeObserver should include Element.h. Please add some more context, i.e. how you found out there is a build error. 1518816 4 365328 cathiechen 2019-03-20 02:34:40 -0700 Comment on attachment 365328 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review Hi Rob, Thanks for the review! :) >> Source/WebCore/ChangeLog:8 >> + ContentChangeObserver should include Element.h. > > Please add some more context, i.e. how you found out there is a build error. Done. 1518818 5 365330 cathiechen 2019-03-20 02:36:05 -0700 Created attachment 365330 Patch 1518819 6 365330 rbuis 2019-03-20 02:39:38 -0700 Comment on attachment 365330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365330&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:33 > +#include "Element.h" I forgot, this include should not be needed since we include HTMLImageElement.h. 1518823 7 365331 cathiechen 2019-03-20 02:52:36 -0700 Created attachment 365331 Patch 1519637 8 365331 rbuis 2019-03-21 08:28:45 -0700 Comment on attachment 365331 Patch Retry. 1519648 9 365331 commit-queue 2019-03-21 08:43:41 -0700 Comment on attachment 365331 Patch Clearing flags on attachment: 365331 Committed r243290: <https://trac.webkit.org/changeset/243290> 1519649 10 commit-queue 2019-03-21 08:43:42 -0700 All reviewed patches have been landed. Closing bug. 1519650 11 webkit-bug-importer 2019-03-21 08:44:19 -0700 <rdar://problem/49108425> 365327 2019-03-20 02:03:50 -0700 2019-03-20 02:06:05 -0700 Patch bug-195993-20190320170348.patch text/plain 1759 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZkNmI0N2U1MGQwMzg3 YmFjZWZhOTkyNWYwYjhjZTE0MjIzZDhiNi4uMmIxODQyY2RiZTFjMWUwMTYzOGZjNjViMTUwYmMw NDc4ZTlhYmJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTIwICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlZCBDb250ZW50 Q2hhbmdlT2JzZXJ2ZXIgYnVpbGQgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb250ZW50Q2hhbmdlT2JzZXJ2ZXIgc2hvdWxkIGluY2x1ZGUg RWxlbWVudC5oLgorCisgICAgICAgICogcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNw cDoKKyAgICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaDoKKwogMjAxOS0w My0xOCAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBs aWZ5IENvY29hIHBsYXRmb3JtIHVzZXIgYWdlbnQgbG9naWMgYnkgdXNpbmcgc3RyaW5nIGNvbnN0 YW50cyBpbnN0ZWFkIG9mIGZ1bmN0aW9uIGNhbGxzIGZvciB0aGUgZnJvemVuIHBhcnRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAppbmRl eCA4YmRlMmQzN2ZjMzMwM2I1ZTVlZDc2ZjBhMjgwM2E4YTdkNjQ0ZmE0Li5hYzRlYjMwYWVhZjkx NTk4ZjVhZDIxZTI2YzNlOTNmMWUzNTVjYTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNs dWRlICJDaHJvbWVDbGllbnQuaCIKICNpbmNsdWRlICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRv Y3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxJbWFnZUVsZW1l bnQuaCIKICNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm9kZVJlbmRlclN0eWxlLmgi CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2 ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCmlu ZGV4IDZhZTE4MDI2MjFmODI0Njg1NGM0ZTFjZDliOTZmYTE1OTJmOWUxZmYuLjQ4NDM5NmQ2YmZh YjdlMDgxNTMwMjgzNTdmM2IwNGM2ZWZkODlmODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCkBAIC0zNSw2ICszNSw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogY2xhc3MgRE9NVGltZXI7CiBjbGFzcyBEb2N1bWVudDsKK2NsYXNzIEVs ZW1lbnQ7CiAKIGNsYXNzIENvbnRlbnRDaGFuZ2VPYnNlcnZlciB7CiBwdWJsaWM6Cg== 365328 2019-03-20 02:06:10 -0700 2019-03-20 02:35:59 -0700 Patch bug-195993-20190320170608.patch text/plain 1753 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZkNmI0N2U1MGQwMzg3 YmFjZWZhOTkyNWYwYjhjZTE0MjIzZDhiNi4uYmRjNmRiYmYwZTc1ODYyMTUwMzc3ZWFkZDA2MjBi NzJiNjgzM2Q5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTIwICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlZCBDb250ZW50 Q2hhbmdlT2JzZXJ2ZXIgYnVpbGQgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVp cy4KKworICAgICAgICBDb250ZW50Q2hhbmdlT2JzZXJ2ZXIgc2hvdWxkIGluY2x1ZGUgRWxlbWVu dC5oLgorCisgICAgICAgICogcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcDoKKyAg ICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaDoKKwogMjAxOS0wMy0xOCAg TWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IENv Y29hIHBsYXRmb3JtIHVzZXIgYWdlbnQgbG9naWMgYnkgdXNpbmcgc3RyaW5nIGNvbnN0YW50cyBp bnN0ZWFkIG9mIGZ1bmN0aW9uIGNhbGxzIGZvciB0aGUgZnJvemVuIHBhcnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAppbmRleCA4YmRl MmQzN2ZjMzMwM2I1ZTVlZDc2ZjBhMjgwM2E4YTdkNjQ0ZmE0Li5hYzRlYjMwYWVhZjkxNTk4ZjVh ZDIxZTI2YzNlOTNmMWUzNTVjYTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lv cy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9z L0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJD aHJvbWVDbGllbnQuaCIKICNpbmNsdWRlICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRvY3VtZW50 LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxJbWFnZUVsZW1lbnQuaCIK ICNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm9kZVJlbmRlclN0eWxlLmgiCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCmluZGV4IDZh ZTE4MDI2MjFmODI0Njg1NGM0ZTFjZDliOTZmYTE1OTJmOWUxZmYuLjQ4NDM5NmQ2YmZhYjdlMDgx NTMwMjgzNTdmM2IwNGM2ZWZkODlmODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv aW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9z L0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCkBAIC0zNSw2ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogY2xhc3MgRE9NVGltZXI7CiBjbGFzcyBEb2N1bWVudDsKK2NsYXNzIEVsZW1lbnQ7 CiAKIGNsYXNzIENvbnRlbnRDaGFuZ2VPYnNlcnZlciB7CiBwdWJsaWM6Cg== 365330 2019-03-20 02:36:05 -0700 2019-03-20 02:52:29 -0700 Patch bug-195993-20190320173603.patch text/plain 1816 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZkNmI0N2U1MGQwMzg3 YmFjZWZhOTkyNWYwYjhjZTE0MjIzZDhiNi4uYjQ1YjIyZGJjZGVmNjJkMWE3NTg3MmZlZjY2MmNl MmU3MjNkZDY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTIwICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlZCBDb250ZW50 Q2hhbmdlT2JzZXJ2ZXIgYnVpbGQgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVp cy4KKworICAgICAgICBFV1MgSU9TIGNvbXBpbGVyIGNvbXBsYWlucyB3aGVuIGFkZGVkIG5ldyBm aWxlcyBpbiBCdWcgMTU3NzQzLiBDb250ZW50Q2hhbmdlT2JzZXJ2ZXIgc2hvdWxkIGluY2x1ZGUg RWxlbWVudC5oLgorCisgICAgICAgICogcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNw cDoKKyAgICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaDoKKwogMjAxOS0w My0xOCAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBs aWZ5IENvY29hIHBsYXRmb3JtIHVzZXIgYWdlbnQgbG9naWMgYnkgdXNpbmcgc3RyaW5nIGNvbnN0 YW50cyBpbnN0ZWFkIG9mIGZ1bmN0aW9uIGNhbGxzIGZvciB0aGUgZnJvemVuIHBhcnRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAppbmRl eCA4YmRlMmQzN2ZjMzMwM2I1ZTVlZDc2ZjBhMjgwM2E4YTdkNjQ0ZmE0Li5hYzRlYjMwYWVhZjkx NTk4ZjVhZDIxZTI2YzNlOTNmMWUzNTVjYTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNs dWRlICJDaHJvbWVDbGllbnQuaCIKICNpbmNsdWRlICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRv Y3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxJbWFnZUVsZW1l bnQuaCIKICNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm9kZVJlbmRlclN0eWxlLmgi CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2 ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCmlu ZGV4IDZhZTE4MDI2MjFmODI0Njg1NGM0ZTFjZDliOTZmYTE1OTJmOWUxZmYuLjQ4NDM5NmQ2YmZh YjdlMDgxNTMwMjgzNTdmM2IwNGM2ZWZkODlmODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCkBAIC0zNSw2ICszNSw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogY2xhc3MgRE9NVGltZXI7CiBjbGFzcyBEb2N1bWVudDsKK2NsYXNzIEVs ZW1lbnQ7CiAKIGNsYXNzIENvbnRlbnRDaGFuZ2VPYnNlcnZlciB7CiBwdWJsaWM6Cg== 365331 2019-03-20 02:52:36 -0700 2019-03-21 08:43:41 -0700 Patch bug-195993-20190320175234.patch text/plain 1329 cathiechen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZkNmI0N2U1MGQwMzg3 YmFjZWZhOTkyNWYwYjhjZTE0MjIzZDhiNi4uMGI0OTRhMTM5NWMxYzcwNWNiMTZlMTcyODdhODUx NDQxY2Q1MjBhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTIwICBDYXRo aWUgQ2hlbiAgPGNhdGhpZWNoZW5AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlZCBDb250ZW50 Q2hhbmdlT2JzZXJ2ZXIgYnVpbGQgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVp cy4KKworICAgICAgICBFV1MgSU9TIGNvbXBpbGVyIGNvbXBsYWlucyBhZnRlciBhZGRpbmcgbmV3 IGZpbGVzIGluIEJ1ZyAxNTc3NDMuCisgICAgICAgIENvbnRlbnRDaGFuZ2VPYnNlcnZlci5oIHNo b3VsZCBoYXZlIGZvcndhcmQgZGVjbGFyYXRpb24gZm9yIEVsZW1lbnQuCisKKyAgICAgICAgKiBw YWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwOgorICAgICAgICAqIHBhZ2UvaW9zL0Nv bnRlbnRDaGFuZ2VPYnNlcnZlci5oOgorCiAyMDE5LTAzLTE4ICBNYWNpZWogU3RhY2hvd2lhayAg PG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxpZnkgQ29jb2EgcGxhdGZvcm0gdXNlciBh Z2VudCBsb2dpYyBieSB1c2luZyBzdHJpbmcgY29uc3RhbnRzIGluc3RlYWQgb2YgZnVuY3Rpb24g Y2FsbHMgZm9yIHRoZSBmcm96ZW4gcGFydHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3Mv Q29udGVudENoYW5nZU9ic2VydmVyLmgKaW5kZXggNmFlMTgwMjYyMWY4MjQ2ODU0YzRlMWNkOWI5 NmZhMTU5MmY5ZTFmZi4uNDg0Mzk2ZDZiZmFiN2UwODE1MzAyODM1N2YzYjA0YzZlZmQ4OWY4NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmgK QEAgLTM1LDYgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBET01UaW1lcjsK IGNsYXNzIERvY3VtZW50OworY2xhc3MgRWxlbWVudDsKIAogY2xhc3MgQ29udGVudENoYW5nZU9i c2VydmVyIHsKIHB1YmxpYzoK