195969 2019-03-19 15:50:56 -0700 [ Mac WK2 ] Layout Test js/dom/unhandled-promise-rejection-bindings-type-error.html is a flaky failure 2019-05-13 15:07:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts hi achristensen commit-queue hi joepeck lforschler saam webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1518589 0 sroberts 2019-03-19 15:50:56 -0700 The following layout test is failing on Mac WK2 js/dom/unhandled-promise-rejection-bindings-type-error.html Probable cause: Just showed up on the dashboard for the first time around r243141. Cannot find a regression point as I got it to fail locally with the oldest builds I could spade of Mojave Release WK2(228049) and Mojave Debug WK2(230024) . I could get it to fail consistently once I added -gf to my repro steps, and it would fail usually 2 within 10 tries. I could also get it to fail when running without it, but maybe 1 or 2 times in 10000 iterations. I get the same diff locally as seen on the server error. Reproduced with : run-webkit-tests js/dom/unhandled-promise-rejection-bindings-type-error.html -gf --iterations 2500 --exit-after-n-failures=2 --no-retry run-webkit-tests js/dom/unhandled-promise-rejection-bindings-type-error.html -gf --iterations 2500 --debug --exit-after-n-failures=2 --no-retry Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Funhandled-promise-rejection-bindings-type-error.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/js/dom/unhandled-promise-rejection-bindings-type-error-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/js/dom/unhandled-promise-rejection-bindings-type-error-actual.txt @@ -1,10 +1,7 @@ -CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: The PromiseRejectionEvent.promise getter can only be used on instances of PromiseRejectionEvent Test rejected promises are returned from bindings and trigger unhandledrejection. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS error.promise is promise -PASS error.reason instanceof TypeError is true PASS successfullyParsed is true TEST COMPLETE 1518590 1 webkit-bug-importer 2019-03-19 15:52:03 -0700 <rdar://problem/49039441> 1518669 2 joepeck 2019-03-19 17:46:14 -0700 It is possible for this to fail if somehow the 100ms timeout fires before promise rejections are handled. Which in practice should never happen... --debug will certainly make things slower -g is libgmalloc which will make the tests slower still -f is fully parallel which shouldn't do much Perhaps there is something better for the test to use instead of setTimeout. Maybe queueMicrotask a few times? 1535560 3 369707 hi 2019-05-13 01:04:14 -0700 Created attachment 369707 Patch 1535807 4 369707 commit-queue 2019-05-13 15:07:58 -0700 Comment on attachment 369707 Patch Clearing flags on attachment: 369707 Committed r245256: <https://trac.webkit.org/changeset/245256> 1535808 5 commit-queue 2019-05-13 15:07:59 -0700 All reviewed patches have been landed. Closing bug. 369707 2019-05-13 01:04:14 -0700 2019-05-13 15:07:58 -0700 Patch bug-195969-20190513010413.patch text/plain 1651 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZmI1NGVjOTk3YjNkZDZhYWQ0MzlmZmYxMGQwOGM5MDIzZjg2NDY1Li5kZDM4ODM4 MjUzMjRlMzU4MmE2ZGU2ZGYwY2Q5ZGU0NWZhNDI5OTRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTktMDUtMTMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFsgTWFjIFdLMiBdIExheW91dCBUZXN0IGpzL2RvbS91bmhhbmRsZWQtcHJvbWlzZS1yZWplY3Rp b24tYmluZGluZ3MtdHlwZS1lcnJvci5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1OTY5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80OTAzOTQ0MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGpzL2RvbS91bmhhbmRsZWQtcHJvbWlzZS1yZWplY3Rpb24tYmlu ZGluZ3MtdHlwZS1lcnJvci5odG1sOgorCiAyMDE5LTA1LTExICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJhY2tpbmctc2hhcmluZyBsYXllcnMgd2l0 aCB0cmFuc2Zvcm1zIHJlbmRlciBpbmNvcnJlY3RseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv anMvZG9tL3VuaGFuZGxlZC1wcm9taXNlLXJlamVjdGlvbi1iaW5kaW5ncy10eXBlLWVycm9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9qcy9kb20vdW5oYW5kbGVkLXByb21pc2UtcmVqZWN0aW9uLWJpbmRp bmdzLXR5cGUtZXJyb3IuaHRtbAppbmRleCA3NzgzZDQxMDBiNzM0ODNlYzhlYzEyMDQ3MGUyMzFl MWZmZTc4YjNkLi5jMjM0ZTU1YThjYmY1NzdmZDU1Yjg5MmU4NDlkN2MwYTVkNTc2YjZlIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9kb20vdW5oYW5kbGVkLXByb21pc2UtcmVqZWN0aW9uLWJp bmRpbmdzLXR5cGUtZXJyb3IuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9qcy9kb20vdW5oYW5kbGVk LXByb21pc2UtcmVqZWN0aW9uLWJpbmRpbmdzLXR5cGUtZXJyb3IuaHRtbApAQCAtMTcsNiArMTcs OCBAQCB3aW5kb3cub251bmhhbmRsZWRyZWplY3Rpb24gPSBmdW5jdGlvbiAoZSkgewogICAgIGVy cm9yID0gZTsKICAgICBzaG91bGRCZShgZXJyb3IucHJvbWlzZWAsIGBwcm9taXNlYCk7CiAgICAg c2hvdWxkQmVUcnVlKGBlcnJvci5yZWFzb24gaW5zdGFuY2VvZiBUeXBlRXJyb3JgKTsKKworICAg IHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgeyBmaW5pc2hKU1Rlc3QoKTsgfSwgMTAwKTsKIH07CiAK IHRyeSB7CkBAIC0yNCw5ICsyNiw2IEBAIHRyeSB7CiB9IGNhdGNoIChlKSB7CiAgICAgdGVzdEZh aWxlZCgiVHlwZUVycm9ycyBwcm9kdWNlZCBieSBnZXR0ZXJzIGZvciBQcm9taXNlIHJlc3VsdHMg c2hvdWxkIGJlIHdyYXBwZWQgaW4gYSBQcm9taXNlIik7CiB9Ci0KLXNldFRpbWVvdXQoZnVuY3Rp b24gKCkgeyBmaW5pc2hKU1Rlc3QoKTsgfSwgMTAwKTsKLQogPC9zY3JpcHQ+CiA8c2NyaXB0IHNy Yz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+Cg==