195963 2019-03-19 14:43:18 -0700 [ews-build] Improve summary for CheckOutSource step 2019-03-19 15:24:53 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu ews-watchlist jbedard lforschler webkit-bug-importer oldest_to_newest 1518532 0 aakash_jain 2019-03-19 14:43:18 -0700 The summary automatically generated by Buildbot for CheckOutSource step (which uses Buildbot base class git.Git) is 'update'. We should improve this. Buildbot doesn't seem to respect descriptionDone for git.Git class. Reference: https://github.com/buildbot/buildbot/issues/4666 1518533 1 365229 aakash_jain 2019-03-19 14:46:46 -0700 Created attachment 365229 Patch 1518534 2 ews-watchlist 2019-03-19 14:48:02 -0700 Attachment 365229 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:100: [CheckOutSource.getResultSummary] Instance of 'CheckOutSource' has no 'results' member [pylint/E1101] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1518537 3 aakash_jain 2019-03-19 14:48:51 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/19/builds/2215 1518552 4 365229 lforschler 2019-03-19 15:10:24 -0700 Comment on attachment 365229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365229&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:103 > + I think you should not abbreviate summary as 'summ'. it only saves a couple chars, so just use stepsummary or step_summary. or, just 'summary' this could also be written: if self.results != SUCCESS: return {u'step': u'Failed to updated working directory'} else: return {u'step': u'Cleaned and updated working directory' } which avoids the variable name altogether. 1518565 5 aakash_jain 2019-03-19 15:22:54 -0700 Committed r243174: <https://trac.webkit.org/changeset/243174> 1518566 6 aakash_jain 2019-03-19 15:24:34 -0700 > this could also be written: Thanks. used this. 1518567 7 webkit-bug-importer 2019-03-19 15:24:53 -0700 <rdar://problem/49038313> 365229 2019-03-19 14:46:46 -0700 2019-03-19 15:10:24 -0700 Patch bug-195963-20190319174714.patch text/plain 1340 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzE3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBJbXByb3ZlIHN1bW1hcnkgZm9yIENoZWNrT3V0U291 cmNlIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NTk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ2hlY2tP dXRTb3VyY2UuZ2V0UmVzdWx0U3VtbWFyeSk6CisKIDIwMTktMDMtMTkgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEZvY3VzIG5vdCBwcmVzZXJ2ZWQg d2hlbiBzd2l0Y2hpbmcgYmV0d2VlbiB0YWJzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNDMxNzApCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTk1LDYgKzk1 LDEyIEBAIGNsYXNzIENoZWNrT3V0U291cmNlKGdpdC5HaXQpOgogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvZ3Jlc3M9VHJ1ZSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICoqa3dhcmdzKQogCisgICAgZGVm IGdldFJlc3VsdFN1bW1hcnkoc2VsZik6CisgICAgICAgIHN0ZXBzdW1tID0gdSdDbGVhbmVkIGFu ZCB1cGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5JworICAgICAgICBpZiBzZWxmLnJlc3VsdHMgIT0g U1VDQ0VTUzoKKyAgICAgICAgICAgIHN0ZXBzdW1tID0gdSdGYWlsZWQgdG8gdXBkYXRlZCB3b3Jr aW5nIGRpcmVjdG9yeScKKyAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiBzdGVwc3VtbX0KKwogCiBj bGFzcyBDbGVhbldvcmtpbmdEaXJlY3Rvcnkoc2hlbGwuU2hlbGxDb21tYW5kKToKICAgICBuYW1l ID0gJ2NsZWFuLXdvcmtpbmctZGlyZWN0b3J5Jwo=