195931 2019-03-18 20:45:55 -0700 [WPE] Fix build warnings because of missing an argument when initializing wpe_input_axis_event 2019-03-19 18:38:19 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim aperez bugs-noreply cgarcia commit-queue mcatanzaro zan oldest_to_newest 1518116 0 gyuyoung.kim 2019-03-18 20:45:55 -0700 There are still build warning when building wpe port. I think that these build warnings have been caused by missing to set an argument for the modifier parameter of wpe_input_axis_event. /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp: In member function ‘bool WebKit::ScrollGestureController::handleEvent(const wpe_input_touch_event_raw*)’: /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp:59:13: warning: missing initializer for member ‘wpe_input_axis_event::modifiers’ [-Wmissing-field-initializers] }; ^ /home/gyuyoung/LGE/starfish/webkit/WebKit/Source/WebKit/UIProcess/API/wpe/ScrollGestureController.cpp:71:13: warning: missing initializer for member ‘wpe_input_axis_event::modifiers’ [-Wmissing-field-initializers] }; 1518120 1 365118 gyuyoung.kim 2019-03-18 21:01:03 -0700 Created attachment 365118 Patch 1518158 2 gyuyoung.kim 2019-03-18 23:46:17 -0700 If 0 is a wrong value for the modifier, please let me know. 1518224 3 365118 aperez 2019-03-19 06:20:06 -0700 Comment on attachment 365118 Patch Patch LGTM → informal r+ 1518681 4 gyuyoung.kim 2019-03-19 18:13:12 -0700 Thanks Adrian and Michael! 1518698 5 365118 commit-queue 2019-03-19 18:38:18 -0700 Comment on attachment 365118 Patch Clearing flags on attachment: 365118 Committed r243184: <https://trac.webkit.org/changeset/243184> 1518699 6 commit-queue 2019-03-19 18:38:19 -0700 All reviewed patches have been landed. Closing bug. 365118 2019-03-18 21:01:03 -0700 2019-03-19 18:38:18 -0700 Patch bug-195931-20190319130102.patch text/plain 2169 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc4MDY4OGVhZTI4N2JkOGVk MzMzMWRiM2E0MzJlZWQ3OTczY2VmYjEuLjM3ZGE3YTUzMjg2ZjQ4NWRlYTg5NTJkMWQ2ZWE5M2E5 MmRhMjNjMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDMtMTggIEd5dXlvdW5n IEtpbSAgPGd5dXlvdW5nLmtpbUBsZ2UuY29tPgorCisgICAgICAgIFtXUEVdIEZpeCBidWlsZCB3 YXJuaW5ncyBiZWNhdXNlIG9mIG1pc3NpbmcgYW4gYXJndW1lbnQgd2hlbiBpbml0aWFsaXppbmcg d3BlX2lucHV0X2F4aXNfZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NTkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZXJlIGFyZSBzdGlsbCBidWlsZCB3YXJuaW5ncyB3aGVuIGJ1aWxkaW5n IHdwZSBwb3J0LiBJdCBsb29rcyBsaWtlCisgICAgICAgIHRoZXNlIGJ1aWxkIHdhcm5pbmdzIGhh dmUgYmVlbiBjYXVzZWQgYnkgbWlzc2luZyB0byBzZXQgYW4gYXJndW1lbnQKKyAgICAgICAgZm9y IHRoZSBtb2RpZmllciBwYXJhbWV0ZXIgb2Ygd3BlX2lucHV0X2F4aXNfZXZlbnQuIFRoaXMgcGF0 Y2ggc2V0cyAwCisgICAgICAgIGZvciB0aGUgbW9kaWZpZXIgYXJndW1lbnQgdG8gYXZvaWQgdGhl IGJ1aWxkIHdhcm5pbmdzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2Vz dHVyZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpTY3JvbGxHZXN0dXJlQ29udHJv bGxlcjo6aGFuZGxlRXZlbnQpOgorCiAyMDE5LTAzLTE4ICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQz MDkyIGFuZCByMjQzMDk2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L3dwZS9TY3JvbGxHZXN0dXJlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcAppbmRleCBkYTEyYzhlYjM1MTc1 Yzk2NDAwOTY2ZjQ2MzZhMTM4YjliNDA4OTlkLi4xZTYxM2FlZTRkMTgzNzMwNGVlZmNjY2UxZDMw ODE4ODNlY2I0NmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3Bl L1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcApAQCAtNTUsNyArNTUsNyBAQCBi b29sIFNjcm9sbEdlc3R1cmVDb250cm9sbGVyOjpoYW5kbGVFdmVudChjb25zdCBzdHJ1Y3Qgd3Bl X2lucHV0X3RvdWNoX2V2ZW50X3JhdwogICAgICAgICAgICAgbV9heGlzRXZlbnQgPSB7CiAgICAg ICAgICAgICAgICAgd3BlX2lucHV0X2F4aXNfZXZlbnRfdHlwZV9tb3Rpb24sCiAgICAgICAgICAg ICAgICAgdG91Y2hQb2ludC0+dGltZSwgbV9zdGFydC54LCBtX3N0YXJ0LnksCi0gICAgICAgICAg ICAgICAgMiwgKHRvdWNoUG9pbnQtPnkgLSBtX29mZnNldC55KQorICAgICAgICAgICAgICAgIDIs ICh0b3VjaFBvaW50LT55IC0gbV9vZmZzZXQueSksIDAKICAgICAgICAgICAgIH07CiAgICAgICAg ICAgICBtX29mZnNldC54ID0gdG91Y2hQb2ludC0+eDsKICAgICAgICAgICAgIG1fb2Zmc2V0Lnkg PSB0b3VjaFBvaW50LT55OwpAQCAtNjcsNyArNjcsNyBAQCBib29sIFNjcm9sbEdlc3R1cmVDb250 cm9sbGVyOjpoYW5kbGVFdmVudChjb25zdCBzdHJ1Y3Qgd3BlX2lucHV0X3RvdWNoX2V2ZW50X3Jh dwogICAgICAgICAgICAgbV9oYW5kbGluZyA9IGZhbHNlOwogICAgICAgICAgICAgbV9heGlzRXZl bnQgPSB7CiAgICAgICAgICAgICAgICAgd3BlX2lucHV0X2F4aXNfZXZlbnRfdHlwZV9udWxsLAot ICAgICAgICAgICAgICAgIDAsIDAsIDAsIDAsIDAKKyAgICAgICAgICAgICAgICAwLCAwLCAwLCAw LCAwLCAwCiAgICAgICAgICAgICB9OwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAg IH0K