195927 2019-03-18 18:57:58 -0700 [JSC] Add missing exception checks revealed by newly added exception checks, follow-up after r243081 2019-03-18 20:01:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1518074 0 ysuzuki 2019-03-18 18:57:58 -0700 [JSC] Add missing exception checks revealed by newly added exception checks, follow-up after r243081 1518081 1 365106 ysuzuki 2019-03-18 19:00:37 -0700 Created attachment 365106 Patch 1518098 2 365106 mark.lam 2019-03-18 19:40:36 -0700 Comment on attachment 365106 Patch r=me 1518101 3 ysuzuki 2019-03-18 20:00:33 -0700 Committed r243128: <https://trac.webkit.org/changeset/243128> 1518102 4 webkit-bug-importer 2019-03-18 20:01:29 -0700 <rdar://problem/49004990> 365106 2019-03-18 19:00:37 -0700 2019-03-18 19:40:36 -0700 Patch bug-195927-20190318190036.patch text/plain 4174 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ODVjNjEyOTYwYTIxNzlhMGI4ODJlMWExZjkxMGEzNzVlYWJhZGYyLi5mODBlZTI2ZDljNGQzZTdj NThlNDAwZmRmYmE4ZDFlYmU5YjNlMGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMy0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVja3MgcmV2ZWFsZWQg YnkgbmV3bHkgYWRkZWQgZXhjZXB0aW9uIGNoZWNrcywgZm9sbG93LXVwIGFmdGVyIHIyNDMwODEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTkyNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNDMwODEg YWRkcyBtb3JlIGV4Y2VwdGlvbiBjaGVja3Mgd2hpY2ggYXJlIHByZXZpb3VzbHkgbWlzc2luZywg YW5kIGl0IHJldmVhbHMgbWlzc2luZyBleGNlcHRpb24gY2hlY2tzIGluIHRoZSBjYWxsZXIuCisg ICAgICAgIFRoaXMgcGF0Y2ggaXMgYSBmb2xsb3ctdXAgcGF0Y2ggYWZ0ZXIgcjI0MzA4MSwgYWRk aW5nIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrcyBtb3JlIHRvIGZpeCBkZWJ1ZyB0ZXN0IGZhaWx1 cmVzLgorCisgICAgICAgICogcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAg IChKU0M6OnNldFJlZ0V4cENvbnN0cnVjdG9ySW5wdXQpOgorICAgICAgICAoSlNDOjpzZXRSZWdF eHBDb25zdHJ1Y3Rvck11bHRpbGluZSk6CisgICAgICAgICogcnVudGltZS9SZWdFeHBHbG9iYWxE YXRhLmNwcDoKKyAgICAgICAgKEpTQzo6UmVnRXhwR2xvYmFsRGF0YTo6Z2V0QmFja3JlZik6Cisg ICAgICAgIChKU0M6OlJlZ0V4cEdsb2JhbERhdGE6OmdldExhc3RQYXJlbik6CisKIDIwMTktMDMt MTggIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgdGhlIGlubGluZSBjYXBhY2l0eSBvZiBPcGVyYW5kcwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3IuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3IuY3BwCmluZGV4IDZkYTQ5NmZlMzc2 ZDExNjIzNDQ4ZmFkZjRlNzgwM2U2MDVmYTY0NzkuLjY4MGI2ZDE1NzFhODllOTJjMGYyZmVhMTI0 MmExZDI2Nzc2NGE5ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1JlZ0V4cENvbnN0cnVjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9SZWdFeHBDb25zdHJ1Y3Rvci5jcHAKQEAgLTE1MCw5ICsxNTAsMTMgQEAgRW5jb2RlZEpTVmFs dWUgcmVnRXhwQ29uc3RydWN0b3JSaWdodENvbnRleHQoRXhlY1N0YXRlKiBleGVjLCBFbmNvZGVk SlNWYWx1ZSB0aGkKIGJvb2wgc2V0UmVnRXhwQ29uc3RydWN0b3JJbnB1dChFeGVjU3RhdGUqIGV4 ZWMsIEVuY29kZWRKU1ZhbHVlIHRoaXNWYWx1ZSwgRW5jb2RlZEpTVmFsdWUgdmFsdWUpCiB7CiAg ICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19T Q09QRSh2bSk7CiAgICAgaWYgKGF1dG8gY29uc3RydWN0b3IgPSBqc0R5bmFtaWNDYXN0PFJlZ0V4 cENvbnN0cnVjdG9yKj4odm0sIEpTVmFsdWU6OmRlY29kZSh0aGlzVmFsdWUpKSkgeworICAgICAg ICBhdXRvKiBzdHJpbmcgPSBKU1ZhbHVlOjpkZWNvZGUodmFsdWUpLnRvU3RyaW5nKGV4ZWMpOwor ICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0pOworICAgICAgICBzY29wZS5y ZWxlYXNlKCk7CiAgICAgICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBjb25zdHJ1 Y3Rvci0+Z2xvYmFsT2JqZWN0KHZtKTsKLSAgICAgICAgZ2xvYmFsT2JqZWN0LT5yZWdFeHBHbG9i YWxEYXRhKCkuc2V0SW5wdXQoZXhlYywgZ2xvYmFsT2JqZWN0LCBKU1ZhbHVlOjpkZWNvZGUodmFs dWUpLnRvU3RyaW5nKGV4ZWMpKTsKKyAgICAgICAgZ2xvYmFsT2JqZWN0LT5yZWdFeHBHbG9iYWxE YXRhKCkuc2V0SW5wdXQoZXhlYywgZ2xvYmFsT2JqZWN0LCBzdHJpbmcpOwogICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTYxLDkgKzE2NSwxMyBAQCBi b29sIHNldFJlZ0V4cENvbnN0cnVjdG9ySW5wdXQoRXhlY1N0YXRlKiBleGVjLCBFbmNvZGVkSlNW YWx1ZSB0aGlzVmFsdWUsIEVuY29kZQogYm9vbCBzZXRSZWdFeHBDb25zdHJ1Y3Rvck11bHRpbGlu ZShFeGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIHRoaXNWYWx1ZSwgRW5jb2RlZEpTVmFs dWUgdmFsdWUpCiB7CiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0g REVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAgICAgaWYgKGF1dG8gY29uc3RydWN0b3IgPSBqc0R5 bmFtaWNDYXN0PFJlZ0V4cENvbnN0cnVjdG9yKj4odm0sIEpTVmFsdWU6OmRlY29kZSh0aGlzVmFs dWUpKSkgeworICAgICAgICBib29sIG11bHRpbGluZSA9IEpTVmFsdWU6OmRlY29kZSh2YWx1ZSku dG9Cb29sZWFuKGV4ZWMpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0p OworICAgICAgICBzY29wZS5yZWxlYXNlKCk7CiAgICAgICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9i YWxPYmplY3QgPSBjb25zdHJ1Y3Rvci0+Z2xvYmFsT2JqZWN0KHZtKTsKLSAgICAgICAgZ2xvYmFs T2JqZWN0LT5yZWdFeHBHbG9iYWxEYXRhKCkuc2V0TXVsdGlsaW5lKEpTVmFsdWU6OmRlY29kZSh2 YWx1ZSkudG9Cb29sZWFuKGV4ZWMpKTsKKyAgICAgICAgZ2xvYmFsT2JqZWN0LT5yZWdFeHBHbG9i YWxEYXRhKCkuc2V0TXVsdGlsaW5lKG11bHRpbGluZSk7CiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9SZWdFeHBHbG9iYWxEYXRhLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1JlZ0V4cEdsb2JhbERhdGEuY3BwCmluZGV4IDljYmY0YTdkZGU2YTQzMDkwOTJjNWVk NDk1ZjZmNGIyM2FiM2Q0YzMuLmQ0YzJkYzUwOTEyZDQ3YzliYzFmMTcxMzFhM2JlOWY5ZjM1NzY2 NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cEdsb2Jh bERhdGEuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cEdsb2Jh bERhdGEuY3BwCkBAIC00Myw2ICs0Myw3IEBAIEpTVmFsdWUgUmVnRXhwR2xvYmFsRGF0YTo6Z2V0 QmFja3JlZihFeGVjU3RhdGUqIGV4ZWMsIEpTR2xvYmFsT2JqZWN0KiBvd25lciwgdW5zCiAKICAg ICBpZiAoaSA8IGFycmF5LT5sZW5ndGgoKSkgewogICAgICAgICBKU1ZhbHVlIHJlc3VsdCA9IEpT VmFsdWUoYXJyYXkpLmdldChleGVjLCBpKTsKKyAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihz Y29wZSwgeyB9KTsKICAgICAgICAgQVNTRVJUKHJlc3VsdC5pc1N0cmluZygpIHx8IHJlc3VsdC5p c1VuZGVmaW5lZCgpKTsKICAgICAgICAgaWYgKCFyZXN1bHQuaXNVbmRlZmluZWQoKSkKICAgICAg ICAgICAgIHJldHVybiByZXN1bHQ7CkBAIC02MSw2ICs2Miw3IEBAIEpTVmFsdWUgUmVnRXhwR2xv YmFsRGF0YTo6Z2V0TGFzdFBhcmVuKEV4ZWNTdGF0ZSogZXhlYywgSlNHbG9iYWxPYmplY3QqIG93 bmVyKQogICAgIHVuc2lnbmVkIGxlbmd0aCA9IGFycmF5LT5sZW5ndGgoKTsKICAgICBpZiAobGVu Z3RoID4gMSkgewogICAgICAgICBKU1ZhbHVlIHJlc3VsdCA9IEpTVmFsdWUoYXJyYXkpLmdldChl eGVjLCBsZW5ndGggLSAxKTsKKyAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgeyB9 KTsKICAgICAgICAgQVNTRVJUKHJlc3VsdC5pc1N0cmluZygpIHx8IHJlc3VsdC5pc1VuZGVmaW5l ZCgpKTsKICAgICAgICAgaWYgKCFyZXN1bHQuaXNVbmRlZmluZWQoKSkKICAgICAgICAgICAgIHJl dHVybiByZXN1bHQ7Cg==