195922 2019-03-18 16:56:58 -0700 media/track/track-in-band-style.html is flaky 2019-03-19 15:10:33 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167516 InRadar P2 Normal --- 195758 1 cdumez cdumez ap commit-queue eric.carlson jer.noble tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1518018 0 cdumez 2019-03-18 16:56:58 -0700 media/track/track-in-band-style.html is flaky: Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/track/track-in-band-style-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/media/track/track-in-band-style-actual.txt @@ -14,6 +14,6 @@ ** Test current cue colors EXPECTED (getComputedStyle(cueDisplayElement).color == 'rgb(255, 255, 255)') OK -EXPECTED (getComputedStyle(cueNode).backgroundColor == 'rgb(0, 0, 0)') OK +EXPECTED (getComputedStyle(cueNode).backgroundColor == 'rgb(0, 0, 0)'), OBSERVED 'rgba(0, 0, 0, 0)' FAIL END OF TEST It started happening after https://trac.webkit.org/changeset/243094 although I bet this change merely impacted the timing. 1518019 1 cdumez 2019-03-18 16:57:13 -0700 I can reproduce like so: run-webkit-tests -gf --repeat-each=100 media/track/track-in-band-style.html 1518103 2 cdumez 2019-03-18 20:20:06 -0700 If I add logging to InbandTextTrackPrivateAVF::processCueAttributes() and run the test, I see that cueData.setForegroundColor(color) gets called with 'rgb(255, 255, 255)'. However, I never see any call to cueData.setBackgroundColor(color), no matter if the test passes or fail. Therefore, I am unsure where 'rgb(0, 0, 0)' and 'rgba(0, 0, 0, 0)' come from. Maybe some default values? 1518109 3 cdumez 2019-03-18 20:34:36 -0700 It looks like Color().cssText() returns "rgba(0, 0, 0, 0)" so it would make sense for the background color to be rgba(0, 0, 0, 0) if it does not get set. 1518282 4 cdumez 2019-03-19 08:41:38 -0700 (In reply to Chris Dumez from comment #3) > It looks like Color().cssText() returns "rgba(0, 0, 0, 0)" so it would make > sense for the background color to be rgba(0, 0, 0, 0) if it does not get set. Although I do not see the AV code setting the cue's backgroundColor, it does set the highlightColor. The highlightColor ends up being set as css background-color for the element. 1518322 5 365177 cdumez 2019-03-19 10:05:11 -0700 Created attachment 365177 Patch 1518465 6 365177 eric.carlson 2019-03-19 12:45:06 -0700 Comment on attachment 365177 Patch thanks cdumez! 1518487 7 365177 cdumez 2019-03-19 13:05:40 -0700 Comment on attachment 365177 Patch Clearing flags on attachment: 365177 Committed r243164: <https://trac.webkit.org/changeset/243164> 1518488 8 cdumez 2019-03-19 13:05:41 -0700 All reviewed patches have been landed. Closing bug. 1518492 9 webkit-bug-importer 2019-03-19 13:11:16 -0700 <rdar://problem/49031582> 1518551 10 ap 2019-03-19 15:08:12 -0700 We have a flaky timeout expectation for this test. I don't imagine this is likely to fix it, is it? LayoutTests/platform/mac/TestExpectations:1370:webkit.org/b/171465 media/track/track-in-band-style.html [ Pass Timeout ] 1518553 11 cdumez 2019-03-19 15:10:33 -0700 (In reply to Alexey Proskuryakov from comment #10) > We have a flaky timeout expectation for this test. I don't imagine this is > likely to fix it, is it? > > LayoutTests/platform/mac/TestExpectations:1370:webkit.org/b/171465 > media/track/track-in-band-style.html [ Pass Timeout ] No sorry, I don't think my change would help address a timeout. 365177 2019-03-19 10:05:11 -0700 2019-03-19 13:05:40 -0700 Patch bug-195922-20190319100510.patch text/plain 5077 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRiM2M1MjQ5NzM3MjFk OWUyOTQxZTAzMzg1NTA5ZDlmOTcxODU2ZC4uMjdjYzMzN2JjZmU0ZDA3NDI0Njc3OGJlNTYwMDlm MzE2MTExMDcwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgbWVkaWEvdHJhY2svdHJhY2st aW4tYmFuZC1zdHlsZS5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU5MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJh bmRUZXh0VHJhY2tQcml2YXRlQVZGLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluYmFuZFRleHRU cmFja1ByaXZhdGVBVkY6OnByb2Nlc3NDdWVBdHRyaWJ1dGVzKToKKyAgICAgICAgU21hbGwgb3B0 aW1pemF0aW9uOiBzb21lIG9mIHRoZSBpZiBjaGVja3Mgd2VyZSBtaXNzaW5nIHRoZWlyICJjb250 aW51ZTsiCisgICAgICAgIHN0YXRlbWVudC4gVGhpcyB3b3VsZCBjYXVzZSB1cyB0byBrZWVwIGNo ZWNraW5nIGZvbGxvd2luZyBrZXlzIGV2ZW4gdGhvdWdoCisgICAgICAgIHdlIGFscmVhZHkgZ290 IGEgbWF0Y2guCisKIDIwMTktMDMtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCB3ZWJraXRFZGl0YWJsZUNvbnRlbnRDaGFuZ2VkIGV2 ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRi5jcHAK aW5kZXggNTAyMjVjMzQ4N2Q3MmVkMTM3ZmI1YWJjMzM1NWFkMDk5NzQ0MjIxZS4uZTZkZmVjZTdh NzVhNjI5N2ZlY2E5ZGViNzJjMTY2OTNmZjJkOGM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFuZFRleHRUcmFja1ByaXZhdGVB VkYuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9JbmJhbmRUZXh0VHJhY2tQcml2YXRlQVZGLmNwcApAQCAtMjcwLDYgKzI3MCw3IEBAIHZvaWQg SW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRjo6cHJvY2Vzc0N1ZUF0dHJpYnV0ZXMoQ0ZBdHRyaWJ1 dGVkU3RyaW5nUmVmIGF0dHJpCiAgICAgICAgICAgICAgICAgaWYgKCFtYWtlUkdCQTMyRnJvbUFS R0JDRkFycmF5KGFycmF5VmFsdWUsIGNvbG9yKSkKICAgICAgICAgICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgICAgICAgICAgY3VlRGF0YS5zZXRGb3JlZ3JvdW5kQ29sb3IoY29sb3IpOwor ICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgCiAg ICAgICAgICAgICBpZiAoQ0ZTdHJpbmdDb21wYXJlKGtleSwga0NNVGV4dE1hcmt1cEF0dHJpYnV0 ZV9CYWNrZ3JvdW5kQ29sb3JBUkdCLCAwKSA9PSBrQ0ZDb21wYXJlRXF1YWxUbykgewpAQCAtMjgx LDYgKzI4Miw3IEBAIHZvaWQgSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRjo6cHJvY2Vzc0N1ZUF0 dHJpYnV0ZXMoQ0ZBdHRyaWJ1dGVkU3RyaW5nUmVmIGF0dHJpCiAgICAgICAgICAgICAgICAgaWYg KCFtYWtlUkdCQTMyRnJvbUFSR0JDRkFycmF5KGFycmF5VmFsdWUsIGNvbG9yKSkKICAgICAgICAg ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgY3VlRGF0YS5zZXRCYWNrZ3Jv dW5kQ29sb3IoY29sb3IpOworICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAg fQogCiAgICAgICAgICAgICBpZiAoQ0ZTdHJpbmdDb21wYXJlKGtleSwga0NNVGV4dE1hcmt1cEF0 dHJpYnV0ZV9DaGFyYWN0ZXJCYWNrZ3JvdW5kQ29sb3JBUkdCLCAwKSA9PSBrQ0ZDb21wYXJlRXF1 YWxUbykgewpAQCAtMjkyLDYgKzI5NCw3IEBAIHZvaWQgSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFW Rjo6cHJvY2Vzc0N1ZUF0dHJpYnV0ZXMoQ0ZBdHRyaWJ1dGVkU3RyaW5nUmVmIGF0dHJpCiAgICAg ICAgICAgICAgICAgaWYgKCFtYWtlUkdCQTMyRnJvbUFSR0JDRkFycmF5KGFycmF5VmFsdWUsIGNv bG9yKSkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgY3Vl RGF0YS5zZXRIaWdobGlnaHRDb2xvcihjb2xvcik7CisgICAgICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDczNjU0YzIwYWE1NzkyNDQ0OWYx NWMyNWI0MGZmNDhmMTFmNWExOTUuLjRkMGJlMmQ2YmQyZWUzMzI3ZTUxNjZmNDk0OGNlYmYxYWI2 NmYwNWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOS0wMy0xOSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIG1lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQtc3R5 bGUuaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk1OTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLXN0eWxlLWV4cGVjdGVkLnR4dDoK KyAgICAgICAgKiBtZWRpYS90cmFjay90cmFjay1pbi1iYW5kLXN0eWxlLmh0bWw6CisgICAgICAg IC0gQ2hlY2sgZWxlbWVudC5zdHlsZSBpbnN0ZWFkIG9mIGdldENvbXB1dGVkU3R5bGUoZWxlbWVu dCkgdG8gZ2V0IHRoZQorICAgICAgICAgIENTUyBjb2xvcnMgYXMgdGhpcyBzZWVtcyBtb3JlIHJl bGlhYmxlLgorICAgICAgICAtIEZvciB0aGUgZm9yZWdyb3VuZCB0ZXh0IGNvbG9yLCBjaGVjayBj dWVOb2RlLnN0eWxlLmNvbG9yIGluc3RlYWQgb2YKKyAgICAgICAgICBjdWVEaXNwbGF5RWxlbWVu dCBnaXZlbiB0aGF0IHRoZSBpbXBsZW1lbnRhdGlvbiBzZXRzIHRoZSBDU1MgYXR0cmlidXRlCisg ICAgICAgICAgb24gdGhlIGN1ZU5vZGUsIG5vdCB0aGUgY3VlRGlzcGxheUVsZW1lbnQuCisKIDIw MTktMDMtMTggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV0hMU0xdIEhvb2sgdXAgdGhlIGNvbXBpbGVyIHRvIG91ciBXZWJHUFUgaW1wbGVtZW50 YXRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWluLWJhbmQt c3R5bGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFu ZC1zdHlsZS1leHBlY3RlZC50eHQKaW5kZXggZjE1NzEyNTY3NTBhYmVmMzQzMmQ3NTNjMjRmOGE3 NmM2ZWIxY2I1My4uMzI3YTQ4NGZjYjcyMzAxNzQ4ZjhmYzAyZTY1OTAyYWYyY2IyZTkyYiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1zdHlsZS1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1zdHls ZS1leHBlY3RlZC50eHQKQEAgLTEzLDcgKzEzLDcgQEAgUlVOKHZpZGVvLnBsYXkoKSkKIEVWRU5U KGN1ZWNoYW5nZSkKIAogKiogVGVzdCBjdXJyZW50IGN1ZSBjb2xvcnMKLUVYUEVDVEVEIChnZXRD b21wdXRlZFN0eWxlKGN1ZURpc3BsYXlFbGVtZW50KS5jb2xvciA9PSAncmdiKDI1NSwgMjU1LCAy NTUpJykgT0sKLUVYUEVDVEVEIChnZXRDb21wdXRlZFN0eWxlKGN1ZU5vZGUpLmJhY2tncm91bmRD b2xvciA9PSAncmdiKDAsIDAsIDApJykgT0sKK0VYUEVDVEVEIChjdWVOb2RlLnN0eWxlLmNvbG9y ID09ICdyZ2IoMjU1LCAyNTUsIDI1NSknKSBPSworRVhQRUNURUQgKGN1ZU5vZGUuc3R5bGUuYmFj a2dyb3VuZENvbG9yID09ICdyZ2IoMCwgMCwgMCknKSBPSwogRU5EIE9GIFRFU1QKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1zdHlsZS5odG1sIGIv TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC1zdHlsZS5odG1sCmluZGV4IDY0 YzI3ZTU4NTc1NmQ2Y2E2ODQ1MDZkYWVmN2YzNWYxYzJmZmNiOTEuLjE1ZmM3NzA1MDBkNWIzMmZm MmRiODNjYjQ3MWMxNDMwMDRmMjg0MGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3Ry YWNrL3RyYWNrLWluLWJhbmQtc3R5bGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFj ay90cmFjay1pbi1iYW5kLXN0eWxlLmh0bWwKQEAgLTI1LDggKzI1LDggQEAKICAgICAgICAgICAg ICAgICAgICAgfQogICAgIAogICAgICAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIjxicj48 aT4qKiBUZXN0IGN1cnJlbnQgY3VlIGNvbG9yczwiICsgIi9pPiIpOwotICAgICAgICAgICAgICAg ICAgICB0ZXN0RXhwZWN0ZWQoImdldENvbXB1dGVkU3R5bGUoY3VlRGlzcGxheUVsZW1lbnQpLmNv bG9yIiwgInJnYigyNTUsIDI1NSwgMjU1KSIpOwotICAgICAgICAgICAgICAgICAgICB0ZXN0RXhw ZWN0ZWQoImdldENvbXB1dGVkU3R5bGUoY3VlTm9kZSkuYmFja2dyb3VuZENvbG9yIiwgInJnYigw LCAwLCAwKSIpOworICAgICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImN1ZU5vZGUuc3R5 bGUuY29sb3IiLCAicmdiKDI1NSwgMjU1LCAyNTUpIik7CisgICAgICAgICAgICAgICAgICAgIHRl c3RFeHBlY3RlZCgiY3VlTm9kZS5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IiLCAicmdiKDAsIDAsIDAp Iik7CiAgICAgCiAgICAgICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKICAgICAgICAgICAgICAg ICB9Cg==