19592 2008-06-16 12:12:03 -0700 Mismatched GraphicsContext::save()/restore() pairs in shadow painting code 2008-06-16 13:11:30 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jonathon mitz oldest_to_newest 83515 0 jonathon 2008-06-16 12:12:03 -0700 If you look at the following code, you'll notice two calls to context->save() with only a single restore() at teh end of the function. The context is not modified at all between the two calls to save(), so I think the first one is useless and will lead to mismatched save/restore pairs. http://trac.webkit.org/browser/trunk/WebCore/rendering/InlineFlowBox.cpp#L934 83523 1 21743 jonathon 2008-06-16 13:01:34 -0700 Created attachment 21743 remove the extra save() I'm not sure if there's a test we can add for this. I haven't been able to actually come up with a rendering failure due to this, it just looks like it may be a bug in waiting. 83525 2 21743 mitz 2008-06-16 13:07:49 -0700 Comment on attachment 21743 remove the extra save() r=me I am going to land it, tweaking the change log format and removing the reference to GraphicsContextCairo.cpp. 83527 3 jonathon 2008-06-16 13:08:45 -0700 oops, how did that get in there? :P thanks. 83528 4 mitz 2008-06-16 13:11:30 -0700 Landed in <http://trac.webkit.org/changeset/34604>. 21743 2008-06-16 13:01:34 -0700 2008-06-16 13:07:49 -0700 remove the extra save() 0001-remove-an-extra-context-save-from-the-shadow-pain.patch text/plain 1832 jonathon RnJvbSBmMjk5ODExOTQzOWZhY2EwMjQzMjdhMDJkOGQzYzFiMjNmMjYyZTk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhvbiBKb25nc21hIDxqb25hdGhvbi5qb25nc21hQGNv bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAxNiBKdW4gMjAwOCAxNDo1NDozNSAtMDUwMApTdWJq ZWN0OiBbUEFUQ0hdIHJlbW92ZSBhbiBleHRyYSBjb250ZXh0LT5zYXZlKCkgZnJvbSB0aGUgc2hh ZG93IHBhaW50aW5nIGNvZGUuICBUaGlzIGNvdWxkIGxlYWQKIHRvIHVuYmFsYW5jZWQgc2F2ZS9y ZXN0b3JlIHBhaXJzLiAgU2VlIGJ1ZyAjMTk1OTIKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViQ29yZS9yZW5kZXJpbmcvSW5s aW5lRmxvd0JveC5jcHAgfCAgICAxIC0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDRhYTZhZDYuLjliMmQyZmQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgt MDYtMTYgIEpvbmF0aG9uIEpvbmdzbWEgIDxqb25hdGhvbi5qb25nc21hQGNvbGxhYm9yYS5jby51 az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXQVJO SU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKiByZW5k ZXJpbmcvSW5saW5lRmxvd0JveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVGbG93Qm94 OjpwYWludFRleHREZWNvcmF0aW9ucyk6IHJlbW92ZSBhbiBleHRyYSBjb250ZXh0LT5zYXZlKCkK KyAgICAgICAgZnJvbSB0aGUgc2hhZG93IHBhaW50aW5nIGNvZGUuICBUaGlzIGNvdWxkIGxlYWQg dG8gdW5iYWxhbmNlZCBzYXZlL3Jlc3RvcmUgcGFpcnMuCisgICAgICAgIFNlZSBidWcgIzE5NTky CisKIDIwMDgtMDYtMTYgIEFkcmlhYW4gZGUgR3Jvb3QgIDxncm9vdEBrZGUub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvSW5s aW5lRmxvd0JveC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAppbmRl eCBjMzk2MWE2Li41ZjM3YWQ2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVG bG93Qm94LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcApAQCAt OTMyLDcgKzkzMiw2IEBAIHZvaWQgSW5saW5lRmxvd0JveDo6cGFpbnRUZXh0RGVjb3JhdGlvbnMo UmVuZGVyT2JqZWN0OjpQYWludEluZm8mIHBhaW50SW5mbywgaW50CiAgICAgICAgIGludCBleHRy YU9mZnNldCA9IDA7CiAgICAgICAgIFNoYWRvd0RhdGEqIHNoYWRvdyA9IHN0eWxlVG9Vc2UtPnRl eHRTaGFkb3coKTsKICAgICAgICAgaWYgKCFsaW5lc0FyZU9wYXF1ZSAmJiBzaGFkb3cgJiYgc2hh ZG93LT5uZXh0KSB7Ci0gICAgICAgICAgICBjb250ZXh0LT5zYXZlKCk7CiAgICAgICAgICAgICBJ bnRSZWN0IGNsaXBSZWN0KHR4LCB0eSwgdywgbV9iYXNlbGluZSArIDIpOwogICAgICAgICAgICAg Zm9yIChTaGFkb3dEYXRhKiBzID0gc2hhZG93OyBzOyBzID0gcy0+bmV4dCkgewogICAgICAgICAg ICAgICAgIEludFJlY3Qgc2hhZG93UmVjdCh0eCwgdHksIHcsIG1fYmFzZWxpbmUgKyAyKTsKLS0g CjEuNS41Cgo=