195893 2019-03-18 09:42:49 -0700 Missing a ThrowScope release in JSObject::toString(). 2019-03-18 10:36:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1517728 0 mark.lam 2019-03-18 09:42:49 -0700 <rdar://problem/48970986> 1517729 1 365022 mark.lam 2019-03-18 09:47:33 -0700 Created attachment 365022 proposed patch. 1517741 2 365022 rmorisset 2019-03-18 10:08:36 -0700 Comment on attachment 365022 proposed patch. LGTM 1517742 3 365022 msaboff 2019-03-18 10:09:38 -0700 Comment on attachment 365022 proposed patch. r=me 1517743 4 365022 mark.lam 2019-03-18 10:10:22 -0700 Comment on attachment 365022 proposed patch. Thanks for the review. Landing now. 1517765 5 365022 commit-queue 2019-03-18 10:36:54 -0700 Comment on attachment 365022 proposed patch. Clearing flags on attachment: 365022 Committed r243079: <https://trac.webkit.org/changeset/243079> 1517766 6 commit-queue 2019-03-18 10:36:56 -0700 All reviewed patches have been landed. Closing bug. 365022 2019-03-18 09:47:33 -0700 2019-03-18 10:36:54 -0700 proposed patch. bug-195893.patch text/plain 2380 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMwNzEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBNaXNzaW5nIGEgVGhyb3dTY29wZSByZWxlYXNlIGluIEpTT2JqZWN0Ojp0 b1N0cmluZygpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1ODkzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODk3MDk4Nj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy90by1zdHJpbmct ZXhjZXB0aW9uLWNoZWNrLXJlbGVhc2UuanM6IEFkZGVkLgorCiAyMDE5LTAzLTE4ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0 aW9uYXJ5KCkgc2hvdWxkIGNsZWFyIHVudXNlZCBwcm9wZXJ0eSBzbG90cy4KSW5kZXg6IEpTVGVz dHMvc3RyZXNzL3RvLXN0cmluZy1leGNlcHRpb24tY2hlY2stcmVsZWFzZS5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL3N0cmVzcy90by1zdHJpbmctZXhjZXB0aW9uLWNoZWNrLXJlbGVhc2UuanMJ KG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvdG8tc3RyaW5nLWV4Y2VwdGlvbi1jaGVj ay1yZWxlYXNlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNSBAQAorLy8gVGhpcyB0ZXN0 IHNob3VsZCBub3QgZmFpbCBleGNlcHRpb24gY2hlY2sgdmFsaWRhdGlvbi4KKworbGV0IHMgPSBu ZXcgU3RyaW5nKCk7CitzLnRvU3RyaW5nID0gKCk9Pnt9CitKU09OLnN0cmluZ2lmeShzKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQzMDY5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisy MDE5LTAzLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBNaXNz aW5nIGEgVGhyb3dTY29wZSByZWxlYXNlIGluIEpTT2JqZWN0Ojp0b1N0cmluZygpLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODkzCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80ODk3MDk4Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQbGFjYXRlIHRoZSB2YWxpZGF0b3Igd2l0aCBhIFJFTEVBU0Vf QU5EX1JFVFVSTigpLgorCisgICAgICAgICogcnVudGltZS9KU09iamVjdC5jcHA6CisgICAgICAg IChKU0M6OkpTT2JqZWN0Ojp0b1N0cmluZyBjb25zdCk6CisKIDIwMTktMDMtMTggIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFN0cnVjdHVyZTo6ZmxhdHRlbkRpY3Rp b25hcnkoKSBzaG91bGQgY2xlYXIgdW51c2VkIHByb3BlcnR5IHNsb3RzLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkocmV2aXNpb24gMjQzMDY4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yNDM1LDcgKzI0MzUsNyBAQCBKU1N0cmluZyogSlNPYmplY3Q6OnRvU3RyaW5nKEV4 ZWNTdGF0ZSogCiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAg IEpTVmFsdWUgcHJpbWl0aXZlID0gdG9QcmltaXRpdmUoZXhlYywgUHJlZmVyU3RyaW5nKTsKICAg ICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBqc0VtcHR5U3RyaW5nKGV4ZWMpKTsKLSAgICBy ZXR1cm4gcHJpbWl0aXZlLnRvU3RyaW5nKGV4ZWMpOworICAgIFJFTEVBU0VfQU5EX1JFVFVSTihz Y29wZSwgcHJpbWl0aXZlLnRvU3RyaW5nKGV4ZWMpKTsKIH0KIAogSlNWYWx1ZSBKU09iamVjdDo6 dG9UaGlzKEpTQ2VsbCogY2VsbCwgRXhlY1N0YXRlKiwgRUNNQU1vZGUpCg==