195892 2019-03-18 09:27:51 -0700 REGRESSION: (r243032) inspector/model/remote-object.html is failing. 2019-03-23 21:16:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196008 InRadar P2 Normal --- 1 tsavell mark.lam fpizlo jlewis3 keith_miller lforschler msaboff rmorisset ryanhaddad saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1517719 0 tsavell 2019-03-18 09:27:51 -0700 The following layout test is failing on Mac inspector/model/remote-object.html Probable cause: This test began failing near constantly after changes in https://trac.webkit.org/changeset/243032/webkit. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fmodel%2Fremote-object.html Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r243062%20(11965)/inspector/model/remote-object-diff.txt I was able to reproduce this locally with command: run-webkit-tests inspector/model/remote-object.html --iterations 100 -f it fails often on 242032 but passes on 242031. 1517721 1 tsavell 2019-03-18 09:30:58 -0700 marked failing in https://trac.webkit.org/changeset/243071/webkit until mark can fix this. 1517727 2 webkit-bug-importer 2019-03-18 09:40:54 -0700 <rdar://problem/48981239> 1519696 3 mark.lam 2019-03-21 10:10:43 -0700 Also from https://bugs.webkit.org/show_bug.cgi?id=195827#c8: It appears that changes in https://trac.webkit.org/changeset/243032 Are causing a JSC failure on the Debug queue microbenchmarks/data-view-accesses-2.js.ftl-no-cjit-small-pool https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/2348/steps/jscore-test/logs/stdio Regression range is 243030 to 243033 1520671 4 mark.lam 2019-03-23 21:11:37 -0700 From the rollout ChangeLog: The fix is incorrect: it relies on being able to determine liveness of an object in an ObjectPropertyCondition based on the state of the object's MarkedBit. However, there's no guarantee that GC has run and that the MarkedBit is already set even if the object is live. As a result, we may not re-install adaptive watchpoints based on presumed dead objects which are actually live. I'm rolling this out, and will implement a more comprehensive fix to handle watchpoint liveness later. 1520673 5 mark.lam 2019-03-23 21:12:08 -0700 *** Bug 196008 has been marked as a duplicate of this bug. *** 1520674 6 mark.lam 2019-03-23 21:16:47 -0700 The rollout was landed in r243420: <http://trac.webkit.org/r243420>.