195888 2019-03-18 08:45:11 -0700 REGRESSION(r243058): [GStreamer] 3 tests now timing out 2019-03-19 07:54:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris webkit-bug-importer oldest_to_newest 1517698 0 pnormand 2019-03-18 08:45:11 -0700 . 1517700 1 pnormand 2019-03-18 08:46:43 -0700 Regressions: Unexpected timeouts (3) http/tests/media/video-play-stall-seek.html [ Timeout ] http/wpt/fetch/dnt-header-after-redirection.html [ Timeout ] imported/w3c/web-platform-tests/resource-timing/resource_initiator_types.html [ Timeout ] 1517703 2 365016 pnormand 2019-03-18 08:52:44 -0700 Created attachment 365016 Patch 1518242 3 365016 calvaris 2019-03-19 07:17:08 -0700 Comment on attachment 365016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291 > + mutable uint64_t m_networkReadPosition { 0 }; Do you need this variable to be mutable as well? 1518257 4 365016 pnormand 2019-03-19 07:49:52 -0700 Comment on attachment 365016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291 >> + mutable uint64_t m_networkReadPosition { 0 }; > > Do you need this variable to be mutable as well? It is not. Good catch! 1518259 5 pnormand 2019-03-19 07:53:26 -0700 Committed r243140: <https://trac.webkit.org/changeset/243140> 1518260 6 webkit-bug-importer 2019-03-19 07:54:16 -0700 <rdar://problem/49018785> 365016 2019-03-18 08:52:44 -0700 2019-03-19 07:17:08 -0700 Patch bug-195888-20190318155242.patch text/plain 5722 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTcwNzBkNjk5OWI1ZGQ5 Y2U4YzhlYjUyY2RlNWM0NzgxMjcxNjZjNS4uYzE1N2FmOTRlNmY0MzdhNjlkZGMzODUyNmNjOGNl NmVjYzI3YjQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE5LTAzLTE4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O KHIyNDMwNTgpOiBbR1N0cmVhbWVyXSAzIHRlc3RzIG5vdyB0aW1pbmcgb3V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU4ODgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGJyZWFraW5nIGNoYW5nZSB3 YXMgaW50cm9kdWNlZCBpbiByMjQzMDU4LiBOb3cgb24tZGlzay1idWZmZXJpbmcKKyAgICAgICAg aXMgZGlzYWJsZWQgd2hlbiB0aGUgcmVwb3J0ZWQgQ29udGVudC1MZW5ndGggaXMgMCBvciBub3Qg cHJlc2VudAorICAgICAgICBhdCBhbGwuIFRoaXMgYnJva2UgdGhlIHByb2dyZXNzIGV2ZW50IGxv Z2ljIGluIGRpZExvYWRQcm9ncmVzcygpCisgICAgICAgIGJlY2F1c2UgbGVhZGluZyB0byBwcm9n cmVzcyBldmVudHMgbm90IGJlaW5nIGZpcmVkIGFzIGV4cGVjdGVkLgorCisgICAgICAgIFRoZSBw cm9wb3NlZCBzb2x1dGlvbiBpcyB0byBtYWtlIHdlYmtpdHdlYnNyYyBub3RpZnkgdGhlIHBsYXll cgorICAgICAgICBldmVyeSB0aW1lIHRoZSBuZXR3b3JrIHByb2Nlc3MgcmVjZWl2ZXMgZGF0YSBm cm9tIHRoZSBuZXR3b3JrLiBTbworICAgICAgICB0aGUgcGxheWVyIGNhbiBub3cgZWFzaWx5IGRl dGVybWluZSBpZiB0aGUgbG9hZCBwcm9ncmVzc2VkIGJ5CisgICAgICAgIGNoZWNraW5nIHRoZSBy ZXBvcnRlZCBzdGF0aXN0aWNzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZXhpc3RpbmcgbWVk aWEgdGVzdHMgY292ZXIgdGhpcyBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6CisgICAg ICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmRpZExvYWRpbmdQcm9n cmVzcyBjb25zdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoQ2FjaGVkUmVz b3VyY2VTdHJlYW1pbmdDbGllbnQ6OmRhdGFSZWNlaXZlZCk6CisKIDIwMTktMDMtMTggIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJd IFJld3JpdGUgSFRUUCBzb3VyY2UgZWxlbWVudCB1c2luZyBwdXNoc3JjIGJhc2UgY2xhc3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMWZl ZTk2MjNjMTliYmFhNzUzYjljYjE0Njk5OTliY2E4MTNiZDIyMy4uNjBlNGZmZmVkMmZlYjQ0OTdl NjNmZDExYTNjZTMxZmRkODdjOTc3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTEzNzQsNiArMTM3NCw5IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3NhZ2UpCiAg ICAgICAgICAgICAgICAgICAgIHNldERvd25sb2FkQnVmZmVyaW5nKCk7CiAgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgfQorICAgICAgICB9IGVsc2UgaWYgKGdzdF9zdHJ1Y3R1cmVfaGFz X25hbWUoc3RydWN0dXJlLCAid2Via2l0LW5ldHdvcmstc3RhdGlzdGljcyIpKSB7CisgICAgICAg ICAgICBpZiAoZ3N0X3N0cnVjdHVyZV9nZXRfdWludDY0KHN0cnVjdHVyZSwgInJlYWQtcG9zaXRp b24iLCAmbV9uZXR3b3JrUmVhZFBvc2l0aW9uKSkKKyAgICAgICAgICAgICAgICBHU1RfREVCVUdf T0JKRUNUKHBpcGVsaW5lKCksICJVcGRhdGVkIG5ldHdvcmsgcmVhZCBwb3NpdGlvbiAlIiBHX0dV SU5UNjRfRk9STUFULCBtX25ldHdvcmtSZWFkUG9zaXRpb24pOwogICAgICAgICB9IGVsc2UgaWYg KGdzdF9zdHJ1Y3R1cmVfaGFzX25hbWUoc3RydWN0dXJlLCAiYWRhcHRpdmUtc3RyZWFtaW5nLXN0 YXRpc3RpY3MiKSkgewogICAgICAgICAgICAgaWYgKFdFQktJVF9JU19XRUJfU1JDKG1fc291cmNl LmdldCgpKSkKICAgICAgICAgICAgICAgICBpZiAoY29uc3QgY2hhciogdXJpID0gZ3N0X3N0cnVj dHVyZV9nZXRfc3RyaW5nKHN0cnVjdHVyZSwgInVyaSIpKQpAQCAtMTcwMyw4ICsxNzA2LDEyIEBA IGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpkaWRMb2FkaW5nUHJvZ3Jlc3MoKSBj b25zdAogICAgIGlmIChtX2Vycm9yT2NjdXJlZCB8fCBtX2xvYWRpbmdTdGFsbGVkKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoaXNMaXZlU3RyZWFtKCkpCi0gICAgICAgIHJldHVy biB0cnVlOworICAgIGlmIChXRUJLSVRfSVNfV0VCX1NSQyhtX3NvdXJjZS5nZXQoKSkpIHsKKyAg ICAgICAgR1NUX0xPR19PQkpFQ1QocGlwZWxpbmUoKSwgIkxhc3QgbmV0d29yayByZWFkIHBvc2l0 aW9uOiAlIiBHX0dVSU5UNjRfRk9STUFUICIsIGN1cnJlbnQ6ICUiIEdfR1VJTlQ2NF9GT1JNQVQs IG1fcmVhZFBvc2l0aW9uQXRMYXN0RGlkTG9hZGluZ1Byb2dyZXNzLCBtX25ldHdvcmtSZWFkUG9z aXRpb24pOworICAgICAgICBib29sIGRpZExvYWRpbmdQcm9ncmVzcyA9IG1fcmVhZFBvc2l0aW9u QXRMYXN0RGlkTG9hZGluZ1Byb2dyZXNzICE9IG1fbmV0d29ya1JlYWRQb3NpdGlvbjsKKyAgICAg ICAgbV9yZWFkUG9zaXRpb25BdExhc3REaWRMb2FkaW5nUHJvZ3Jlc3MgPSBtX25ldHdvcmtSZWFk UG9zaXRpb247CisgICAgICAgIHJldHVybiBkaWRMb2FkaW5nUHJvZ3Jlc3M7CisgICAgfQogCiAg ICAgaWYgKFVOTElLRUxZKCFtX3BpcGVsaW5lIHx8ICFkdXJhdGlvbk1lZGlhVGltZSgpIHx8ICgh aXNNZWRpYVNvdXJjZSgpICYmICF0b3RhbEJ5dGVzKCkpKSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwpAQCAtMTcxMiw3ICsxNzE5LDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 OmRpZExvYWRpbmdQcm9ncmVzcygpIGNvbnN0CiAgICAgTWVkaWFUaW1lIGN1cnJlbnRNYXhUaW1l TG9hZGVkID0gbWF4VGltZUxvYWRlZCgpOwogICAgIGJvb2wgZGlkTG9hZGluZ1Byb2dyZXNzID0g Y3VycmVudE1heFRpbWVMb2FkZWQgIT0gbV9tYXhUaW1lTG9hZGVkQXRMYXN0RGlkTG9hZGluZ1By b2dyZXNzOwogICAgIG1fbWF4VGltZUxvYWRlZEF0TGFzdERpZExvYWRpbmdQcm9ncmVzcyA9IGN1 cnJlbnRNYXhUaW1lTG9hZGVkOwotICAgIEdTVF9MT0coImRpZExvYWRpbmdQcm9ncmVzczogJXMi LCB0b1N0cmluZyhkaWRMb2FkaW5nUHJvZ3Jlc3MpLnV0ZjgoKS5kYXRhKCkpOworICAgIEdTVF9M T0dfT0JKRUNUKHBpcGVsaW5lKCksICJkaWRMb2FkaW5nUHJvZ3Jlc3M6ICVzIiwgYm9vbEZvclBy aW50aW5nKGRpZExvYWRpbmdQcm9ncmVzcykpOwogICAgIHJldHVybiBkaWRMb2FkaW5nUHJvZ3Jl c3M7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaApp bmRleCA5ZTYwNmNjODc3NzExNDIxNTUwZDUzM2UzNTQ4ZDA1ODQ2OWQ4YjdlLi43YjRiYmJjNjdj MmMwN2I3YTljZGY0ODllMGI2NzJiMTgyMTMzYzQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0yODgsNiArMjg4LDkgQEAgcHJpdmF0ZToKICNl bmRpZgogICAgIHZpcnR1YWwgYm9vbCBpc01lZGlhU291cmNlKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KIAorICAgIG11dGFibGUgdWludDY0X3QgbV9uZXR3b3JrUmVhZFBvc2l0aW9uIHsgMCB9 OworICAgIG11dGFibGUgdWludDY0X3QgbV9yZWFkUG9zaXRpb25BdExhc3REaWRMb2FkaW5nUHJv Z3Jlc3MgeyAwIH07CisKICAgICBPcHRpb25hbDxib29sPiBtX2hhc1RhaW50ZWRPcmlnaW4geyBX VEY6Om51bGxvcHQgfTsKIH07CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3Ry ZWFtZXIuY3BwCmluZGV4IDU3NGEyYTViNTZiYjFjNWE4MTZmYzFiMThhYWU2ZWFkOGZmYTE1NWEu LjE0N2ViMGJmMDE4NDdmOWY1N2NkMDNjMjBjOTMwOWY0OTg1ZmNjNjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VH U3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05NzgsNiArOTc4LDggQEAgdm9p ZCBDYWNoZWRSZXNvdXJjZVN0cmVhbWluZ0NsaWVudDo6ZGF0YVJlY2VpdmVkKFBsYXRmb3JtTWVk aWFSZXNvdXJjZSYsIGNvbnN0IGMKICAgICBpZiAoTElLRUxZIChwcml2LT5yZXF1ZXN0ZWRQb3Np dGlvbiA9PSBwcml2LT5yZWFkUG9zaXRpb24pKQogICAgICAgICBwcml2LT5yZXF1ZXN0ZWRQb3Np dGlvbiA9IG5ld1Bvc2l0aW9uOwogICAgIHByaXYtPnJlYWRQb3NpdGlvbiA9IG5ld1Bvc2l0aW9u OworICAgIGdzdF9lbGVtZW50X3Bvc3RfbWVzc2FnZShHU1RfRUxFTUVOVF9DQVNUKHNyYyksIGdz dF9tZXNzYWdlX25ld19lbGVtZW50KEdTVF9PQkpFQ1RfQ0FTVChzcmMpLAorICAgICAgICBnc3Rf c3RydWN0dXJlX25ldygid2Via2l0LW5ldHdvcmstc3RhdGlzdGljcyIsICJyZWFkLXBvc2l0aW9u IiwgR19UWVBFX1VJTlQ2NCwgcHJpdi0+cmVhZFBvc2l0aW9uLCBudWxscHRyKSkpOwogCiAgICAg dWludDY0X3QgbmV3U2l6ZSA9IDA7CiAgICAgaWYgKHByaXYtPmhhdmVTaXplICYmIChuZXdQb3Np dGlvbiA+IHByaXYtPnNpemUpKSB7Cg==