<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>195885</bug_id>
          
          <creation_ts>2019-03-18 07:46:38 -0700</creation_ts>
          <short_desc>[WPE] Tarballs generated with “make dist” cannot build documentation</short_desc>
          <delta_ts>2019-03-18 08:35:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mitz</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1517679</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-03-18 07:46:38 -0700</bug_when>
    <thetext>Using the “dist” (or “distcheck”) targets results in a tarball
from which it is not possible to build the documentation using
gtk-doc. The error is:


  make: *** [Makefile:152: all] Error 2
  Traceback (most recent call last):
    File &quot;/home/aperez/wpe/WebKit/Tools/Scripts/make-dist&quot;, line 345, in &lt;module&gt;
      Distcheck(arguments.source_dir, arguments.build_dir).check(output_filename, arguments.port)
    File &quot;/home/aperez/wpe/WebKit/Tools/Scripts/make-dist&quot;, line 283, in check
      self.build(build_dir)
    File &quot;/home/aperez/wpe/WebKit/Tools/Scripts/make-dist&quot;, line 257, in build
      subprocess.check_call(command, cwd=build_dir)
    File &quot;/usr/lib64/python2.7/subprocess.py&quot;, line 190, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command &apos;[&apos;make&apos;, &apos;-j64&apos;]&apos; returned non-zero exit status 2
  FAILED: Source/CMakeFiles/distcheck

Inspecting the generated tarball, file “Tools/glib/common.py” is
missing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517680</commentid>
    <comment_count>1</comment_count>
      <attachid>365014</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2019-03-18 07:53:17 -0700</bug_when>
    <thetext>Created attachment 365014
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517695</commentid>
    <comment_count>2</comment_count>
      <attachid>365014</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-18 08:34:56 -0700</bug_when>
    <thetext>Comment on attachment 365014
Patch

Clearing flags on attachment: 365014

Committed r243066: &lt;https://trac.webkit.org/changeset/243066&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517696</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-18 08:34:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517697</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-03-18 08:35:44 -0700</bug_when>
    <thetext>&lt;rdar://problem/48979604&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>365014</attachid>
            <date>2019-03-18 07:53:17 -0700</date>
            <delta_ts>2019-03-18 08:34:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195885-20190318165315.patch</filename>
            <type>text/plain</type>
            <size>1152</size>
            <attacher name="Adrian Perez">aperez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmQxMzQxOTc2MGZkZGY1OTE4NDdjODI0YTIwNzJmNmE4
NTk1Yzg2OC4uMDQwYjY0YWY1MGQyYWZkMzRiMTk3NjBhMGVmZDJlMWQzOWE1N2QxYiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDE5LTAzLTE4ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j
b20+CisKKyAgICAgICAgW1dQRV0gVGFyYmFsbHMgZ2VuZXJhdGVkIHdpdGgg4oCcbWFrZSBkaXN0
4oCdIGNhbm5vdCBidWlsZCBkb2N1bWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU4ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIHdwZS9tYW5pZmVzdC50eHQuaW46IEFkZCBtaXNzaW5n
IFRvb2xzL2dsaWIvY29tbW9uLnB5IGZpbGUgdG8gYmUgaW5jbHVkZWQgaW4gcmVsZWFzZSB0YXJi
YWxscy4KKwogMjAxOS0wMy0xOCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2Fs
aWEuY29tPgogCiAgICAgICAgIFtXUEVdIEJ1bXAgZGVwZW5kZW5jaWVzIHRvIHdwZS0xLjAgYW5k
IHdwZWJhY2tlbmQtZmRvLTEuMApkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL21hbmlmZXN0LnR4dC5p
biBiL1Rvb2xzL3dwZS9tYW5pZmVzdC50eHQuaW4KaW5kZXggOTE2M2YyYjliMDEzMzJkMTlmMzVj
NDk4OTZhNDEyODQzM2EwMDIyNy4uNmZkNDg5ZDAxOTU5MWJjZWZkMDE4MTE3ZjJkZjkyZGNlMjM1
NDRiZiAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL21hbmlmZXN0LnR4dC5pbgorKysgYi9Ub29scy93
cGUvbWFuaWZlc3QudHh0LmluCkBAIC04NCw2ICs4NCw3IEBAIGV4Y2x1ZGUgVG9vbHMvd3BlL3Bh
dGNoZXMKIGV4Y2x1ZGUgVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcwogZXhjbHVkZSBUb29scy93
cGUvamhidWlsZHJjCiAKK2ZpbGUgVG9vbHMvZ2xpYi9jb21tb24ucHkKIGZpbGUgVG9vbHMvZ2xp
Yi9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5CiAKIGRpcmVjdG9yeSBU
b29scy9ndGtkb2MK
</data>

          </attachment>
      

    </bug>

</bugzilla>