195882 2019-03-18 05:34:14 -0700 [ews-build] API and layout test builders shouldn't apply Patch 2019-07-10 09:31:44 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED WORKSFORME P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist jbedard lforschler oldest_to_newest 1517657 0 aakash_jain 2019-03-18 05:34:14 -0700 Since API and layout test builders download archive and run test for that archive, they don't need to apply the patch to working directory. Similarly they don't even need to update the working directory. These steps might take long time for large patches (and might even fail in case of network issues). We shouldn't run these steps on these builders. 1517658 1 365010 aakash_jain 2019-03-18 05:35:54 -0700 Created attachment 365010 Patch 1517659 2 ews-watchlist 2019-03-18 05:37:32 -0700 Attachment 365010 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:102: [TestFactory.__init__] Undefined variable 'ConfigureBuild' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:103: [TestFactory.__init__] Undefined variable 'ValidatePatch' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:104: [TestFactory.__init__] Undefined variable 'PrintConfiguration' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:105: [TestFactory.__init__] Undefined variable 'CheckOutSource' [pylint/E0602] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1517707 3 jbedard 2019-03-18 09:06:57 -0700 The checkout is relevant for both API and layout tests, though. As is the patch. For layout tests, if we don't apply the patch, we won't get any updates to the layout tests or test results. For API tests, it's less of a concern since the only thing we'd potentially be missing is harness code in webkitpy. In both cases, I feel like not applying the patch is confusing and undermines the purpose of EWS. We want EWS to fail if someone uploads a tools patch that breaks layout tests, right? 365010 2019-03-18 05:35:54 -0700 2019-07-10 09:31:06 -0700 Patch bug-195882-20190318083619.patch text/plain 1744 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzA2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBUEkgYW5kIGxheW91dCB0ZXN0IGJ1aWxkZXJzIHNo b3VsZG4ndCBhcHBseSBQYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1ODgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Ogor ICAgICAgICAoVGVzdEZhY3RvcnkpOgorCiAyMDE5LTAzLTE4ICBBZHJpYW4gUGVyZXogZGUgQ2Fz dHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gQnVtcCBkZXBlbmRlbmNp ZXMgdG8gd3BlLTEuMCBhbmQgd3BlYmFja2VuZC1mZG8tMS4wCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDI0MzA2MCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHdvcmtp bmcgY29weSkKQEAgLTg5LDcgKzg5LDcgQEAgY2xhc3MgQnVpbGRGYWN0b3J5KEZhY3RvcnkpOgog ICAgICAgICB9CiAKIAotY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CitjbGFzcyBUZXN0RmFj dG9yeShmYWN0b3J5LkJ1aWxkRmFjdG9yeSk6CiAgICAgTGF5b3V0VGVzdENsYXNzID0gTm9uZQog ICAgIEFQSVRlc3RDbGFzcyA9IE5vbmUKIApAQCAtOTgsNyArOTgsMTIgQEAgY2xhc3MgVGVzdEZh Y3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIHNlbGYuYWRkU3RlcChFeHRyYWN0QnVpbHRQcm9kdWN0 KCkpCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Tm9u ZSwgYXJjaGl0ZWN0dXJlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUsICoqa3dhcmdz KToKLSAgICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlv biwgYXJjaGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudHMpCisgICAgICAgIGZh Y3RvcnkuQnVpbGRGYWN0b3J5Ll9faW5pdF9fKHNlbGYpCisgICAgICAgIHNlbGYuYWRkU3RlcChD b25maWd1cmVCdWlsZChwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgRmFs c2UsIGFkZGl0aW9uYWxBcmd1bWVudHMpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoVmFsaWRhdGVQ YXRjaCgpKQorICAgICAgICBzZWxmLmFkZFN0ZXAoUHJpbnRDb25maWd1cmF0aW9uKCkpCisgICAg ICAgIHNlbGYuYWRkU3RlcChDaGVja091dFNvdXJjZSgpKQorCiAgICAgICAgIHNlbGYuZ2V0UHJv ZHVjdCgpCiAgICAgICAgIGlmIHNlbGYuTGF5b3V0VGVzdENsYXNzOgogICAgICAgICAgICAgc2Vs Zi5hZGRTdGVwKHNlbGYuTGF5b3V0VGVzdENsYXNzKCkpCg==