195876 2019-03-18 01:11:21 -0700 [WPE][GTK] Fix a build warning because of missing to handle an enum value 2019-03-18 02:30:54 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim bugs-noreply cmarcelo commit-queue ews-watchlist fred.wang jamesr luiz tonikitoo zan oldest_to_newest 1517625 0 gyuyoung.kim 2019-03-18 01:11:21 -0700 When building WPE or GTK port, there is a build warning. I think that the warning has caused by missing to handle an enum value in the switch ~ case. [3540/4386] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-767013ce-18.cpp.o In file included from /home/gyuyoung/LGE/starfish/webkit/WebKit/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource-767013ce-18.cpp:4:0: ../../Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp: In member function ‘virtual WTF::Ref<WebCore::ScrollingTreeNode> WebCore::ScrollingTreeNicosia::createScrollingTreeNode(WebCore::ScrollingNodeType, WebCore::ScrollingNodeID)’: ../../Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:52:12: warning: enumeration value ‘Positioned’ not handled in switch [-Wswitch] switch (nodeType) { ^ 1517626 1 365004 gyuyoung.kim 2019-03-18 01:16:59 -0700 Created attachment 365004 Patch 1517631 2 365004 commit-queue 2019-03-18 02:30:52 -0700 Comment on attachment 365004 Patch Clearing flags on attachment: 365004 Committed r243057: <https://trac.webkit.org/changeset/243057> 1517632 3 commit-queue 2019-03-18 02:30:54 -0700 All reviewed patches have been landed. Closing bug. 365004 2019-03-18 01:16:59 -0700 2019-03-18 02:30:52 -0700 Patch bug-195876-20190318171658.patch text/plain 1782 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDcwYTJlN2NjOTdjMzgy MzE3N2RmMGI3YTFiMTBiZTM5MjAwMmIxMC4uNmEzZjdiMjA5ZmE0NzYyY2QzOWZkY2Q2NzBmNDI3 Mjg2ODY5YmIzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTE4ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbV1BFXVtHVEtd IEZpeCBhIGJ1aWxkIHdhcm5pbmcgYmVjYXVzZSBvZiBtaXNzaW5nIHRvIGhhbmRsZSBhbiBlbnVt IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTU4NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIGJ1aWxkaW5nIFdQRSBvciBHVEsgcG9ydCwgdGhlcmUgaXMgYSBidWlsZCB3YXJuaW5nLiBU aGUgc3dpdGNoLWNhc2UgbmVlZHMgdG8KKyAgICAgICAgaGFuZGxlICpQb3NpdGlvbmVkKiBlbnVt IHZhbHVlIGFzIHdlbGwgaW4gb3JkZXIgdG8gYXZvaWQgdGhlIGJ1aWxkIHdhcm5pbmcuCisKKyAg ICAgICAgKiBwYWdlL3Njcm9sbGluZy9uaWNvc2lhL1Njcm9sbGluZ1RyZWVOaWNvc2lhLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1RyZWVOaWNvc2lhOjpjcmVhdGVTY3JvbGxpbmdU cmVlTm9kZSk6IEFkZCBjYXNlIFNjcm9sbGluZ05vZGVUeXBlOjpQb3NpdGlvbmVkLgorCiAyMDE5 LTAzLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTjogIXZtLmlzSW5pdGlhbGl6aW5nT2JqZWN0KCkgdm9pZCogSlNDOjp0cnlBbGxvY2F0 ZUNlbGxIZWxwZXI8SlNDOjpTdHJ1Y3R1cmU+IEpTQzo6U3RydWN0dXJlOjpjcmVhdGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL25pY29zaWEvU2Nyb2xsaW5nVHJl ZU5pY29zaWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3Jv bGxpbmdUcmVlTmljb3NpYS5jcHAKaW5kZXggYzJhNjVkMjlkNGM5NmM4NDJjZGI4ODY2YjIzNWJm ZTFlNGVlZThhNS4uY2VhNzE0NmYxMTgwOTYwNWM1MzZiYTc3ODU4M2YwNGZiYzM5YTgwZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3NpYS9TY3JvbGxpbmdU cmVlTmljb3NpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbmljb3Np YS9TY3JvbGxpbmdUcmVlTmljb3NpYS5jcHAKQEAgLTYyLDYgKzYyLDggQEAgUmVmPFNjcm9sbGlu Z1RyZWVOb2RlPiBTY3JvbGxpbmdUcmVlTmljb3NpYTo6Y3JlYXRlU2Nyb2xsaW5nVHJlZU5vZGUo U2Nyb2xsaW5nTm8KICAgICAgICAgcmV0dXJuIFNjcm9sbGluZ1RyZWVGaXhlZE5vZGU6OmNyZWF0 ZSgqdGhpcywgbm9kZUlEKTsKICAgICBjYXNlIFNjcm9sbGluZ05vZGVUeXBlOjpTdGlja3k6CiAg ICAgICAgIHJldHVybiBTY3JvbGxpbmdUcmVlU3RpY2t5Tm9kZTo6Y3JlYXRlKCp0aGlzLCBub2Rl SUQpOworICAgIGNhc2UgU2Nyb2xsaW5nTm9kZVR5cGU6OlBvc2l0aW9uZWQ6CisgICAgICAgIFJF TEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCiAgICAgUkVMRUFTRV9BU1NFUlRf Tk9UX1JFQUNIRUQoKTsK