195871 2019-03-17 20:00:11 -0700 Structure::flattenDictionary() should clear unused property slots. 2019-03-18 09:18:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset rniwa saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1517601 0 mark.lam 2019-03-17 20:00:11 -0700 It current attempts to do this but fails because it's actually clearing up the preCapacity region instead. <rdar://problem/48959497> 1517602 1 364996 mark.lam 2019-03-17 20:04:29 -0700 Created attachment 364996 proposed patch. 1517678 2 364996 msaboff 2019-03-18 07:38:46 -0700 Comment on attachment 364996 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=364996&action=review r=me after addressing ChangeLog wording. > Source/JavaScriptCore/ChangeLog:9 > + It current attempts to do this but fails because it's actually clearing up the Should this read *currently* ? > Source/JavaScriptCore/ChangeLog:10 > + preCapacity region instead. The fix i simply to account for the preCapacity Should this read "The fix is simply to ..."? 1517715 3 mark.lam 2019-03-18 09:18:50 -0700 Thanks for the review. I've fixed the typos. Landed in r243069: <http://trac.webkit.org/r243069>. 364996 2019-03-17 20:04:29 -0700 2019-03-18 07:38:46 -0700 proposed patch. bug-195871.patch text/plain 3502 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDMwNTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5KCkgc2hvdWxkIGNsZWFy IHVudXNlZCBwcm9wZXJ0eSBzbG90cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NTg3MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg5NTk0OTc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJl c3Mvc3RydWN0dXJlLWZsYXR0ZW5EaWN0aW9uYXJ5LXNob3VsZC1jbGVhci11bnVzZWQtcHJvcGVy dHktc2xvdHMuanM6IEFkZGVkLgorCiAyMDE5LTAzLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBOZWVkIHRvIGNoZWNrIE9iamVjdFByb3BlcnR5Q29uZGl0aW9u IGxpdmVuZXNzIGJlZm9yZSBhY2Nlc3NpbmcgaXQgd2hlbiBmaXJpbmcgd2F0Y2hwb2ludHMuCklu ZGV4OiBKU1Rlc3RzL3N0cmVzcy9zdHJ1Y3R1cmUtZmxhdHRlbkRpY3Rpb25hcnktc2hvdWxkLWNs ZWFyLXVudXNlZC1wcm9wZXJ0eS1zbG90cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVz cy9zdHJ1Y3R1cmUtZmxhdHRlbkRpY3Rpb25hcnktc2hvdWxkLWNsZWFyLXVudXNlZC1wcm9wZXJ0 eS1zbG90cy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9zdHJ1Y3R1cmUtZmxh dHRlbkRpY3Rpb25hcnktc2hvdWxkLWNsZWFyLXVudXNlZC1wcm9wZXJ0eS1zbG90cy5qcwkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACisvLyBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBjcmFz aC4KKwordmFyIGFyciA9IFtdOworYXJyLnggPSAwOworYXJyLnkgPSAwOworZGVsZXRlIGFyclsi eCJdOworCitmb3IgKHZhciBpID0gMDsgaSA8IDI7ICsraSkKKyAgICBhcnIudW5zaGlmdChpKTsK KworYXJyLnogPSA0MjsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQz MDUzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5KCkgc2hvdWxkIGNsZWFy IHVudXNlZCBwcm9wZXJ0eSBzbG90cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NTg3MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg5NTk0OTc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgY3Vy cmVudCBhdHRlbXB0cyB0byBkbyB0aGlzIGJ1dCBmYWlscyBiZWNhdXNlIGl0J3MgYWN0dWFsbHkg Y2xlYXJpbmcgdXAgdGhlCisgICAgICAgIHByZUNhcGFjaXR5IHJlZ2lvbiBpbnN0ZWFkLiAgVGhl IGZpeCBpIHNpbXBseSB0byBhY2NvdW50IGZvciB0aGUgcHJlQ2FwYWNpdHkKKyAgICAgICAgd2hl biBjb21wdXRpbmcgdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIHByb3BlcnR5IHNsb3RzLgorCisg ICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmUuY3BwOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6 OmZsYXR0ZW5EaWN0aW9uYXJ5U3RydWN0dXJlKToKKwogMjAxOS0wMy0xNyAgUm9iaW4gTW9yaXNz ZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFBhcnNlckVycm9yIGNhbiBiZSBz aHJ1bmsgYnkgOCBieXRlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry dWN0dXJlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJ1Y3R1cmUuY3BwCShyZXZpc2lvbiAyNDMwNTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TdHJ1Y3R1cmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoK LSAqIENvcHlyaWdodCAoQykgMjAwOCwgMjAwOSwgMjAxMy0yMDE2IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOC0yMDE5IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNzc4 LDEwICs3NzgsMTAgQEAgU3RydWN0dXJlKiBTdHJ1Y3R1cmU6OmZsYXR0ZW5EaWN0aW9uYXJ5Uwog ICAgICAgICAgICAgKGlubGluZUNhcGFjaXR5KCkgLSBpbmxpbmVTaXplKCkpICogc2l6ZW9mKEVu Y29kZWRKU1ZhbHVlKSk7CiAKICAgICAgICAgQnV0dGVyZmx5KiBidXR0ZXJmbHkgPSBvYmplY3Qt PmJ1dHRlcmZseSgpOwotICAgICAgICBtZW1zZXQoCi0gICAgICAgICAgICBidXR0ZXJmbHktPmJh c2UoYnV0dGVyZmx5LT5pbmRleGluZ0hlYWRlcigpLT5wcmVDYXBhY2l0eSh0aGlzKSwgYmVmb3Jl T3V0T2ZMaW5lQ2FwYWNpdHkpLAotICAgICAgICAgICAgMCwKLSAgICAgICAgICAgIChiZWZvcmVP dXRPZkxpbmVDYXBhY2l0eSAtIG91dE9mTGluZVNpemUoKSkgKiBzaXplb2YoRW5jb2RlZEpTVmFs dWUpKTsKKyAgICAgICAgc2l6ZV90IHByZUNhcGFjaXR5ID0gYnV0dGVyZmx5LT5pbmRleGluZ0hl YWRlcigpLT5wcmVDYXBhY2l0eSh0aGlzKTsKKyAgICAgICAgdm9pZCogYmFzZSA9IGJ1dHRlcmZs eS0+YmFzZShwcmVDYXBhY2l0eSwgYmVmb3JlT3V0T2ZMaW5lQ2FwYWNpdHkpOworICAgICAgICB2 b2lkKiBzdGFydE9mUHJvcGVydHlTdG9yYWdlU2xvdHMgPSByZWludGVycHJldF9jYXN0PEVuY29k ZWRKU1ZhbHVlKj4oYmFzZSkgKyBwcmVDYXBhY2l0eTsKKyAgICAgICAgbWVtc2V0KHN0YXJ0T2ZQ cm9wZXJ0eVN0b3JhZ2VTbG90cywgMCwgKGJlZm9yZU91dE9mTGluZUNhcGFjaXR5IC0gb3V0T2ZM aW5lU2l6ZSgpKSAqIHNpemVvZihFbmNvZGVkSlNWYWx1ZSkpOwogICAgICAgICBjaGVja09mZnNl dENvbnNpc3RlbmN5KCk7CiAgICAgfQogCg==