195860 2019-03-17 04:26:21 -0700 Fix WPE and GTK Debug builds after r243049 2019-03-17 18:05:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino webkit-unassigned commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1517525 0 dpino 2019-03-17 04:26:21 -0700 Fix WPE and GTK Debug builds after r243049 1517526 1 364962 dpino 2019-03-17 04:27:53 -0700 Created attachment 364962 Patch 1517528 2 364962 commit-queue 2019-03-17 05:06:54 -0700 Comment on attachment 364962 Patch Clearing flags on attachment: 364962 Committed r243052: <https://trac.webkit.org/changeset/243052> 1517529 3 commit-queue 2019-03-17 05:06:55 -0700 All reviewed patches have been landed. Closing bug. 1517530 4 webkit-bug-importer 2019-03-17 05:08:57 -0700 <rdar://problem/48961043> 1517587 5 364962 mark.lam 2019-03-17 18:05:38 -0700 Comment on attachment 364962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364962&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:1822 > + default: > + ASSERT_NOT_REACHED(); How can this be possibly be correct? Normalization form is an enum class with only the above four values. Can you please provide details on what the WPE and GTK Debug builds errors are? This patch would have be r-ed under normal circumstances. 364962 2019-03-17 04:27:53 -0700 2019-03-17 05:06:54 -0700 Patch bug-195860-20190317112752.patch text/plain 1314 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YzBkZWI0N2M3YzBmN2NjMWNjOTk1MzMzMjJkZmQ1NzI5ZDVmMjk2Li4zYTdmZDQwYTczMzkwYTg5 YmNiMjA3MzRhZGJmOTVhZDJjMTYzYzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wMy0xNyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIEZpeCBXUEUgYW5kIEdUSyBEZWJ1ZyBidWlsZHMgYWZ0ZXIgcjI0MzA0 OQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODYw CisKKyAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4IGFmdGVyIHIyNDMwNDkuCisKKyAgICAg ICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6Om5vcm1hbGl6 YXRpb25BZmZlY3RzOEJpdCk6CisKIDIwMTktMDMtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgbm9ybWFsaXphdGlvbiBjb2RlLCBpbmNsdWRpbmcg bW92aW5nIGZyb20gdW5vcm0uaCB0byB1bm9ybTIuaApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKaW5kZXggM2FmZmNjYjEyYzAzZDU4Y2Rh NDQ1YWFkYmQ5ZWIzNjQ0ZWY0ZTQ2OS4uOGRjY2QwMTdhYmE2ZjVjMTE1MGJiZTczM2I5NmY3ODc0 NDM5YjU5MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5n UHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQ cm90b3R5cGUuY3BwCkBAIC0xODE4LDggKzE4MTgsOSBAQCBzdGF0aWMgY29uc3RleHByIGJvb2wg bm9ybWFsaXphdGlvbkFmZmVjdHM4Qml0KE5vcm1hbGl6YXRpb25Gb3JtIGZvcm0pCiAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICBjYXNlIE5vcm1hbGl6YXRpb25Gb3JtOjpORktEOgogICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKICAgICB9Ci0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgcmV0dXJuIHRydWU7CiB9 CiAK