19586 2008-06-16 09:53:05 -0700 Show the file and line in the call frame next to the function name 2008-06-17 15:35:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy oldest_to_newest 83480 0 timothy 2008-06-16 09:53:05 -0700 We should show the file and line number next to each call frame in the Call Stack pane. 83481 1 timothy 2008-06-16 09:53:16 -0700 I have a fix for this. 83500 2 21733 timothy 2008-06-16 11:32:14 -0700 Created attachment 21733 Proposed patch 83610 3 21733 aroben 2008-06-17 13:45:29 -0700 Comment on attachment 21733 Proposed patch + if (scriptOrResource instanceof WebInspector.Script) + subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL); + else if (scriptOrResource instanceof WebInspector.Resource) + subtitle = WebInspector.displayNameForURL(scriptOrResource.url); You could probably do this instead: subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL || scriptOrResource.url) Or we could make Scripts and Resources use the same property for their URL. r=me 83649 4 timothy 2008-06-17 15:35:09 -0700 Landed in r34635. 21733 2008-06-16 11:32:14 -0700 2008-06-17 13:45:29 -0700 Proposed patch 0005-Adds-the-file-name-and-line-number-for-call.patch text/plain 3493 timothy RnJvbSAxNWVjNzM1MDA0NzJjZTAyYWRlOTk4MmZkNzJiNzNhZWRlY2JiYWFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDE2IEp1biAyMDA4IDExOjMyOjU5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBBZGRzIHRoZSBmaWxlIG5hbWUgYW5kIGxpbmUgbnVtYmVyIGZvciBjYWxsIGZyYW1lcyBu ZXh0IHRvCiAgICAgICAgIHRoZSBmdW5jdGlvbiBuYW1lIGluIHRoZSBDYWxsIFN0YWNrIHBhbmUu CgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU4NgoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBFbmdsaXNoLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanM6IFVwZGF0ZWQgc3RyaW5ncy4KICAgICAgICAqIHBhZ2Uv aW5zcGVjdG9yL0NhbGxTdGFja1NpZGViYXJQYW5lLmpzOgogICAgICAgIChXZWJJbnNwZWN0b3Iu Q2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlLnVwZGF0ZSk6IENyZWF0ZSBhIHN1YnRpdGxl CiAgICAgICAgYmFzZWQgb24gdGhlIFVSTCBhbmQgbGluZSBudW1iZXIuCi0tLQogV2ViQ29yZS9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysr KysKIFdlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzICAgICAgfCAgQmlu IDE1NDU0IC0+IDE1NTM2IGJ5dGVzCiBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0NhbGxTdGFja1Np ZGViYXJQYW5lLmpzIHwgICAxNiArKysrKysrKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDI5 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYjJjMDdiLi5iZGI3NGM0IDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE5IEBACiAyMDA4LTA2LTE2ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4K IAorICAgICAgICBBZGRzIHRoZSBmaWxlIG5hbWUgYW5kIGxpbmUgbnVtYmVyIGZvciBjYWxsIGZy YW1lcyBuZXh0IHRvCisgICAgICAgIHRoZSBmdW5jdGlvbiBuYW1lIGluIHRoZSBDYWxsIFN0YWNr IHBhbmUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBFbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6IFVwZGF0ZWQgc3RyaW5ncy4KKyAg ICAgICAgKiBwYWdlL2luc3BlY3Rvci9DYWxsU3RhY2tTaWRlYmFyUGFuZS5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5DYWxsU3RhY2tTaWRlYmFyUGFuZS5wcm90b3R5cGUudXBkYXRlKTogQ3Jl YXRlIGEgc3VidGl0bGUKKyAgICAgICAgYmFzZWQgb24gdGhlIFVSTCBhbmQgbGluZSBudW1iZXIu CisKKzIwMDgtMDYtMTYgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAg ICAgICAgIFVzZSBhY2N1cmF0ZSBjYWxsIGZyYW1lIHRpdGxlJ3MgYmFzZWQgb24gdGhlIGNhbGwg ZnJhbWUgdHlwZS4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk1ODUKZGlmZiAtLWdpdCBhL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRT dHJpbmdzLmpzIGIvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5k ZXggYWNkZWQ2OThiMGFjZmIxOGVhYTQ4YjhkNTA5MWYwYThmYmM1N2VhNy4uNjUzZjMxMjRjN2Iy MzlhNDViNTc5Y2NlOTM5ODZmMjQyMmUyODU3ZiAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0 YSA1Ngp5Y21jYXR2N3ZJcUVpM2dMaEQ/UyRoRXhVeDIzM1g+MXxeMUFBaj1rcmxeOVREQ1NQUkst aDlpZGclSlImRiVBYSsKCmRlbHRhIDEyClRjbWRsYGQ5UHhfRXZ3QnMpLTgreEVnbDhxCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9DYWxsU3RhY2tTaWRlYmFyUGFuZS5qcyBi L1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvQ2FsbFN0YWNrU2lkZWJhclBhbmUuanMKaW5kZXggMjll NDYzZC4uMGU4MWIzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9DYWxsU3Rh Y2tTaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0NhbGxTdGFja1Np ZGViYXJQYW5lLmpzCkBAIC00NSw2ICs0NSw4IEBAIFdlYkluc3BlY3Rvci5DYWxsU3RhY2tTaWRl YmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICB2YXIgdGl0bGU7Cisg ICAgICAgIHZhciBzdWJ0aXRsZTsKKwogICAgICAgICBkbyB7CiAgICAgICAgICAgICBpZiAoc291 cmNlSURNYXApCiAgICAgICAgICAgICAgICAgdmFyIHNjcmlwdE9yUmVzb3VyY2UgPSBzb3VyY2VJ RE1hcFtjYWxsRnJhbWUuc291cmNlSWRlbnRpZmllcl07CkBAIC02NSw3ICs2NywxOSBAQCBXZWJJ bnNwZWN0b3IuQ2FsbFN0YWNrU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICB2YXIgcGxhY2FyZCA9IG5l dyBXZWJJbnNwZWN0b3IuUGxhY2FyZCh0aXRsZSk7CisgICAgICAgICAgICBpZiAoc2NyaXB0T3JS ZXNvdXJjZSBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5TY3JpcHQpCisgICAgICAgICAgICAgICAg c3VidGl0bGUgPSBXZWJJbnNwZWN0b3IuZGlzcGxheU5hbWVGb3JVUkwoc2NyaXB0T3JSZXNvdXJj ZS5zb3VyY2VVUkwpOworICAgICAgICAgICAgZWxzZSBpZiAoc2NyaXB0T3JSZXNvdXJjZSBpbnN0 YW5jZW9mIFdlYkluc3BlY3Rvci5SZXNvdXJjZSkKKyAgICAgICAgICAgICAgICBzdWJ0aXRsZSA9 IFdlYkluc3BlY3Rvci5kaXNwbGF5TmFtZUZvclVSTChzY3JpcHRPclJlc291cmNlLnVybCk7CisK KyAgICAgICAgICAgIGlmIChjYWxsRnJhbWUubGluZSA+IDApIHsKKyAgICAgICAgICAgICAgICBp ZiAoc3VidGl0bGUpCisgICAgICAgICAgICAgICAgICAgIHN1YnRpdGxlICs9ICI6IiArIGNhbGxG cmFtZS5saW5lOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgc3Vi dGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoImxpbmUgJWQiLCBjYWxsRnJhbWUubGluZSk7 CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIHZhciBwbGFjYXJkID0gbmV3IFdlYkluc3Bl Y3Rvci5QbGFjYXJkKHRpdGxlLCBzdWJ0aXRsZSk7CiAgICAgICAgICAgICBwbGFjYXJkLmNhbGxG cmFtZSA9IGNhbGxGcmFtZTsKIAogICAgICAgICAgICAgcGxhY2FyZC5lbGVtZW50LmFkZEV2ZW50 TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fcGxhY2FyZFNlbGVjdGVkLmJpbmQodGhpcyksIGZhbHNl KTsKLS0gCjEuNS40LjQKCg==