195857 2019-03-16 14:37:30 -0700 ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail: 2019-03-16 15:04:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer wenson_hsieh oldest_to_newest 1517475 0 dino 2019-03-16 14:37:30 -0700 ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail: 1517476 1 dino 2019-03-16 14:38:02 -0700 <rdar://problem/48954679> 1517477 2 364942 dino 2019-03-16 14:42:19 -0700 Created attachment 364942 Patch 1517478 3 364942 wenson_hsieh 2019-03-16 14:47:41 -0700 Comment on attachment 364942 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364942&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:652 > + [_doubleTapGestureRecognizer setGestureFailedTarget:self action:nil]; Nit - Is there a reason we prefer setting the target to self instead of nil? 1517486 4 dino 2019-03-16 15:04:35 -0700 Committed r243047: <https://trac.webkit.org/changeset/243047> 364942 2019-03-16 14:42:19 -0700 2019-03-16 14:47:41 -0700 Patch bug-195857-20190317084217.patch text/plain 2593 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMwZDkzZTgxZTdmODc3MGUx NzFmZjIyOWY1NmM0Y2MxNDQzZDA2NGQuLjFiNjkzOWQ5ZjM0OTg0NzIyMWE1NTRlYmM0NTNhNzFj YTJmYzM4MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMTYgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVChnZXN0dXJlUmVjb2duaXpl ciA9PSBfZG91YmxlVGFwR2VzdHVyZVJlY29nbml6ZXIpIGluIF9kb3VibGVUYXBEaWRGYWlsOgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODU3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODk1NDY3OT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldCBhbiBleGlzdGluZyBnZXN0dXJlIHJlY29n bml6ZXIgYmVmb3JlIGNyZWF0aW5nIGEgbmV3IG9uZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3 IF9jcmVhdGVBbmRDb25maWd1cmVEb3VibGVUYXBHZXN0dXJlUmVjb2duaXplcl0pOgorICAgICAg ICAoLVtXS0NvbnRlbnRWaWV3IF9zZXREb3VibGVUYXBHZXN0dXJlc0VuYWJsZWQ6XSk6CisKIDIw MTktMDMtMTUgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IEFsbCBuZXR3b3JraW5nIGZyb20gV2ViS2l0Lk5ldHdvcmtpbmcgZmFpbHMgd2hlbiBOZXR3b3Jr IEV4dGVuc2lvbiBjb250ZW50IGZpbHRlciBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA2 YmZkY2U0OGUyYzQ0MjNmNjY5Mzc3MmI4ZDBjYWVhZjI2ZGRhOWRhLi45ZTg1NjQ2YmIxNGRiM2Y5 NzVmZTg0ZjYyZDA5YzZkZjk1ZGFlYzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTY0Niw2ICs2NDYs MTIgQEAgc3RhdGljIGlubGluZSBib29sIGhhc0ZvY3VzZWRFbGVtZW50KFdlYktpdDo6Rm9jdXNl ZEVsZW1lbnRJbmZvcm1hdGlvbiBmb2N1c2VkRWwKIAogLSAodm9pZClfY3JlYXRlQW5kQ29uZmln dXJlRG91YmxlVGFwR2VzdHVyZVJlY29nbml6ZXIKIHsKKyAgICBpZiAoX2RvdWJsZVRhcEdlc3R1 cmVSZWNvZ25pemVyKSB7CisgICAgICAgIFtzZWxmIHJlbW92ZUdlc3R1cmVSZWNvZ25pemVyOl9k b3VibGVUYXBHZXN0dXJlUmVjb2duaXplci5nZXQoKV07CisgICAgICAgIFtfZG91YmxlVGFwR2Vz dHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsKKyAgICAgICAgW19kb3VibGVUYXBHZXN0 dXJlUmVjb2duaXplciBzZXRHZXN0dXJlRmFpbGVkVGFyZ2V0OnNlbGYgYWN0aW9uOm5pbF07Cisg ICAgfQorCiAgICAgX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyID0gYWRvcHROUyhbW1dLU3lu dGhldGljVGFwR2VzdHVyZVJlY29nbml6ZXIgYWxsb2NdIGluaXRXaXRoVGFyZ2V0OnNlbGYgYWN0 aW9uOkBzZWxlY3RvcihfZG91YmxlVGFwUmVjb2duaXplZDopXSk7CiAgICAgW19kb3VibGVUYXBH ZXN0dXJlUmVjb2duaXplciBzZXRHZXN0dXJlRmFpbGVkVGFyZ2V0OnNlbGYgYWN0aW9uOkBzZWxl Y3RvcihfZG91YmxlVGFwRGlkRmFpbDopXTsKICAgICBbX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25p emVyIHNldE51bWJlck9mVGFwc1JlcXVpcmVkOjJdOwpAQCAtMzczOCw4ICszNzQ0LDYgQEAgc3Rh dGljIHZvaWQgc2VsZWN0aW9uQ2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3ICp2aWV3LCBj b25zdCBXZWJDb3JlOjpJbnRQb2kKICAgICBpZiAoZW5hYmxlZCAmJiAhW19kb3VibGVUYXBHZXN0 dXJlUmVjb2duaXplciBpc0VuYWJsZWRdKSB7CiAgICAgICAgIC8vIFRoZSBmaXJzdCB0YXAgcmVj b2duaXplZCBhZnRlciByZS1lbmFibGluZyBkb3VibGUgdGFwIGdlc3R1cmVzIHdpbGwgbm90IHdh aXQgZm9yIHRoZQogICAgICAgICAvLyBzZWNvbmQgdGFwIGJlZm9yZSBjb21taXR0aW5nLiBUbyBm aXggdGhpcywgd2UgdXNlIGEgbmV3IGRvdWJsZSB0YXAgZ2VzdHVyZSByZWNvZ25pemVyLgotICAg ICAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfZG91YmxlVGFwR2VzdHVyZVJlY29n bml6ZXIuZ2V0KCldOwotICAgICAgICBbX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyIHNldERl bGVnYXRlOm5pbF07CiAgICAgICAgIFtzZWxmIF9jcmVhdGVBbmRDb25maWd1cmVEb3VibGVUYXBH ZXN0dXJlUmVjb2duaXplcl07CiAgICAgfQogCg==