195852 2019-03-16 10:35:28 -0700 REGRESSION (r242807): Unified sources build failure from missing imports 2019-03-16 11:39:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue pvollan webkit-bug-importer oldest_to_newest 1517435 0 timothy 2019-03-16 10:35:28 -0700 /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/UnifiedSource32-mm.o In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/DerivedSources/WebKit2/unified-sources/UnifiedSource32-mm.mm:1: /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:82:1: error: unknown type name 'SOFT_LINK_PRIVATE_FRAMEWORK' SOFT_LINK_PRIVATE_FRAMEWORK(BackBoardServices) ^ /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:82:47: error: expected ';' after top level declarator SOFT_LINK_PRIVATE_FRAMEWORK(BackBoardServices) ^ ; /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:393:12: error: use of undeclared identifier 'BKSDisplayBrightnessGetCurrent' return BKSDisplayBrightnessGetCurrent(); ^ /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:399:76: error: use of undeclared identifier 'BKSDisplayBrightnessGetCurrent' pool->sendToAllProcesses(Messages::WebProcess::BacklightLevelDidChange(BKSDisplayBrightnessGetCurrent())); ^ /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:450:146: error: use of undeclared identifier 'UIBacklightLevelChangedNotification' CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, backlightLevelDidChangeCallback, static_cast<CFStringRef>(UIBacklightLevelChangedNotification), nullptr, CFNotificationSuspensionBehaviorCoalesce); ^ /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:473:116: error: use of undeclared identifier 'UIBacklightLevelChangedNotification' CFNotificationCenterRemoveObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, static_cast<CFStringRef>(UIBacklightLevelChangedNotification) , nullptr); ^ 6 errors generated. 1517436 1 364935 timothy 2019-03-16 10:40:27 -0700 Created attachment 364935 Patch 1517438 2 364936 timothy 2019-03-16 11:00:55 -0700 Created attachment 364936 Patch 1517444 3 364936 commit-queue 2019-03-16 11:38:51 -0700 Comment on attachment 364936 Patch Clearing flags on attachment: 364936 Committed r243042: <https://trac.webkit.org/changeset/243042> 1517445 4 commit-queue 2019-03-16 11:38:53 -0700 All reviewed patches have been landed. Closing bug. 1517446 5 webkit-bug-importer 2019-03-16 11:39:19 -0700 <rdar://problem/48954938> 364935 2019-03-16 10:40:27 -0700 2019-03-16 11:00:55 -0700 Patch bug-195852-20190316104026.patch text/plain 1463 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5YmI2NDhiOTZlZDM4N2Nj Mjk4MzJkYjE4ZGQyN2VlY2RkN2JhZGEuLmJlMzA5YzUyMmM3MjdkNGYzZjI3ZDM1YTFhNzgyYzY1 NmEyODU3OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDMtMTYgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDI4 MDcpOiBVbmlmaWVkIHNvdXJjZXMgYnVpbGQgZmFpbHVyZSBmcm9tIG1pc3NpbmcgI2ltcG9ydCA8 d3RmL1NvZnRMaW5raW5nLmg+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTU4NTIKKworICAgICAgICBVbnJldmlld2VkIHNwZWN1bGF0aXZlIGJ1aWxk IGZpeC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1t OgorICAgICAgICBJbmNsdWRlIDx3dGYvU29mdExpbmtpbmcuaD4gb24gaU9TLgorCiAyMDE5LTAz LTE1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBCbG9jayB0aGUgYWNjZXNzaWJpbGl0eSBzZXJ2ZXIgd2hlbiBhY2Nlc3NpYmlsaXR5IGlzIG5v dCBlbmFibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2Vi UHJvY2Vzc1Bvb2xDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBy b2Nlc3NQb29sQ29jb2EubW0KaW5kZXggY2JhMTQ0OGIzYjg4Y2ZlZTMyN2NlZGU2MzllNzY5Nzgz OTY3ZTIxNS4uM2M0NWNkZjJhNjM3YmIwNThmNjc4MjlhYjdjZGQ4ZGM3NTg2MDY0YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29h Lm1tCkBAIC02MSw2ICs2MSwxMCBAQAogI2ltcG9ydCA8UXVhcnR6Q29yZS9DQVJlbW90ZUxheWVy U2VydmVyLmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKElPUykKKyNpbXBvcnQgPHd0Zi9Tb2Z0 TGlua2luZy5oPgorI2VuZGlmCisKIE5TU3RyaW5nICpXZWJTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uRGlyZWN0b3J5RGVmYXVsdHNLZXkgPSBAIldlYlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25E aXJlY3RvcnkiOwogTlNTdHJpbmcgKldlYktpdExvY2FsQ2FjaGVEZWZhdWx0c0tleSA9IEAiV2Vi S2l0TG9jYWxDYWNoZSI7CiBOU1N0cmluZyAqV2ViS2l0SlNDSklURW5hYmxlZERlZmF1bHRzS2V5 ID0gQCJXZWJLaXRKU0NKSVRFbmFibGVkRGVmYXVsdHNLZXkiOwo= 364936 2019-03-16 11:00:55 -0700 2019-03-16 11:38:51 -0700 Patch bug-195852-20190316110055.patch text/plain 1483 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5YmI2NDhiOTZlZDM4N2Nj Mjk4MzJkYjE4ZGQyN2VlY2RkN2JhZGEuLjdkYTQ1NWUxZWEyYzYwZmFkMTFlN2JhY2IxMTk0YTg4 MmViZTNhZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDMtMTYgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDI4 MDcpOiBVbmlmaWVkIHNvdXJjZXMgYnVpbGQgZmFpbHVyZSBmcm9tIG1pc3NpbmcgaW1wb3J0cy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTg1Mgor CisgICAgICAgIFVucmV2aWV3ZWQgc3BlY3VsYXRpdmUgYnVpbGQgZml4LgorCisgICAgICAgICog VUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW06CisgICAgICAgIEluY2x1ZGUg PHd0Zi9Tb2Z0TGlua2luZy5oPiBhbmQgIlVJS2l0U1BJLmgiIG9uIGlPUy4KKwogMjAxOS0wMy0x NSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g QmxvY2sgdGhlIGFjY2Vzc2liaWxpdHkgc2VydmVyIHdoZW4gYWNjZXNzaWJpbGl0eSBpcyBub3Qg ZW5hYmxlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBy b2Nlc3NQb29sQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9j ZXNzUG9vbENvY29hLm1tCmluZGV4IGNiYTE0NDhiM2I4OGNmZWUzMjdjZWRlNjM5ZTc2OTc4Mzk2 N2UyMTUuLmU5NTlmNjUwNTA1MzM2N2ZlMWQ4MmUzNGVhNzgzN2M0NmNlMmM2OTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5t bQpAQCAtNjEsNiArNjEsMTEgQEAKICNpbXBvcnQgPFF1YXJ0ekNvcmUvQ0FSZW1vdGVMYXllclNl cnZlci5oPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShJT1MpCisjaW1wb3J0ICJVSUtpdFNQSS5o IgorI2ltcG9ydCA8d3RmL1NvZnRMaW5raW5nLmg+CisjZW5kaWYKKwogTlNTdHJpbmcgKldlYlNl cnZpY2VXb3JrZXJSZWdpc3RyYXRpb25EaXJlY3RvcnlEZWZhdWx0c0tleSA9IEAiV2ViU2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbkRpcmVjdG9yeSI7CiBOU1N0cmluZyAqV2ViS2l0TG9jYWxDYWNo ZURlZmF1bHRzS2V5ID0gQCJXZWJLaXRMb2NhbENhY2hlIjsKIE5TU3RyaW5nICpXZWJLaXRKU0NK SVRFbmFibGVkRGVmYXVsdHNLZXkgPSBAIldlYktpdEpTQ0pJVEVuYWJsZWREZWZhdWx0c0tleSI7 Cg==