195851 2019-03-16 08:48:25 -0700 [ews-build] Don't run clean builds on EWS builders 2019-04-13 06:40:11 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196897 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ggaren jbedard kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1517426 0 aakash_jain 2019-03-16 08:48:25 -0700 Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. The current EWS also doesn't run clean builds, ews-build should do the same. 1517427 1 364932 aakash_jain 2019-03-16 08:49:16 -0700 Created attachment 364932 Patch 1517466 2 364932 ggaren 2019-03-16 13:48:41 -0700 Comment on attachment 364932 Patch r=me 1517510 3 364932 commit-queue 2019-03-16 20:50:52 -0700 Comment on attachment 364932 Patch Clearing flags on attachment: 364932 Committed r243050: <https://trac.webkit.org/changeset/243050> 1517511 4 commit-queue 2019-03-16 20:50:53 -0700 All reviewed patches have been landed. Closing bug. 1517512 5 webkit-bug-importer 2019-03-16 20:51:16 -0700 <rdar://problem/48958641> 1517706 6 jbedard 2019-03-18 09:01:50 -0700 Question about this change: What happens if we need a clean build for some reason? Is there a mechanism to, for example, force a clean build if the build fails? 1517794 7 jbedard 2019-03-18 11:08:24 -0700 (In reply to Jonathan Bedard from comment #6) > Question about this change: What happens if we need a clean build for some > reason? Is there a mechanism to, for example, force a clean build if the > build fails? Discussed this on IRC with Aakash. Turns out, the code which cleans up after a patch fails to build removes the build directory. So we shouldn't need to do anything special to handle this case. 364932 2019-03-16 08:49:16 -0700 2019-03-16 20:50:52 -0700 Patch bug-195851-20190316114936.patch text/plain 1273 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzA0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTE2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEb24ndCBydW4gY2xlYW4gYnVpbGRzIG9uIEVXUyBi dWlsZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk1ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorCiAyMDE5LTAzLTE1 ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRw eTogVXBsb2FkIHRlc3QgcmVzdWx0cwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL2ZhY3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNDMwNDApCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02 OSw3ICs2OSw2IEBAIGNsYXNzIEJ1aWxkRmFjdG9yeShGYWN0b3J5KToKICAgICBkZWYgX19pbml0 X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Tm9uZSwgYXJjaGl0ZWN0dXJlcz1Ob25l LCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUsIHRyaWdnZXJzPU5vbmUsICoqa3dhcmdzKToKICAg ICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJj aGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudHMpCiAgICAgICAgIHNlbGYuYWRk U3RlcChLaWxsT2xkUHJvY2Vzc2VzKCkpCi0gICAgICAgIHNlbGYuYWRkU3RlcChDbGVhbkJ1aWxk KCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChDb21waWxlV2ViS2l0KCkpCiAgICAgICAgIHNlbGYu YWRkU3RlcChVbkFwcGx5UGF0Y2hJZlJlcXVpcmVkKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChD b21waWxlV2ViS2l0VG9UKCkpCg==