<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>195850</bug_id>
          
          <creation_ts>2019-03-16 02:47:20 -0700</creation_ts>
          <short_desc>[GTK] [WPE] Fix compilation errors due to undefined ALWAYS_LOG_IF</short_desc>
          <delta_ts>2019-03-16 04:58:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego Pino">dpino</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1517408</commentid>
    <comment_count>0</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2019-03-16 02:47:20 -0700</bug_when>
    <thetext>WPE and GTK build bots failed after https://trac.webkit.org/changeset/243033/webkit.

The changeset introduced new functions ALWAYS_LOG_IF and alike when RELEASE_LOG_DISABLED is false. These macros need to be defined as empty when !RELEASE_LOG_DISABLED.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517410</commentid>
    <comment_count>1</comment_count>
      <attachid>364926</attachid>
    <who name="Diego Pino">dpino</who>
    <bug_when>2019-03-16 02:50:19 -0700</bug_when>
    <thetext>Created attachment 364926
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517411</commentid>
    <comment_count>2</comment_count>
      <attachid>364927</attachid>
    <who name="Diego Pino">dpino</who>
    <bug_when>2019-03-16 02:51:59 -0700</bug_when>
    <thetext>Created attachment 364927
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517419</commentid>
    <comment_count>3</comment_count>
      <attachid>364927</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-16 04:26:20 -0700</bug_when>
    <thetext>Comment on attachment 364927
Patch

Clearing flags on attachment: 364927

Committed r243040: &lt;https://trac.webkit.org/changeset/243040&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517420</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-16 04:26:22 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1517422</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-03-16 04:58:08 -0700</bug_when>
    <thetext>&lt;rdar://problem/48952567&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>364926</attachid>
            <date>2019-03-16 02:50:19 -0700</date>
            <delta_ts>2019-03-16 02:51:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195850-20190316095017.patch</filename>
            <type>text/plain</type>
            <size>1237</size>
            <attacher name="Diego Pino">dpino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIxZWFmYTJhZjA2ZDhjNDk0MGQ2Njlm
MmUzYjQwZGEyMzBiNzZlMjguLjMxOGI5NWE2MGNlN2EyZTdlM2ExZTVmNTVjMzYzNjcyZDJhMTRh
NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDMtMTYgIERpZWdvIFBpbm8gR2FyY2lhICA8
ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbV1BFXSBGaXggY29tcGlsYXRpb24g
ZXJyb3JzIGR1ZSB0byB1bmRlZmluZWQgQUxXQVlTX0xPR19JRgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODUwCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvTG9nZ2VySGVscGVyLmg6CisKIDIw
MTktMDMtMTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAg
ICAgQWRkIG1lZGlhIHN0cmVhbSByZWxlYXNlIGxvZ2dpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
VEYvd3RmL0xvZ2dlckhlbHBlci5oIGIvU291cmNlL1dURi93dGYvTG9nZ2VySGVscGVyLmgKaW5k
ZXggZDAzYWZlNjQxNGNjOWM1MGU5YjM3ZTc3MjgwZjJjNjljYTM4MTliMS4uNzVhMjBiZGRjZWVl
NWQxMDhkM2EwMzI5NDZkMjM0ZjJkYzNjZTIzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv
TG9nZ2VySGVscGVyLmgKKysrIGIvU291cmNlL1dURi93dGYvTG9nZ2VySGVscGVyLmgKQEAgLTgx
LDYgKzgxLDEyIEBAIHB1YmxpYzoKICNkZWZpbmUgREVCVUdfTE9HKC4uLikgICAgICAoKHZvaWQp
MCkKICNkZWZpbmUgV0lMTF9MT0coX2xldmVsXykgICBmYWxzZQogCisjZGVmaW5lIEFMV0FZU19M
T0dfSUYoY29uZGl0aW9uLCAuLi4pICAgICAoKHZvaWQpMCkKKyNkZWZpbmUgRVJST1JfTE9HX0lG
KGNvbmRpdGlvbiwgLi4uKSAgICAgICgodm9pZCkwKQorI2RlZmluZSBXQVJOSU5HX0xPR19JRihj
b25kaXRpb24sIC4uLikgICAgKCh2b2lkKTApCisjZGVmaW5lIElORk9fTE9HX0lGKGNvbmRpdGlv
biwgLi4uKSAgICAgICAoKHZvaWQpMCkKKyNkZWZpbmUgREVCVUdfTE9HX0lGKGNvbmRpdGlvbiwg
Li4uKSAgICAgICgodm9pZCkwKQorCiAjZW5kaWYKICAgICAKIH07Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>364927</attachid>
            <date>2019-03-16 02:51:59 -0700</date>
            <delta_ts>2019-03-16 04:26:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195850-20190316095157.patch</filename>
            <type>text/plain</type>
            <size>1246</size>
            <attacher name="Diego Pino">dpino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIxZWFmYTJhZjA2ZDhjNDk0MGQ2Njlm
MmUzYjQwZGEyMzBiNzZlMjguLmYwMDAyMTdiZDEzNTE4NGU4MWQzYmFmMDZlMjRhN2I4NWE5YmQ5
MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDMtMTYgIERpZWdvIFBpbm8gR2FyY2lhICA8
ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbV1BFXSBGaXggY29tcGlsYXRpb24g
ZXJyb3JzIGR1ZSB0byB1bmRlZmluZWQgQUxXQVlTX0xPR19JRgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODUwCisKKyAgICAgICAgVW5yZXZpZXdl
ZCBidWlsZCBmaXggYWZ0ZXIgcjI0MzAzMy4gCisKKyAgICAgICAgKiB3dGYvTG9nZ2VySGVscGVy
Lmg6CisKIDIwMTktMDMtMTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+
CiAKICAgICAgICAgQWRkIG1lZGlhIHN0cmVhbSByZWxlYXNlIGxvZ2dpbmcKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XVEYvd3RmL0xvZ2dlckhlbHBlci5oIGIvU291cmNlL1dURi93dGYvTG9nZ2VySGVs
cGVyLmgKaW5kZXggZDAzYWZlNjQxNGNjOWM1MGU5YjM3ZTc3MjgwZjJjNjljYTM4MTliMS4uNzVh
MjBiZGRjZWVlNWQxMDhkM2EwMzI5NDZkMjM0ZjJkYzNjZTIzYiAxMDA2NDQKLS0tIGEvU291cmNl
L1dURi93dGYvTG9nZ2VySGVscGVyLmgKKysrIGIvU291cmNlL1dURi93dGYvTG9nZ2VySGVscGVy
LmgKQEAgLTgxLDYgKzgxLDEyIEBAIHB1YmxpYzoKICNkZWZpbmUgREVCVUdfTE9HKC4uLikgICAg
ICAoKHZvaWQpMCkKICNkZWZpbmUgV0lMTF9MT0coX2xldmVsXykgICBmYWxzZQogCisjZGVmaW5l
IEFMV0FZU19MT0dfSUYoY29uZGl0aW9uLCAuLi4pICAgICAoKHZvaWQpMCkKKyNkZWZpbmUgRVJS
T1JfTE9HX0lGKGNvbmRpdGlvbiwgLi4uKSAgICAgICgodm9pZCkwKQorI2RlZmluZSBXQVJOSU5H
X0xPR19JRihjb25kaXRpb24sIC4uLikgICAgKCh2b2lkKTApCisjZGVmaW5lIElORk9fTE9HX0lG
KGNvbmRpdGlvbiwgLi4uKSAgICAgICAoKHZvaWQpMCkKKyNkZWZpbmUgREVCVUdfTE9HX0lGKGNv
bmRpdGlvbiwgLi4uKSAgICAgICgodm9pZCkwKQorCiAjZW5kaWYKICAgICAKIH07Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>