195822 2019-03-15 14:42:36 -0700 Provide an option for an always-on fast click mode in iOS 2019-03-15 15:07:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino sam webkit-bug-importer oldest_to_newest 1517146 0 dino 2019-03-15 14:42:36 -0700 Provide an option for an always-on fast click mode in iOS 1517151 1 dino 2019-03-15 14:49:45 -0700 <rdar://problem/48939357> 1517154 2 364849 dino 2019-03-15 14:53:51 -0700 Created attachment 364849 Patch 1517159 3 364849 sam 2019-03-15 14:58:32 -0700 Comment on attachment 364849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364849&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1507 > + RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self); You call it a tap here, but clicks elsewhere. Which is it??? 1517167 4 dino 2019-03-15 15:07:39 -0700 Committed r243015: <https://trac.webkit.org/changeset/243015> 364849 2019-03-15 14:53:51 -0700 2019-03-15 14:58:32 -0700 Patch bug-195822-20190316085350.patch text/plain 7536 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA5MGVmOWRlYmNlYjYxMmZl YjkyNDdkZGM0NjAzZTM0MmE2MDM1MGMuLmUyNTFlMGIxZGIyNGJjMzQzODAwNmI1MGUxYWY1NmQ4 ZTI0MDkwNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTktMDMtMTUgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgYW4gb3B0aW9uIGZvciBh biBhbHdheXMtb24gZmFzdCBjbGljayBtb2RlIGluIGlPUworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80ODkzOTM1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgYW4gb3B0aW9uIHRoYXQgd2lsbCBhbHdheXMgdHJpZ2dlciBhIGNsaWNrIGFuZCBu ZXZlcgorICAgICAgICB3YWl0IGZvciBhIGRvdWJsZSB0YXAgdG8gem9vbS4gSXQgaXMgZGlzYWJs ZWQgYnkgZGVmYXVsdC4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sOgor ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAg ICAgICAoLVtXS0NvbnRlbnRWaWV3IF9oYW5kbGVTbWFydE1hZ25pZmljYXRpb25JbmZvcm1hdGlv bkZvclBvdGVudGlhbFRhcDpyZW5kZXJSZWN0OmZpdEVudGlyZVJlY3Q6dmlld3BvcnRNaW5pbXVt U2NhbGU6dmlld3BvcnRNYXhpbXVtU2NhbGU6XSk6CisKKzIwMTktMDMtMTUgIERlYW4gSmFja3Nv biAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgYW4gb3B0aW9uIGZvciBhbiBh bHdheXMtb24gZmFzdCBjbGljayBtb2RlIGluIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAg ICAgKC1bV0tDb250ZW50VmlldyBfaGFuZGxlU21hcnRNYWduaWZpY2F0aW9uSW5mb3JtYXRpb25G b3JQb3RlbnRpYWxUYXA6cmVuZGVyUmVjdDpmaXRFbnRpcmVSZWN0OnZpZXdwb3J0TWluaW11bVNj YWxlOnZpZXdwb3J0TWF4aW11bVNjYWxlOl0pOgorCiAyMDE5LTAzLTEzICBEZWFuIEphY2tzb24g IDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBCbG9jayBhbGwgcGx1Z2lucyBzbWFsbGVyIHRo YW4gNXg1cHgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2Vz LnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IDEy NDUxODVmNzRhODM5N2RkNzQwZDE1OWQ0MWE2NDE0NTQ3OGUyMTUuLjE2ODk4NzZiNTg2MzI1YzNk Mjg2ODI5NmIwY2NmYTYxZTVhOWMyYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVy ZW5jZXMueWFtbApAQCAtMTQ4Niw2ICsxNDg2LDE1IEBAIEZhc3RlckNsaWNrc0VuYWJsZWQ6CiAg IHdlYmNvcmVCaW5kaW5nOiBub25lCiAgIGNhdGVnb3J5OiBpbnRlcm5hbAogCitGYXN0Q2xpY2tz RXZlcnl3aGVyZToKKyAgdHlwZTogYm9vbAorICBkZWZhdWx0VmFsdWU6IGZhbHNlCisgIGNvbmRp dGlvbjogUExBVEZPUk0oSU9TX0ZBTUlMWSkKKyAgaHVtYW5SZWFkYWJsZU5hbWU6ICJGYXN0IGNs aWNrcyBldmVyeXdoZXJlIgorICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246ICJGb3JjZSBmYXN0 IGNsaWNrcyBvbiBhbGwgcGFnZXMiCisgIHdlYmNvcmVCaW5kaW5nOiBub25lCisgIGNhdGVnb3J5 OiBpbnRlcm5hbAorCiBJbnB1dFR5cGVDb2xvckVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKICAgZGVm YXVsdFZhbHVlOiBERUZBVUxUX0lOUFVUX1RZUEVfQ09MT1JfRU5BQkxFRApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K aW5kZXggN2ZjNDZhNmY0OThkNWIxNDExMDUxMjQ4YWUyMTdhN2Y3ZWE3NzFkMS4uMDYyMmVmNzcz NjBlNmQ0MWFkMzNhZjlmZmMxNjJmMDI0NjcyNTg2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xNTAz LDYgKzE1MDMsMTIgQEAgc3RhdGljIE5TVmFsdWUgKm5zU2l6ZUZvclRhcEhpZ2hsaWdodEJvcmRl clJhZGl1cyhXZWJDb3JlOjpJbnRTaXplIGJvcmRlclJhZGl1cywKICAgICBpZiAoIV9wb3RlbnRp YWxUYXBJblByb2dyZXNzKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoX3BhZ2UtPnByZWZl cmVuY2VzKCkuZmFzdENsaWNrc0V2ZXJ5d2hlcmUoKSkgeworICAgICAgICBSRUxFQVNFX0xPRyhW aWV3R2VzdHVyZXMsICJQb3RlbnRpYWwgdGFwIGZvdW5kIGFuIGVsZW1lbnQgYW5kIGZhc3QgdGFw cyBhcmUgZm9yY2VkIG9uLiBUcmlnZ2VyIGNsaWNrLiAoJXApIiwgc2VsZik7CisgICAgICAgIFtz ZWxmIF9zZXREb3VibGVUYXBHZXN0dXJlc0VuYWJsZWQ6Tk9dOworICAgICAgICByZXR1cm47Cisg ICAgfQorCiAgICAgYXV0byB0YXJnZXRTY2FsZSA9IF9zbWFydE1hZ25pZmljYXRpb25Db250cm9s bGVyLT56b29tRmFjdG9yRm9yVGFyZ2V0UmVjdChyZW5kZXJSZWN0LCBmaXRFbnRpcmVSZWN0LCB2 aWV3cG9ydE1pbmltdW1TY2FsZSwgdmlld3BvcnRNYXhpbXVtU2NhbGUpOwogCiAgICAgYXV0byBp bml0aWFsU2NhbGUgPSBbc2VsZiBfaW5pdGlhbFNjYWxlRmFjdG9yXTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiOTg1ODA0 ODQ0M2M1ZTk3NGE0OTI0M2FjMzYzMjAwYzk1NmY4MWE5Li44OTdiNmU5MTQ2M2UwZmEyZjRlMzdk OTQ5YWEyYjJhMzU3OWI4MGQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMTUgIERl YW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgYW4gb3B0aW9u IGZvciBhbiBhbHdheXMtb24gZmFzdCBjbGljayBtb2RlIGluIGlPUworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODIyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80ODkzOTM1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOZXcgdGVzdCBmb3IgImFsd2F5cyBmYXN0IGNsaWNrIiBtb2RlLgorCisgICAg ICAgICogZmFzdC9ldmVudHMvaW9zL2lwYWQvZmFzdC1jbGljay1hbHdheXMtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvaXBhZC9mYXN0LWNsaWNrLWFsd2F5 cy5odG1sOiBDb3BpZWQgZnJvbSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvaXBhZC9mYXN0 LWNsaWNrLWRvdWJsZS10YXAtc2VuZHMtY2xpY2stb24taW5zaWduaWZpY2FudC16b29tLmh0bWwu CisgICAgICAgICogZmFzdC9ldmVudHMvaW9zL2lwYWQvZmFzdC1jbGljay1kb3VibGUtdGFwLXNl bmRzLWNsaWNrLW9uLWluc2lnbmlmaWNhbnQtem9vbS5odG1sOgorCiAyMDE5LTAzLTEzICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBCbG9jayBhbGwgcGx1Z2lucyBz bWFsbGVyIHRoYW4gNXg1cHgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lv cy9pcGFkL2Zhc3QtY2xpY2stYWx3YXlzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2lvcy9pcGFkL2Zhc3QtY2xpY2stYWx3YXlzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li41ZTE3ZjQ0ZjMyYzE5MzI4ODZhMTRlNjRmNTg2YmYwOTAzZTI1MTM3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2lwYWQvZmFzdC1jbGljay1hbHdheXMt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorUEFTUzogQ2xpY2sgZmlyZWQgb24gZWxlbWVu dCB3aXRoIGhhbmRsZXIuCitUaGlzIGRvY3VtZW50IGRvZXNuJ3QgaGF2ZSBmYXN0IGNsaWNrcyBi ZWNhdXNlIGl0IHNldHMgYSB2aWV3cG9ydCB3aWR0aC4gSXQgaGFzIGEgc2lnbmlmaWNhbnQgem9v bSBzaW5jZSB0aGUgdmlld3BvcnQgd2lkdGggaXMgc2lnbmlmaWNhbnRseSBiaWdnZXIgdGhhbiB0 aGUgYm9keSB3aWR0aC4gSG93ZXZlciwgaXQgc2V0cyBmYXN0IGNsaWNrIGV2ZXJ5d2hlcmUgdG8g b24sIHNvIGRvdWJsZSB0YXBwaW5nIG9uIHRoZSByZWN0YW5nbGUgYWJvdmUgc2hvdWxkIHNlbmQg YSBjbGljayBldmVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9p cGFkL2Zhc3QtY2xpY2stYWx3YXlzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mv aXBhZC9mYXN0LWNsaWNrLWFsd2F5cy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUyZTI4MTlmOGE3YjNjZjQ1 OWM2ODkyZTVlZWI2MWZlYjY0NjUwMmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9pb3MvaXBhZC9mYXN0LWNsaWNrLWFsd2F5cy5odG1sCkBAIC0wLDAgKzEsNTUg QEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIHVzZUZsZXhpYmxl Vmlld3BvcnQ9dHJ1ZSBpbnRlcm5hbDpGYXN0Q2xpY2tzRXZlcnl3aGVyZT10cnVlIF0gLS0+CisK KzxodG1sPgorPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPTgwMCI+Cis8aGVh ZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGJvZHkgeworICAgICAgICAgICAgZm9udC1mYW1pbHk6 IHN5c3RlbS11aTsKKyAgICAgICAgICAgIGxpbmUtaGVpZ2h0OiAxLjQ7CisgICAgICAgICAgICBw YWRkaW5nOiAxMHB4IDEwcHg7CisgICAgICAgICAgICB3aWR0aDogNTAwcHg7CisgICAgICAgICAg ICBtYXJnaW46IDA7CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQgc3JjPSIu Li8uLi8uLi8uLi9yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0 PgorICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgICAgIHRlc3RSdW5u ZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7 CisgICAgICAgIH0KKworICAgICAgICBhc3luYyBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICAgICAg eworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpLmFkZEV2ZW50 TGlzdGVuZXIoImNsaWNrIiwgaGFuZGxlQ2xpY2ssIGZhbHNlKTsKKworICAgICAgICAgICAgaWYg KCF3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAg ICBhd2FpdCBVSUhlbHBlci5odW1hblNwZWVkRG91YmxlVGFwQXQoMzAsIDMwKTsKKyAgICAgICAg fQorCisgICAgICAgIGZ1bmN0aW9uIGhhbmRsZUNsaWNrKGV2ZW50KQorICAgICAgICB7CisgICAg ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikudGV4dENvbnRlbnQgPSAi UEFTUzogQ2xpY2sgZmlyZWQgb24gZWxlbWVudCB3aXRoIGhhbmRsZXIuIjsKKyAgICAgICAgICAg IHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+CisgICAg PHN0eWxlPgorICAgICAgICBib2R5IHsKKyAgICAgICAgICAgIG1hcmdpbjogMDsKKyAgICAgICAg fQorICAgICAgICAjdGFyZ2V0IHsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAg ICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBzaWx2ZXI7 CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0 KCkiPgorPGRpdiBpZD0idGFyZ2V0Ij48L2Rpdj4KKzxkaXYgaWQ9ImRlc2NyaXB0aW9uIj5UaGlz IGRvY3VtZW50IGRvZXNuJ3QgaGF2ZSBmYXN0IGNsaWNrcyBiZWNhdXNlCisgICAgaXQgc2V0cyBh IHZpZXdwb3J0IHdpZHRoLiBJdCBoYXMgYSBzaWduaWZpY2FudCB6b29tIHNpbmNlIHRoZSB2aWV3 cG9ydAorICAgIHdpZHRoIGlzIHNpZ25pZmljYW50bHkgYmlnZ2VyIHRoYW4gdGhlIGJvZHkgd2lk dGguIEhvd2V2ZXIsIGl0IHNldHMgZmFzdCBjbGljayBldmVyeXdoZXJlIHRvCisgICAgb24sIHNv IGRvdWJsZSB0YXBwaW5nIG9uIHRoZSByZWN0YW5nbGUgYWJvdmUgc2hvdWxkIHNlbmQgYSBjbGlj ayBldmVudC48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2lvcy9pcGFkL2Zhc3QtY2xpY2stZG91YmxlLXRhcC1zZW5kcy1jbGljay1v bi1pbnNpZ25pZmljYW50LXpvb20uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9p cGFkL2Zhc3QtY2xpY2stZG91YmxlLXRhcC1zZW5kcy1jbGljay1vbi1pbnNpZ25pZmljYW50LXpv b20uaHRtbAppbmRleCBkMzRjMjJmNWNjODcwMWEwN2Y5YWY4ZDkxMmE5MWIxNTVhNzNjMmM2Li5m NjQyNTE3ODAwNzllYTYzMDVhZGE5ODA0MjdkYzZlNWIwMjBiNWE1IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvaXBhZC9mYXN0LWNsaWNrLWRvdWJsZS10YXAtc2VuZHMt Y2xpY2stb24taW5zaWduaWZpY2FudC16b29tLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvaW9zL2lwYWQvZmFzdC1jbGljay1kb3VibGUtdGFwLXNlbmRzLWNsaWNrLW9uLWluc2ln bmlmaWNhbnQtem9vbS5odG1sCkBAIC0xMiw3ICsxMiw3IEBACiAgICAgICAgICAgICBtYXJnaW46 IDA7CiAgICAgICAgIH0KICAgICA8L3N0eWxlPgotICAgIDxzY3JpcHQgc3JjPSIuLi8uLi8uLi9y ZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4v Li4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KICAg ICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAgICAgICAgICAgICB0ZXN0UnVubmVyLmR1 bXBBc1RleHQoKTsK