195818 2019-03-15 13:43:55 -0700 Remove incremental attribute and search event 2023-07-14 12:31:22 -0700 1 1 1 Unclassified WebKit DOM Safari 12 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=257686 https://bugs.chromium.org/p/chromium/issues/detail?id=690143 InRadar, WPTImpact P2 Normal --- 1 mike annevk ahmad.saleem792 akeerthi annevk karlcow rniwa webkit-bug-importer webkit wenson_hsieh zcorpan oldest_to_newest 1517102 0 mike 2019-03-15 13:43:55 -0700 WebKit implements the following non-standard APIs: - Document#onsearch - Element#onsearch - the `search` event Neither Firefox nor Edge implement these. Blink *does* implement these APIs, but the Blink maintainers are currently investigating the impact of its removal [1]. That issue includes references to the `incremental` attribute, but I have not seen any indication of its existence in WebKit. WebKit currently has at least one open bug concerning the behavior of this feature [2]. [1] https://github.com/whatwg/html/issues/667 [2] https://bugs.webkit.org/show_bug.cgi?id=13786 1517113 1 webkit-bug-importer 2019-03-15 13:55:16 -0700 <rdar://problem/48937114> 1585088 2 zcorpan 2019-10-29 14:14:34 -0700 Tests added in https://github.com/web-platform-tests/wpt/pull/19889 The test results suggest WebKit does support an incremental attribute. 1903442 3 ahmad.saleem792 2022-10-05 09:17:35 -0700 Only Firefox passes these tests: https://wpt.fyi/results/html/semantics/forms?label=master&label=experimental&aligned&view=subtest&q=historical-search-event.html https://wpt.fyi/results/html/semantics/forms/historical.html?label=master&label=experimental&aligned&view=subtest&q=html%2Fsemantics%2F _____ Do we have any strategy to remove these non-standards APIs? 1960082 4 ahmad.saleem792 2023-06-06 10:01:45 -0700 *** Bug 257687 has been marked as a duplicate of this bug. *** 1961028 5 ahmad.saleem792 2023-06-12 07:22:42 -0700 *** Bug 257686 has been marked as a duplicate of this bug. *** 1966419 6 annevk 2023-07-12 11:12:55 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15788 1966422 7 annevk 2023-07-12 11:25:56 -0700 I'm checking with Chromium if they're still interested in doing this: https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25. Aditya, are you still comfortable with what you said in https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262? 1966466 8 akeerthi 2023-07-12 13:51:18 -0700 (In reply to Anne van Kesteren from comment #7) > I'm checking with Chromium if they're still interested in doing this: > https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25. > > Aditya, are you still comfortable with what you said in > https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262? I'm slightly more concerned about removing the "search" event without a link check, since it could it completely break search functionality in apps that rely on it. Whereas, if we removed incremental without a link check, users could still use the enter key to initiate a search. I'm still comfortable with removing both from the web, but would lean towards keeping the "search" event with a link check, since we don't know the surface of apps we may affect. 1966791 9 ews-feeder 2023-07-14 12:31:19 -0700 Committed 266068@main (99ff08340f12): <https://commits.webkit.org/266068@main> Reviewed commits have been landed. Closing PR #15788 and removing active labels.